stripe 3.3.0 → 3.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 93c701571b0b8167fe9a2816d458715fe646e0fa
-  data.tar.gz: 27a4af6cf8afca19384f7d9901b2980ac8da0d93
+  metadata.gz: bae6f0ad07bc976943ede420d50734662a18dece
+  data.tar.gz: fb0a6559f1a927cb2fc5092159572b86badbb0e6
 SHA512:
-  metadata.gz: f8ebb06861148fe8e40b2737cf5f65f00e11921e6b6d4ddd790126da4d3dfa5be3ed01353a5538bfaccfc8d0fa2027d96b2ae40659e22f8b88a99f897928640f
-  data.tar.gz: 1971744e0adf6616d472967740b8bd321cd1dc6d639ec582d436560eca093446021435f702c8662632ece248eff119019322a7e327f8b79bb025877ca589bc89
+  metadata.gz: 6ef3f38ac0b0e0fdbf2beb1519f2242f9268461a86be79f00a481d7a4ab841d1f7f0bde63e2f58acafc9c97d2e429a687dc492264b1d8b5b014fa5599dd585f9
+  data.tar.gz: af934590bfb40438ecc031f5ea17c81f6832debac19ead3b7a186887bcc41a1b7addb5f45b730c538dc413fa37beb0b6e3074588b53c5bc7f32953a1ae861ae8

data/History.txt

@@ -1,3 +1,8 @@
+=== 3.3.1 2017-08-18
+
+* Only parse webhook payload after verification to decrease likelihood of
+  attack
+
 === 3.3.0 2017-08-11
 
 * Add support for standard library logger interface with `Stripe.logger`

data/VERSION

@@ -1 +1 @@
-3.3.0
+3.3.1

data/lib/stripe/version.rb

@@ -1,3 +1,3 @@
 module Stripe
-  VERSION = '3.3.0'
+  VERSION = '3.3.1'
 end

data/lib/stripe/webhook.rb

@@ -7,12 +7,15 @@ module Stripe
     # This may raise JSON::ParserError if the payload is not valid JSON, or
     # SignatureVerificationError if the signature verification fails.
     def self.construct_event(payload, sig_header, secret, tolerance: DEFAULT_TOLERANCE)
-      data = JSON.parse(payload, symbolize_names: true)
-      event = Event.construct_from(data)
-
       Signature.verify_header(payload, sig_header, secret, tolerance: tolerance)
 
-      event
+      # It's a good idea to parse the payload only after verifying it. We use
+      # `symbolize_names` so it would otherwise be technically possible to
+      # flood a target's memory if they were on an older version of Ruby that
+      # doesn't GC symbols. It also decreases the likelihood that we receive a
+      # bad payload that fails to parse and throws an exception.
+      data = JSON.parse(payload, symbolize_names: true)
+      Event.construct_from(data)
     end
 
     module Signature

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: stripe
 version: !ruby/object:Gem::Version
-  version: 3.3.0
+  version: 3.3.1
 platform: ruby
 authors:
 - Stripe
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-08-11 00:00:00.000000000 Z
+date: 2017-08-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday