stripe 3.26.0 → 3.26.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: a8e4c5dabe1fd48d0cfeddea151a30bee86c8547
-  data.tar.gz: 726a6104b5ecdf200bd80c0b453257304be359c8
+SHA256:
+  metadata.gz: 4ac82de8d5c93956f56ab752a21fbd5470aa3f2452c7360c8bad21b62437f1de
+  data.tar.gz: 4c03b8ed0e4d03a24a4b18e6668147b7c88e4ae1977cbb5d7d6319ff4c0535f0
 SHA512:
-  metadata.gz: 7f9c83449bc4558dbd2a89b6a41cfa4e4ab35b985c073eb278039114bca94b0c21fe1167a55c68098a40f0cd87f37a742d7ca181aaf2d940efed372b20e55b9a
-  data.tar.gz: 935f38cfdbfd7edfbd84f72ece0b89db1cd8a3198ee0a6cafb52d7d9058f4e64374e25e2454795afbcbc63415bea8ae465ed03ffbc99d5a95143126aade66a15
+  metadata.gz: 3094e2f430018ebba15fe8f78c6b9e28480c8f47ec5aeb3185296a5c7f27357673b3436f1631c76bdc5b09535bdd6885794de7a5b24c6cfe4d6d2fb16e1c68b5
+  data.tar.gz: ef354896a762a5cb3fd34028f9f04413bf1b576b44d040167b2e51fd6724164cb72821a2f4be02679c16ea4663738409b6a83ffd8426a4de2191832f397ed250

data/CHANGELOG.md

@@ -1,5 +1,8 @@
 # Changelog
 
+## 3.26.1 - 2018-09-14
+* [#688](https://github.com/stripe/stripe-ruby/pull/688) Fix hash equality on `StripeObject`
+
 ## 3.26.0 - 2018-09-05
 * [#681](https://github.com/stripe/stripe-ruby/pull/681) Add support for reporting resources
 

data/VERSION

@@ -1 +1 @@
-3.26.0
+3.26.1

data/lib/stripe/stripe_object.rb

@@ -96,6 +96,17 @@ module Stripe
       other.is_a?(StripeObject) && @values == other.instance_variable_get(:@values)
     end
 
+    # Hash equality. As with ==, we consider two equivalent Stripe objects equal.
+    def eql?(other)
+      self == other
+    end
+
+    # As for equality, we hash to Stripe objects to the same value if they're
+    # equivalent objects.
+    def hash
+      @values.hash
+    end
+
     # Indicates whether or not the resource has been deleted on the server.
     # Note that some, but not all, resources can indicate whether they have
     # been deleted.

data/lib/stripe/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Stripe
-  VERSION = "3.26.0".freeze
+  VERSION = "3.26.1".freeze
 end

data/test/stripe/stripe_object_test.rb

@@ -117,6 +117,46 @@ module Stripe
       end
     end
 
+    context "#eql?" do
+      should "produce the true for two equivalent Stripe objects" do
+        obj1 = Stripe::StripeObject.construct_from(id: 1, name: "Stripe")
+        obj2 = Stripe::StripeObject.construct_from(id: 1, name: "Stripe")
+        assert obj1.eql?(obj2)
+      end
+
+      should "produce false for non-equivalent Stripe objects" do
+        obj1 = Stripe::StripeObject.construct_from(id: 1, name: "Stripe")
+        obj2 = Stripe::StripeObject.construct_from(id: 2, name: "Stripe")
+        refute obj1.eql?(obj2)
+      end
+
+      should "produce false for different types" do
+        obj1 = Stripe::StripeObject.construct_from(id: 1, name: "Stripe")
+        obj2 = 7
+        refute obj1.eql?(obj2)
+      end
+    end
+
+    context "#hash" do
+      should "produce the same hash for two equivalent Stripe objects" do
+        obj1 = Stripe::StripeObject.construct_from(id: 1, name: "Stripe")
+        obj2 = Stripe::StripeObject.construct_from(id: 1, name: "Stripe")
+        assert_equal obj1.hash, obj2.hash
+      end
+
+      should "produce different hashes for non-equivalent Stripe objects" do
+        obj1 = Stripe::StripeObject.construct_from(id: 1, name: "Stripe")
+        obj2 = Stripe::StripeObject.construct_from(id: 2, name: "Stripe")
+        refute_equal obj1.hash, obj2.hash
+      end
+
+      should "produce different hashes for different types" do
+        obj1 = Stripe::StripeObject.construct_from(id: 1, name: "Stripe")
+        obj2 = 7
+        refute_equal obj1.hash, obj2.hash
+      end
+    end
+
     context "#to_hash" do
       should "skip calling to_hash on nil" do
         module NilWithToHash

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: stripe
 version: !ruby/object:Gem::Version
-  version: 3.26.0
+  version: 3.26.1
 platform: ruby
 authors:
 - Stripe
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-09-05 00:00:00.000000000 Z
+date: 2018-09-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -211,7 +211,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.14
+rubygems_version: 2.7.7
 signing_key: 
 specification_version: 4
 summary: Ruby bindings for the Stripe API