stripe 3.2.0 → 5.16.0

data/test/stripe/webhook_test.rb

@@ -1,14 +1,18 @@
-require File.expand_path('../../test_helper', __FILE__)
+# frozen_string_literal: true
+
+require ::File.expand_path("../test_helper", __dir__)
 
 module Stripe
   class WebhookTest < Test::Unit::TestCase
-    EVENT_PAYLOAD = '''{
-  "id": "evt_test_webhook",
-  "object": "event"
-}'''
-    SECRET = 'whsec_test_secret'
+    EVENT_PAYLOAD = <<~PAYLOAD
+      {
+        "id": "evt_test_webhook",
+        "object": "event"
+      }
+    PAYLOAD
+    SECRET = "whsec_test_secret"
 
-    def generate_header(opts={})
+    def generate_header(opts = {})
       opts[:timestamp] ||= Time.now.to_i
       opts[:payload] ||= EVENT_PAYLOAD
       opts[:secret] ||= SECRET
@@ -21,19 +25,19 @@ module Stripe
       should "return an Event instance from a valid JSON payload and valid signature header" do
         header = generate_header
         event = Stripe::Webhook.construct_event(EVENT_PAYLOAD, header, SECRET)
-        assert event.kind_of?(Stripe::Event)
+        assert event.is_a?(Stripe::Event)
       end
 
       should "raise a JSON::ParserError from an invalid JSON payload" do
         assert_raises JSON::ParserError do
-          payload = 'this is not valid JSON'
+          payload = "this is not valid JSON"
           header = generate_header(payload: payload)
           Stripe::Webhook.construct_event(payload, header, SECRET)
         end
       end
 
       should "raise a SignatureVerificationError from a valid JSON payload and an invalid signature header" do
-        header = 'bad_header'
+        header = "bad_header"
         assert_raises Stripe::SignatureVerificationError do
           Stripe::Webhook.construct_event(EVENT_PAYLOAD, header, SECRET)
         end
@@ -42,25 +46,25 @@ module Stripe
 
     context ".verify_signature_header" do
       should "raise a SignatureVerificationError when the header does not have the expected format" do
-        header = 'i\'m not even a real signature header'
+        header = "i'm not even a real signature header"
         e = assert_raises(Stripe::SignatureVerificationError) do
-          Stripe::Webhook::Signature.verify_header(EVENT_PAYLOAD, header, 'secret')
+          Stripe::Webhook::Signature.verify_header(EVENT_PAYLOAD, header, "secret")
         end
         assert_match("Unable to extract timestamp and signatures from header", e.message)
       end
 
       should "raise a SignatureVerificationError when there are no signatures with the expected scheme" do
-        header = generate_header(scheme: 'v0')
+        header = generate_header(scheme: "v0")
         e = assert_raises(Stripe::SignatureVerificationError) do
-          Stripe::Webhook::Signature.verify_header(EVENT_PAYLOAD, header, 'secret')
+          Stripe::Webhook::Signature.verify_header(EVENT_PAYLOAD, header, "secret")
         end
         assert_match("No signatures found with expected scheme", e.message)
       end
 
       should "raise a SignatureVerificationError when there are no valid signatures for the payload" do
-        header = generate_header(signature: 'bad_signature')
+        header = generate_header(signature: "bad_signature")
         e = assert_raises(Stripe::SignatureVerificationError) do
-          Stripe::Webhook::Signature.verify_header(EVENT_PAYLOAD, header, 'secret')
+          Stripe::Webhook::Signature.verify_header(EVENT_PAYLOAD, header, "secret")
         end
         assert_match("No signatures found matching the expected signature for payload", e.message)
       end
@@ -84,7 +88,7 @@ module Stripe
       end
 
       should "return true when the header contains a valid signature and the timestamp is off but no tolerance is provided" do
-        header = generate_header(timestamp: 12345)
+        header = generate_header(timestamp: 12_345)
         assert(Stripe::Webhook::Signature.verify_header(EVENT_PAYLOAD, header, SECRET))
       end
     end

data/test/stripe_mock.rb

@@ -0,0 +1,78 @@
+# frozen_string_literal: true
+
+module Stripe
+  class StripeMock
+    include Singleton
+
+    PATH_SPEC = "#{::File.dirname(__FILE__)}/openapi/spec3.json"
+    PATH_FIXTURES = "#{::File.dirname(__FILE__)}/openapi/fixtures3.json"
+
+    @pid = nil
+    @port = -1
+
+    # Starts stripe-mock, if necessary. Returns the port on which stripe-mock is listening.
+    def self.start
+      unless ::File.exist?(PATH_SPEC)
+        port = ENV["STRIPE_MOCK_PORT"] || 12_111
+        puts("No custom spec file found, assuming stripe-mock is already running on port #{port}")
+        return port
+      end
+
+      unless @pid.nil?
+        puts("stripe-mock already running on port #{@port}")
+        return @port
+      end
+
+      puts("Starting stripe-mock...")
+
+      @stdout, @child_stdout = ::IO.pipe
+      @stderr, @child_stderr = ::IO.pipe
+
+      @pid = ::Process.spawn(
+        %w[stripe-mock stripe-mock],
+        "-http-port",
+        "0", # have stripe-mock select a port
+        "-spec",
+        PATH_SPEC,
+        "-fixtures",
+        PATH_FIXTURES,
+        out: @child_stdout,
+        err: @child_stderr
+      )
+
+      [@child_stdout, @child_stderr].each(&:close)
+
+      # Look for port in "Listening for HTTP on port: 50602"
+      buffer = ""
+      loop do
+        buffer += @stdout.readpartial(4096)
+        if (matches = buffer.match(/ port: (\d+)/))
+          @port = matches[1]
+          break
+        end
+        sleep(0.1)
+      end
+
+      status = (::Process.wait2(@pid, ::Process::WNOHANG) || []).last
+      if status.nil?
+        puts("Started stripe-mock; PID = #{@pid}, port = #{@port}")
+      else
+        abort("stripe-mock terminated early: #{status}")
+      end
+
+      @port
+    end
+
+    # Stops stripe-mock, if necessary.
+    def self.stop
+      return if @pid.nil?
+
+      puts("Stopping stripe-mock...")
+      ::Process.kill(:SIGTERM, @pid)
+      ::Process.waitpid2(@pid)
+      @pid = nil
+      @port = -1
+      puts("Stopped stripe-mock")
+    end
+  end
+end

data/test/stripe_test.rb

@@ -1,31 +1,22 @@
-require File.expand_path('../test_helper', __FILE__)
+# frozen_string_literal: true
 
-class StripeTest < Test::Unit::TestCase
-  should "warn that #refresh_from is deprecated" do
-    old_stderr = $stderr
-    $stderr = StringIO.new
-    begin
-      Stripe.uri_encode({})
-      message = "NOTE: Stripe.uri_encode is deprecated; use " +
-        "Stripe::Util#encode_parameters instead"
-      assert_match Regexp.new(message), $stderr.string
-    ensure
-      $stderr = old_stderr
-    end
-  end
+require ::File.expand_path("test_helper", __dir__)
 
+class StripeTest < Test::Unit::TestCase
   should "allow app_info to be configured" do
     begin
       old = Stripe.app_info
       Stripe.set_app_info(
         "MyAwesomePlugin",
+        partner_id: "partner_1234",
         url: "https://myawesomeplugin.info",
         version: "1.2.34"
       )
       assert_equal({
         name: "MyAwesomePlugin",
+        partner_id: "partner_1234",
         url: "https://myawesomeplugin.info",
-        version: "1.2.34"
+        version: "1.2.34",
       }, Stripe.app_info)
     ensure
       Stripe.app_info = old

data/test/test_data.rb

@@ -1,58 +1,60 @@
+# frozen_string_literal: true
+
 module Stripe
   module TestData
     def make_error(type, message)
       {
-        :error => {
-          :type => type,
-          :message => message,
-        }
+        error: {
+          type: type,
+          message: message,
+        },
       }
     end
 
     def make_invalid_api_key_error
       {
-        :error => {
-          :type => "invalid_request_error",
-          :message => "Invalid API Key provided: invalid"
-        }
+        error: {
+          type: "invalid_request_error",
+          message: "Invalid API Key provided: invalid",
+        },
       }
     end
 
     def make_invalid_exp_year_error
       {
-        :error => {
-          :code => "invalid_expiry_year",
-          :param => "exp_year",
-          :type => "card_error",
-          :message => "Your card's expiration year is invalid"
-        }
+        error: {
+          code: "invalid_expiry_year",
+          param: "exp_year",
+          type: "card_error",
+          message: "Your card's expiration year is invalid",
+        },
       }
     end
 
     def make_missing_id_error
       {
-        :error => {
-          :param => "id",
-          :type => "invalid_request_error",
-          :message => "Missing id"
-        }
+        error: {
+          param: "id",
+          type: "invalid_request_error",
+          message: "Missing id",
+        },
       }
     end
 
     def make_rate_limit_error
       {
-        :error => {
-          :type => "invalid_request_error",
-          :message => "Too many requests in a period of time."
-        }
+        error: {
+          type: "invalid_request_error",
+          message: "Too many requests in a period of time.",
+        },
       }
     end
 
     def make_api_error
       {
-        :error => {
-          :type => "api_error"
-        }
+        error: {
+          type: "api_error",
+        },
       }
     end
   end

data/test/test_helper.rb

@@ -1,17 +1,23 @@
-require 'stripe'
-require 'test/unit'
-require 'mocha/setup'
-require 'stringio'
-require 'shoulda/context'
-require "timecop"
-require 'webmock/test_unit'
+# frozen_string_literal: true
 
-PROJECT_ROOT = File.expand_path("../../", __FILE__)
+require "coveralls"
+Coveralls.wear!("test_frameworks")
 
-require File.expand_path('../test_data', __FILE__)
+require "stripe"
+require "test/unit"
+require "mocha/setup"
+require "stringio"
+require "shoulda/context"
+require "webmock/test_unit"
 
-MOCK_MINIMUM_VERSION = "0.1.12"
-MOCK_PORT = ENV["STRIPE_MOCK_PORT"] || 12111
+PROJECT_ROOT = ::File.expand_path("../", __dir__)
+
+require ::File.expand_path("test_data", __dir__)
+require ::File.expand_path("stripe_mock", __dir__)
+
+# If changing this number, please also change it in `.travis.yml`.
+MOCK_MINIMUM_VERSION = "0.79.0"
+MOCK_PORT = Stripe::StripeMock.start
 
 # Disable all real network connections except those that are outgoing to
 # stripe-mock.
@@ -21,36 +27,49 @@ WebMock.disable_net_connect!(allow: "localhost:#{MOCK_PORT}")
 # we can print one error and fail fast so that it's more clear to the user how
 # they should fix the problem.
 begin
-  resp = Faraday.get("http://localhost:#{MOCK_PORT}/")
-  version = resp.headers['Stripe-Mock-Version']
+  resp = Net::HTTP.get_response(URI("http://localhost:#{MOCK_PORT}/"))
+  version = resp["Stripe-Mock-Version"]
+
+  if version.nil?
+    abort("Couldn't find `Stripe-Mock-Version` in response from " \
+      "`localhost:#{MOCK_PORT}`. Is the service running there stripe-mock?")
+  end
+
   if version != "master" &&
-      Gem::Version.new(version) < Gem::Version.new(MOCK_MINIMUM_VERSION)
+     Gem::Version.new(version) < Gem::Version.new(MOCK_MINIMUM_VERSION)
     abort("Your version of stripe-mock (#{version}) is too old. The minimum " \
       "version to run this test suite is #{MOCK_MINIMUM_VERSION}. Please " \
       "see its repository for upgrade instructions.")
   end
-rescue Faraday::ConnectionFailed
+rescue Errno::ECONNREFUSED
   abort("Couldn't reach stripe-mock at `localhost:#{MOCK_PORT}`. Is " \
     "it running? Please see README for setup instructions.")
 end
 
-class Test::Unit::TestCase
-  include Stripe::TestData
-  include Mocha
+Test::Unit.at_exit do
+  Stripe::StripeMock.stop
+end
 
-  setup do
-    Stripe.api_key = "sk_test_123"
-    Stripe.api_base = "http://localhost:#{MOCK_PORT}"
-    stub_connect
-  end
+module Test
+  module Unit
+    class TestCase
+      include Stripe::TestData
+      include Mocha
 
-  teardown do
-    Stripe.api_key = nil
-  end
+      setup do
+        Stripe.api_key = "sk_test_123"
+        Stripe.api_base = "http://localhost:#{MOCK_PORT}"
+
+        stub_connect
+      end
 
-  private
+      teardown do
+        Stripe.api_key = nil
+      end
 
-  def stub_connect
-    stub_request(:any, /^#{Stripe.connect_base}/).to_return(:body => "{}")
+      private def stub_connect
+        stub_request(:any, /^#{Stripe.connect_base}/).to_return(body: "{}")
+      end
+    end
   end
 end