stripe 3.10.0 → 3.11.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 2e7b5bea101451f3c7a05b79a5b7dbad7e02d2a7
-  data.tar.gz: efc7af8e83a025865095472b00130d9720ad5575
+SHA256:
+  metadata.gz: 981d54e75ed0dc6a6c6e9134cbf338a2d8ed02e7169afc93f37c5c65d1e23955
+  data.tar.gz: 844de1199f90a2e1eb32f2a011fda913b0ee3c799cd670c8dd42d441d0135805
 SHA512:
-  metadata.gz: 826e1e1a0883d6a103da74ea2b3221ab55d786772e616038d05f2c7a38981ba45e2a9b14885358fef978cdf9aca0da8187f5c6da09d4c416e212e3c38c9b742f
-  data.tar.gz: 5a79ab66f87303e6ff5b06dc7999b6ede34ef2ee23126f47c318d25e37f51ba10551e09d3efe54d9811b5d8dfdc52d37c75b58024eb1d3c8979f8f85a8fe7371
+  metadata.gz: 7890d0984cb8d83aec246a5fe745f2e57343e1b1c256343e79c49f35479de9cbafd90046dd00b537339a6b08257eb9dd39a1aa96f420059d5596584f7f2b7bd5
+  data.tar.gz: 371d48d97dedf110422c91e70b25be7aa092576f55e87d5b1cf3e3d336b847ff9e0000fa18bd5f234459f33dd9b5826a7400fc53c7ac8939ac42de3c831220f3

data/.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2017-10-30 14:39:50 +0100 using RuboCop version 0.50.0.
+# on 2018-02-23 14:17:07 +0100 using RuboCop version 0.50.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -8,23 +8,23 @@
 
 # Offense count: 19
 Metrics/AbcSize:
-  Max: 49
+  Max: 45
 
 # Offense count: 27
 # Configuration parameters: CountComments, ExcludedMethods.
 Metrics/BlockLength:
-  Max: 467
+  Max: 469
 
 # Offense count: 8
 # Configuration parameters: CountComments.
 Metrics/ClassLength:
-  Max: 595
+  Max: 597
 
-# Offense count: 10
+# Offense count: 11
 Metrics/CyclomaticComplexity:
   Max: 13
 
-# Offense count: 257
+# Offense count: 259
 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
 # URISchemes: http, https
 Metrics/LineLength:
@@ -33,14 +33,14 @@ Metrics/LineLength:
 # Offense count: 32
 # Configuration parameters: CountComments.
 Metrics/MethodLength:
-  Max: 47
+  Max: 45
 
 # Offense count: 1
 # Configuration parameters: CountComments.
 Metrics/ModuleLength:
   Max: 305
 
-# Offense count: 5
+# Offense count: 6
 # Configuration parameters: CountKeywordArgs.
 Metrics/ParameterLists:
   Max: 7
@@ -55,6 +55,6 @@ Style/ClassVars:
     - 'lib/stripe/stripe_object.rb'
     - 'test/stripe/api_resource_test.rb'
 
-# Offense count: 52
+# Offense count: 53
 Style/Documentation:
   Enabled: false

data/CHANGELOG.md

@@ -1,5 +1,8 @@
 # Changelog
 
+## 3.11.0 - 2018-02-26
+* [#628](https://github.com/stripe/stripe-ruby/pull/628) Add support for `code` attribute on all Stripe exceptions
+
 ## 3.10.0 - 2018-02-21
 * [#627](https://github.com/stripe/stripe-ruby/pull/627) Add support for topups
 

data/VERSION

@@ -1 +1 @@
-3.10.0
+3.11.0

data/lib/stripe/errors.rb

@@ -8,8 +8,7 @@ module Stripe
     # about the response that conveyed the error.
     attr_accessor :response
 
-    # These fields are now available as part of #response and that usage should
-    # be preferred.
+    attr_reader :code
     attr_reader :http_body
     attr_reader :http_headers
     attr_reader :http_status
@@ -18,12 +17,13 @@ module Stripe
 
     # Initializes a StripeError.
     def initialize(message = nil, http_status: nil, http_body: nil, json_body: nil,
-                   http_headers: nil)
+                   http_headers: nil, code: nil)
       @message = message
       @http_status = http_status
       @http_body = http_body
       @http_headers = http_headers || {}
       @json_body = json_body
+      @code = code
       @request_id = @http_headers[:request_id]
     end
 
@@ -55,14 +55,15 @@ module Stripe
   # CardError is raised when a user enters a card that can't be charged for
   # some reason.
   class CardError < StripeError
-    attr_reader :param, :code
+    attr_reader :param
 
+    # TODO: make code a keyword arg in next major release
     def initialize(message, param, code, http_status: nil, http_body: nil, json_body: nil,
                    http_headers: nil)
       super(message, http_status: http_status, http_body: http_body,
-                     json_body: json_body, http_headers: http_headers)
+                     json_body: json_body, http_headers: http_headers,
+                     code: code)
       @param = param
-      @code = code
     end
   end
 
@@ -77,9 +78,10 @@ module Stripe
     attr_accessor :param
 
     def initialize(message, param, http_status: nil, http_body: nil, json_body: nil,
-                   http_headers: nil)
+                   http_headers: nil, code: nil)
       super(message, http_status: http_status, http_body: http_body,
-                     json_body: json_body, http_headers: http_headers)
+                     json_body: json_body, http_headers: http_headers,
+                     code: code)
       @param = param
     end
   end
@@ -109,13 +111,11 @@ module Stripe
   module OAuth
     # OAuthError is raised when the OAuth API returns an error.
     class OAuthError < StripeError
-      attr_accessor :code
-
       def initialize(code, description, http_status: nil, http_body: nil, json_body: nil,
                      http_headers: nil)
         super(description, http_status: http_status, http_body: http_body,
-                           json_body: json_body, http_headers: http_headers)
-        @code = code
+                           json_body: json_body, http_headers: http_headers,
+                           code: code)
       end
     end
 

data/lib/stripe/stripe_client.rb

@@ -294,6 +294,7 @@ module Stripe
         http_headers: resp.http_headers,
         http_status: resp.http_status,
         json_body: resp.data,
+        code: error_data[:code],
       }
 
       case resp.http_status
@@ -310,6 +311,9 @@ module Stripe
       when 401
         AuthenticationError.new(error_data[:message], opts)
       when 402
+        # TODO: modify CardError constructor to make code a keyword argument
+        #       so we don't have to delete it from opts
+        opts.delete(:code)
         CardError.new(
           error_data[:message], error_data[:param], error_data[:code],
           opts

data/lib/stripe/version.rb

@@ -1,3 +1,3 @@
 module Stripe
-  VERSION = "3.10.0".freeze
+  VERSION = "3.11.0".freeze
 end

data/test/stripe/stripe_client_test.rb

@@ -452,13 +452,15 @@ module Stripe
 
         should "raise CardError on 402" do
           stub_request(:post, "#{Stripe.api_base}/v1/charges")
-            .to_return(body: JSON.generate(make_missing_id_error), status: 402)
+            .to_return(body: JSON.generate(make_invalid_exp_year_error), status: 402)
           client = StripeClient.new
           begin
             client.execute_request(:post, "/v1/charges")
           rescue Stripe::CardError => e
             assert_equal(402, e.http_status)
             assert_equal(true, e.json_body.is_a?(Hash))
+            assert_equal("invalid_expiry_year", e.code)
+            assert_equal("exp_year", e.param)
           end
         end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: stripe
 version: !ruby/object:Gem::Version
-  version: 3.10.0
+  version: 3.11.0
 platform: ruby
 authors:
 - Stripe
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-02-21 00:00:00.000000000 Z
+date: 2018-02-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -184,7 +184,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.14
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Ruby bindings for the Stripe API