stripe 2.10.0 → 2.11.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e6ecda0a77dd1fdbc7115558111b52e5afe5e882
-  data.tar.gz: 43003db2cf79373969adef18730c88bb5f60cb76
+  metadata.gz: 6354295ff3cc3d9d5b42cfd49aaa9371cdac40a8
+  data.tar.gz: 9b306be44b4df38c53ac0db5ba98101135958b8c
 SHA512:
-  metadata.gz: 5593a4c1469cdf72619d53eba85fb47c1909167bfa357ee5868b4bd34b58ca3535d46af1e0e01e0b9d6d4ec5aec7ec95c545e6c7962936dd398a3a57d1679251
-  data.tar.gz: 9dce85148f7bbf3f0c2ce8eb826ad34f37e75ff41cb003678997c52c0d73ea855d44ce543d33c755ecc365ad067b9475fe9cb64dc3e1e2507d8ca0cc52e1bb12
+  metadata.gz: 72fe2684cc86a668f417ec87156c79e84401dbbc72b33d46836eee737e427ddfb838ad78cb4fe6517d3e064e4ffd9538d3634fc153def9ca874b60a3ddb505dc
+  data.tar.gz: 073939a037d90f8daf19740cf639c1a1aa09e9996b1510e2eb2ce79fccd083f757d7211d6034a16b0704b199895d0a53108995143a813e28be6abf209b4aaf77

data/History.txt

@@ -1,3 +1,7 @@
+=== 2.11.0 2017-05-26
+
+* Warn when keys that look like opts are included as parameters
+
 === 2.10.0 2017-05-25
 
 * Add support for account login links

data/VERSION

@@ -1 +1 @@
-2.10.0
+2.11.0

data/lib/stripe/api_operations/request.rb

@@ -5,6 +5,8 @@ module Stripe
         OPTS_KEYS_TO_PERSIST = Set[:api_key, :api_base, :client, :stripe_account, :stripe_version]
 
         def request(method, url, params={}, opts={})
+          warn_on_opts_in_params(params)
+
           opts = Util.normalize_opts(opts)
           opts[:client] ||= StripeClient.active_client
 
@@ -30,6 +32,19 @@ module Stripe
 
           [resp, opts_to_persist]
         end
+
+        private
+
+        KNOWN_OPTS = Set[:api_key, :idempotency_key, :stripe_account, :stripe_version]
+        private_constant :KNOWN_OPTS
+
+        def warn_on_opts_in_params(params)
+          KNOWN_OPTS.each do |opt|
+            if params.has_key?(opt)
+              $stderr.puts("WARNING: #{opt} should be in opts instead of params.")
+            end
+          end
+        end
       end
 
       def self.included(base)

data/lib/stripe/version.rb

@@ -1,3 +1,3 @@
 module Stripe
-  VERSION = '2.10.0'
+  VERSION = '2.11.0'
 end

data/test/stripe/api_resource_test.rb

@@ -182,11 +182,37 @@ module Stripe
         Stripe::Charge.list(:count => nil, :offset => 5, :sad => false)
 
         stub_request(:post, "#{Stripe.api_base}/v1/charges").
-          with(body: {  'amount' => '50', 'currency' => 'usd' }).
+          with(body: { 'amount' => '50', 'currency' => 'usd' }).
           to_return(body: JSON.generate({ :count => 1, :data => [API_FIXTURES.fetch(:charge)] }))
         Stripe::Charge.create(:amount => 50, :currency => 'usd', :card => { :number => nil })
       end
 
+      should "not trigger a warning if a known opt, such as idempotency_key, is in opts" do
+        stub_request(:post, "#{Stripe.api_base}/v1/charges").
+          to_return(body: JSON.generate(API_FIXTURES.fetch(:charge)))
+        old_stderr = $stderr
+        $stderr = StringIO.new
+        begin
+          Stripe::Charge.create({ :amount => 100, :currency => 'usd', :card => 'sc_token' }, { :idempotency_key => '12345' })
+          assert $stderr.string.empty?
+        ensure
+          $stderr = old_stderr
+        end
+      end
+
+      should "trigger a warning if a known opt, such as idempotency_key, is in params" do
+        stub_request(:post, "#{Stripe.api_base}/v1/charges").
+          to_return(body: JSON.generate(API_FIXTURES.fetch(:charge)))
+        old_stderr = $stderr
+        $stderr = StringIO.new
+        begin
+          Stripe::Charge.create({ :amount => 100, :currency => 'usd', :card => 'sc_token', :idempotency_key => '12345' })
+          assert_match Regexp.new('WARNING:'), $stderr.string
+        ensure
+          $stderr = old_stderr
+        end
+      end
+
       should "requesting with a unicode ID should result in a request" do
         stub_request(:get, "#{Stripe.api_base}/v1/customers/%E2%98%83").
           to_return(body: JSON.generate(make_missing_id_error), status: 404)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: stripe
 version: !ruby/object:Gem::Version
-  version: 2.10.0
+  version: 2.11.0
 platform: ruby
 authors:
 - Stripe
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-25 00:00:00.000000000 Z
+date: 2017-05-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday