stripe 10.2.0.pre.beta.1 → 10.2.0

data/lib/stripe/resources/terminal/reader.rb

@@ -23,33 +23,6 @@ module Stripe
         )
       end
 
-      def collect_inputs(params = {}, opts = {})
-        request_stripe_object(
-          method: :post,
-          path: format("/v1/terminal/readers/%<reader>s/collect_inputs", { reader: CGI.escape(self["id"]) }),
-          params: params,
-          opts: opts
-        )
-      end
-
-      def collect_payment_method(params = {}, opts = {})
-        request_stripe_object(
-          method: :post,
-          path: format("/v1/terminal/readers/%<reader>s/collect_payment_method", { reader: CGI.escape(self["id"]) }),
-          params: params,
-          opts: opts
-        )
-      end
-
-      def confirm_payment_intent(params = {}, opts = {})
-        request_stripe_object(
-          method: :post,
-          path: format("/v1/terminal/readers/%<reader>s/confirm_payment_intent", { reader: CGI.escape(self["id"]) }),
-          params: params,
-          opts: opts
-        )
-      end
-
       def process_payment_intent(params = {}, opts = {})
         request_stripe_object(
           method: :post,
@@ -95,33 +68,6 @@ module Stripe
         )
       end
 
-      def self.collect_inputs(reader, params = {}, opts = {})
-        request_stripe_object(
-          method: :post,
-          path: format("/v1/terminal/readers/%<reader>s/collect_inputs", { reader: CGI.escape(reader) }),
-          params: params,
-          opts: opts
-        )
-      end
-
-      def self.collect_payment_method(reader, params = {}, opts = {})
-        request_stripe_object(
-          method: :post,
-          path: format("/v1/terminal/readers/%<reader>s/collect_payment_method", { reader: CGI.escape(reader) }),
-          params: params,
-          opts: opts
-        )
-      end
-
-      def self.confirm_payment_intent(reader, params = {}, opts = {})
-        request_stripe_object(
-          method: :post,
-          path: format("/v1/terminal/readers/%<reader>s/confirm_payment_intent", { reader: CGI.escape(reader) }),
-          params: params,
-          opts: opts
-        )
-      end
-
       def self.process_payment_intent(reader, params = {}, opts = {})
         request_stripe_object(
           method: :post,

data/lib/stripe/resources.rb

@@ -3,7 +3,6 @@
 
 require "stripe/resources/account"
 require "stripe/resources/account_link"
-require "stripe/resources/account_notice"
 require "stripe/resources/account_session"
 require "stripe/resources/apple_pay_domain"
 require "stripe/resources/application_fee"
@@ -15,14 +14,13 @@ require "stripe/resources/bank_account"
 require "stripe/resources/billing_portal/configuration"
 require "stripe/resources/billing_portal/session"
 require "stripe/resources/capability"
-require "stripe/resources/capital/financing_offer"
-require "stripe/resources/capital/financing_summary"
-require "stripe/resources/capital/financing_transaction"
 require "stripe/resources/card"
 require "stripe/resources/cash_balance"
 require "stripe/resources/charge"
 require "stripe/resources/checkout/session"
-require "stripe/resources/confirmation_token"
+require "stripe/resources/climate/order"
+require "stripe/resources/climate/product"
+require "stripe/resources/climate/supplier"
 require "stripe/resources/country_spec"
 require "stripe/resources/coupon"
 require "stripe/resources/credit_note"
@@ -30,7 +28,6 @@ require "stripe/resources/credit_note_line_item"
 require "stripe/resources/customer"
 require "stripe/resources/customer_balance_transaction"
 require "stripe/resources/customer_cash_balance_transaction"
-require "stripe/resources/customer_session"
 require "stripe/resources/discount"
 require "stripe/resources/dispute"
 require "stripe/resources/ephemeral_key"
@@ -39,34 +36,24 @@ require "stripe/resources/exchange_rate"
 require "stripe/resources/file"
 require "stripe/resources/file_link"
 require "stripe/resources/financial_connections/account"
-require "stripe/resources/financial_connections/account_inferred_balance"
 require "stripe/resources/financial_connections/account_owner"
 require "stripe/resources/financial_connections/account_ownership"
 require "stripe/resources/financial_connections/session"
-require "stripe/resources/financial_connections/transaction"
 require "stripe/resources/funding_instructions"
-require "stripe/resources/gift_cards/card"
-require "stripe/resources/gift_cards/transaction"
 require "stripe/resources/identity/verification_report"
 require "stripe/resources/identity/verification_session"
 require "stripe/resources/invoice"
 require "stripe/resources/invoice_item"
 require "stripe/resources/invoice_line_item"
-require "stripe/resources/invoice_payment"
 require "stripe/resources/issuing/authorization"
 require "stripe/resources/issuing/card"
 require "stripe/resources/issuing/cardholder"
-require "stripe/resources/issuing/credit_underwriting_record"
 require "stripe/resources/issuing/dispute"
-require "stripe/resources/issuing/personalization_design"
-require "stripe/resources/issuing/physical_bundle"
 require "stripe/resources/issuing/token"
 require "stripe/resources/issuing/transaction"
 require "stripe/resources/line_item"
 require "stripe/resources/login_link"
 require "stripe/resources/mandate"
-require "stripe/resources/margin"
-require "stripe/resources/order"
 require "stripe/resources/payment_intent"
 require "stripe/resources/payment_link"
 require "stripe/resources/payment_method"
@@ -79,9 +66,6 @@ require "stripe/resources/price"
 require "stripe/resources/product"
 require "stripe/resources/promotion_code"
 require "stripe/resources/quote"
-require "stripe/resources/quote_phase"
-require "stripe/resources/quote_preview_invoice"
-require "stripe/resources/quote_preview_subscription_schedule"
 require "stripe/resources/radar/early_fraud_warning"
 require "stripe/resources/radar/value_list"
 require "stripe/resources/radar/value_list_item"
@@ -101,7 +85,6 @@ require "stripe/resources/subscription_item"
 require "stripe/resources/subscription_schedule"
 require "stripe/resources/tax/calculation"
 require "stripe/resources/tax/calculation_line_item"
-require "stripe/resources/tax/form"
 require "stripe/resources/tax/registration"
 require "stripe/resources/tax/settings"
 require "stripe/resources/tax/transaction"

data/lib/stripe/stripe_client.rb

@@ -36,8 +36,7 @@ module Stripe
                 end
     end
 
-    attr_reader :config
-    attr_reader :options
+    attr_reader :config, :options
 
     # Gets a currently active `StripeClient`. Set for the current thread when
     # `StripeClient#request` is being run so that API operations being executed
@@ -80,9 +79,7 @@ module Stripe
             end
           end
 
-          if thread_context.default_connection_managers.empty?
-            pruned_contexts << thread_context
-          end
+          pruned_contexts << thread_context if thread_context.default_connection_managers.empty?
         end
 
         @thread_contexts_with_connection_managers.subtract(pruned_contexts)
@@ -120,7 +117,7 @@ module Stripe
       when Net::OpenTimeout, Net::ReadTimeout
         # Retry on timeout-related problems (either on open or read).
         true
-      when EOFError, Errno::ECONNREFUSED, Errno::ECONNRESET,
+      when EOFError, Errno::ECONNREFUSED, Errno::ECONNRESET, # rubocop:todo Lint/DuplicateBranch
             Errno::EHOSTUNREACH, Errno::ETIMEDOUT, SocketError
         # Destination refused the connection, the connection was reset, or a
         # variety of other connection failures. This could occur from a single
@@ -212,10 +209,9 @@ module Stripe
     end
 
     def execute_request(method, path,
-                        api_base: nil, api_key: nil,
-                        headers: {}, params: {}, api_mode: nil)
+                        api_base: nil, api_key: nil, headers: {}, params: {})
       http_resp, api_key = execute_request_internal(
-        method, path, api_base, api_key, headers, params, api_mode
+        method, path, api_base, api_key, headers, params
       )
 
       begin
@@ -246,7 +242,6 @@ module Stripe
     def execute_request_stream(method, path,
                                api_base: nil, api_key: nil,
                                headers: {}, params: {},
-                               api_mode: nil,
                                &read_body_chunk_block)
       unless block_given?
         raise ArgumentError,
@@ -254,8 +249,7 @@ module Stripe
       end
 
       http_resp, api_key = execute_request_internal(
-        method, path, api_base, api_key,
-        headers, params, api_mode, &read_body_chunk_block
+        method, path, api_base, api_key, headers, params, &read_body_chunk_block
       )
 
       # When the read_body_chunk_block is given, we no longer have access to the
@@ -290,21 +284,21 @@ module Stripe
 
     ERROR_MESSAGE_CONNECTION =
       "Unexpected error communicating when trying to connect to " \
-        "Stripe (%s). You may be seeing this message because your DNS is not " \
-        "working or you don't have an internet connection.  To check, try " \
-        "running `host stripe.com` from the command line."
+      "Stripe (%s). You may be seeing this message because your DNS is not " \
+      "working or you don't have an internet connection.  To check, try " \
+      "running `host stripe.com` from the command line."
     ERROR_MESSAGE_SSL =
       "Could not establish a secure connection to Stripe (%s), you " \
-        "may need to upgrade your OpenSSL version. To check, try running " \
-        "`openssl s_client -connect api.stripe.com:443` from the command " \
-        "line."
+      "may need to upgrade your OpenSSL version. To check, try running " \
+      "`openssl s_client -connect api.stripe.com:443` from the command " \
+      "line."
 
     # Common error suffix sared by both connect and read timeout messages.
     ERROR_MESSAGE_TIMEOUT_SUFFIX =
       "Please check your internet connection and try again. " \
-        "If this problem persists, you should check Stripe's service " \
-        "status at https://status.stripe.com, or let us know at " \
-        "support@stripe.com."
+      "If this problem persists, you should check Stripe's service " \
+      "status at https://status.stripe.com, or let us know at " \
+      "support@stripe.com."
 
     ERROR_MESSAGE_TIMEOUT_CONNECT = (
       "Timed out connecting to Stripe (%s). " +
@@ -435,7 +429,7 @@ module Stripe
 
     private def execute_request_internal(method, path,
                                          api_base, api_key, headers, params,
-                                         api_mode, &read_body_chunk_block)
+                                         &read_body_chunk_block)
       raise ArgumentError, "method should be a symbol" \
       unless method.is_a?(Symbol)
       raise ArgumentError, "path should be a string" \
@@ -443,10 +437,9 @@ module Stripe
 
       api_base ||= config.api_base
       api_key ||= config.api_key
-      authenticator ||= config.authenticator
       params = Util.objects_to_ids(params)
 
-      check_keys!(api_key, authenticator)
+      check_api_key!(api_key)
 
       body_params = nil
       query_params = nil
@@ -459,9 +452,8 @@ module Stripe
 
       query_params, path = merge_query_params(query_params, path)
 
-      headers = request_headers(api_key, method, api_mode)
+      headers = request_headers(api_key, method)
                 .update(Util.normalize_headers(headers))
-
       url = api_url(path, api_base)
 
       # Merge given query parameters with any already encoded in the path.
@@ -472,16 +464,13 @@ module Stripe
       # a log-friendly variant of the encoded form. File objects are displayed
       # as such instead of as their file contents.
       body, body_log =
-        body_params ? encode_body(body_params, headers, api_mode) : [nil, nil]
-
-      authenticator.authenticate(method, headers, body) unless api_key
+        body_params ? encode_body(body_params, headers) : [nil, nil]
 
       # stores information on the request we're about to make so that we don't
       # have to pass as many parameters around for logging.
       context = RequestLogContext.new
       context.account         = headers["Stripe-Account"]
       context.api_key         = api_key
-      context.authenticator   = authenticator
       context.api_version     = headers["Stripe-Version"]
       context.body            = body_log
       context.idempotency_key = headers["Idempotency-Key"]
@@ -496,9 +485,7 @@ module Stripe
       response_block =
         if block_given?
           lambda do |response|
-            unless should_handle_as_error(response.code.to_i)
-              response.read_body(&read_body_chunk_block)
-            end
+            response.read_body(&read_body_chunk_block) unless should_handle_as_error(response.code.to_i)
           end
         end
 
@@ -520,35 +507,27 @@ module Stripe
       (api_base || config.api_base) + url
     end
 
-    private def check_keys!(api_key, authenticator)
-      if api_key && authenticator
-        raise AuthenticationError, "Can't specify both API key " \
-          "and authenticator. Either set your API key" \
-          'using "Stripe.api_key = <API-KEY>", or set your authenticator ' \
-          'using "Stripe.authenticator = <AUTHENTICATOR>"' \
-      end
-
-      unless api_key || authenticator
-        # Default to missing API key error message for general users.
+    private def check_api_key!(api_key)
+      unless api_key
         raise AuthenticationError, "No API key provided. " \
-          'Set your API key using "Stripe.api_key = <API-KEY>". ' \
-          "You can generate API keys from the Stripe web interface. " \
-          "See https://stripe.com/api for details, or email " \
-          "support@stripe.com if you have any questions."
+                                   'Set your API key using "Stripe.api_key = <API-KEY>". ' \
+                                   "You can generate API keys from the Stripe web interface. " \
+                                   "See https://stripe.com/api for details, or email " \
+                                   "support@stripe.com if you have any questions."
       end
 
       return unless api_key =~ /\s/
 
       raise AuthenticationError, "Your API key is invalid, as it contains " \
-        "whitespace. (HINT: You can double-check your API key from the " \
-        "Stripe web interface. See https://stripe.com/api for details, or " \
-        "email support@stripe.com if you have any questions.)"
+                                 "whitespace. (HINT: You can double-check your API key from the " \
+                                 "Stripe web interface. See https://stripe.com/api for details, or " \
+                                 "email support@stripe.com if you have any questions.)"
     end
 
     # Encodes a set of body parameters using multipart if `Content-Type` is set
     # for that, or standard form-encoding otherwise. Returns the encoded body
     # and a version of the encoded body that's safe to be logged.
-    private def encode_body(body_params, headers, api_mode)
+    private def encode_body(body_params, headers)
       body = nil
       flattened_params = Util.flatten_params(body_params)
 
@@ -564,22 +543,15 @@ module Stripe
         flattened_params =
           flattened_params.map { |k, v| [k, v.is_a?(String) ? v : v.to_s] }.to_h
 
-      elsif api_mode == :preview
-        body = JSON.generate(body_params)
-        headers["Content-Type"] = "application/json"
       else
         body = Util.encode_parameters(body_params)
       end
 
-      if api_mode == :preview
-        body_log = body
-      else
-        # We don't use `Util.encode_parameters` partly as an optimization (to
-        # not redo work we've already done), and partly because the encoded
-        # forms of certain characters introduce a lot of visual noise and it's
-        # nice to have a clearer format for logs.
-        body_log = flattened_params.map { |k, v| "#{k}=#{v}" }.join("&")
-      end
+      # We don't use `Util.encode_parameters` partly as an optimization (to not
+      # redo work we've already done), and partly because the encoded forms of
+      # certain characters introduce a lot of visual noise and it's nice to
+      # have a clearer format for logs.
+      body_log = flattened_params.map { |k, v| "#{k}=#{v}" }.join("&")
 
       [body, body_log]
     end
@@ -605,9 +577,7 @@ module Stripe
         http_status = resp.code.to_i
         context = context.dup_from_response_headers(resp)
 
-        if should_handle_as_error(http_status)
-          handle_error_response(resp, context)
-        end
+        handle_error_response(resp, context) if should_handle_as_error(http_status)
 
         log_response(context, request_start, http_status, resp.body, resp)
         notify_request_end(context, request_duration, http_status,
@@ -657,7 +627,7 @@ module Stripe
 
         # Only handle errors when we know we can do so, and re-raise otherwise.
         # This should be pretty infrequent.
-        else
+        else # rubocop:todo Lint/DuplicateBranch
           raise
         end
       end
@@ -768,11 +738,10 @@ module Stripe
     end
 
     private def specific_api_error(resp, error_data, context)
-      message = error_data[:message]
       Util.log_error("Stripe API error",
                      status: resp.http_status,
                      error_code: error_data[:code],
-                     error_message: message,
+                     error_message: error_data[:message],
                      error_param: error_data[:param],
                      error_type: error_data[:type],
                      idempotency_key: context.idempotency_key,
@@ -793,26 +762,26 @@ module Stripe
       when 400, 404
         case error_data[:type]
         when "idempotency_error"
-          IdempotencyError.new(message, **opts)
+          IdempotencyError.new(error_data[:message], **opts)
         else
           InvalidRequestError.new(
-            message, error_data[:param],
+            error_data[:message], error_data[:param],
             **opts
           )
         end
       when 401
-        AuthenticationError.new(message, **opts)
+        AuthenticationError.new(error_data[:message], **opts)
       when 402
         CardError.new(
-          message, error_data[:param],
+          error_data[:message], error_data[:param],
           **opts
         )
       when 403
-        PermissionError.new(message, **opts)
+        PermissionError.new(error_data[:message], **opts)
       when 429
-        RateLimitError.new(message, **opts)
+        RateLimitError.new(error_data[:message], **opts)
       else
-        APIError.new(message, **opts)
+        APIError.new(error_data[:message], **opts)
       end
     end
 
@@ -868,7 +837,7 @@ module Stripe
 
       if errors.nil?
         message = "Unexpected error #{error.class.name} communicating " \
-          "with Stripe. Please let us know at support@stripe.com."
+                  "with Stripe. Please let us know at support@stripe.com."
       end
 
       api_base ||= config.api_base
@@ -880,22 +849,16 @@ module Stripe
             message + "\n\n(Network error: #{error.message})"
     end
 
-    private def request_headers(api_key, method, api_mode)
+    private def request_headers(api_key, method)
       user_agent = "Stripe/v1 RubyBindings/#{Stripe::VERSION}"
-      unless Stripe.app_info.nil?
-        user_agent += " " + format_app_info(Stripe.app_info)
-      end
+      user_agent += " " + format_app_info(Stripe.app_info) unless Stripe.app_info.nil?
 
       headers = {
         "User-Agent" => user_agent,
         "Authorization" => "Bearer #{api_key}",
+        "Content-Type" => "application/x-www-form-urlencoded",
       }
 
-      if api_mode != :preview
-        # TODO: (major) don't set Content-Type if method is not post
-        headers["Content-Type"] = "application/x-www-form-urlencoded"
-      end
-
       if config.enable_telemetry? && !@last_request_metrics.nil?
         headers["X-Stripe-Client-Telemetry"] = JSON.generate(
           last_request_metrics: @last_request_metrics.payload
@@ -908,12 +871,7 @@ module Stripe
         headers["Idempotency-Key"] ||= SecureRandom.uuid
       end
 
-      if api_mode == :preview
-        headers["Stripe-Version"] = ApiVersion::PREVIEW
-      elsif config.api_version
-        headers["Stripe-Version"] = config.api_version
-      end
-
+      headers["Stripe-Version"] = config.api_version if config.api_version
       headers["Stripe-Account"] = config.stripe_account if config.stripe_account
 
       user_agent = @system_profiler.user_agent
@@ -996,16 +954,7 @@ module Stripe
     # that we can log certain information. It's useful because it means that we
     # don't have to pass around as many parameters.
     class RequestLogContext
-      attr_accessor :body
-      attr_accessor :account
-      attr_accessor :api_key
-      attr_accessor :authenticator
-      attr_accessor :api_version
-      attr_accessor :idempotency_key
-      attr_accessor :method
-      attr_accessor :path
-      attr_accessor :query
-      attr_accessor :request_id
+      attr_accessor :body, :account, :api_key, :api_version, :idempotency_key, :method, :path, :query, :request_id
 
       # The idea with this method is that we might want to update some of
       # context information because a response that we've received from the API

data/lib/stripe/stripe_configuration.rb

@@ -25,27 +25,12 @@ module Stripe
   # If `.logger` is set, the value of `.log_level` is ignored. The decision on
   # what levels to print is entirely deferred to the logger.
   class StripeConfiguration
-    attr_accessor :api_key
-    attr_accessor :api_version
-    attr_accessor :authenticator
-    attr_accessor :client_id
-    attr_accessor :enable_telemetry
-    attr_accessor :logger
-    attr_accessor :stripe_account
-
-    attr_reader :api_base
-    attr_reader :uploads_base
-    attr_reader :connect_base
-    attr_reader :ca_bundle_path
-    attr_reader :log_level
-    attr_reader :initial_network_retry_delay
-    attr_reader :max_network_retries
-    attr_reader :max_network_retry_delay
-    attr_reader :open_timeout
-    attr_reader :read_timeout
-    attr_reader :write_timeout
-    attr_reader :proxy
-    attr_reader :verify_ssl_certs
+    attr_accessor :api_key, :api_version, :client_id, :enable_telemetry, :logger, :stripe_account
+
+    attr_reader :api_base, :uploads_base, :connect_base, :ca_bundle_path, :log_level, :initial_network_retry_delay,
+                # rubocop:todo Layout/LineLength
+                :max_network_retries, :max_network_retry_delay, :open_timeout, :read_timeout, :write_timeout, :proxy, :verify_ssl_certs
+    # rubocop:enable Layout/LineLength
 
     def self.setup
       new.tap do |instance|
@@ -65,7 +50,6 @@ module Stripe
 
     def initialize
       @api_version = ApiVersion::CURRENT
-
       @ca_bundle_path = Stripe::DEFAULT_CA_BUNDLE_PATH
       @enable_telemetry = true
       @verify_ssl_certs = true
@@ -97,8 +81,8 @@ module Stripe
 
       if !val.nil? && !levels.include?(val)
         raise ArgumentError,
-              "log_level should only be set to `nil`, `debug`, `info`," \
-              " or `error`"
+              "log_level should only be set to `nil`, `debug`, `info`, " \
+              "or `error`"
       end
       @log_level = val
     end
@@ -126,9 +110,7 @@ module Stripe
     end
 
     def write_timeout=(write_timeout)
-      unless Net::HTTP.instance_methods.include?(:write_timeout=)
-        raise NotImplementedError
-      end
+      raise NotImplementedError unless Net::HTTP.instance_methods.include?(:write_timeout=)
 
       @write_timeout = write_timeout
       StripeClient.clear_all_connection_managers(config: self)
@@ -179,10 +161,10 @@ module Stripe
     # and is itself not thread safe.
     def ca_store
       @ca_store ||= begin
-                      store = OpenSSL::X509::Store.new
-                      store.add_file(ca_bundle_path)
-                      store
-                    end
+        store = OpenSSL::X509::Store.new
+        store.add_file(ca_bundle_path)
+        store
+      end
     end
 
     def enable_telemetry?

data/lib/stripe/stripe_object.rb

@@ -320,8 +320,8 @@ module Stripe
               # Here we swallow that error and issue a warning so at least
               # the program doesn't crash.
               warn("WARNING: Unable to remove method `#{method_name}`; " \
-                "if custom, please consider renaming to a name that doesn't " \
-                "collide with an API property name.")
+                   "if custom, please consider renaming to a name that doesn't " \
+                   "collide with an API property name.")
             end
           end
         end
@@ -351,17 +351,15 @@ module Stripe
           define_method(:"#{k}=") do |v|
             if v == ""
               raise ArgumentError, "You cannot set #{k} to an empty string. " \
-                "We interpret empty strings as nil in requests. " \
-                "You may set (object).#{k} = nil to delete the property."
+                                   "We interpret empty strings as nil in requests. " \
+                                   "You may set (object).#{k} = nil to delete the property."
             end
             @values[k] = Util.convert_to_stripe_object(v, @opts)
             dirty_value!(@values[k])
             @unsaved_values.add(k)
           end
 
-          if [FalseClass, TrueClass].include?(values[k].class)
-            define_method(:"#{k}?") { @values[k] }
-          end
+          define_method(:"#{k}?") { @values[k] } if [FalseClass, TrueClass].include?(values[k].class)
         end
       end
     end
@@ -369,7 +367,6 @@ module Stripe
     # Disabling the cop because it's confused by the fact that the methods are
     # protected, but we do define `#respond_to_missing?` just below. Hopefully
     # this is fixed in more recent Rubocop versions.
-    # rubocop:disable Style/MissingRespondToMissing
     protected def method_missing(name, *args)
       # TODO: only allow setting in updateable classes.
       if name.to_s.end_with?("=")
@@ -405,16 +402,14 @@ module Stripe
 
         raise NoMethodError,
               e.message + ".  HINT: The '#{name}' attribute was set in the " \
-              "past, however.  It was then wiped when refreshing the object " \
-              "with the result returned by Stripe's API, probably as a " \
-              "result of a save().  The attributes currently available on " \
-              "this object are: #{@values.keys.join(', ')}"
+                          "past, however.  It was then wiped when refreshing the object " \
+                          "with the result returned by Stripe's API, probably as a " \
+                          "result of a save().  The attributes currently available on " \
+                          "this object are: #{@values.keys.join(', ')}"
       end
     end
-    # rubocop:enable Style/MissingRespondToMissing
-
     protected def respond_to_missing?(symbol, include_private = false)
-      @values && @values.key?(symbol) || super
+      (@values && @values.key?(symbol)) || super
     end
 
     # Re-initializes the object based on a hash of values (usually one that's
@@ -460,7 +455,8 @@ module Stripe
       self
     end
 
-    protected def serialize_params_value(value, original, unsaved, force,
+    # rubocop:todo Metrics/PerceivedComplexity
+    protected def serialize_params_value(value, original, unsaved, force, # rubocop:todo Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
                                          key: nil)
       if value.nil?
         ""
@@ -494,8 +490,8 @@ module Stripe
           value
         else
           raise ArgumentError, "Cannot save property `#{key}` containing " \
-            "an API resource. It doesn't appear to be persisted and is " \
-            "not marked as `save_with_parent`."
+                               "an API resource. It doesn't appear to be persisted and is " \
+                               "not marked as `save_with_parent`."
         end
 
       elsif value.is_a?(Array)
@@ -535,6 +531,7 @@ module Stripe
         value
       end
     end
+    # rubocop:enable Metrics/PerceivedComplexity
 
     # Produces a deep copy of the given object including support for arrays,
     # hashes, and StripeObjects.