stripe 1.8.8 → 1.9.9

data/History.txt

@@ -1,3 +1,13 @@
+=== 1.9.9 2013-12-02
+
+* Add ApplicationFee API resource
+
+=== 1.8.9 2013-11-14
+
+* 2 bugfixes:
+  * Fix gemspec dependencies so the gem doesn't break for Ruby 1.8 users
+  * Fix api_resource_test to not use returns as a way of testing rescue behavior
+
 === 1.8.8 2013-10-3
 
 * Add support for metadata API

data/VERSION

@@ -1 +1 @@
-1.8.8
+1.9.9

data/lib/stripe.rb

@@ -36,6 +36,7 @@ require 'stripe/event'
 require 'stripe/transfer'
 require 'stripe/recipient'
 require 'stripe/card'
+require 'stripe/application_fee'
 
 # Errors
 require 'stripe/errors/stripe_error'

data/lib/stripe/application_fee.rb

@@ -0,0 +1,21 @@
+module Stripe
+  class ApplicationFee < APIResource
+    include Stripe::APIOperations::List
+
+    def self.url
+      '/v1/application_fees'
+    end
+
+    def refund(params={})
+      response, api_key = Stripe.request(:post, refund_url, @api_key, params)
+      refresh_from(response, api_key)
+      self
+    end
+
+    private
+
+    def refund_url
+      url + '/refund'
+    end
+  end
+end

data/lib/stripe/util.rb

@@ -29,7 +29,8 @@ module Stripe
         'transfer' => Transfer,
         'recipient' => Recipient,
         'card' => Card,
-        'list' => ListObject
+        'list' => ListObject,
+        'application_fee' => ApplicationFee
       }
     end
 

data/lib/stripe/version.rb

@@ -1,3 +1,3 @@
 module Stripe
-  VERSION = '1.8.8'
+  VERSION = '1.9.9'
 end

data/stripe.gemspec

@@ -12,6 +12,7 @@ spec = Gem::Specification.new do |s|
   s.homepage = 'https://stripe.com/api'
 
   s.add_dependency('rest-client', '~> 1.4')
+  s.add_dependency('mime-types', '~> 1.25')
   s.add_dependency('multi_json', '>= 1.0.4', '< 2')
 
   s.add_development_dependency('mocha', '~> 0.13.2')

data/test/stripe/api_resource_test.rb

@@ -5,12 +5,12 @@ module Stripe
   class ApiResourceTest < Test::Unit::TestCase
     should "creating a new APIResource should not fetch over the network" do
       @mock.expects(:get).never
-      c = Stripe::Customer.new("someid")
+      Stripe::Customer.new("someid")
     end
 
     should "creating a new APIResource from a hash should not fetch over the network" do
       @mock.expects(:get).never
-      c = Stripe::Customer.construct_from({
+      Stripe::Customer.construct_from({
         :id => "somecustomer",
         :card => {:id => "somecard", :object => "card"},
         :object => "customer"
@@ -185,14 +185,14 @@ module Stripe
           (url =~ %r{^#{Stripe.api_base}/v1/charges?} &&
            query.keys.sort == ['offset', 'sad'])
         end.returns(test_response({ :count => 1, :data => [test_charge] }))
-        c = Stripe::Charge.all(:count => nil, :offset => 5, :sad => false)
+        Stripe::Charge.all(:count => nil, :offset => 5, :sad => false)
 
         @mock.expects(:post).with do |url, api_key, params|
-          url == "#{Stripe.api_base}/v1/charges" && 
-            api_key.nil? && 
+          url == "#{Stripe.api_base}/v1/charges" &&
+            api_key.nil? &&
             CGI.parse(params) == { 'amount' => ['50'], 'currency' => ['usd'] }
         end.returns(test_response({ :count => 1, :data => [test_charge] }))
-        c = Stripe::Charge.create(:amount => 50, :currency => 'usd', :card => { :number => nil })
+        Stripe::Charge.create(:amount => 50, :currency => 'usd', :card => { :number => nil })
       end
 
       should "requesting with a unicode ID should result in a request" do
@@ -210,7 +210,7 @@ module Stripe
       should "making a GET request with parameters should have a query string and no body" do
         params = { :limit => 1 }
         @mock.expects(:get).once.with("#{Stripe.api_base}/v1/charges?limit=1", nil, nil).returns(test_response([test_charge]))
-        c = Stripe::Charge.all(params)
+        Stripe::Charge.all(params)
       end
 
       should "making a POST request with parameters should have a body and no query string" do
@@ -218,7 +218,7 @@ module Stripe
         @mock.expects(:post).once.with do |url, get, post|
           get.nil? && CGI.parse(post) == {'amount' => ['100'], 'currency' => ['usd'], 'card' => ['sc_token']}
         end.returns(test_response(test_charge))
-        c = Stripe::Charge.create(params)
+        Stripe::Charge.create(params)
       end
 
       should "loading an object should issue a GET request" do
@@ -294,50 +294,53 @@ module Stripe
           response = test_response(test_missing_id_error, 404)
           @mock.expects(:get).once.raises(RestClient::ExceptionWithResponse.new(response, 404))
 
+          rescued = false
           begin
             Stripe::Customer.new("test_customer").refresh
             assert false #shouldn't get here either
           rescue Stripe::InvalidRequestError => e # we don't use assert_raises because we want to examine e
+            rescued = true
             assert e.kind_of? Stripe::InvalidRequestError
             assert_equal "id", e.param
             assert_equal "Missing id", e.message
-            return
           end
 
-          assert false #shouldn't get here
+          assert_equal true, rescued
         end
 
         should "5XXs should raise an APIError" do
           response = test_response(test_api_error, 500)
           @mock.expects(:get).once.raises(RestClient::ExceptionWithResponse.new(response, 500))
 
+          rescued = false
           begin
             Stripe::Customer.new("test_customer").refresh
             assert false #shouldn't get here either
           rescue Stripe::APIError => e # we don't use assert_raises because we want to examine e
+            rescued = true
             assert e.kind_of? Stripe::APIError
-            return
           end
 
-          assert false #shouldn't get here
+          assert_equal true, rescued
         end
 
         should "402s should raise a CardError" do
           response = test_response(test_invalid_exp_year_error, 402)
           @mock.expects(:get).once.raises(RestClient::ExceptionWithResponse.new(response, 402))
 
+          rescued = false
           begin
             Stripe::Customer.new("test_customer").refresh
             assert false #shouldn't get here either
           rescue Stripe::CardError => e # we don't use assert_raises because we want to examine e
+            rescued = true
             assert e.kind_of? Stripe::CardError
             assert_equal "invalid_expiry_year", e.code
             assert_equal "exp_year", e.param
             assert_equal "Your card's expiration year is invalid", e.message
-            return
           end
 
-          assert false #shouldn't get here
+          assert_equal true, rescued
         end
       end
     end

data/test/stripe/application_fee_test.rb

@@ -0,0 +1,22 @@
+require File.expand_path('../../test_helper', __FILE__)
+
+module Stripe
+  class ApplicationFeeTest < Test::Unit::TestCase
+    should "application fees should be listable" do
+      @mock.expects(:get).once.returns(test_response(test_application_fee_array))
+      fees = Stripe::ApplicationFee.all
+      assert fees.data.kind_of? Array
+      fees.each do |fee|
+        assert fee.kind_of?(Stripe::ApplicationFee)
+      end
+    end
+
+    should "application fees should be refundable" do
+      @mock.expects(:get).never
+      @mock.expects(:post).once.returns(test_response({:id => "fee_test_fee", :refunded => true}))
+      fee = Stripe::ApplicationFee.new("test_application_fee")
+      fee.refund
+      assert fee.refunded
+    end
+  end
+end

data/test/stripe/customer_test.rb

@@ -52,10 +52,10 @@ module Stripe
       # Not an accurate response, but whatever
 
       @mock.expects(:delete).once.with("#{Stripe.api_base}/v1/customers/c_test_customer/subscription?at_period_end=true", nil, nil).returns(test_response(test_subscription('silver')))
-      s = c.cancel_subscription({:at_period_end => 'true'})
+      c.cancel_subscription({:at_period_end => 'true'})
 
       @mock.expects(:delete).once.with("#{Stripe.api_base}/v1/customers/c_test_customer/subscription", nil, nil).returns(test_response(test_subscription('silver')))
-      s = c.cancel_subscription
+      c.cancel_subscription
     end
 
     should "be able to delete a customer's discount" do
@@ -63,7 +63,7 @@ module Stripe
       c = Stripe::Customer.retrieve("test_customer")
 
       @mock.expects(:delete).once.with("#{Stripe.api_base}/v1/customers/c_test_customer/discount", nil, nil).returns(test_response(test_delete_discount_response))
-      s = c.delete_discount
+      c.delete_discount
       assert_equal nil, c.discount
     end
   end

data/test/test_helper.rb

@@ -70,6 +70,29 @@ def test_balance_transaction_array
   }
 end
 
+def test_application_fee(params={})
+  {
+    :refunded => false,
+    :amount => 100,
+    :application => "ca_test_application",
+    :user => "acct_test_user",
+    :charge => "ch_test_charge",
+    :id => "fee_test_fee",
+    :livemode => false,
+    :currency => "usd",
+    :object => "application_fee",
+    :created => 1304114826
+  }.merge(params)
+end
+
+def test_application_fee_array
+  {
+    :data => [test_application_fee, test_application_fee, test_application_fee],
+    :object => 'list',
+    :url => '/v1/application_fees'
+  }
+end
+
 def test_customer(params={})
   {
     :subscription_history => [],

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: stripe
 version: !ruby/object:Gem::Version
-  version: 1.8.8
+  version: 1.9.9
   prerelease: 
 platform: ruby
 authors:
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-18 00:00:00.000000000 Z
+date: 2013-12-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client
@@ -28,6 +28,22 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: '1.4'
+- !ruby/object:Gem::Dependency
+  name: mime-types
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '1.25'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '1.25'
 - !ruby/object:Gem::Dependency
   name: multi_json
   requirement: !ruby/object:Gem::Requirement
@@ -145,6 +161,7 @@ files:
 - lib/stripe/api_operations/list.rb
 - lib/stripe/api_operations/update.rb
 - lib/stripe/api_resource.rb
+- lib/stripe/application_fee.rb
 - lib/stripe/balance.rb
 - lib/stripe/balance_transaction.rb
 - lib/stripe/card.rb
@@ -173,6 +190,7 @@ files:
 - stripe.gemspec
 - test/stripe/account_test.rb
 - test/stripe/api_resource_test.rb
+- test/stripe/application_fee_test.rb
 - test/stripe/charge_test.rb
 - test/stripe/coupon_test.rb
 - test/stripe/customer_test.rb
@@ -208,6 +226,7 @@ summary: Ruby bindings for the Stripe API
 test_files:
 - test/stripe/account_test.rb
 - test/stripe/api_resource_test.rb
+- test/stripe/application_fee_test.rb
 - test/stripe/charge_test.rb
 - test/stripe/coupon_test.rb
 - test/stripe/customer_test.rb