stripe 1.56.0 → 1.56.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3b273184e3b48184ef5e176b93ffdb3718a6a14d
-  data.tar.gz: 87924962ce71917ba07bba6c569ebbf1094460c8
+  metadata.gz: 7d9f405c4db8edc9240894eb3099379d3d0087a6
+  data.tar.gz: da77c34e7d3266080224c70e49535273963b93d4
 SHA512:
-  metadata.gz: c9af5980662e32de67a8b82fe18b31643a5ec77f76c1314587dd8e32045d3bfeac449e790d459f2726cf4dc33eb5a0d530c09cd786a874189e4a27450c5ac804
-  data.tar.gz: f7cd412ac99de4bd45b62077a977d99db568408b710ab85af44ff17c8f9eb04b14064579adafd4f68a58a6e3601f693cb5e2690fd4c24128537fb4fe56ce5ab0
+  metadata.gz: 5dbde07ba469e1f1c4d6120bac0856037e7047a776308de7285c6378bb83c1ebf366550498eb894591f374d3982f3caae98d36466da5ba2beeb3c4835295d852
+  data.tar.gz: 088ce1eb0e4845edfaad0b804a5b8347d65a3eb8c5bfcb25bf6c005212858e6ee08bbf180905bfbebd4561f44187348c346fa86d1bcfade1ded9a05708a21702

data/.github/ISSUE_TEMPLATE.md

@@ -0,0 +1,5 @@
+Please only file issues here that you believe represent actual bugs or feature requests for the Stripe Ruby library.
+
+If you're having general trouble with your Stripe integration, please reach out to support using the form at https://support.stripe.com/ (preferred) or via email to support@stripe.com.
+
+If you are reporting a bug, please include your Ruby version and the version of the Stripe Ruby library you're using, as well as any other details that may be helpful in reproducing the problem.

data/History.txt

@@ -1,3 +1,7 @@
+=== 1.56.1 2016-11-09
+
+* Fix (fairly serious) memory like in `StripeObject`
+
 === 1.56.0 2016-10-24
 
 * Add accessors for new fields added in `#update_attributes`

data/VERSION

@@ -1 +1 @@
-1.56.0
+1.56.1

data/lib/stripe/stripe_object.rb

@@ -145,12 +145,6 @@ module Stripe
       construct_from(values, opts)
     end
 
-    if RUBY_VERSION < '1.9.2'
-      def respond_to?(symbol)
-        @values.has_key?(symbol) || super
-      end
-    end
-
     # Sets all keys within the StripeObject as unsaved so that they will be
     # included with an update when #serialize_params is called. This method is
     # also recursive, so any StripeObjects contained as values or which are
@@ -214,9 +208,13 @@ module Stripe
         keys.each do |k|
           next if f.include?(k)
           next if @@permanent_attributes.include?(k)
-          k_eq = :"#{k}="
-          remove_method(k) if method_defined?(k)
-          remove_method(k_eq) if method_defined?(k_eq)
+
+          # Remove methods for the accessor's reader and writer.
+          [k, :"#{k}=", :"#{k}?"].each do |method_name|
+            if method_defined?(method_name)
+              remove_method(method_name)
+            end
+          end
         end
       end
     end
@@ -227,9 +225,9 @@ module Stripe
         keys.each do |k|
           next if f.include?(k)
           next if @@permanent_attributes.include?(k)
-          k_eq = :"#{k}="
+
           define_method(k) { @values[k] }
-          define_method(k_eq) do |v|
+          define_method(:"#{k}=") do |v|
             if v == ""
               raise ArgumentError.new(
                 "You cannot set #{k} to an empty string. " \
@@ -242,8 +240,7 @@ module Stripe
           end
 
           if [FalseClass, TrueClass].include?(values[k].class)
-            k_bool = :"#{k}?"
-            define_method(k_bool) { @values[k] }
+            define_method(:"#{k}?") { @values[k] }
           end
         end
       end
@@ -305,10 +302,8 @@ module Stripe
       # customer, where there is no persistent card parameter.  Mark those values
       # which don't persist as transient
 
-      instance_eval do
-        remove_accessors(removed)
-        add_accessors(added, values)
-      end
+      remove_accessors(removed)
+      add_accessors(added, values)
 
       removed.each do |k|
         @values.delete(k)

data/lib/stripe/util.rb

@@ -63,7 +63,7 @@ module Stripe
     # array of +StripeObject+s. These new objects will be created as a concrete
     # type as dictated by their `object` field (e.g. an `object` value of
     # `charge` would create an instance of +Charge+), but if `object` is not
-    # present or of an unkown type, the newly created instance will fall back
+    # present or of an unknown type, the newly created instance will fall back
     # to being a +StripeObject+.
     #
     # ==== Attributes

data/lib/stripe/version.rb

@@ -1,3 +1,3 @@
 module Stripe
-  VERSION = '1.56.0'
+  VERSION = '1.56.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: stripe
 version: !ruby/object:Gem::Version
-  version: 1.56.0
+  version: 1.56.1
 platform: ruby
 authors:
 - Stripe
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-10-24 00:00:00.000000000 Z
+date: 2016-11-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client
@@ -38,6 +38,7 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/ISSUE_TEMPLATE.md"
 - ".gitignore"
 - ".travis.yml"
 - CONTRIBUTORS