stripe 1.53.0 → 1.54.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: aaac101c727d5f284f347ff3b73db94988bf1a00
-  data.tar.gz: f5d117727672e52096a19eb9e318cf61537480a9
+  metadata.gz: 2e8c4b76709e3ec68cbde150b1a649435e1e1f29
+  data.tar.gz: 702b785a0995a4eb697a97ff3b6699c54e139d37
 SHA512:
-  metadata.gz: cd86ad3e6fcd4dbef56323ce43076d9649c39a6f29e46b996c9144e215d480f8192e6d538b7986d6ac403d6f1347caa8cbdac4eeaddd9c7e2f9e5c85359b7ef5
-  data.tar.gz: 2d7d177a707880c9000a4291ab2e453f8d9cd9d2384097860519aed751722b69988e7410c89980d5a40f9a6e05fa2e64898a7fd0a23dc1e8bfc3c2d8cf9425d5
+  metadata.gz: e00542306c9b283d4a982fc5cdfce20e64f955517cca663baa0c2f6f5e9c0da7851f8895b9fa71c447e7fdfa785faa465cec2a930ec0064f3842bfbbcc9a247d
+  data.tar.gz: 5dd42345b9e9722cb4512010f6cffa56bac39c9ddcb4acfff228135fd3d4ac44c3098ca8f25abc7f371472a377c16783fad160ca545b454f23447ef3e65d1025

data/History.txt

@@ -1,3 +1,7 @@
+=== 1.54.0 2016-09-01
+
+* Whitelist errors that should be retried; scope to known socket and HTTP errors
+
 === 1.53.0 2016-08-31
 
 * Relax version constraint on rest-client (and by extension mime-types) for users on Ruby 2+

data/VERSION

@@ -1 +1 @@
-1.53.0
+1.54.0

data/lib/stripe.rb

@@ -70,10 +70,22 @@ require 'stripe/errors/rate_limit_error'
 module Stripe
   DEFAULT_CA_BUNDLE_PATH = File.dirname(__FILE__) + '/data/ca-certificates.crt'
 
-  # HTTP status exceptions which we'd like to retry. Most HTTP status
-  # exceptions are from a Stripe API server response, so we generally _don't_
-  # retry because doing so would have the same result as the original request.
-  RETRY_HTTP_EXCEPTIONS = [
+  # Exceptions which we'd like to retry. This includes both socket errors that
+  # may represent an intermittent problem and some special HTTP statuses.
+  RETRY_EXCEPTIONS = [
+    # Destination refused the connection. This could occur from a single
+    # saturated server, so retry in case it's intermittent.
+    Errno::ECONNREFUSED,
+
+    # Connection reset. This occasionally occurs on a server problem, and
+    # deserves a retry because the server should terminate all requests
+    # properly even if they were invalid.
+    Errno::ECONNRESET,
+
+    # Timed out making the connection. It's worth retrying under this
+    # circumstance.
+    Errno::ETIMEDOUT,
+
     # A server may respond with a 409 to indicate that there is a concurrent
     # request executing with the same idempotency key. In the case that a
     # request failed due to a connection problem and the client has retried too
@@ -442,18 +454,8 @@ module Stripe
   end
 
   def self.should_retry?(e, retry_count)
-    return false if retry_count >= self.max_network_retries
-
-    # Certificate validation problem: do not retry.
-    return false if e.is_a?(RestClient::SSLCertificateNotVerified)
-
-    # Generally don't retry when we got a successful response back from the
-    # Stripe API server, but with some exceptions (for more details, see notes
-    # on RETRY_HTTP_EXCEPTIONS).
-    return false if e.is_a?(RestClient::ExceptionWithResponse) &&
-      !RETRY_HTTP_EXCEPTIONS.any? { |klass| e.is_a?(klass) }
-
-    return true
+    retry_count < self.max_network_retries &&
+      RETRY_EXCEPTIONS.any? { |klass| e.is_a?(klass) }
   end
 
   def self.sleep_time(retry_count)

data/lib/stripe/version.rb

@@ -1,3 +1,3 @@
 module Stripe
-  VERSION = '1.53.0'
+  VERSION = '1.54.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: stripe
 version: !ruby/object:Gem::Version
-  version: 1.53.0
+  version: 1.54.0
 platform: ruby
 authors:
 - Stripe
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-31 00:00:00.000000000 Z
+date: 2016-09-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client