stripe 1.39.0 → 1.40.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d85fbb3d136599c0b9bae5cb778c12f9ae096d63
-  data.tar.gz: 67f6bc92701eb682d59e02475b40856cbcd809f2
+  metadata.gz: df8595ba1c8112e53a16598f41277d6fe8e0f120
+  data.tar.gz: c4511690653728df59c9e060ed1e01967fdd8e4e
 SHA512:
-  metadata.gz: 7862e43d639dd5fefe90dd86d08849f93632fe53bb32d891b501e0b57756dc6057edec00a1985baab7a2bfa5ad0314211798e4e892bdf331f1354d9bb936a84b
-  data.tar.gz: 45f6bbf7da450324722d0fa9d6f03ce3eaf22fc28cd56c2f82d1d181d6e6f3bf482e55df59a894fee7aff3ff903e235d5d1033881b26f0d19070fa5e7399748c
+  metadata.gz: abab2102477a032ee062eade9b36b4a99a2704c5e831d7e43d9500ca63e7d6bd800dd256ec6ee3525d585cde3b2da3244326a9c134e28125eb879ee65e30cd8a
+  data.tar.gz: 725cb8e7ac1c6899311a750a90b905451340b41f34ed5a737d420d20108791366beb7f475d384760497c2345a8a6b622b1e23c9472fbc18bc1c7b03a6b91ce96

data/History.txt

@@ -1,3 +1,7 @@
+=== 1.40.0 2016-04-06
+
+* Fix bug that omitted subresources from serialization
+
 === 1.39.0 2016-03-31
 
 * Update CA cert bundle for compatibility with OpenSSL versions below 1.0.1

data/VERSION

@@ -1 +1 @@
-1.39.0
+1.40.0

data/lib/stripe.rb

@@ -75,6 +75,7 @@ module Stripe
   @initial_network_retry_delay = 0.5
 
   @ca_bundle_path  = DEFAULT_CA_BUNDLE_PATH
+  @ca_store = nil
   @verify_ssl_certs = true
 
   @open_timeout = 30
@@ -111,7 +112,7 @@ module Stripe
 
     if verify_ssl_certs
       request_opts = {:verify_ssl => OpenSSL::SSL::VERIFY_PEER,
-                      :ssl_ca_file => @ca_bundle_path}
+                      :ssl_cert_store => ca_store}
     else
       request_opts = {:verify_ssl => false}
       unless @verify_ssl_warned
@@ -156,6 +157,26 @@ module Stripe
 
   def self.ca_bundle_path=(path)
     @ca_bundle_path = path
+
+    # empty this field so a new store is initialized
+    @ca_store = nil
+  end
+
+  # A certificate store initialized from the the bundle in #ca_bundle_path and
+  # which is used to validate TLS on every request.
+  #
+  # This was added to the give the gem "pseudo thread safety" in that it seems
+  # when initiating many parallel requests marshaling the certificate store is
+  # the most likely point of failure (see issue #382). Any program attempting
+  # to leverage this pseudo safety should make a call to this method (i.e.
+  # `Stripe.ca_store`) in their initialization code because it marshals lazily
+  # and is itself not thread safe.
+  def self.ca_store
+    @ca_store ||= begin
+      store = OpenSSL::X509::Store.new
+      store.add_file(ca_bundle_path)
+      store
+    end
   end
 
   def self.max_network_retries

data/lib/stripe/stripe_object.rb

@@ -329,14 +329,6 @@ module Stripe
       when nil
         ''
 
-      # The logic here is that essentially any object embedded in another
-      # object that had a `type` is actually an API resource of a different
-      # type that's been included in the response. These other resources must
-      # be updated from their proper endpoints, and therefore they are not
-      # included when serializing even if they've been modified.
-      when APIResource
-        nil
-
       when Array
         update = value.map { |v| serialize_params_value(v, nil, true, force) }
 

data/lib/stripe/version.rb

@@ -1,3 +1,3 @@
 module Stripe
-  VERSION = '1.39.0'
+  VERSION = '1.40.0'
 end

data/test/stripe/api_resource_test.rb

@@ -551,21 +551,6 @@ module Stripe
         acct.save
       end
 
-      should 'not save nested API resources' do
-        ch = Stripe::Charge.construct_from({
-          :id => 'charge_id',
-          :customer => {
-            :object => 'customer',
-            :id => 'customer_id'
-          }
-        })
-
-        @mock.expects(:post).once.with("#{Stripe.api_base}/v1/charges/charge_id", nil, '').returns(make_response({"id" => "charge_id"}))
-
-        ch.customer.description = 'Bob'
-        ch.save
-      end
-
       should 'correctly handle replaced nested objects' do
         acct = Stripe::Account.construct_from({
           :id => 'myid',

data/test/stripe/stripe_object_test.rb

@@ -240,15 +240,6 @@ module Stripe
       assert_equal([{ :foo => "bar" }], serialized[:metadata])
     end
 
-    should "#serialize_params and remove embedded APIResources" do
-      obj = Stripe::StripeObject.construct_from({
-        :customer => Customer.construct_from({})
-      })
-
-      serialized = obj.serialize_params
-      assert_equal({}, serialized)
-    end
-
     should "#serialize_params takes a force option" do
       obj = Stripe::StripeObject.construct_from({
         :id => 'id',

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: stripe
 version: !ruby/object:Gem::Version
-  version: 1.39.0
+  version: 1.40.0
 platform: ruby
 authors:
 - Ross Boucher
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-03-31 00:00:00.000000000 Z
+date: 2016-04-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client