stripe 1.35.0 → 1.35.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f50fd1e27e8c051d54b1b3c25f043023dd4ad639
-  data.tar.gz: 0c181ec61f06f8930b9e869417c78d7399d98ebe
+  metadata.gz: ba258c6ce34968c0caaadec16763905ff632084a
+  data.tar.gz: d80c2169b9ae78b37236a3124419679c7a2a93f7
 SHA512:
-  metadata.gz: af8a5469317dfc41a081c8d8e744297f778844a50f2a8699a66790638abb97081eb0660f044478ab176ec9f5f8ebcae2ea42573173f888542cf2c2b158648b82
-  data.tar.gz: b3db8bd2ead8c03e0d7b0c2914e50f695b75f6030e606bcb2783c1c7b37257238eb56f8cf0dcda741fd80289c9093afe0803ea3a4b56cf5723b69c38adb3b0ab
+  metadata.gz: dcf9630e2a0cf7e77bd21a933c00f91808418913a87b367ba7d4e19add2e9fda9b9632d6c111e9e9fa8ca1b575d75f1f1c44888dcf814017e14c46672b4cd67e
+  data.tar.gz: 1e28646f0b94e1c56d7acd5440d17707b1b247e2c1a593595520ee650a6de08a402548e8c3c9f9d0866ba0d8ac2b02740f84faf4f111042604caaccd33810ee7

data/History.txt

@@ -1,3 +1,7 @@
+=== 1.35.1 2016-02-03
+
+* Add compatibility layer for old API versions on `Charge#refund`
+
 === 1.35.0 2016-02-01
 
 * Allow CA cert bundle location to be configured

data/VERSION

@@ -1 +1 @@
-1.35.0
+1.35.1

data/lib/stripe/charge.rb

@@ -5,12 +5,24 @@ module Stripe
     include Stripe::APIOperations::Update
 
     def refund(params={}, opts={})
-      self.refunds.create(params, opts)
+      # Old versions of charge objects included a `refunds` field that was just
+      # a vanilla array instead of a Stripe list object.
+      #
+      # Where possible, we'd still like to use the new refund endpoint (thus
+      # `self.refunds.create`), but detect the old API version by looking for
+      # an `Array` and fall back to the old refund URL if necessary so as to
+      # maintain internal compatibility.
+      unless self.refunds.is_a?(Array)
+        refund = self.refunds.create(params, opts)
 
-      # now that a refund has been created, we expect the state of this object
-      # to change as well (i.e. `refunded` will now be `true`) so refresh it
-      # from the server
-      self.refresh
+        # now that a refund has been created, we expect the state of this object
+        # to change as well (i.e. `refunded` will now be `true`) so refresh it
+        # from the server
+        self.refresh
+      else
+        response, opts = request(:post, refund_url, params, opts)
+        initialize_from(response, opts)
+      end
     end
 
     def capture(params={}, opts={})
@@ -58,5 +70,11 @@ module Stripe
     def close_dispute_url
       url + '/dispute/close'
     end
+
+    # Note that this is actually the *old* refund URL and its use is no longer
+    # preferred.
+    def refund_url
+      url + '/refund'
+    end
   end
 end

data/lib/stripe/version.rb

@@ -1,3 +1,3 @@
 module Stripe
-  VERSION = '1.35.0'
+  VERSION = '1.35.1'
 end

data/test/stripe/charge_test.rb

@@ -19,6 +19,20 @@ module Stripe
       assert r.is_a?(Stripe::Refund)
     end
 
+    should "charges should be refundable for old API versions" do
+      # "refunds" was a plain array in old API versions but is not a Stripe
+      # list (see the implementation of `make_charge` for a current example)
+      data = make_charge.merge!(:refunds => [])
+      c = Stripe::Charge.construct_from(data)
+      @mock.expects(:get).never
+      @mock.expects(:post).once.
+        with("#{Stripe.api_base}/v1/charges/#{c.id}/refund", nil, '').
+        returns(make_response(data.merge(:refunded => true)))
+      c = c.refund
+      assert c.is_a?(Stripe::Charge)
+      assert c.refunded
+    end
+
     should "charges should not be deletable" do
       assert_raises NoMethodError do
         @mock.expects(:get).once.returns(make_response(make_charge))

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: stripe
 version: !ruby/object:Gem::Version
-  version: 1.35.0
+  version: 1.35.1
 platform: ruby
 authors:
 - Ross Boucher
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-01 00:00:00.000000000 Z
+date: 2016-02-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client