stripe 1.30.3 → 2.0.0

data/test/stripe/reversal_test.rb

@@ -2,46 +2,42 @@ require File.expand_path('../../test_helper', __FILE__)
 
 module Stripe
   class ReversalTest < Test::Unit::TestCase
-    should "reversals should be listable" do
-      @mock.expects(:get).once.returns(make_response(make_transfer))
+    FIXTURE = API_FIXTURES.fetch(:transfer_reversal)
 
-      transfer = Stripe::Transfer.retrieve('test_transfer')
-
-      assert transfer.reversals.first.kind_of?(Stripe::Reversal)
+    setup do
+      @transfer = Stripe::Transfer.retrieve(API_FIXTURES.fetch(:transfer)[:id])
     end
 
-    should "reversals should be refreshable" do
-      @mock.expects(:get).twice.returns(make_response(make_transfer), make_response(make_reversal(:id => 'refreshed_reversal')))
-
-      transfer = Stripe::Transfer.retrieve('test_transfer')
-      reversal = transfer.reversals.first
-      reversal.refresh
-
-      assert_equal 'refreshed_reversal', reversal.id
+    should "be listable" do
+      reversals = @transfer.reversals.list
+      assert_requested :get,
+        "#{Stripe.api_base}/v1/transfers/#{@transfer.id}/reversals"
+      assert reversals.data.kind_of?(Array)
+      assert reversals.data[0].kind_of?(Stripe::Reversal)
     end
 
-    should "reversals should be updateable" do
-      @mock.expects(:get).once.returns(make_response(make_transfer))
-      @mock.expects(:post).once.returns(make_response(make_reversal(:metadata => {'key' => 'value'})))
-
-      transfer = Stripe::Transfer.retrieve('test_transfer')
-      reversal = transfer.reversals.first
+    should "be retrievable" do
+      reversal = @transfer.reversals.retrieve(FIXTURE[:id])
+      assert_requested :get,
+        "#{Stripe.api_base}/v1/transfers/#{@transfer.id}/reversals/#{FIXTURE[:id]}"
+      assert reversal.kind_of?(Stripe::Reversal)
+    end
 
-      assert_equal nil, reversal.metadata['key']
+    should "be creatable" do
+      reversal = @transfer.reversals.create(
+        amount: 100
+      )
+      assert_requested :post,
+        "#{Stripe.api_base}/v1/transfers/#{@transfer.id}/reversals"
+      assert reversal.kind_of?(Stripe::Reversal)
+    end
 
+    should "be saveable" do
+      reversal = @transfer.reversals.retrieve(FIXTURE[:id])
       reversal.metadata['key'] = 'value'
       reversal.save
-
-      assert_equal 'value', reversal.metadata['key']
-    end
-
-    should "create should return a new reversal" do
-      @mock.expects(:get).once.returns(make_response(make_transfer))
-      @mock.expects(:post).once.returns(make_response(make_reversal(:id => 'test_new_reversal')))
-
-      transfer = Stripe::Transfer.retrieve('test_transfer')
-      reversals = transfer.reversals.create(:amount => 20)
-      assert_equal 'test_new_reversal', reversals.id
+      assert_requested :post,
+        "#{Stripe.api_base}/v1/transfers/#{@transfer.id}/reversals/#{FIXTURE[:id]}"
     end
   end
 end

data/test/stripe/sku_test.rb

@@ -2,23 +2,49 @@ require File.expand_path('../../test_helper', __FILE__)
 
 module Stripe
   class SKUTest < Test::Unit::TestCase
-    should "SKUs should be listable" do
-      @mock.expects(:get).once.
-        returns(make_response(make_sku_array("test_product")))
+    FIXTURE = API_FIXTURES.fetch(:sku)
+
+    should "be listable" do
       skus = Stripe::SKU.list
-      assert skus.data.kind_of? Array
-      skus.each do |sku|
-        assert sku.kind_of?(Stripe::SKU)
-      end
+      assert_requested :get, "#{Stripe.api_base}/v1/skus"
+      assert skus.data.kind_of?(Array)
+      assert skus.data[0].kind_of?(Stripe::SKU)
+    end
+
+    should "be retrievable" do
+      sku = Stripe::SKU.retrieve(FIXTURE[:id])
+      assert_requested :get, "#{Stripe.api_base}/v1/skus/#{FIXTURE[:id]}"
+      assert sku.kind_of?(Stripe::SKU)
+    end
+
+    should "be creatable" do
+      _ = Stripe::SKU.create(
+        currency: "USD",
+        inventory: { type: "finite", quantity: 500 },
+        price: 100,
+        product: API_FIXTURES.fetch(:product)[:id]
+      )
+      assert_requested :post, "#{Stripe.api_base}/v1/skus"
+    end
+
+    should "be saveable" do
+      sku = Stripe::SKU.retrieve(FIXTURE[:id])
+      sku.metadata['key'] = 'value'
+      sku.save
+      assert_requested :post, "#{Stripe.api_base}/v1/skus/#{FIXTURE[:id]}"
     end
 
-    should "SKUs should not be deletable" do
-      assert_raises NoMethodError do
-        @mock.expects(:get).once.returns(make_response(make_sku))
-        p = Stripe::SKU.retrieve("test_product")
-        p.delete
-      end
+    should "be updateable" do
+      sku = Stripe::SKU.update(FIXTURE[:id], metadata: {foo: 'bar'})
+      assert_requested :post, "#{Stripe.api_base}/v1/skus/#{FIXTURE[:id]}"
+      assert sku.kind_of?(Stripe::SKU)
     end
 
+    should "be deletable" do
+      sku = Stripe::SKU.retrieve(FIXTURE[:id])
+      sku = sku.delete
+      assert_requested :delete, "#{Stripe.api_base}/v1/skus/#{FIXTURE[:id]}"
+      assert sku.kind_of?(Stripe::SKU)
+    end
   end
 end

data/test/stripe/source_test.rb

@@ -0,0 +1,43 @@
+require File.expand_path('../../test_helper', __FILE__)
+
+module Stripe
+  class SourceTest < Test::Unit::TestCase
+    FIXTURE = API_FIXTURES.fetch(:source)
+
+    should "be retrievable" do
+      source = Stripe::Source.retrieve(FIXTURE[:id])
+      assert_requested :get, "#{Stripe.api_base}/v1/sources/#{FIXTURE[:id]}"
+      assert source.kind_of?(Stripe::Source)
+    end
+
+    should "be creatable" do
+      source = Stripe::Source.create(
+        type: 'card',
+        token: API_FIXTURES.fetch(:token)[:id]
+      )
+      assert_requested :post, "#{Stripe.api_base}/v1/sources"
+      assert source.kind_of?(Stripe::Card)
+    end
+
+    should "be saveable" do
+      source = Stripe::Source.retrieve(FIXTURE[:id])
+      source.metadata['key'] = 'value'
+      source.save
+      assert_requested :post, "#{Stripe.api_base}/v1/sources/#{FIXTURE[:id]}"
+    end
+
+    should "be updateable" do
+      source = Stripe::Source.update(FIXTURE[:id], metadata: {foo: 'bar'})
+      assert_requested :post, "#{Stripe.api_base}/v1/sources/#{FIXTURE[:id]}"
+      assert source.kind_of?(Stripe::Card)
+    end
+
+    context "#verify" do
+      should "verify the source" do
+        source = Stripe::Source.retrieve(FIXTURE[:id])
+        source = source.verify(:values => [1,2])
+        assert source.kind_of?(Stripe::Source)
+      end
+    end
+  end
+end

data/test/stripe/stripe_client_test.rb

@@ -0,0 +1,428 @@
+require File.expand_path('../../test_helper', __FILE__)
+
+module Stripe
+  class StripeClientTest < Test::Unit::TestCase
+    context ".active_client" do
+      should "be .default_client outside of #request" do
+        assert_equal StripeClient.default_client, StripeClient.active_client
+      end
+
+      should "be active client inside of #request" do
+        client = StripeClient.new
+        client.request do
+          assert_equal client, StripeClient.active_client
+        end
+      end
+    end
+
+    context ".default_client" do
+      should "be a StripeClient" do
+        assert_kind_of StripeClient, StripeClient.default_client
+      end
+    end
+
+    context ".default_conn" do
+      should "be a Faraday::Connection" do
+        assert_kind_of Faraday::Connection, StripeClient.default_conn
+      end
+
+      should "be a different connection on each thread" do
+        other_thread_conn = nil
+        thread = Thread.new do
+          other_thread_conn = StripeClient.default_conn
+        end
+        thread.join
+        refute_equal StripeClient.default_conn, other_thread_conn
+      end
+    end
+
+    context ".should_retry?" do
+      setup do
+        Stripe.stubs(:max_network_retries).returns(2)
+      end
+
+      should 'retry on timeout' do
+        assert StripeClient.should_retry?(Faraday::TimeoutError.new(""), 0)
+      end
+
+      should 'retry on a failed connection' do
+        assert StripeClient.should_retry?(Faraday::ConnectionFailed.new(""), 0)
+      end
+
+      should 'retry on a conflict' do
+        error = make_rate_limit_error
+        e = Faraday::ClientError.new(error[:error][:message], { status: 409 })
+        assert StripeClient.should_retry?(e, 0)
+      end
+
+      should 'not retry at maximum count' do
+        refute StripeClient.should_retry?(RuntimeError.new, Stripe.max_network_retries)
+      end
+
+      should 'not retry on a certificate validation error' do
+        refute StripeClient.should_retry?(Faraday::SSLError.new(""), 0)
+      end
+    end
+
+    context ".sleep_time" do
+      should "should grow exponentially" do
+        StripeClient.stubs(:rand).returns(1)
+        Stripe.stubs(:max_network_retry_delay).returns(999)
+        assert_equal(Stripe.initial_network_retry_delay, StripeClient.sleep_time(1))
+        assert_equal(Stripe.initial_network_retry_delay * 2, StripeClient.sleep_time(2))
+        assert_equal(Stripe.initial_network_retry_delay * 4, StripeClient.sleep_time(3))
+        assert_equal(Stripe.initial_network_retry_delay * 8, StripeClient.sleep_time(4))
+      end
+
+      should "enforce the max_network_retry_delay" do
+        StripeClient.stubs(:rand).returns(1)
+        Stripe.stubs(:initial_network_retry_delay).returns(1)
+        Stripe.stubs(:max_network_retry_delay).returns(2)
+        assert_equal(1, StripeClient.sleep_time(1))
+        assert_equal(2, StripeClient.sleep_time(2))
+        assert_equal(2, StripeClient.sleep_time(3))
+        assert_equal(2, StripeClient.sleep_time(4))
+      end
+
+      should "add some randomness" do
+        random_value = 0.8
+        StripeClient.stubs(:rand).returns(random_value)
+        Stripe.stubs(:initial_network_retry_delay).returns(1)
+        Stripe.stubs(:max_network_retry_delay).returns(8)
+
+        base_value = Stripe.initial_network_retry_delay * (0.5 * (1 + random_value))
+
+        # the initial value cannot be smaller than the base,
+        # so the randomness is ignored
+        assert_equal(Stripe.initial_network_retry_delay, StripeClient.sleep_time(1))
+
+        # after the first one, the randomness is applied
+        assert_equal(base_value * 2, StripeClient.sleep_time(2))
+        assert_equal(base_value * 4, StripeClient.sleep_time(3))
+        assert_equal(base_value * 8, StripeClient.sleep_time(4))
+      end
+    end
+
+    context "#initialize" do
+      should "set Stripe.default_conn" do
+        client = StripeClient.new
+        assert_equal StripeClient.default_conn, client.conn
+      end
+
+      should "set a different connection if one was specified" do
+        conn = Faraday.new
+        client = StripeClient.new(conn)
+        assert_equal conn, client.conn
+      end
+    end
+
+    context "#execute_request" do
+      context "headers" do
+        should "support literal headers" do
+          stub_request(:post, "#{Stripe.api_base}/v1/account").
+            with(headers: { "Stripe-Account" => "bar" }).
+            to_return(body: JSON.generate(API_FIXTURES.fetch(:account)))
+
+          client = StripeClient.new
+          client.execute_request(:post, '/v1/account',
+            headers: { "Stripe-Account" => "bar" }
+          )
+        end
+
+        should "support RestClient-style header keys" do
+          stub_request(:post, "#{Stripe.api_base}/v1/account").
+            with(headers: { "Stripe-Account" => "bar" }).
+            to_return(body: JSON.generate(API_FIXTURES.fetch(:account)))
+
+          client = StripeClient.new
+          client.execute_request(:post, '/v1/account',
+            headers: { :stripe_account => "bar" }
+          )
+        end
+      end
+
+      context "Stripe-Account header" do
+        should "use a globally set header" do
+          Stripe.stripe_account = 'acct_1234'
+
+          stub_request(:post, "#{Stripe.api_base}/v1/account").
+            with(headers: {"Stripe-Account" => Stripe.stripe_account}).
+            to_return(body: JSON.generate(API_FIXTURES.fetch(:account)))
+
+          client = StripeClient.new
+          client.execute_request(:post, '/v1/account')
+        end
+
+        should "use a locally set header" do
+          stripe_account = "acct_0000"
+          stub_request(:post, "#{Stripe.api_base}/v1/account").
+            with(headers: {"Stripe-Account" => stripe_account}).
+            to_return(body: JSON.generate(API_FIXTURES.fetch(:account)))
+
+          client = StripeClient.new
+          client.execute_request(:post, '/v1/account',
+            headers: { :stripe_account => stripe_account }
+          )
+        end
+
+        should "not send it otherwise" do
+          stub_request(:post, "#{Stripe.api_base}/v1/account").
+            with { |req|
+              req.headers["Stripe-Account"].nil?
+            }.to_return(body: JSON.generate(API_FIXTURES.fetch(:account)))
+
+          client = StripeClient.new
+          client.execute_request(:post, '/v1/account')
+        end
+      end
+
+      context "error handling" do
+        should "handle error response with empty body" do
+          stub_request(:post, "#{Stripe.api_base}/v1/charges").
+            to_return(body: '', status: 500)
+
+          client = StripeClient.new
+          e = assert_raises Stripe::APIError do
+            client.execute_request(:post, '/v1/charges')
+          end
+
+          assert_equal 'Invalid response object from API: "" (HTTP response code was 500)', e.message
+        end
+
+        should "handle error response with non-object error value" do
+          stub_request(:post, "#{Stripe.api_base}/v1/charges").
+            to_return(body: JSON.generate({ error: "foo" }), status: 500)
+
+          client = StripeClient.new
+          e = assert_raises Stripe::APIError do
+            client.execute_request(:post, '/v1/charges')
+          end
+
+          assert_equal 'Invalid response object from API: "{\"error\":\"foo\"}" (HTTP response code was 500)', e.message
+        end
+
+        should "raise InvalidRequestError on 400" do
+          stub_request(:post, "#{Stripe.api_base}/v1/charges").
+            to_return(body: JSON.generate(make_missing_id_error), status: 400)
+          client = StripeClient.new
+          begin
+            client.execute_request(:post, '/v1/charges')
+          rescue Stripe::InvalidRequestError => e
+            assert_equal(400, e.http_status)
+            assert_equal(true, !!e.http_body)
+            assert_equal(true, e.json_body.kind_of?(Hash))
+          end
+        end
+
+        should "raise AuthenticationError on 401" do
+          stub_request(:post, "#{Stripe.api_base}/v1/charges").
+            to_return(body: JSON.generate(make_missing_id_error), status: 401)
+          client = StripeClient.new
+          begin
+            client.execute_request(:post, '/v1/charges')
+          rescue Stripe::AuthenticationError => e
+            assert_equal(401, e.http_status)
+            assert_equal(true, !!e.http_body)
+            assert_equal(true, e.json_body.kind_of?(Hash))
+          end
+        end
+
+        should "raise CardError on 402" do
+          stub_request(:post, "#{Stripe.api_base}/v1/charges").
+            to_return(body: JSON.generate(make_missing_id_error), status: 402)
+          client = StripeClient.new
+          begin
+            client.execute_request(:post, '/v1/charges')
+          rescue Stripe::CardError => e
+            assert_equal(402, e.http_status)
+            assert_equal(true, !!e.http_body)
+            assert_equal(true, e.json_body.kind_of?(Hash))
+          end
+        end
+
+        should "raise PermissionError on 403" do
+          stub_request(:post, "#{Stripe.api_base}/v1/charges").
+            to_return(body: JSON.generate(make_missing_id_error), status: 403)
+          client = StripeClient.new
+          begin
+            client.execute_request(:post, '/v1/charges')
+          rescue Stripe::PermissionError => e
+            assert_equal(403, e.http_status)
+            assert_equal(true, !!e.http_body)
+            assert_equal(true, e.json_body.kind_of?(Hash))
+          end
+        end
+
+        should "raise InvalidRequestError on 404" do
+          stub_request(:post, "#{Stripe.api_base}/v1/charges").
+            to_return(body: JSON.generate(make_missing_id_error), status: 404)
+          client = StripeClient.new
+          begin
+            client.execute_request(:post, '/v1/charges')
+          rescue Stripe::InvalidRequestError => e
+            assert_equal(404, e.http_status)
+            assert_equal(true, !!e.http_body)
+            assert_equal(true, e.json_body.kind_of?(Hash))
+          end
+        end
+
+        should "raise RateLimitError on 429" do
+          stub_request(:post, "#{Stripe.api_base}/v1/charges").
+            to_return(body: JSON.generate(make_rate_limit_error), status: 429)
+          client = StripeClient.new
+          begin
+            client.execute_request(:post, '/v1/charges')
+          rescue Stripe::RateLimitError => e
+            assert_equal(429, e.http_status)
+            assert_equal(true, !!e.http_body)
+            assert_equal(true, e.json_body.kind_of?(Hash))
+          end
+        end
+      end
+
+      context "idempotency keys" do
+        setup do
+          Stripe.stubs(:max_network_retries).returns(2)
+        end
+
+        should 'not add an idempotency key to GET requests' do
+          SecureRandom.expects(:uuid).times(0)
+          stub_request(:get, "#{Stripe.api_base}/v1/charges/#{API_FIXTURES.fetch(:charge)[:id]}").
+            with { |req|
+              req.headers['Idempotency-Key'].nil?
+            }.to_return(body: JSON.generate(API_FIXTURES.fetch(:charge)))
+          client = StripeClient.new
+          client.execute_request(:get, "/v1/charges/#{API_FIXTURES.fetch(:charge)[:id]}")
+        end
+
+        should 'ensure there is always an idempotency_key on POST requests' do
+          SecureRandom.expects(:uuid).at_least_once.returns("random_key")
+          stub_request(:post, "#{Stripe.api_base}/v1/charges").
+            with(headers: {"Idempotency-Key" => "random_key"}).
+            to_return(body: JSON.generate(API_FIXTURES.fetch(:charge)))
+          client = StripeClient.new
+          client.execute_request(:post, "/v1/charges")
+        end
+
+        should 'ensure there is always an idempotency_key on DELETE requests' do
+          SecureRandom.expects(:uuid).at_least_once.returns("random_key")
+          stub_request(:delete, "#{Stripe.api_base}/v1/charges/#{API_FIXTURES.fetch(:charge)[:id]}").
+            with(headers: {"Idempotency-Key" => "random_key"}).
+            to_return(body: JSON.generate(API_FIXTURES.fetch(:charge)))
+          client = StripeClient.new
+          client.execute_request(:delete, "/v1/charges/#{API_FIXTURES.fetch(:charge)[:id]}")
+        end
+
+        should 'not override a provided idempotency_key' do
+          # Note that this expectation looks like `:idempotency_key` instead of
+          # the header `Idempotency-Key` because it's user provided as seen
+          # below. The ones injected by the library itself look like headers
+          # (`Idempotency-Key`), but rest-client does allow this symbol
+          # formatting and will properly override the system generated one as
+          # expected.
+          stub_request(:post, "#{Stripe.api_base}/v1/charges").
+            with(headers: {"Idempotency-Key" => "provided_key"}).
+            to_return(body: JSON.generate(API_FIXTURES.fetch(:charge)))
+
+          client = StripeClient.new
+          client.execute_request(:post, "/v1/charges",
+            headers: {:idempotency_key => 'provided_key'})
+        end
+      end
+
+      context "retry logic" do
+        setup do
+          Stripe.stubs(:max_network_retries).returns(2)
+        end
+
+        should 'retry failed requests and raise if error persists' do
+          StripeClient.expects(:sleep_time).at_least_once.returns(0)
+          stub_request(:post, "#{Stripe.api_base}/v1/charges").
+            to_raise(Errno::ECONNREFUSED.new)
+
+          client = StripeClient.new
+          err = assert_raises Stripe::APIConnectionError do
+            client.execute_request(:post, '/v1/charges')
+          end
+          assert_match(/Request was retried 2 times/, err.message)
+        end
+
+        should 'retry failed requests and return successful response' do
+          StripeClient.expects(:sleep_time).at_least_once.returns(0)
+
+          i = 0
+          stub_request(:post, "#{Stripe.api_base}/v1/charges").
+            to_return { |_|
+              if i < 2
+                i += 1
+                raise Errno::ECONNREFUSED.new
+              else
+                { body: JSON.generate({"id" => "myid"}) }
+              end
+            }
+
+          client = StripeClient.new
+          client.execute_request(:post, '/v1/charges')
+        end
+      end
+    end
+
+    context "#request" do
+      should "return a result and response object" do
+        stub_request(:post, "#{Stripe.api_base}/v1/charges").
+          to_return(body: JSON.generate(API_FIXTURES.fetch(:charge)))
+
+        client = StripeClient.new
+        charge, resp = client.request { Charge.create }
+
+        assert charge.is_a?(Charge)
+        assert resp.is_a?(StripeResponse)
+        assert_equal 200, resp.http_status
+      end
+
+      should "return the value of given block" do
+        client = StripeClient.new
+        ret, _ = client.request { 7 }
+        assert_equal 7, ret
+      end
+
+      should "reset local thread state after a call" do
+        begin
+          Thread.current[:stripe_client] = :stripe_client
+
+          client = StripeClient.new
+          client.request {}
+
+          assert_equal :stripe_client, Thread.current[:stripe_client]
+        ensure
+          Thread.current[:stripe_client] = nil
+        end
+      end
+    end
+  end
+
+  class SystemProfilerTest < Test::Unit::TestCase
+    context "#get_uname" do
+      should "run without failure" do
+        # Don't actually check the result because we try a variety of different
+        # strategies that will have different results depending on where this
+        # test and running. We're mostly making sure that no exception is thrown.
+        _ = StripeClient::SystemProfiler.get_uname
+      end
+    end
+
+    context "#get_uname_from_system" do
+      should "run without failure" do
+        # as above, just verify that an exception is not thrown
+        _ = StripeClient::SystemProfiler.get_uname_from_system
+      end
+    end
+
+    context "#get_uname_from_system_ver" do
+      should "run without failure" do
+        # as above, just verify that an exception is not thrown
+        _ = StripeClient::SystemProfiler.get_uname_from_system_ver
+      end
+    end
+  end
+end