stripe 1.30.1 → 1.30.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a744255415d993917d419962d5f1420b8daed37d
-  data.tar.gz: 1c9085d745949c729e3c9caa3e986d16c6373eda
+  metadata.gz: a832c74b94a7a2346a38e3053363aa80f31b04d5
+  data.tar.gz: 2b0d72e9641fdde9d3a4db16e39407ceb33ecd6b
 SHA512:
-  metadata.gz: 02b09d3707b1861f069cbd46124fe5c03aa86a44f47973a01315156056765404ddc54423b6479141f56cb1cd9ef28679dcfed3147d98e65d11835eb5622a275f
-  data.tar.gz: 1f7d8ccf6eac75aea02b7935587f8448d363601f92f1f5245ebb4639e6f9a6c9f71f0201c88a14d86a6e172dab79351088bd103ae47230718b18a47340dc9c17
+  metadata.gz: 019e999e649b2f9e39dd0a900aec1b0b44ff19a740ea37663f67ca77749fc93f540b7c4c588e47e30ba050be9ffaca7a8e7d43ccbd518c1781bcc92c077fa3e7
+  data.tar.gz: 692e479177426a0b3974ffa7ed6d5725e01b40ddd61afd0c42fe133b764a0f6b3201afb387f8f17efe7a7d66ed1e5e06e892f21c37a88fc172cdde4d4a3b3700

data/History.txt

@@ -1,7 +1,11 @@
+=== 1.30.2 2015-10-12
+
+* Fix bug where `opts` didn't properly propagate to descendant `StripeObjects`
+
 === 1.30.1 2015-10-10
 
 * Fix bug that prevent lists of hashes from being URI-encoded properly
-* Fix bug where filter conditions were not making it fast the first instantiated `ListObject`
+* Fix bug where filter conditions were not making it past the first instantiated `ListObject`
 
 === 1.30.0 2015-10-09
 

data/VERSION

@@ -1 +1 @@
-1.30.1
+1.30.2

data/lib/stripe/stripe_object.rb

@@ -333,7 +333,7 @@ module Stripe
         @unsaved_values.delete(k)
       end
 
-      update_attributes(values, :opts => opts)
+      update_attributes(values, opts)
       values.each do |k, _|
         @transient_values.delete(k)
         @unsaved_values.delete(k)
@@ -341,36 +341,5 @@ module Stripe
 
       self
     end
-
-    # Mass assigns attributes on the model.
-    #
-    # This is a version of +update_attributes+ that takes some extra options
-    # for internal use.
-    #
-    # ==== Options
-    #
-    # * +:opts:+ Options for StripeObject like an API key.
-    # * +:raise_error:+ Set to false to suppress ArgumentErrors on keys that
-    #   don't exist.
-    def update_attributes_with_options(values, options={})
-      # `opts` are StripeObject options
-      opts        = options.fetch(:opts, {})
-      raise_error = options.fetch(:raise_error, true)
-
-      values.each do |k, v|
-        if !@@permanent_attributes.include?(k) && !self.respond_to?(:"#{k}=")
-          if raise_error
-            raise ArgumentError,
-              "#{k} is not an attribute that can be assigned on this object"
-          else
-            next
-          end
-        end
-
-        @values[k] = Util.convert_to_stripe_object(v, opts)
-        @unsaved_values.add(k)
-      end
-      self
-    end
   end
 end

data/lib/stripe/version.rb

@@ -1,3 +1,3 @@
 module Stripe
-  VERSION = '1.30.1'
+  VERSION = '1.30.2'
 end

data/test/stripe/stripe_object_test.rb

@@ -84,5 +84,20 @@ module Stripe
         $stderr = old_stderr
       end
     end
+
+    should "pass opts down to children when initializing" do
+      opts = { :custom => "opts" }
+
+      # customer comes with a `sources` list that makes a convenient object to
+      # perform tests on
+      customer = Stripe::Customer.construct_from(make_customer, opts)
+
+      source = customer.sources.first
+      # Pulling `@opts` as an instance variable here is not ideal, but it's
+      # important enough argument that the test here is worth it. we should
+      # consider exposing it publicly on a future pull (and possibly renaming
+      # it to something more useful).
+      assert_equal opts, source.instance_variable_get(:@opts)
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: stripe
 version: !ruby/object:Gem::Version
-  version: 1.30.1
+  version: 1.30.2
 platform: ruby
 authors:
 - Ross Boucher
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-10 00:00:00.000000000 Z
+date: 2015-10-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client