stripe-ruby-mock 2.1.0 → 2.1.1

data/.travis.yml

@@ -6,7 +6,7 @@ rvm:
 before_script:
   - "sudo touch /var/log/stripe-mock-server.log"
   - "sudo chown travis /var/log/stripe-mock-server.log"
-script: "bundle exec rspec"
+script: "bundle exec rspec; bundle exec rspec -t live"
 notifications:
   webhooks:
     urls:

data/README.md

@@ -8,7 +8,7 @@
 
 In your gemfile:
 
-    gem 'stripe-ruby-mock', '~> 2.1.0', :require => 'stripe_mock'
+    gem 'stripe-ruby-mock', '~> 2.1.1', :require => 'stripe_mock'
 
 ## Features
 
@@ -125,7 +125,7 @@ it "mocks a declined card error" do
   # Prepares an error for the next create charge request
   StripeMock.prepare_card_error(:card_declined)
 
-  expect { Stripe::Charge.create }.to raise_error {|e|
+  expect { Stripe::Charge.create(amount: 1, currency: 'usd') }.to raise_error {|e|
     expect(e).to be_a Stripe::CardError
     expect(e.http_status).to eq(402)
     expect(e.code).to eq('card_declined')
@@ -181,7 +181,7 @@ it "raises a custom error for specific actions" do
 
   StripeMock.prepare_error(custom_error, :new_customer)
 
-  expect { Stripe::Charge.create }.to_not raise_error
+  expect { Stripe::Charge.create(amount: 1, currency: 'usd') }.to_not raise_error
   expect { Stripe::Customer.create }.to raise_error {|e|
     expect(e).to be_a StandardError
     expect(e.message).to eq("Please knock first.")

data/lib/stripe_mock/request_handlers/charges.rb

@@ -27,6 +27,8 @@ module StripeMock
           raise Stripe::InvalidRequestError.new("Invalid token id: #{params[:card]}", 'card', 400)
         end
 
+        ensure_required_params(params)
+
         charges[id] = Data.mock_charge(params.merge :id => id, :balance_transaction => new_balance_transaction('txn'))
       end
 
@@ -88,6 +90,31 @@ module StripeMock
         refund
       end
 
+      private
+
+      def ensure_required_params(params)
+        if params[:amount].nil?
+          require_param(:amount)
+        elsif params[:currency].nil?
+          require_param(:currency)
+        elsif non_integer_charge_amount?(params)
+          raise Stripe::InvalidRequestError.new("Invalid integer: #{params[:amount]}", 'amount', 400)
+        elsif non_positive_charge_amount?(params)
+          raise Stripe::InvalidRequestError.new('Invalid positive integer', 'amount', 400)
+        end
+      end
+
+      def non_integer_charge_amount?(params)
+        params[:amount] && !params[:amount].is_a?(Integer)
+      end
+
+      def non_positive_charge_amount?(params)
+        params[:amount] && params[:amount] < 1
+      end
+
+      def require_param(param)
+        raise Stripe::InvalidRequestError.new("Missing required param: #{param}", param.to_s, 400)
+      end
     end
   end
 end

data/lib/stripe_mock/request_handlers/helpers/card_helpers.rb

@@ -6,8 +6,13 @@ module StripeMock
         cards = object[:cards] || object[:sources]
         card = cards[:data].find{|cc| cc[:id] == card_id }
         if card.nil?
-          msg = "#{class_name} #{object[:id]} does not have card #{card_id}"
-          raise Stripe::InvalidRequestError.new(msg, 'card', 404)
+          if class_name == 'Recipient'
+            msg = "#{class_name} #{object[:id]} does not have a card with ID #{card_id}"
+            raise Stripe::InvalidRequestError.new(msg, 'card', 404)
+          else
+            msg = "There is no source with ID #{card_id}"
+            raise Stripe::InvalidRequestError.new(msg, 'id', 404)
+          end
         end
         card
       end
@@ -22,13 +27,14 @@ module StripeMock
           cards_or_sources[:data].delete_if {|card| card[:id] == object[:default_card]}
           object[:default_card]   = card[:id] unless is_customer
           object[:default_source] = card[:id] if is_customer
+          cards_or_sources[:data] = [card]
         else
           cards_or_sources[:total_count] += 1
+          cards_or_sources[:data] << card
         end
 
         object[:default_card]   = card[:id] if !is_customer && object[:default_card].nil?
         object[:default_source] = card[:id] if is_customer  && object[:default_source].nil?
-        cards_or_sources[:data] << card
 
         card
       end

data/lib/stripe_mock/version.rb

@@ -1,4 +1,4 @@
 module StripeMock
   # stripe-ruby-mock version
-  VERSION = "2.1.0"
+  VERSION = "2.1.1"
 end

data/spec/list_spec.rb

@@ -33,9 +33,9 @@ describe StripeMock::Data::List do
   end
 
   it "eventually gets turned into a hash" do
-    charge1 = Stripe::Charge.create
-    charge2 = Stripe::Charge.create
-    charge3 = Stripe::Charge.create
+    charge1 = Stripe::Charge.create(amount: 1, currency: 'usd')
+    charge2 = Stripe::Charge.create(amount: 1, currency: 'usd')
+    charge3 = Stripe::Charge.create(amount: 1, currency: 'usd')
     list = StripeMock::Data::List.new([charge1, charge2, charge3])
     hash = list.to_h
 
@@ -95,15 +95,15 @@ describe StripeMock::Data::List do
 
   context "pagination" do
     it "has a has_more field when it has more" do
-      list = StripeMock::Data::List.new([Stripe::Charge.create] * 256)
+      list = StripeMock::Data::List.new([Stripe::Charge.create(amount: 1, currency: 'usd')] * 256)
 
       expect(list).to have_more
     end
 
     it "accepts a starting_after parameter" do
       data = []
-      255.times { data << Stripe::Charge.create }
-      new_charge = Stripe::Charge.create
+      255.times { data << Stripe::Charge.create(amount: 1, currency: 'usd') }
+      new_charge = Stripe::Charge.create(amount: 1, currency: 'usd')
       data[89] = new_charge
       list = StripeMock::Data::List.new(data, starting_after: new_charge.id)
       hash = list.to_h
@@ -114,7 +114,7 @@ describe StripeMock::Data::List do
 
     it "raises an error if starting_after cursor is not found" do
       data = []
-      255.times { data << Stripe::Charge.create }
+      255.times { data << Stripe::Charge.create(amount: 1, currency: 'usd') }
       list = StripeMock::Data::List.new(data, starting_after: "test_ch_unknown")
 
       expect { list.to_h }.to raise_error

data/spec/readme_spec.rb

@@ -20,7 +20,7 @@ describe 'README examples' do
     # Prepares an error for the next create charge request
     StripeMock.prepare_card_error(:card_declined)
 
-    expect { Stripe::Charge.create }.to raise_error {|e|
+    expect { Stripe::Charge.create(amount: 1, currency: 'usd') }.to raise_error {|e|
       expect(e).to be_a Stripe::CardError
       expect(e.http_status).to eq(402)
       expect(e.code).to eq('card_declined')

data/spec/shared_stripe_examples/card_examples.rb

@@ -221,8 +221,8 @@ shared_examples 'Card API' do
       card_id = "card_123"
       expect { customer.sources.retrieve(card_id) }.to raise_error {|e|
         expect(e).to be_a Stripe::InvalidRequestError
-        expect(e.message).to include "Customer", customer.id, "does not have", card_id
-        expect(e.param).to eq 'card'
+        expect(e.message).to include "no source", card_id
+        expect(e.param).to eq 'id'
         expect(e.http_status).to eq 404
       }
     end

data/spec/shared_stripe_examples/card_token_examples.rb

@@ -7,7 +7,7 @@ shared_examples 'Card Token Mocking' do
     it "generates and reads a card token for create charge" do
       card_token = StripeMock.generate_card_token(last4: "2244", exp_month: 33, exp_year: 2255)
 
-      charge = Stripe::Charge.create(amount: 500, source: card_token)
+      charge = Stripe::Charge.create(amount: 500, currency: 'usd', source: card_token)
       card = charge.source
       expect(card.last4).to eq("2244")
       expect(card.exp_month).to eq(33)

data/spec/shared_stripe_examples/charge_examples.rb

@@ -12,6 +12,44 @@ shared_examples 'Charge API' do
     }.to raise_error(Stripe::InvalidRequestError, /token/i)
   end
 
+  it "requires presence of amount", :live => true do
+    expect {
+      charge = Stripe::Charge.create(
+        currency: 'usd',
+        card: stripe_helper.generate_card_token
+      )
+    }.to raise_error(Stripe::InvalidRequestError, /missing required param: amount/i)
+  end
+
+  it "requires presence of currency", :live => true do
+    expect {
+      charge = Stripe::Charge.create(
+        amount: 99,
+        card: stripe_helper.generate_card_token
+      )
+    }.to raise_error(Stripe::InvalidRequestError, /missing required param: currency/i)
+  end
+
+  it "requires a valid positive amount", :live => true do
+    expect {
+      charge = Stripe::Charge.create(
+        amount: -99,
+        currency: 'usd',
+        card: stripe_helper.generate_card_token
+      )
+    }.to raise_error(Stripe::InvalidRequestError, /invalid positive integer/i)
+  end
+
+  it "requires a valid integer amount", :live => true do
+    expect {
+      charge = Stripe::Charge.create(
+        amount: 99.0,
+        currency: 'usd',
+        card: stripe_helper.generate_card_token
+      )
+    }.to raise_error(Stripe::InvalidRequestError, /invalid integer/i)
+  end
+
   it "creates a stripe charge item with a card token" do
     charge = Stripe::Charge.create(
       amount: 999,
@@ -116,8 +154,8 @@ shared_examples 'Charge API' do
   context "retrieving a list of charges" do
     before do
       @customer = Stripe::Customer.create(email: 'johnny@appleseed.com')
-      @charge = Stripe::Charge.create(customer: @customer.id)
-      @charge2 = Stripe::Charge.create
+      @charge = Stripe::Charge.create(amount: 1, currency: 'usd', customer: @customer.id)
+      @charge2 = Stripe::Charge.create(amount: 1, currency: 'usd')
     end
 
     it "stores charges for a customer in memory" do
@@ -129,12 +167,12 @@ shared_examples 'Charge API' do
     end
 
     it "defaults count to 10 charges" do
-      11.times { Stripe::Charge.create }
+      11.times { Stripe::Charge.create(amount: 1, currency: 'usd') }
       expect(Stripe::Charge.all.data.count).to eq(10)
     end
 
     it "is marked as having more when more objects exist" do
-      11.times { Stripe::Charge.create }
+      11.times { Stripe::Charge.create(amount: 1, currency: 'usd') }
 
       expect(Stripe::Charge.all.has_more).to eq(true)
     end

data/spec/shared_stripe_examples/customer_examples.rb

@@ -226,7 +226,7 @@ shared_examples 'Customer API' do
     original.save
 
     new_card = original.sources.data.last
-    expect(original.sources.count).to eq(2)
+    expect(original.sources.count).to eq(1)
     expect(original.default_source).to_not eq(card.id)
 
     expect(new_card.id).to_not eq(card.id)

data/spec/shared_stripe_examples/error_mock_examples.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 def expect_card_error(code, param)
-  expect { Stripe::Charge.create() }.to raise_error {|e|
+  expect { Stripe::Charge.create(amount: 1, currency: 'usd') }.to raise_error {|e|
     expect(e).to be_a(Stripe::CardError)
     expect(e.http_status).to eq(402)
     expect(e.code).to eq(code)
@@ -33,7 +33,7 @@ shared_examples 'Stripe Error Mocking' do
     error = Stripe::InvalidRequestError.new('Test Invalid', 'param', 987, 'ibody', 'json ibody')
     StripeMock.prepare_error(error)
 
-    expect { Stripe::Charge.create() }.to raise_error {|e|
+    expect { Stripe::Charge.create(amount: 1, currency: 'usd') }.to raise_error {|e|
       expect(e).to be_a(Stripe::InvalidRequestError)
       expect(e.param).to eq('param')
       expect(e.message).to eq('Test Invalid')
@@ -64,7 +64,7 @@ shared_examples 'Stripe Error Mocking' do
     custom_error = StandardError.new("Please knock first.")
     StripeMock.prepare_error(custom_error, :new_customer)
 
-    expect { Stripe::Charge.create }.to_not raise_error
+    expect { Stripe::Charge.create(amount: 1, currency: 'usd') }.to_not raise_error
     expect { Stripe::Customer.create }.to raise_error {|e|
       expect(e).to be_a StandardError
       expect(e.message).to eq("Please knock first.")
@@ -84,12 +84,12 @@ shared_examples 'Stripe Error Mocking' do
   it "only raises a card error when a card charge is attempted" do
     StripeMock.prepare_card_error(:card_declined)
     expect { Stripe::Customer.create(id: 'x') }.to_not raise_error
-    expect { Stripe::Charge.create() }.to raise_error Stripe::CardError
+    expect { Stripe::Charge.create(amount: 1, currency: 'usd') }.to raise_error Stripe::CardError
   end
 
   it "mocks a card error with a given handler" do
     StripeMock.prepare_card_error(:incorrect_cvc, :new_customer)
-    expect { Stripe::Charge.create() }.to_not raise_error
+    expect { Stripe::Charge.create(amount: 1, currency: 'usd') }.to_not raise_error
 
     expect { Stripe::Customer.create() }.to raise_error {|e|
       expect(e).to be_a(Stripe::CardError)

data/spec/shared_stripe_examples/subscription_examples.rb

@@ -568,8 +568,7 @@ shared_examples 'Customer Subscriptions' do
         :interval => 'month',
         :name => 'Sample Plan',
         :currency => 'usd',
-        :id => 'Sample5',
-        :statement_description => "Plan Statement"
+        :id => 'Sample5'
       )
 
       customer = Stripe::Customer.create({

data/stripe-ruby-mock.gemspec

@@ -17,7 +17,7 @@ Gem::Specification.new do |gem|
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
   gem.require_paths = ['lib']
 
-  gem.add_dependency 'stripe', '>= 1.20.1'
+  gem.add_dependency 'stripe', '= 1.20.1'
   gem.add_dependency 'jimson-temp'
   gem.add_dependency 'dante', '>= 0.2.0'
 

metadata

@@ -1,60 +1,68 @@
 --- !ruby/object:Gem::Specification
 name: stripe-ruby-mock
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.1.1
+  prerelease: 
 platform: ruby
 authors:
 - Gilbert
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-27 00:00:00.000000000 Z
+date: 2015-03-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: stripe
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - '='
       - !ruby/object:Gem::Version
         version: 1.20.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - '='
       - !ruby/object:Gem::Version
         version: 1.20.1
 - !ruby/object:Gem::Dependency
   name: jimson-temp
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: dante
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: 0.2.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: 0.2.0
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -62,6 +70,7 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -69,6 +78,7 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: rubygems-tasks
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -76,6 +86,7 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -83,15 +94,17 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: thin
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: A drop-in library to test stripe without hitting their servers
@@ -232,26 +245,27 @@ files:
 homepage: https://github.com/rebelidealist/stripe-ruby-mock
 licenses:
 - MIT
-metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
-  - - '>='
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
-  - - '>='
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 1.8.25
 signing_key: 
-specification_version: 4
+specification_version: 3
 summary: TDD with stripe
 test_files:
 - spec/_dummy/webhooks/dummy.event.json

checksums.yaml

@@ -1,7 +0,0 @@
----
-SHA1:
-  metadata.gz: 78209961f8a5b11ad4a2146246a6162b534af59e
-  data.tar.gz: 3192d4420c6f44537422804b4b60fb479584f6db
-SHA512:
-  metadata.gz: fcec4c716ccd97608cb2e81c001baf9e174cc32e29d7578dd1ff5cb2eff1b412ba74299c5e0ae913e4f4fab01951cc3ea3f7f2927f040c6eca9b62891f30ad3a
-  data.tar.gz: 4a643be3f0acca2ad89dfc44dc76484df58c400f0bfcafca62338a0095dafdd4d7f5104ed9fa200d1cd6321db6dab616032bdbb6c6c8a88bb33f60117f510664