stripe-ruby-mock 1.8.3.9 → 1.8.3.10

data/lib/stripe_mock.rb

@@ -23,6 +23,7 @@ require 'stripe_mock/api/client'
 require 'stripe_mock/api/server'
 require 'stripe_mock/api/errors'
 require 'stripe_mock/api/webhooks'
+require 'stripe_mock/api/strict'
 require 'stripe_mock/api/debug'
 
 require 'stripe_mock/request_handlers/charges.rb'

data/lib/stripe_mock/api/strict.rb

@@ -0,0 +1,11 @@
+module StripeMock
+
+  def self.toggle_strict(toggle)
+    if @state == 'local'
+      @instance.strict = toggle
+    elsif @state == 'remote'
+      @client.set_server_strict(toggle)
+    end
+  end
+
+end

data/lib/stripe_mock/client.rb

@@ -12,7 +12,14 @@ module StripeMock
     end
 
     def mock_request(method, url, api_key, params={}, headers={})
-      timeout_wrap { @pipe.mock_request(method, url, api_key, params, headers) }
+      timeout_wrap do
+        @pipe.mock_request(method, url, api_key, params, headers).tap {|result|
+          response, api_key = result
+          if response.is_a?(Hash) && response['error_raised'] == 'invalid_request'
+            raise Stripe::InvalidRequestError.new(*response['error_params'])
+          end
+        }
+      end
     end
 
     def get_server_data(key)
@@ -32,6 +39,14 @@ module StripeMock
       timeout_wrap { @pipe.debug? }
     end
 
+    def set_server_strict(toggle)
+      timeout_wrap { @pipe.set_strict(toggle) }
+    end
+
+    def server_strict?
+      timeout_wrap { @pipe.strict? }
+    end
+
     def clear_server_data
       timeout_wrap { @pipe.clear_data }
     end
@@ -54,9 +69,6 @@ module StripeMock
       raise
     rescue Errno::ECONNREFUSED => e
       raise StripeMock::ServerTimeoutError.new(e)
-    rescue StandardError => e
-      puts "Unexpected StripeMock Client Error: #{e.inspect}"
-      {}
     end
   end
 

data/lib/stripe_mock/instance.rb

@@ -18,7 +18,7 @@ module StripeMock
 
 
     attr_reader :charges, :customers, :plans
-    attr_accessor :pending_error, :debug
+    attr_accessor :pending_error, :debug, :strict
 
     def initialize
       @customers = {}
@@ -28,6 +28,7 @@ module StripeMock
       @id_counter = 0
       @pending_error = nil
       @debug = false
+      @strict = true
     end
 
     def mock_request(method, url, api_key, params={}, headers={})
@@ -62,6 +63,14 @@ module StripeMock
 
     private
 
+    def assert_existance(type, id, obj)
+      return unless @strict == true
+
+      if obj.nil?
+        raise Stripe::InvalidRequestError.new("No such #{type}: #{id}", type.to_s, 400)
+      end
+    end
+
     def new_id(prefix)
       # Stripe ids must be strings
       "test_#{prefix}_#{@id_counter += 1}"

data/lib/stripe_mock/request_handlers/charges.rb

@@ -14,6 +14,7 @@ module StripeMock
 
       def get_charge(route, method_url, params, headers)
         route =~ method_url
+        assert_existance :charge, $1, charges[$1]
         charges[$1] ||= Data.test_charge(:id => $1)
       end
 

data/lib/stripe_mock/request_handlers/customers.rb

@@ -12,26 +12,33 @@ module StripeMock
       end
 
       def new_customer(route, method_url, params, headers)
-        id = new_id('cus')
-        customers[id] = Data.test_customer(params.merge :id => id)
+        params[:id] ||= new_id('cus')
+        customers[ params[:id] ] = Data.test_customer(params)
       end
 
       def new_subscription(route, method_url, params, headers)
+        route =~ method_url
+        assert_existance :customer, $1, customers[$1]
+        assert_existance :plan, params[:plan], plans[ params[:plan] ]
         Data.test_subscription(params[:plan])
       end
 
       def cancel_subscription(route, method_url, params, headers)
+        route =~ method_url
+        assert_existance :customer, $1, customers[$1]
         Data.test_delete_subscription(params[:id])
       end
 
       def update_customer(route, method_url, params, headers)
         route =~ method_url
+        assert_existance :customer, $1, customers[$1]
         customers[$1] ||= Data.test_customer(:id => $1)
         customers[$1].merge!(params)
       end
 
       def get_customer(route, method_url, params, headers)
         route =~ method_url
+        assert_existance :customer, $1, customers[$1]
         customers[$1] ||= Data.test_customer(:id => $1)
       end
 

data/lib/stripe_mock/request_handlers/plans.rb

@@ -3,9 +3,10 @@ module StripeMock
     module Plans
 
       def Plans.included(klass)
-        klass.add_handler 'post /v1/plans',     :new_plan
-        klass.add_handler 'get /v1/plans/(.*)', :get_plan
-        klass.add_handler 'get /v1/plans',      :list_plans
+        klass.add_handler 'post /v1/plans',       :new_plan
+        klass.add_handler 'post /v1/plans/(.*)',  :update_plan
+        klass.add_handler 'get /v1/plans/(.*)',   :get_plan
+        klass.add_handler 'get /v1/plans',        :list_plans
       end
 
       def new_plan(route, method_url, params, headers)
@@ -13,8 +14,16 @@ module StripeMock
         plans[ params[:id] ] = Data.test_plan(params)
       end
 
+      def update_plan(route, method_url, params, headers)
+        route =~ method_url
+        assert_existance :plan, $1, plans[$1]
+        plans[$1] ||= Data.test_plan(:id => $1)
+        plans[$1].merge!(params)
+      end
+
       def get_plan(route, method_url, params, headers)
         route =~ method_url
+        assert_existance :plan, $1, plans[$1]
         plans[$1] ||= Data.test_plan(:id => $1)
       end
 

data/lib/stripe_mock/server.rb

@@ -21,7 +21,14 @@ module StripeMock
     end
 
     def mock_request(*args)
-      @instance.mock_request(*args)
+      begin
+        @instance.mock_request(*args)
+      rescue Stripe::InvalidRequestError => e
+        {
+          :error_raised => 'invalid_request',
+          :error_params => [e.message, e.param, e.http_status, e.http_body, e.json_body]
+        }
+      end
     end
 
     def get_data(key)
@@ -36,10 +43,12 @@ module StripeMock
       @instance.debug = toggle
     end
 
-    def debug?
-      @instance.debug
+    def set_strict(toggle)
+      @instance.strict = toggle
     end
 
+    def debug?; @instance.debug; end
+    def strict?; @instance.strict; end
     def ping; true; end
   end
 

data/lib/stripe_mock/version.rb

@@ -1,4 +1,4 @@
 module StripeMock
   # stripe-ruby-mock version
-  VERSION = "1.8.3.9"
+  VERSION = "1.8.3.10"
 end

data/spec/server_spec.rb

@@ -54,6 +54,7 @@ describe 'StripeMock Server' do
 
 
   it "returns a response with symbolized hash keys" do
+    Stripe::Plan.create(id: 'x')
     response, api_key = StripeMock.redirect_to_mock_server('get', '/v1/plans/x', 'xxx')
     response.keys.each {|k| expect(k).to be_a(Symbol) }
   end

data/spec/shared_stripe_examples/charges.rb

@@ -48,13 +48,28 @@ shared_examples 'Charge API' do
     expect(charge.amount).to eq(original.amount)
   end
 
-  it "retrieves a stripe charge with an id that doesn't exist" do
-    charge = Stripe::Charge.retrieve('test_charge_x')
-    expect(charge.id).to eq('test_charge_x')
-    expect(charge.amount).to_not be_nil
-    expect(charge.card).to_not be_nil
+  it "cannot retrieve a charge that doesn't exist" do
+    expect { Stripe::Charge.retrieve('nope') }.to raise_error {|e|
+      expect(e).to be_a Stripe::InvalidRequestError
+      expect(e.param).to eq('charge')
+      expect(e.http_status).to eq(400)
+    }
   end
 
+
+  context "With strict mode toggled off" do
+
+    before { StripeMock.toggle_strict(false) }
+
+    it "retrieves a stripe charge with an id that doesn't exist" do
+      charge = Stripe::Charge.retrieve('test_charge_x')
+      expect(charge.id).to eq('test_charge_x')
+      expect(charge.amount).to_not be_nil
+      expect(charge.card).to_not be_nil
+    end
+  end
+
+
   describe 'captured status value' do
     it "reports captured by default" do
       charge = Stripe::Charge.create({

data/spec/shared_stripe_examples/customers.rb

@@ -41,11 +41,12 @@ shared_examples 'Customer API' do
     expect(customer.email).to eq(original.email)
   end
 
-  it "retrieves a stripe customer with an id that doesn't exist" do
-    customer = Stripe::Customer.retrieve('test_customer_x')
-    expect(customer.id).to eq('test_customer_x')
-    expect(customer.email).to_not be_nil
-    expect(customer.description).to_not be_nil
+  it "cannot retrieve a customer that doesn't exist" do
+    expect { Stripe::Customer.retrieve('nope') }.to raise_error {|e|
+      expect(e).to be_a Stripe::InvalidRequestError
+      expect(e.param).to eq('customer')
+      expect(e.http_status).to eq(400)
+    }
   end
 
   it "retrieves all customers" do
@@ -58,7 +59,7 @@ shared_examples 'Customer API' do
   end
 
   it "updates a stripe customer" do
-    original = Stripe::Customer.retrieve("test_customer_update")
+    original = Stripe::Customer.create(id: 'test_customer_update')
     email = original.email
 
     original.description = 'new desc'
@@ -73,7 +74,8 @@ shared_examples 'Customer API' do
   end
 
   it "updates a stripe customer's subscription" do
-    customer = Stripe::Customer.retrieve("test_customer_sub")
+    plan = Stripe::Plan.create(id: 'silver')
+    customer = Stripe::Customer.create(id: 'test_customer_sub')
     sub = customer.update_subscription({ :plan => 'silver' })
 
     expect(sub.object).to eq('subscription')
@@ -81,10 +83,30 @@ shared_examples 'Customer API' do
   end
 
   it "cancels a stripe customer's subscription" do
-    customer = Stripe::Customer.retrieve("test_customer_sub")
+    customer = Stripe::Customer.create(id: 'test_customer_sub')
     sub = customer.cancel_subscription
 
     expect(sub.deleted).to eq(true)
   end
 
+  it "cannot reference a plan that does not exist" do
+    customer = Stripe::Customer.create(id: 'test_customer_sub')
+    expect {
+      customer.update_subscription(plan: 'imagination')
+    }.to raise_error Stripe::InvalidRequestError
+  end
+
+
+  context "With strict mode toggled off" do
+
+    before { StripeMock.toggle_strict(false) }
+
+    it "retrieves a stripe customer with an id that doesn't exist" do
+      customer = Stripe::Customer.retrieve('test_customer_x')
+      expect(customer.id).to eq('test_customer_x')
+      expect(customer.email).to_not be_nil
+      expect(customer.description).to_not be_nil
+    end
+  end
+
 end

data/spec/shared_stripe_examples/plans.rb

@@ -57,17 +57,28 @@ shared_examples 'Plan API' do
   end
 
 
-  it "retrieves a stripe plan with an id that doesn't exist" do
-    plan = Stripe::Plan.retrieve('test_charge_x')
+  it "updates a stripe plan" do
+    Stripe::Plan.create(id: 'super_member', amount: 111)
 
-    expect(plan.id).to eq('test_charge_x')
-    expect(plan.amount).to_not be_nil
-    expect(plan.name).to_not be_nil
+    plan = Stripe::Plan.retrieve('super_member')
+    expect(plan.amount).to eq(111)
 
-    expect(plan.currency).to_not be_nil
-    expect(plan.interval).to_not be_nil
+    plan.amount = 789
+    plan.save
+    plan = Stripe::Plan.retrieve('super_member')
+    expect(plan.amount).to eq(789)
   end
 
+
+  it "cannot retrieve a stripe plan that doesn't exist" do
+    expect { Stripe::Plan.retrieve('nope') }.to raise_error {|e|
+      expect(e).to be_a Stripe::InvalidRequestError
+      expect(e.param).to eq('plan')
+      expect(e.http_status).to eq(400)
+    }
+  end
+
+
   it "retrieves all plans" do
     Stripe::Plan.create({ id: 'Plan One', amount: 54321 })
     Stripe::Plan.create({ id: 'Plan Two', amount: 98765 })
@@ -78,4 +89,21 @@ shared_examples 'Plan API' do
     all.map(&:amount).should include(54321, 98765)
   end
 
+
+  context "With strict mode toggled off" do
+
+    before { StripeMock.toggle_strict(false) }
+
+    it "can retrieve a stripe plan with an id that doesn't exist" do
+      plan = Stripe::Plan.retrieve('test_charge_x')
+
+      expect(plan.id).to eq('test_charge_x')
+      expect(plan.amount).to_not be_nil
+      expect(plan.name).to_not be_nil
+
+      expect(plan.currency).to_not be_nil
+      expect(plan.interval).to_not be_nil
+    end
+  end
+
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: stripe-ruby-mock
 version: !ruby/object:Gem::Version
-  version: 1.8.3.9
+  version: 1.8.3.10
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-06-21 00:00:00.000000000 Z
+date: 2013-06-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: stripe
@@ -111,6 +111,7 @@ files:
 - lib/stripe_mock/api/errors.rb
 - lib/stripe_mock/api/instance.rb
 - lib/stripe_mock/api/server.rb
+- lib/stripe_mock/api/strict.rb
 - lib/stripe_mock/api/webhooks.rb
 - lib/stripe_mock/client.rb
 - lib/stripe_mock/data.rb