stripe-rails 2.3.4 → 2.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 98454699702b467527128031422cf82e5e5cdd3a3f6fa7b883cc4fd8727d35dd
-  data.tar.gz: 47982d0fd7a62bb8bd2e38e08fd83082ad0c5475e5bf474f8e9386057e1a1f54
+  metadata.gz: 4f877c1646308e099953867cf62109fc8274a9d452d4b1ddbaddacc421c5bc77
+  data.tar.gz: c6986a7464043e10d13580ad1149120931b794070640c4103368daa474580bf9
 SHA512:
-  metadata.gz: c338725947f21b22a4f9d259142841bf586053b994b14c598b012674869dcfab1f34e89f8a68e53084c10fdc6055e536cc363b00dbcdff65d294ff77285198ad
-  data.tar.gz: 0fd4604bfb3c91bb54d66d1fa7819431249c0d1576cac15fa9deb7cb6eb05fdb831099444729943d1f5e6f59718be929f7d9f7caa7aef3dd5e140280915c001b
+  metadata.gz: 132c1fec2a1510815e2694c0150a646cbec3d90f7bf8cb4b231ad209ba28e12e9b40ba2a89f77d75d8499b8a5559c332d4e5f6db9c20f3d4f4ff5b08601f6d7d
+  data.tar.gz: 43779b3dfbcfdeeb1ed74c14e783faf09b74dc81a8279a800c815cab4717bfc746d0a1da558853201546199545c25f991eaa44348c477418edae4cca63c3c7bf

data/.github/workflows/ruby.yml

@@ -14,12 +14,12 @@ jobs:
 
     strategy:
       matrix:
-        ruby: [2.5.x, 2.6.x, 2.7.x]
+        ruby: [2.5.9, 2.6.10, 2.7.7]
         gemfile: [Gemfile, gemfiles/rails60.gemfile, gemfiles/rails52.gemfile, gemfiles/rails51.gemfile]
     steps:
     - uses: actions/checkout@v1
     - name: Set up Ruby
-      uses: actions/setup-ruby@v1
+      uses: ruby/setup-ruby@v1
       with:
         ruby-version: ${{ matrix.ruby }}
     - name: Set up Code Climate

data/Changelog.md

@@ -1,4 +1,11 @@
-## Unreleased
+## 2.4.0 (2023-02-04)
+
+- Add `tax_behavior` attribute to Price. Thanks @szechyjs !
+
+## 2.3.5 (2022-10-01)
+
+- Fix some deprecation warnings in tests. Thanks @smtlaissezfaire !
+- Fix `NameError when loading JavascriptHelper`. Thanks @smtlaissezfaire !
 
 ## 2.3.4 (2022-05-03)
 

data/Gemfile

@@ -16,7 +16,7 @@ group :test do
   gem 'webmock'
   # System tests
   gem 'capybara'
-  gem 'puma'
+  gem 'puma', '< 6' # https://github.com/teamcapybara/capybara/issues/2598
   gem 'selenium-webdriver'
   gem 'webdrivers'
 end

data/gemfiles/rails51.gemfile

@@ -14,7 +14,7 @@ group :test do
   gem 'webmock'
   # Required for system tests
   gem 'capybara'
-  gem 'puma'
+  gem 'puma', '< 6' # https://github.com/teamcapybara/capybara/issues/2598
   gem 'selenium-webdriver'
   gem 'webdrivers'
 end

data/gemfiles/rails52.gemfile

@@ -14,7 +14,7 @@ group :test do
   gem 'webmock'
   # Required for system tests
   gem 'capybara'
-  gem 'puma'
+  gem 'puma', '< 6' # https://github.com/teamcapybara/capybara/issues/2598
   gem 'selenium-webdriver'
   gem 'webdrivers'
 end

data/gemfiles/rails60.gemfile

@@ -13,7 +13,7 @@ group :test do
   gem 'webmock'
   # Required for system tests
   gem 'capybara'
-  gem 'puma'
+  gem 'puma', '< 6' # https://github.com/teamcapybara/capybara/issues/2598
   gem 'selenium-webdriver'
   gem 'webdrivers'
 end

data/lib/stripe/engine.rb

@@ -79,7 +79,7 @@ environment file directly.
       end
     end
 
-    initializer 'stripe.javascript_helper' do
+    config.to_prepare do
       ActiveSupport.on_load :action_controller do
         # ActionController::API does not have a helper method
         if respond_to?(:helper)

data/lib/stripe/prices.rb

@@ -16,6 +16,7 @@ module Stripe
                     :product_id,
                     :recurring,
                     :statement_descriptor,
+                    :tax_behavior,
                     :tiers,
                     :tiers_mode,
                     :transform_quantity,
@@ -40,6 +41,7 @@ module Stripe
       validates :billing_scheme,            inclusion: { in: %w{ per_unit tiered } }, allow_nil: true
       validates :recurring_aggregate_usage, inclusion: { in: %w{ sum last_during_period last_ever max } }, allow_nil: true
       validates :recurring_usage_type,      inclusion: { in: %w{ metered licensed } }, allow_nil: true
+      validates :tax_behavior,              inclusion: { in: %w{ inclusive exclusive unspecified } }, allow_nil: true
       validates :tiers_mode,                inclusion: { in: %w{ graduated volume } }, allow_nil: true
 
       validate :name_or_product_id
@@ -171,6 +173,7 @@ module Stripe
           tiers_mode: tiers_mode,
           billing_scheme: billing_scheme,
           lookup_key: @lookup_key,
+          tax_behavior: tax_behavior,
           transform_quantity: transform_quantity,
         }.merge(product_options).compact
       end

data/lib/stripe/rails/version.rb

@@ -1,5 +1,5 @@
 module Stripe
   module Rails
-    VERSION = '2.3.4'.freeze
+    VERSION = '2.4.0'.freeze
   end
 end

data/test/dummy/config/stripe/prices.rb

@@ -6,6 +6,12 @@ Stripe.price :gold do |price|
    }
 end
 
+Stripe.price :taxable_gold do |price|
+  price.name = 'Taxable Gold'
+  price.unit_amount = 699
+  price.tax_behavior = 'exclusive'
+end
+
 Stripe.price "Solid Gold".to_sym do |price|
    price.constant_name = 'SOLID_GOLD'
    price.name = 'Solid Gold'

data/test/plan_builder_spec.rb

@@ -307,7 +307,7 @@ describe 'building plans' do
 
           describe 'when passed invalid arguments for tiered pricing' do
             it 'raises a Stripe::InvalidConfigurationError when billing tiers are invalid' do
-              lambda {
+              _(lambda {
                 Stripe.plan "Bad Tiers".to_sym do |plan|
                   plan.name = 'Acme as a service BAD TIERS'
                   plan.constant_name = 'BAD_TIERS'
@@ -328,11 +328,11 @@ describe 'building plans' do
                     }
                   ]
                 end
-              }.must_raise Stripe::InvalidConfigurationError
+              }).must_raise Stripe::InvalidConfigurationError
             end
 
             it 'raises a Stripe::InvalidConfigurationError when billing tiers is not an array' do
-              lambda {
+              _(lambda {
                 Stripe.plan "Bad Tiers".to_sym do |plan|
                   plan.name = 'Acme as a service BAD TIERS'
                   plan.constant_name = 'BAD_TIERS'
@@ -348,7 +348,7 @@ describe 'building plans' do
                     up_to: 10
                   }
                 end
-              }.must_raise Stripe::InvalidConfigurationError
+              }).must_raise Stripe::InvalidConfigurationError
             end
           end
 

data/test/price_builder_spec.rb

@@ -267,6 +267,46 @@ describe 'building prices' do
       }).must_raise Stripe::InvalidConfigurationError
     end
 
+    it 'denies invalid tax_behavior' do
+      _(lambda {
+        Stripe.price :broken do |price|
+          price.name = 'Invalid tax'
+          price.unit_amount = 999
+          price.tax_behavior = 'whatever'
+        end
+      }).must_raise Stripe::InvalidConfigurationError
+    end
+
+    it 'accepts a tax_behavior of exclusive' do
+      Stripe.price :exclusive do |price|
+        price.name = 'Exclusive tax'
+        price.unit_amount = 4800
+        price.tax_behavior = 'exclusive'
+      end
+
+      _(Stripe::Prices::EXCLUSIVE).wont_be_nil
+    end
+
+    it 'accepts a tax_behavior of inclusive' do
+      Stripe.price :inclusive do |price|
+        price.name = 'Inclusive tax'
+        price.unit_amount = 4800
+        price.tax_behavior = 'inclusive'
+      end
+
+      _(Stripe::Prices::INCLUSIVE).wont_be_nil
+    end
+
+    it 'accepts a tax_behavior of unspecified' do
+      Stripe.price :unspecified do |price|
+        price.name = 'Unspecified tax'
+        price.unit_amount = 4800
+        price.tax_behavior = 'unspecified'
+      end
+
+      _(Stripe::Prices::UNSPECIFIED).wont_be_nil
+    end
+
     describe 'name and product id validation' do
       it 'should be valid when using just the product id' do
         Stripe.price :prodded do |price|
@@ -322,6 +362,22 @@ describe 'building prices' do
           Stripe::Prices::GOLD.put!
         end
 
+        it 'creates a price with tax_behavior' do
+          Stripe::Price.expects(:create).with(
+            :lookup_key => 'taxable_gold',
+            :nickname => 'taxable_gold',
+            :currency => 'usd',
+            :product_data => {
+              :name => 'Taxable Gold',
+              :statement_descriptor => nil
+            },
+            :unit_amount => 699,
+            :recurring => {},
+            :tax_behavior => 'exclusive'
+          )
+          Stripe::Prices::TAXABLE_GOLD.put!
+        end
+
         it 'creates a price with an alternative currency' do
           Stripe::Price.expects(:create).with(
             :lookup_key => 'alternative_currency',
@@ -392,7 +448,7 @@ describe 'building prices' do
 
         describe 'when passed invalid arguments for tiered pricing' do
           it 'raises a Stripe::InvalidConfigurationError when billing tiers are invalid' do
-            lambda {
+            _(lambda {
               Stripe.price "Bad Tiers".to_sym do |price|
                 price.name = 'Acme as a service BAD TIERS'
                 price.constant_name = 'BAD_TIERS'
@@ -414,11 +470,11 @@ describe 'building prices' do
                   }
                 ]
               end
-            }.must_raise Stripe::InvalidConfigurationError
+            }).must_raise Stripe::InvalidConfigurationError
           end
 
           it 'raises a Stripe::InvalidConfigurationError when billing tiers is not an array' do
-            lambda {
+            _(lambda {
               Stripe.price "Bad Tiers".to_sym do |price|
                 price.name = 'Acme as a service BAD TIERS'
                 price.constant_name = 'BAD_TIERS'
@@ -435,7 +491,7 @@ describe 'building prices' do
                   up_to: 10
                 }
               end
-            }.must_raise Stripe::InvalidConfigurationError
+            }).must_raise Stripe::InvalidConfigurationError
           end
         end
 

data/test/spec_helper.rb

@@ -34,6 +34,6 @@ if ActiveSupport::TestCase.method_defined?(:fixture_path=)
 end
 
 Stripe::Engine.testing = true
-require 'mocha/setup'
+require 'mocha/minitest'
 
 require 'irb'

data/test/stripe_initializers_spec.rb

@@ -4,12 +4,18 @@ describe "Configuring the stripe engine" do
   i_suck_and_my_tests_are_order_dependent! # the default test must be run first!
 
   # NOTE: skipped `stripe.plans_and_coupons` to prevent warnings about constants
-  STRIPE_INITIALIZER_NAMES = %w{ stripe.configure.defaults stripe.configure stripe.callbacks.eager_load stripe.javascript_helper }
+  STRIPE_INITIALIZER_NAMES = %w{
+    stripe.configure.defaults
+    stripe.configure
+    stripe.callbacks.eager_load
+  }
 
   let(:app)           { Rails.application }
   let(:initializers)  { STRIPE_INITIALIZER_NAMES.map{|name| app.initializers.find{|ini| ini.name == name } } }
 
-  def rerun_initializers!; initializers.each{|init| init.run(app) }; end
+  def rerun_initializers!
+    initializers.each { |init| init.run(app) }
+  end
 
   after do
     Stripe.api_version       = nil
@@ -60,11 +66,11 @@ describe "Configuring the stripe engine" do
     it "supports nil signing_secret" do
       subject
 
-      app.config.stripe.signing_secret    = nil
+      app.config.stripe.signing_secret = nil
       rerun_initializers!
 
-      _(app.config.stripe.signing_secret).must_equal nil
-      _(app.config.stripe.signing_secrets).must_equal nil
+      assert_nil app.config.stripe.signing_secret
+      assert_nil app.config.stripe.signing_secrets
     end
 
     it "supports multiple signing secrets" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: stripe-rails
 version: !ruby/object:Gem::Version
-  version: 2.3.4
+  version: 2.4.0
 platform: ruby
 authors:
 - Charles Lowell
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-05-03 00:00:00.000000000 Z
+date: 2023-02-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -188,7 +188,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
+rubygems_version: 3.3.24
 signing_key: 
 specification_version: 4
 summary: A gem to integrate stripe into your rails app