stripe-rails 2.3.4 → 2.3.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 98454699702b467527128031422cf82e5e5cdd3a3f6fa7b883cc4fd8727d35dd
-  data.tar.gz: 47982d0fd7a62bb8bd2e38e08fd83082ad0c5475e5bf474f8e9386057e1a1f54
+  metadata.gz: c0689a9e336780e3cfdd44afb914a5f5162e1ffa00f458f43e91b0f325b07be3
+  data.tar.gz: 74b39a714aea039928fcd94636c080a7ec8cb222a2f3e3a41823285e3c434c25
 SHA512:
-  metadata.gz: c338725947f21b22a4f9d259142841bf586053b994b14c598b012674869dcfab1f34e89f8a68e53084c10fdc6055e536cc363b00dbcdff65d294ff77285198ad
-  data.tar.gz: 0fd4604bfb3c91bb54d66d1fa7819431249c0d1576cac15fa9deb7cb6eb05fdb831099444729943d1f5e6f59718be929f7d9f7caa7aef3dd5e140280915c001b
+  metadata.gz: b5ecf2a6c8812ec03b8accd5ab8453a1a3836dee7b6127692f29f7886a737795027f6f1905a25d68f59afecfc38ac9203d7f01941c133a3f2a80c6d8efeaf51a
+  data.tar.gz: 10a572f102d2670274dc12868993bfc5c10ba555ef0cc342c081f2569117cb928ea1e6c4a87726b6a1b901cabeee305ff8a7437ae0b4d7515ff0c8016d0e8b3c

data/Changelog.md

@@ -1,5 +1,10 @@
 ## Unreleased
 
+## 2.3.5 (2022-10-01)
+
+- Fix some deprecation warnings in tests. Thanks @smtlaissezfaire !
+- Fix `NameError when loading JavascriptHelper`. Thanks @smtlaissezfaire !
+
 ## 2.3.4 (2022-05-03)
 
 -  Add setup_intent.canceled and setup_intent.requires_action callbacks. Thanks @jamesjason !

data/lib/stripe/engine.rb

@@ -79,7 +79,7 @@ environment file directly.
       end
     end
 
-    initializer 'stripe.javascript_helper' do
+    config.to_prepare do
       ActiveSupport.on_load :action_controller do
         # ActionController::API does not have a helper method
         if respond_to?(:helper)

data/lib/stripe/rails/version.rb

@@ -1,5 +1,5 @@
 module Stripe
   module Rails
-    VERSION = '2.3.4'.freeze
+    VERSION = '2.3.5'.freeze
   end
 end

data/test/plan_builder_spec.rb

@@ -307,7 +307,7 @@ describe 'building plans' do
 
           describe 'when passed invalid arguments for tiered pricing' do
             it 'raises a Stripe::InvalidConfigurationError when billing tiers are invalid' do
-              lambda {
+              _(lambda {
                 Stripe.plan "Bad Tiers".to_sym do |plan|
                   plan.name = 'Acme as a service BAD TIERS'
                   plan.constant_name = 'BAD_TIERS'
@@ -328,11 +328,11 @@ describe 'building plans' do
                     }
                   ]
                 end
-              }.must_raise Stripe::InvalidConfigurationError
+              }).must_raise Stripe::InvalidConfigurationError
             end
 
             it 'raises a Stripe::InvalidConfigurationError when billing tiers is not an array' do
-              lambda {
+              _(lambda {
                 Stripe.plan "Bad Tiers".to_sym do |plan|
                   plan.name = 'Acme as a service BAD TIERS'
                   plan.constant_name = 'BAD_TIERS'
@@ -348,7 +348,7 @@ describe 'building plans' do
                     up_to: 10
                   }
                 end
-              }.must_raise Stripe::InvalidConfigurationError
+              }).must_raise Stripe::InvalidConfigurationError
             end
           end
 

data/test/price_builder_spec.rb

@@ -392,7 +392,7 @@ describe 'building prices' do
 
         describe 'when passed invalid arguments for tiered pricing' do
           it 'raises a Stripe::InvalidConfigurationError when billing tiers are invalid' do
-            lambda {
+            _(lambda {
               Stripe.price "Bad Tiers".to_sym do |price|
                 price.name = 'Acme as a service BAD TIERS'
                 price.constant_name = 'BAD_TIERS'
@@ -414,11 +414,11 @@ describe 'building prices' do
                   }
                 ]
               end
-            }.must_raise Stripe::InvalidConfigurationError
+            }).must_raise Stripe::InvalidConfigurationError
           end
 
           it 'raises a Stripe::InvalidConfigurationError when billing tiers is not an array' do
-            lambda {
+            _(lambda {
               Stripe.price "Bad Tiers".to_sym do |price|
                 price.name = 'Acme as a service BAD TIERS'
                 price.constant_name = 'BAD_TIERS'
@@ -435,7 +435,7 @@ describe 'building prices' do
                   up_to: 10
                 }
               end
-            }.must_raise Stripe::InvalidConfigurationError
+            }).must_raise Stripe::InvalidConfigurationError
           end
         end
 

data/test/spec_helper.rb

@@ -34,6 +34,6 @@ if ActiveSupport::TestCase.method_defined?(:fixture_path=)
 end
 
 Stripe::Engine.testing = true
-require 'mocha/setup'
+require 'mocha/minitest'
 
 require 'irb'

data/test/stripe_initializers_spec.rb

@@ -4,12 +4,18 @@ describe "Configuring the stripe engine" do
   i_suck_and_my_tests_are_order_dependent! # the default test must be run first!
 
   # NOTE: skipped `stripe.plans_and_coupons` to prevent warnings about constants
-  STRIPE_INITIALIZER_NAMES = %w{ stripe.configure.defaults stripe.configure stripe.callbacks.eager_load stripe.javascript_helper }
+  STRIPE_INITIALIZER_NAMES = %w{
+    stripe.configure.defaults
+    stripe.configure
+    stripe.callbacks.eager_load
+  }
 
   let(:app)           { Rails.application }
   let(:initializers)  { STRIPE_INITIALIZER_NAMES.map{|name| app.initializers.find{|ini| ini.name == name } } }
 
-  def rerun_initializers!; initializers.each{|init| init.run(app) }; end
+  def rerun_initializers!
+    initializers.each { |init| init.run(app) }
+  end
 
   after do
     Stripe.api_version       = nil
@@ -60,11 +66,11 @@ describe "Configuring the stripe engine" do
     it "supports nil signing_secret" do
       subject
 
-      app.config.stripe.signing_secret    = nil
+      app.config.stripe.signing_secret = nil
       rerun_initializers!
 
-      _(app.config.stripe.signing_secret).must_equal nil
-      _(app.config.stripe.signing_secrets).must_equal nil
+      assert_nil app.config.stripe.signing_secret
+      assert_nil app.config.stripe.signing_secrets
     end
 
     it "supports multiple signing secrets" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: stripe-rails
 version: !ruby/object:Gem::Version
-  version: 2.3.4
+  version: 2.3.5
 platform: ruby
 authors:
 - Charles Lowell
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-05-03 00:00:00.000000000 Z
+date: 2022-10-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -188,7 +188,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
+rubygems_version: 3.3.18
 signing_key: 
 specification_version: 4
 summary: A gem to integrate stripe into your rails app