stripe-rails 1.8.2 → 2.0.0.pre

data/test/product_builder_spec.rb

@@ -15,16 +15,16 @@ describe 'building products' do
   after { Stripe::Products.send(:remove_const, :PRIMO) }
 
   it 'is accessible via id' do
-    Stripe::Products::PRIMO.wont_be_nil
+    _(Stripe::Products::PRIMO).wont_be_nil
   end
 
   it 'is accessible via collection' do
-    Stripe::Products.all.must_include Stripe::Products::PRIMO
+    _(Stripe::Products.all).must_include Stripe::Products::PRIMO
   end
 
   it 'is accessible via hash lookup (symbol/string agnostic)' do
-    Stripe::Products[:primo].must_equal  Stripe::Products::PRIMO
-    Stripe::Products['primo'].must_equal Stripe::Products::PRIMO
+    _(Stripe::Products[:primo]).must_equal  Stripe::Products::PRIMO
+    _(Stripe::Products['primo']).must_equal Stripe::Products::PRIMO
   end
 
   describe '.put!' do
@@ -63,42 +63,42 @@ describe 'building products' do
   describe 'validations' do
     describe 'with missing mandatory values' do
       it 'raises an exception after configuring it' do
-        lambda { Stripe.product(:bad){} }.must_raise Stripe::InvalidConfigurationError
+        _(lambda { Stripe.product(:bad){} }).must_raise Stripe::InvalidConfigurationError
       end
     end
 
     describe 'invalid type' do
       it 'raises an exception during configuration' do
-        lambda {
+        _(lambda {
           Stripe.product :broken do |product|
             product.name = 'Acme as a service BROKEN'
             product.type = 'anything'
           end
-        }.must_raise Stripe::InvalidConfigurationError
+        }).must_raise Stripe::InvalidConfigurationError
       end
     end
 
     describe 'when using an attribute only for goods' do
       it 'raises an exception during configuration' do
-        lambda {
+        _(lambda {
           Stripe.product :broken do |product|
             product.name        = 'Broken Service'
             product.type        = 'service'
             product.caption     = 'So good it is Primo'
           end
-        }.must_raise Stripe::InvalidConfigurationError
+        }).must_raise Stripe::InvalidConfigurationError
       end
     end
 
     describe 'when using an attribute only for services' do
       it 'raises an exception during configuration' do
-        lambda {
+        _(lambda {
           Stripe.product :broken do |product|
             product.name        = 'Broken Good'
             product.type        = 'good'
             product.statement_descriptor = 'SERVICE'
           end
-        }.must_raise Stripe::InvalidConfigurationError
+        }).must_raise Stripe::InvalidConfigurationError
       end
     end
   end

data/test/spec_helper.rb

@@ -6,12 +6,12 @@ end
 require 'minitest/autorun'
 
 require 'webmock/minitest'
-WebMock.disable_net_connect!(allow_localhost: true)
+WebMock.disable_net_connect! allow_localhost: true, allow: ['codeclimate.com', 'chromedriver.storage.googleapis.com']
 
 # Chrome Setup
 require 'selenium-webdriver'
 require 'capybara'
-require 'chromedriver-helper'
+require 'webdrivers'
 Capybara.register_driver :selenium do |app|
   Capybara::Selenium::Driver.new(app, :browser => :chrome)
 end

data/test/stripe_initializers_spec.rb

@@ -19,16 +19,16 @@ describe "Configuring the stripe engine" do
 
   describe 'Stripe configurations' do
     it "will have valid default values" do
-      Stripe.api_base.must_equal          'https://api.stripe.com'
-      Stripe.api_key.must_equal           'XYZ'
-      Stripe.api_version.must_be_nil
-      Stripe.verify_ssl_certs.must_equal  true
-      Stripe.open_timeout.must_equal      30
-      Stripe.read_timeout.must_equal      80
-
-      app.config.stripe.endpoint.must_equal   '/stripe'
-      app.config.stripe.auto_mount.must_equal true
-      app.config.stripe.debug_js.must_equal   false
+      _(Stripe.api_base).must_equal          'https://api.stripe.com'
+      _(Stripe.api_key).must_equal           'XYZ'
+      _(Stripe.api_version).must_be_nil
+      _(Stripe.verify_ssl_certs).must_equal  true
+      _(Stripe.open_timeout).must_equal      30
+      _(Stripe.read_timeout).must_equal      80
+
+      _(app.config.stripe.endpoint).must_equal   '/stripe'
+      _(app.config.stripe.auto_mount).must_equal true
+      _(app.config.stripe.debug_js).must_equal   false
     end
 
     subject do
@@ -40,20 +40,32 @@ describe "Configuring the stripe engine" do
       app.config.stripe.open_timeout      = 33
       app.config.stripe.read_timeout      = 88
       rerun_initializers!
-    end
+    end 
 
     it "reads values that is set in the environment" do
       subject
 
-      Stripe.api_base.must_equal          'http://localhost:5000'
-      Stripe.api_key.must_equal           'SECRET_XYZ'
-      Stripe.verify_ssl_certs.must_equal  false
-      Stripe.api_version.must_equal       '2015-10-16'
-      Stripe.open_timeout.must_equal      33
-      Stripe.read_timeout.must_equal      88
+      _(Stripe.api_base).must_equal          'http://localhost:5000'
+      _(Stripe.api_key).must_equal           'SECRET_XYZ'
+      _(Stripe.verify_ssl_certs).must_equal  false
+      _(Stripe.api_version).must_equal       '2015-10-16'
+      _(Stripe.open_timeout).must_equal      33
+      _(Stripe.read_timeout).must_equal      88
+
+      _(app.config.stripe.signing_secret).must_equal 'SIGNING_SECRET_XYZ'
+      _(app.config.stripe.signing_secrets.length).must_equal 1
+    end
+
+    it "supports multiple signing secrets" do
+      subject
+
+      app.config.stripe.signing_secrets    = ['SIGNING_SECRET_XYZ', 'SIGNING_SECRET_XYZ_CONNECT']
+      rerun_initializers!
 
-      app.config.stripe.signing_secret.must_equal   'SIGNING_SECRET_XYZ'
+      _(app.config.stripe.signing_secret).must_equal 'SIGNING_SECRET_XYZ'
+      _(app.config.stripe.signing_secrets.length).must_equal 2
     end
+
   end
 
   describe 'eager loaded callbacks' do
@@ -65,8 +77,8 @@ describe "Configuring the stripe engine" do
     it 'should be eager loaded' do
       subject
 
-      Dummy.const_defined?(:ModelWithCallbacks).must_equal  true
-      Dummy.const_defined?(:ModuleWithCallbacks).must_equal true
+      _(Dummy.const_defined?(:ModelWithCallbacks)).must_equal  true
+      _(Dummy.const_defined?(:ModuleWithCallbacks)).must_equal true
     end
   end
 
@@ -75,7 +87,7 @@ describe "Configuring the stripe engine" do
     let(:warning_msg) { "[DEPRECATION] to align with stripe nomenclature, stripe.api_key has been renamed to config.stripe.secret_key\n" }
 
     it 'should output a warning' do
-      -> { subject }.must_output '', warning_msg
+      _(-> { subject }).must_output '', warning_msg
     end
   end
 end

data/test/support/application_system_test_case.rb

@@ -1,8 +1,3 @@
-require File.expand_path("null_system_test_case", __dir__)
-
-# For Rails 4 compat
-SystemTestCaseKlass = defined?(ActionDispatch::SystemTestCase) ? ActionDispatch::SystemTestCase : NullSystemTestCase
-
-class ApplicationSystemTestCase < SystemTestCaseKlass
+class ApplicationSystemTestCase < ActionDispatch::SystemTestCase
   driven_by :selenium_chrome_headless
-end
+end

data/test/testing_spec.rb

@@ -28,8 +28,8 @@ describe "Testing" do
 
       it 'the callback must run' do
         subject
-        event.wont_be_nil
-        event.type.must_equal "invoice.payment_succeeded"
+        _(event).wont_be_nil
+        _(event.type).must_equal "invoice.payment_succeeded"
       end
     end
 
@@ -38,7 +38,7 @@ describe "Testing" do
 
       it 'the callback must not run' do
         subject
-        event.must_be_nil
+        _(event).must_be_nil
       end
     end
 
@@ -49,11 +49,11 @@ describe "Testing" do
 
       it 'the callback should run with overwritten properties' do
         subject
-        event.wont_be_nil
-        event.type.must_equal "invoice.payment_succeeded"
-        target.subtotal.must_equal 500
-        target.total.must_equal 1000
-        target.currency.must_equal "eur"
+        _(event).wont_be_nil
+        _(event.type).must_equal "invoice.payment_succeeded"
+        _(target.subtotal).must_equal 500
+        _(target.total).must_equal 1000
+        _(target.currency).must_equal "eur"
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: stripe-rails
 version: !ruby/object:Gem::Version
-  version: 1.8.2
+  version: 2.0.0.pre
 platform: ruby
 authors:
 - Charles Lowell
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-08-31 00:00:00.000000000 Z
+date: 2020-05-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -18,28 +18,28 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3'
+        version: '5.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3'
+        version: '5.1'
 - !ruby/object:Gem::Dependency
   name: stripe
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.36.2
+        version: 3.15.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.36.2
+        version: 3.15.0
 - !ruby/object:Gem::Dependency
   name: responders
   requirement: !ruby/object:Gem::Requirement
@@ -65,9 +65,9 @@ files:
 - ".editorconfig"
 - ".github/issue_template.md"
 - ".github/pull_request_template.md"
+- ".github/workflows/ruby.yml"
 - ".gitignore"
 - ".rubocop.yml"
-- ".travis.yml"
 - CODE_OF_CONDUCT.md
 - Changelog.md
 - Gemfile
@@ -78,21 +78,21 @@ files:
 - app/assets/stripe/stripe_elements.js
 - app/controllers/stripe/application_controller.rb
 - app/controllers/stripe/events_controller.rb
-- app/controllers/stripe/pings_controller.rb
 - app/helpers/stripe/javascript_helper.rb
 - app/models/stripe/event_dispatch.rb
-- app/models/stripe/ping.rb
 - app/views/stripe/_elements.html.erb
 - app/views/stripe/_elements_js.html.erb
 - app/views/stripe/_js.html.erb
 - config/locales/en.yml
 - config/routes.rb
-- gemfiles/rails4.gemfile
+- gemfiles/rails51.gemfile
+- gemfiles/rails52.gemfile
 - lib/generators/stripe/install_generator.rb
 - lib/generators/templates/coupons.rb
 - lib/generators/templates/plans.rb
 - lib/generators/templates/products.rb
 - lib/stripe-rails.rb
+- lib/stripe/billing_tier.rb
 - lib/stripe/callbacks.rb
 - lib/stripe/callbacks/builder.rb
 - lib/stripe/configuration_builder.rb
@@ -155,7 +155,6 @@ files:
 - test/fixtures/stripe_plans_headers_2017.json
 - test/invoice.json
 - test/javascript_helper_spec.rb
-- test/pings_controller_spec.rb
 - test/plan_builder_spec.rb
 - test/product_builder_spec.rb
 - test/spec_helper.rb
@@ -163,7 +162,6 @@ files:
 - test/support/application_system_test_case.rb
 - test/support/callback_helpers.rb
 - test/support/fixture_loader.rb
-- test/support/null_system_test_case.rb
 - test/testing_spec.rb
 homepage: https://github.com/tansengming/stripe-rails
 licenses:
@@ -180,11 +178,11 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: A gem to integrate stripe into your rails app
@@ -238,7 +236,6 @@ test_files:
 - test/fixtures/stripe_plans_headers_2017.json
 - test/invoice.json
 - test/javascript_helper_spec.rb
-- test/pings_controller_spec.rb
 - test/plan_builder_spec.rb
 - test/product_builder_spec.rb
 - test/spec_helper.rb
@@ -246,5 +243,4 @@ test_files:
 - test/support/application_system_test_case.rb
 - test/support/callback_helpers.rb
 - test/support/fixture_loader.rb
-- test/support/null_system_test_case.rb
 - test/testing_spec.rb

data/.travis.yml

@@ -1,28 +0,0 @@
-language: ruby
-rvm:
-- 2.6.0
-- 2.5.5
-- 2.4.5
-- 2.3.8
-addons:
-  chrome: stable
-env:
-  global:
-  - GIT_COMMITTED_AT=$(if [ "$TRAVIS_PULL_REQUEST" == "false" ]; then git log -1 --pretty=format:%ct;
-    else git log -1 --skip 1 --pretty=format:%ct; fi)
-before_script:
-- curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64
-  > ./cc-test-reporter
-- chmod +x ./cc-test-reporter
-- "./cc-test-reporter before-build"
-script:
-- bundle exec rake
-- if [ "$TRAVIS_PULL_REQUEST" == "false" ] && [ `basename $BUNDLE_GEMFILE` == "Gemfile"
-  ]  && [ ${RUBY_VERSION:5:3} == "2.6" ] ; then echo "Sending Coverage..."; ./cc-test-reporter
-  after-build --exit-code $TRAVIS_TEST_RESULT; fi
-gemfile:
-- Gemfile
-- gemfiles/rails4.gemfile
-notifications:
-  slack:
-    secure: csciM073msTrOOdVYVXdAsrx2sR3Y1BKL0VvlSsYxBJawDa8BFNl6Fw8Uz1V2n4OfnkMvMCME4I3EXsCb4Kl5omnK+7ibeCzzzkCR5VwUs5/vLY7awUfCiihSCqg5ULAp2T1whQJUl5HY9Ot62sujIUX/FUhPzdbCqaKQ7cVkUo=

data/app/controllers/stripe/pings_controller.rb

@@ -1,10 +0,0 @@
-module Stripe
-  class PingsController < ::Stripe::ApplicationController
-    respond_to :json
-
-    def show
-      @ping = Ping.new
-      respond_with @ping
-    end
-  end
-end

data/app/models/stripe/ping.rb

@@ -1,9 +0,0 @@
-module Stripe
-  class Ping
-    attr_reader :message
-
-    def initialize
-      @message = "Your sound card works perfectly!"
-    end
-  end
-end

data/test/pings_controller_spec.rb

@@ -1,18 +0,0 @@
-require 'spec_helper'
-
-describe Stripe::PingsController do
-  parallelize_me!
-  include Rack::Test::Methods
-
-  let(:app) { Rails.application }
-  before do
-    header 'Accept', 'application/json'
-    header 'Content-Type', 'application/json'
-  end
-
-  describe 'the ping interface' do
-    subject { get '/stripe/ping' }
-
-    it { subject.must_be :ok? }
-  end
-end

data/test/support/null_system_test_case.rb

@@ -1,11 +0,0 @@
-class NullSystemTestCase
-  def self.driven_by(*_)
-  end
-
-  def self.setup
-  end
-
-  def self.test(_)
-    warn 'WARNING: Skipping system test because this version of Rails does not support it!'
-  end
-end