stripe-rails 1.5.0 → 1.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8fbadf81c0f8478feeffda1a46ed1b29b7fd5771eec9fbec5f2a8cd0684a051f
-  data.tar.gz: baa6413f94ecc16b4ac4ba192e29dc7ef3c5742de759ed1e22397a13e71b764e
+  metadata.gz: 7db8795e52cc3f40773d7104222eb9f36ceea62a5d51ddc9a0f5215d2635021c
+  data.tar.gz: ee17376ed75a5f28e755a7bd7e4e8bcf4e91fb2de23b96226f0837b6f678afe6
 SHA512:
-  metadata.gz: ca51fc8a16bac65cd5ecda5d92130ecf18e83870cacc3c422952846d61359f89ecb877151b4ff9ea93c0e1b25746dd9efe6f86d6790a363de0ede13e6727a9c3
-  data.tar.gz: 7b380bb3b762c6acc39de20b4d0187c15623dc3141adda0bed62d0017a533ccbb546ba4352682d903dae04bf567f504f0a8eb27487b3ab2327d21f1fe973cb41
+  metadata.gz: 007ca00d0dea9a363b5042fa2d82ce42e430a53c7773682b92b74a6c77ce4024756eab6df5b919b08f7b0699b45450b0cb69cb63e1546c6d429f427af520efc9
+  data.tar.gz: d37cfd7ffc037cf80d119c366993d89a1d90a7291bd9a1fe4477b0d120c24e7f550baf948ea4bbdb1ec86c2e05f2644c34bdcf308625078c4b8c1498fc53a2a2

data/Changelog.md

@@ -1,3 +1,8 @@
+## 1.5.1 (2018-10-01)
+
+* Allow statement_descriptor to be set on products - Thanks to @jeanmartin
+
+
 ## 1.5.0 (2018-09-27)
 
 * Add Webhook Signature Validation - Thanks to @wkirby

data/README.md

@@ -177,9 +177,10 @@ end
 As are Products:
 
 ```ruby
-Stripe.products :primo do |products|
-  products.name = 'PRIMO as a service'
-  products.type = 'service'
+Stripe.product :primo do |product|
+  product.name = 'PRIMO as a service'
+  product.type = 'service'
+  product.statement_descriptor = 'PRIMO'
 end
 ```
 

data/lib/stripe/products.rb

@@ -11,19 +11,27 @@ module Stripe
                     :caption,
                     :metadata,
                     :shippable,
-                    :url
+                    :url,
+                    :statement_descriptor
 
       validates_presence_of :name, :type
 
+      validates :statement_descriptor, length: { maximum: 22 }
+
       validates :active, :shippable, inclusion: { in: [true, false] }, allow_nil: true
       validates :type, inclusion: { in: %w(service good) }
       validates :caption, :description, :shippable, :url, absence: true, unless: :good?
+      validates :statement_descriptor, absence: true, unless: :service?
 
       private
       def good?
         type == 'good'
       end
 
+      def service?
+        type == 'service'
+      end
+
       def create_options
         {
           name: name,
@@ -35,6 +43,7 @@ module Stripe
           metadata: metadata,
           shippable: shippable,
           url: url,
+          statement_descriptor: statement_descriptor
         }.delete_if{|_, v| v.nil? }
       end
     end

data/lib/stripe/rails/version.rb

@@ -1,5 +1,5 @@
 module Stripe
   module Rails
-    VERSION = '1.5.0'
+    VERSION = '1.5.1'
   end
 end

data/test/product_builder_spec.rb

@@ -8,6 +8,7 @@ describe 'building products' do
       product.active      = true
       product.attributes  = ['size', 'gender']
       product.metadata    = {:number_of_awesome_things => 5}
+      product.statement_descriptor = 'PRIMO'
     end
   end
 
@@ -32,12 +33,13 @@ describe 'building products' do
 
       it 'creates the plan online' do
         Stripe::Product.expects(:create).with(
-          :id => :primo,
-          :name => 'Acme as a service PRIMO',
-          :type => 'service',
-          :active => true,
-          :attributes => ['size', 'gender'],
-          :metadata => {:number_of_awesome_things => 5},
+          id: :primo,
+          name: 'Acme as a service PRIMO',
+          type: 'service',
+          active: true,
+          attributes: ['size', 'gender'],
+          metadata: {:number_of_awesome_things => 5},
+          statement_descriptor: 'PRIMO'
         )
         Stripe::Products::PRIMO.put!
       end
@@ -87,5 +89,17 @@ describe 'building products' do
         }.must_raise Stripe::InvalidConfigurationError
       end
     end
+
+    describe 'when using an attribute only for services' do
+      it 'raises an exception during configuration' do
+        lambda {
+          Stripe.product :broken do |product|
+            product.name        = 'Broken Good'
+            product.type        = 'good'
+            product.statement_descriptor = 'SERVICE'
+          end
+        }.must_raise Stripe::InvalidConfigurationError
+      end
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: stripe-rails
 version: !ruby/object:Gem::Version
-  version: 1.5.0
+  version: 1.5.1
 platform: ruby
 authors:
 - Charles Lowell
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-09-27 00:00:00.000000000 Z
+date: 2018-10-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails