stripe-rails 1.10.0 → 2.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 95873fe1e4c135546d576191494250facd47172be4b3a91f7325ff69c3ec5723
-  data.tar.gz: a16c59f3cdf162b62103a89332fb749a4f2c44ff45665576e4c00cc7f0637d16
+  metadata.gz: eb58cd2c4b57bfb766859f950ea819137df7d25df3064654877db23a853fc181
+  data.tar.gz: b93b09f34648ff133397a56606a37bb5067130d19aef9007c823e13b993a4cfe
 SHA512:
-  metadata.gz: eb222107648581b675d6a1348d4e7773ed93f0f4326dd6a708a66753d08fcad6a5e2a131375d397c48480570772532d0ec3ccf242739ada5d08417c18a9fb9d7
-  data.tar.gz: dab6fd8cae0e0a23dca3281b63f2734c3252dff6f9b3bd3dc431e75ab425a7ef1418087234493b950f2e0d303777a03f24911a539815890422a525cab0418998
+  metadata.gz: 39ff75adfde760950733e00324423c99506d53f9cee614a7adc0ec61a2ea14758e9d9a1dc49a4cd2ceac83ed7c7597c8c276cb0cb169ba813c7e2de9da7fe237
+  data.tar.gz: 861343d690279311225fda2091e0d318c08c2c4c33e98d4fb73f9e528750a6751e7b0f07a2b1c43341da8a4011e4ff3618c3cee799445a38dd720bfab6d6b250

data/.github/pull_request_template.md

@@ -1,4 +1,15 @@
 <!--
-  Please give us ~1 week to get back to you.
+  Thanks a bunch for helping out with the project!
+
+  Please remember to,
+
+  1. Add tests if they do not exist, fix em if they are breaking
+  2. Fix any issues that are stopping Code Climate from passing
+  2. Add a short description of the feature and tag yourself on Changelog.md
+
+  That's it!
+
+  Please give me ~1 week to get back to you.
+
   If you'd like to receive occasional updates, sign up for our newsletter at http://tinyletter.com/stripe-rails
 -->

data/.github/workflows/ruby.yml

@@ -1,6 +1,12 @@
 name: Ruby
 
-on: [push, pull_request]
+on:
+  push:
+    branches:
+      - master
+  pull_request:
+    branches:
+      - master
 
 jobs:
   build:
@@ -8,9 +14,8 @@ jobs:
 
     strategy:
       matrix:
-        ruby: [2.4.x, 2.5.x, 2.6.x]
-        gemfile: [Gemfile, gemfiles/rails4.gemfile]
-
+        ruby: [2.5.x, 2.6.x, 2.7.x]
+        gemfile: [Gemfile, gemfiles/rails51.gemfile, gemfiles/rails52.gemfile]
     steps:
     - uses: actions/checkout@v1
     - name: Set up Ruby
@@ -28,10 +33,8 @@ jobs:
         CC_TEST_REPORTER_ID: ${{ secrets.CC_TEST_REPORTER_ID }}
         RUBY_VERSION: ${{ matrix.ruby }}
       run: |
-        gem uninstall bundler
-        gem install bundler -v 1.17.3
         bundle install --jobs 4 --retry 3
         bundle exec rake
-        if [ `basename $BUNDLE_GEMFILE` == "Gemfile" ] && [ $RUBY_VERSION == "2.6.x" ] ;
+        if [ `basename $BUNDLE_GEMFILE` == "Gemfile" ] && [ $RUBY_VERSION == "2.7.x" ] && [ ! -z ${CC_TEST_REPORTER_ID} ] ;
           then ./cc-test-reporter after-build --exit-code $? ;
         fi

data/Changelog.md

@@ -1,3 +1,28 @@
+## 2.1.0 (2020-10-18)
+
+- Added option to ignore missing API key and don't show any warning. Thanks @ndbroadbent!
+- Handle passing nil to signing_secret= and add tests. Thanks @martron!
+
+## 2.0.0 (2020-09-18)
+
+- Everything from on the 2.0.0.pre release
+- includes changes from the 1.10.2 release
+
+## 1.10.2 (2020-09-18)
+
+- adds missing callback `invoice.paid`. Thanks @SyborgStudios.
+
+## 2.0.0.pre (2020-05-29)
+
+* [Breaking] Updated to work only with Rails >= 5.1
+* [Breaking] It'll only be tested on Ruby 2.7, 2.6 and 2.5.
+* [Breaking] Supports the Stripe gem => 3.15.0 (from 2 years ago)
+* [Breaking] Removes Stripe::PingsController controller.
+
+## 1.10.1 (2020-05-29)
+
+- adds missing callbacks for `payment_intent`. Thanks @klapperkopp .
+
 ## 1.10.0 (2020-03-31)
 
 - Adds support for using multiple tiers in a plan, thanks @cpsoinos

data/Gemfile

@@ -14,9 +14,9 @@ group :test do
   gem 'simplecov', '< 0.18', require: false
   gem 'stripe-ruby-mock'
   gem 'webmock'
-  # Required for system tests
+  # System tests
   gem 'capybara'
-  gem 'webdrivers'
   gem 'puma'
   gem 'selenium-webdriver'
-end
+  gem 'webdrivers'
+end

data/README.md

@@ -137,6 +137,14 @@ you prefer to environment variables, you can also set `STRIPE_PUBLISHABLE_KEY`:
 export STRIPE_PUBLISHABLE_KEY=pk_test_XXXYYYZZZ
 ```
 
+If no API key is provided, `stripe-rails` will show a warning: "No stripe.com API key was configured ...". You can silence this warning by setting the `ignore_missing_secret_key` option to `true`:
+
+```ruby
+# config/environments/production.rb
+# ...
+config.stripe.ignore_missing_secret_key = true
+```
+
 ### Manually set your API version (optional)
 
 If you need to test a new API version in development, you can override the version number manually.

data/gemfiles/{rails4.gemfile → rails51.gemfile}

@@ -1,10 +1,10 @@
 source :rubygems
 
-gem 'rails', '~> 4.2'
-gem 'sprockets', '< 4'
+gem 'rails', '~> 5.1.0'
 
 gem 'rake'
-gem 'responders', '~> 2.0' # to support Rails 4.2
+gem 'responders'
+gem 'sprockets', '< 4'
 gem 'stripe'
 
 group :test do
@@ -14,7 +14,7 @@ group :test do
   gem 'webmock'
   # Required for system tests
   gem 'capybara'
-  gem 'webdrivers'
-  gem 'puma'                
+  gem 'puma'
   gem 'selenium-webdriver'
-end
+  gem 'webdrivers'
+end

data/gemfiles/rails52.gemfile

@@ -0,0 +1,20 @@
+source :rubygems
+
+gem 'rails', '~> 5.2.0'
+
+gem 'rake'
+gem 'responders'
+gem 'sprockets', '< 4'
+gem 'stripe'
+
+group :test do
+  gem 'mocha'
+  gem 'simplecov', require: false
+  gem 'stripe-ruby-mock'
+  gem 'webmock'
+  # Required for system tests
+  gem 'capybara'
+  gem 'puma'
+  gem 'selenium-webdriver'
+  gem 'webdrivers'
+end

data/lib/stripe/callbacks.rb

@@ -47,6 +47,7 @@ module Stripe
     callback 'invoice.created'
     callback 'invoice.finalized'
     callback 'invoice.marked_uncollectible'
+    callback 'invoice.paid'
     callback 'invoice.payment_action_required'
     callback 'invoice.payment_failed'
     callback 'invoice.payment_succeeded'
@@ -63,8 +64,10 @@ module Stripe
     callback 'order.updated'
     callback 'order_return.created'
     callback 'payment_intent.amount_capturable_updated'
+    callback 'payment_intent.canceled'
     callback 'payment_intent.created'
     callback 'payment_intent.payment_failed'
+    callback 'payment_intent.processing'
     callback 'payment_intent.succeeded'
     callback 'payment_method.attached'
     callback 'payment_method.card_automatically_updated'
@@ -103,10 +106,6 @@ module Stripe
     callback 'ping'
     callback 'stripe.event'
 
-    # Deprecated
-    callback 'transfer.failed' # https://stripe.com/docs/upgrades#2017-04-06
-    callback 'transfer.paid'   # https://stripe.com/docs/upgrades#2017-04-06
-
     class << self
       def run_callbacks(evt, target)
         _run_callbacks evt.type, evt, target

data/lib/stripe/engine.rb

@@ -8,12 +8,12 @@ module Stripe
       attr_accessor :testing
     end
 
-    stripe_config = config.stripe = Struct.new(:api_base, :api_version, :secret_key, :verify_ssl_certs, :signing_secret, :signing_secrets, :publishable_key, :endpoint, :debug_js, :auto_mount, :eager_load, :open_timeout, :read_timeout) do
+    stripe_config = config.stripe = Struct.new(:api_base, :api_version, :secret_key, :ignore_missing_secret_key, :verify_ssl_certs, :signing_secret, :signing_secrets, :publishable_key, :endpoint, :debug_js, :auto_mount, :eager_load, :open_timeout, :read_timeout) do
       # for backwards compatibility treat signing_secret as an alias for signing_secrets
       def signing_secret=(value)
-        self.signing_secrets = Array(value)
+        self.signing_secrets = value.nil? ? value : Array(value)
       end
-  
+
       def signing_secret
         self.signing_secrets && self.signing_secrets.first
       end
@@ -43,7 +43,7 @@ module Stripe
       end
       secret_key = app.config.stripe.secret_key
       Stripe.api_key = secret_key unless secret_key.nil?
-      $stderr.puts <<-MSG unless Stripe.api_key
+      $stderr.puts <<-MSG unless Stripe.api_key || app.config.stripe.ignore_missing_secret_key
 No stripe.com API key was configured for environment #{::Rails.env}! this application will be
 unable to interact with stripe.com. You can set your API key with either the environment
 variable `STRIPE_SECRET_KEY` (recommended) or by setting `config.stripe.secret_key` in your

data/lib/stripe/rails/version.rb

@@ -1,5 +1,5 @@
 module Stripe
   module Rails
-    VERSION = '1.10.0'.freeze
+    VERSION = '2.1.0'.freeze
   end
 end

data/stripe-rails.gemspec

@@ -14,7 +14,7 @@ Gem::Specification.new do |gem|
   gem.name          = "stripe-rails"
   gem.require_paths = ["lib"]
   gem.version       = Stripe::Rails::VERSION
-  gem.add_dependency 'rails', '>= 3'
-  gem.add_dependency 'stripe', '>= 1.36.2'
+  gem.add_dependency 'rails', '>= 5.1'
+  gem.add_dependency 'stripe', '>= 3.15.0'
   gem.add_dependency 'responders'
 end

data/test/callbacks_spec.rb

@@ -31,9 +31,9 @@ describe Stripe::Callbacks do
     describe 'when it is invoked for the invoice.payment_succeeded event' do
       it 'is invoked for the invoice.payment_succeeded event' do
         subject
-        @event.wont_be_nil
-        @event.type.must_equal 'invoice.payment_succeeded'
-        @target.total.must_equal 6999
+        _(@event).wont_be_nil
+        _(@event.type).must_equal 'invoice.payment_succeeded'
+        _(@target.total).must_equal 6999
       end
     end
 
@@ -42,7 +42,7 @@ describe Stripe::Callbacks do
 
       it 'the invoice.payment_succeeded callback is not invoked' do
         subject
-        @event.must_be_nil
+        _(@event).must_be_nil
       end
     end
 
@@ -50,7 +50,7 @@ describe Stripe::Callbacks do
       before { run_callback_with(callback) { fail } }
 
       it 'causes the whole webhook to fail' do
-        ->{ subject }.must_raise RuntimeError
+        _(-> { subject }).must_raise RuntimeError
       end
     end
   end
@@ -61,8 +61,8 @@ describe Stripe::Callbacks do
 
     it 'does not cause the webhook to fail' do
       subject
-      last_response.status.must_be :>=, 200
-      last_response.status.must_be :<, 300
+      _(last_response.status).must_be :>=, 200
+      _(last_response.status).must_be :<, 300
     end
   end
 
@@ -75,7 +75,7 @@ describe Stripe::Callbacks do
 
       it 'it will be run' do
         subject
-        events.first.type.must_equal 'invoice.payment_failed'
+        _(events.first.type).must_equal 'invoice.payment_failed'
       end
     end
 
@@ -84,7 +84,7 @@ describe Stripe::Callbacks do
 
       it 'it will be run' do
         subject
-        events.first.type.must_equal 'foo.bar.baz'
+        _(events.first.type).must_equal 'foo.bar.baz'
       end
     end
   end
@@ -109,7 +109,7 @@ describe Stripe::Callbacks do
       describe 'when a prior attribute was not specified' do
         it 'does not fire events' do
           subject
-          events.length.must_equal 0
+          _(events.length).must_equal 0
         end
       end
 
@@ -117,7 +117,7 @@ describe Stripe::Callbacks do
         before { @stubbed_event.data.previous_attributes['closed'] = true }
         it 'fires events' do
           subject
-          events.length.must_equal 1
+          _(events.length).must_equal 1
         end
       end
     end
@@ -134,7 +134,7 @@ describe Stripe::Callbacks do
       describe 'when a prior attribute was not specified' do
         it 'does not fire events' do
           subject
-          events.length.must_equal 0
+          _(events.length).must_equal 0
         end
       end
 
@@ -142,7 +142,7 @@ describe Stripe::Callbacks do
         before { @stubbed_event.data.previous_attributes['subtotal'] = 699 }
         it 'fire events' do
           subject
-          events.length.must_equal 1
+          _(events.length).must_equal 1
         end
       end
     end
@@ -159,7 +159,7 @@ describe Stripe::Callbacks do
       describe 'when the lambda is not true' do
         it 'does not fire events' do
           subject
-          events.length.must_equal 0
+          _(events.length).must_equal 0
         end
       end
 
@@ -167,7 +167,7 @@ describe Stripe::Callbacks do
         before { @stubbed_event.data.previous_attributes['closed'] = 'false' }
         it 'fires events' do
           subject
-          events.length.must_equal 1
+          _(events.length).must_equal 1
         end
       end
     end

data/test/coupon_builder_spec.rb

@@ -13,7 +13,7 @@ describe 'building coupons' do
       end
     end
     it "allows a single redemption by default" do
-      @coupon.max_redemptions.must_equal 1
+      _(@coupon.max_redemptions).must_equal 1
     end
   end
 
@@ -33,8 +33,8 @@ describe 'building coupons' do
     after {Stripe::Coupons.send(:remove_const, :GOLD25)}
 
     it 'is accessible via hash lookup (symbol/string agnostic)' do
-      Stripe::Coupons[:gold25].must_equal Stripe::Coupons::GOLD25
-      Stripe::Coupons['gold25'].must_equal Stripe::Coupons::GOLD25
+      _(Stripe::Coupons[:gold25]).must_equal Stripe::Coupons::GOLD25
+      _(Stripe::Coupons['gold25']).must_equal Stripe::Coupons::GOLD25
     end
 
     describe 'uploading' do
@@ -116,7 +116,7 @@ describe 'building coupons' do
   end
   describe 'with missing mandatory values' do
     it 'raises an exception after configuring it' do
-      proc {Stripe.coupon(:bad) {}}.must_raise Stripe::InvalidConfigurationError
+      _(proc {Stripe.coupon(:bad) {}}).must_raise Stripe::InvalidConfigurationError
     end
   end
 end

data/test/dummy_apis_controller_spec.rb

@@ -12,6 +12,6 @@ describe ApisController do
   describe 'the ping interface' do
     subject { get '/apis/' }
 
-    it { subject.must_be :ok? }
+    it { _(subject).must_be :ok? }
   end
 end

data/test/events_controller_spec.rb

@@ -10,6 +10,10 @@ describe Stripe::EventsController do
   end
 
   describe 'the events interface' do
+    subject { post '/stripe/events', params.to_json }
+
+    before { stripe_events_stub }
+
     let(:params) {
       {
         id: 'evt_00000000000000',
@@ -17,14 +21,29 @@ describe Stripe::EventsController do
         data: {object: 'customer'},
       }
     }
-
-    before do
+    let(:stripe_events_stub) do
       stub_request(:get, "https://api.stripe.com/v1/events/evt_00000000000000").
         to_return(status: 200, body: Stripe::Event.construct_from(params).to_json, headers: {})
     end
-    subject { post '/stripe/events', params.to_json }
 
-    it { subject.must_be :ok? }
+    it { _(subject).must_be :ok? }
+
+    it 'should call the stripe_events_stub' do
+      subject
+      assert_requested(stripe_events_stub)
+    end
+
+    describe 'when signing_secret is nil' do
+      before do
+        header 'Stripe-Signature', 't=1537832721,v1=123,v0=123'
+        app.config.stripe.signing_secret = nil
+      end
+
+      it 'should call the stripe_events_stub' do
+        subject
+        assert_requested(stripe_events_stub)
+      end
+    end
   end
 
   describe 'signed webhooks' do
@@ -50,12 +69,12 @@ describe Stripe::EventsController do
 
     it 'returns bad_request when invalid' do
       Stripe::Webhook.expects(:construct_event).raises(Stripe::SignatureVerificationError.new('msg', 'sig_header'))
-      subject.must_be :bad_request?
+      _(subject).must_be :bad_request?
     end
 
     it 'returns ok when valid' do
       Stripe::Webhook.expects(:construct_event).returns(Stripe::Event.construct_from(params))
-      subject.must_be :ok?
+      _(subject).must_be :ok?
     end
   end
 
@@ -82,12 +101,12 @@ describe Stripe::EventsController do
 
     it 'returns bad_request when invalid' do
       Stripe::Webhook.expects(:construct_event).twice.raises(Stripe::SignatureVerificationError.new('msg', 'sig_header'))
-      subject.must_be :bad_request?
+      _(subject).must_be :bad_request?
     end
 
     it 'returns ok when valid' do
       Stripe::Webhook.expects(:construct_event).returns(Stripe::Event.construct_from(params))
-      subject.must_be :ok?
+      _(subject).must_be :ok?
     end
   end
 end

data/test/javascript_helper_spec.rb

@@ -8,13 +8,13 @@ describe Stripe::JavascriptHelper do
   describe '#stripe_javascript_tag' do
     describe 'when no options are passed' do
       it 'should default to v3' do
-        view.stripe_javascript_tag.must_include 'https://js.stripe.com/v3/'
+        _(view.stripe_javascript_tag).must_include 'https://js.stripe.com/v3/'
       end
     end
 
     describe 'when the v2 option is passed' do
       it 'should default to v2' do
-        view.stripe_javascript_tag(:v2).must_include 'https://js.stripe.com/v2/'
+        _(view.stripe_javascript_tag(:v2)).must_include 'https://js.stripe.com/v2/'
       end
     end
 
@@ -22,12 +22,12 @@ describe Stripe::JavascriptHelper do
       before { Rails.application.config.stripe.debug_js = true }
       after  { Rails.application.config.stripe.debug_js = false }
       it 'should render the debug js' do
-        view.stripe_javascript_tag(:v1).must_include 'https://js.stripe.com/v1/stripe-debug.js'
+        _(view.stripe_javascript_tag(:v1)).must_include 'https://js.stripe.com/v1/stripe-debug.js'
       end
 
       describe 'when v3 is selected' do
         it 'should not render debug js' do
-          view.stripe_javascript_tag(:v3).wont_include 'https://js.stripe.com/v1/stripe-debug.js'
+          _(view.stripe_javascript_tag(:v3)).wont_include 'https://js.stripe.com/v1/stripe-debug.js'
         end
       end
     end
@@ -37,7 +37,7 @@ describe Stripe::JavascriptHelper do
     subject { view.render :partial => 'stripe/js' }
 
     it 'should render correctly' do
-      subject.must_include 'https://js.stripe.com/v3/'
+      _(subject).must_include 'https://js.stripe.com/v3/'
     end
   end
 
@@ -45,35 +45,35 @@ describe Stripe::JavascriptHelper do
     subject { view.render :partial => 'stripe/js', locals: {stripe_js_version: 'v2'} }
 
     it 'should render correctly' do
-      subject.must_include 'https://js.stripe.com/v2/'
+      _(subject).must_include 'https://js.stripe.com/v2/'
     end
   end
 
   describe '#stripe_elements_tag' do
     describe 'when no options are passed' do
       it 'should display the form' do
-        view.stripe_elements_tag(
+        _(view.stripe_elements_tag(
           submit_path: '/charge',
-        ).must_include 'Credit or debit card'
+        )).must_include 'Credit or debit card'
       end
     end
 
     describe 'with options' do
       describe 'without default js' do
         it 'wont include the default script tag' do
-          view.stripe_elements_tag(
+          _(view.stripe_elements_tag(
             submit_path: '/charge',
             js_path: 'another/path'
-          ).wont_include '<script id="stripe_elements_js">'
+          )).wont_include '<script id="stripe_elements_js">'
         end
       end
 
       describe 'without default css' do
         it 'wont include the default style tag' do
-          view.stripe_elements_tag(
+          _(view.stripe_elements_tag(
             submit_path: '/charge',
             css_path: 'another/path'
-          ).wont_include '<style>'
+          )).wont_include '<style>'
         end
       end
     end

data/test/plan_builder_spec.rb

@@ -23,16 +23,16 @@ describe 'building plans' do
     after { Stripe::Plans.send(:remove_const, :PRIMO) }
 
     it 'is accessible via id' do
-      Stripe::Plans::PRIMO.wont_be_nil
+      _(Stripe::Plans::PRIMO).wont_be_nil
     end
 
     it 'is accessible via collection' do
-      Stripe::Plans.all.must_include Stripe::Plans::PRIMO
+      _(Stripe::Plans.all).must_include Stripe::Plans::PRIMO
     end
 
     it 'is accessible via hash lookup (symbol/string agnostic)' do
-      Stripe::Plans[:primo].must_equal Stripe::Plans::PRIMO
-      Stripe::Plans['primo'].must_equal Stripe::Plans::PRIMO
+      _(Stripe::Plans[:primo]).must_equal Stripe::Plans::PRIMO
+      _(Stripe::Plans['primo']).must_equal Stripe::Plans::PRIMO
     end
 
     it 'accepts a billing interval of a day' do
@@ -42,7 +42,7 @@ describe 'building plans' do
         plan.interval = 'day'
       end
 
-      Stripe::Plans::DAILY.wont_be_nil
+      _(Stripe::Plans::DAILY).wont_be_nil
     end
 
     it 'accepts a billing interval of a week' do
@@ -52,7 +52,7 @@ describe 'building plans' do
         plan.interval = 'week'
       end
 
-      Stripe::Plans::WEEKLY.wont_be_nil
+      _(Stripe::Plans::WEEKLY).wont_be_nil
     end
 
     it 'accepts a billing interval of a month' do
@@ -62,7 +62,7 @@ describe 'building plans' do
         plan.interval = 'month'
       end
 
-      Stripe::Plans::MONTHLY.wont_be_nil
+      _(Stripe::Plans::MONTHLY).wont_be_nil
     end
 
     it 'accepts a billing interval of a year' do
@@ -72,17 +72,17 @@ describe 'building plans' do
         plan.interval = 'year'
       end
 
-      Stripe::Plans::YEARLY.wont_be_nil
+      _(Stripe::Plans::YEARLY).wont_be_nil
     end
 
     it 'denies arbitrary billing intervals' do
-      lambda {
+      _(lambda {
         Stripe.plan :broken do |plan|
           plan.name = 'Acme as a service BROKEN'
           plan.amount = 999
           plan.interval = 'anything'
         end
-      }.must_raise Stripe::InvalidConfigurationError
+      }).must_raise Stripe::InvalidConfigurationError
     end
 
     it 'accepts a statement descriptor' do
@@ -93,55 +93,55 @@ describe 'building plans' do
         plan.statement_descriptor = 'ACME Monthly'
       end
 
-      Stripe::Plans::DESCRIBED.wont_be_nil
+      _(Stripe::Plans::DESCRIBED).wont_be_nil
     end
 
     it 'denies statement descriptors that are too long' do
-      lambda {
+      _(lambda {
         Stripe.plan :described do |plan|
           plan.name = 'Acme as a service'
           plan.amount = 999
           plan.interval = 'month'
           plan.statement_descriptor = 'ACME as a Service Monthly'
         end
-      }.must_raise Stripe::InvalidConfigurationError
+      }).must_raise Stripe::InvalidConfigurationError
     end
 
     it 'denies invalid values for active' do
-      lambda {
+      _(lambda {
         Stripe.plan :broken do |plan|
           plan.name = 'Acme as a service'
           plan.amount = 999
           plan.interval = 'month'
           plan.active = 'whatever'
         end
-      }.must_raise Stripe::InvalidConfigurationError
+      }).must_raise Stripe::InvalidConfigurationError
     end
 
     it 'denies invalid values for usage_type' do
-      lambda {
+      _(lambda {
         Stripe.plan :broken do |plan|
           plan.name = 'Acme as a service'
           plan.amount = 999
           plan.interval = 'month'
           plan.usage_type = 'whatever'
         end
-      }.must_raise Stripe::InvalidConfigurationError
+      }).must_raise Stripe::InvalidConfigurationError
     end
 
     it 'denies invalid values for aggregate_usage' do
-      lambda {
+      _(lambda {
         Stripe.plan :broken do |plan|
           plan.name = 'Acme as a service'
           plan.amount = 999
           plan.interval = 'month'
           plan.aggregate_usage = 'whatever'
         end
-      }.must_raise Stripe::InvalidConfigurationError
+      }).must_raise Stripe::InvalidConfigurationError
     end
 
     it 'denies aggregate_usage if usage type is liecensed' do
-      lambda {
+      _(lambda {
         Stripe.plan :broken do |plan|
           plan.name = 'Acme as a service'
           plan.amount = 999
@@ -149,30 +149,30 @@ describe 'building plans' do
           plan.usage_type = 'licensed'
           plan.aggregate_usage = 'sum'
         end
-      }.must_raise Stripe::InvalidConfigurationError
+      }).must_raise Stripe::InvalidConfigurationError
     end
 
 
     it 'denies invalid values for billing_scheme' do
-      lambda {
+      _(lambda {
         Stripe.plan :broken do |plan|
           plan.name = 'Acme as a service'
           plan.amount = 999
           plan.interval = 'month'
           plan.billing_scheme = 'whatever'
         end
-      }.must_raise Stripe::InvalidConfigurationError
+      }).must_raise Stripe::InvalidConfigurationError
     end
 
     it 'denies invalid values for tiers_mode' do
-      lambda {
+      _(lambda {
         Stripe.plan :broken do |plan|
           plan.name = 'Acme as a service'
           plan.amount = 999
           plan.interval = 'month'
           plan.tiers_mode = 'whatever'
         end
-      }.must_raise Stripe::InvalidConfigurationError
+      }).must_raise Stripe::InvalidConfigurationError
     end
 
     describe 'name and product id validation' do
@@ -182,18 +182,18 @@ describe 'building plans' do
           plan.amount = 999
           plan.interval = 'month'
         end
-        Stripe::Plans::PRODDED.wont_be_nil
+        _(Stripe::Plans::PRODDED).wont_be_nil
       end
 
       it 'should be invalid when using both name and product id' do
-        lambda {
+        _(lambda {
           Stripe.plan :broken do |plan|
             plan.name = 'Acme as a service'
             plan.product_id = 'acme'
             plan.amount = 999
             plan.interval = 'month'
           end
-        }.must_raise Stripe::InvalidConfigurationError
+        }).must_raise Stripe::InvalidConfigurationError
       end
     end
 
@@ -419,7 +419,7 @@ describe 'building plans' do
 
   describe 'with missing mandatory values' do
     it 'raises an exception after configuring it' do
-      proc {Stripe.plan(:bad) {}}.must_raise Stripe::InvalidConfigurationError
+      _(-> { Stripe.plan(:bad) {} }).must_raise Stripe::InvalidConfigurationError
     end
   end
 
@@ -446,28 +446,28 @@ describe 'building plans' do
     after { Stripe::Plans.send(:remove_const, :PRIMO_PLAN) }
 
     it 'is accessible via upcased constant_name' do
-      Stripe::Plans::PRIMO_PLAN.wont_be_nil
+      _(Stripe::Plans::PRIMO_PLAN).wont_be_nil
     end
 
     it 'is accessible via collection' do
-      Stripe::Plans.all.must_include Stripe::Plans::PRIMO_PLAN
+      _(Stripe::Plans.all).must_include Stripe::Plans::PRIMO_PLAN
     end
 
     it 'is accessible via hash lookup (symbol/string agnostic)' do
-      Stripe::Plans[:primo_plan].must_equal Stripe::Plans::PRIMO_PLAN
-      Stripe::Plans['primo_plan'].must_equal Stripe::Plans::PRIMO_PLAN
+      _(Stripe::Plans[:primo_plan]).must_equal Stripe::Plans::PRIMO_PLAN
+      _(Stripe::Plans['primo_plan']).must_equal Stripe::Plans::PRIMO_PLAN
     end
 
     describe 'constant name validation' do
       it 'should be invalid when providing a constant name that can not be used for Ruby constant' do
-        lambda {
+        _(lambda {
           Stripe.plan "Primo Plan".to_sym do |plan|
             plan.name = 'Acme as a service PRIMO'
             plan.constant_name = 'PRIMO PLAN'
             plan.amount = 999
             plan.interval = 'month'
           end
-        }.must_raise Stripe::InvalidConfigurationError
+        }).must_raise Stripe::InvalidConfigurationError
       end
     end
 

data/test/product_builder_spec.rb

@@ -15,16 +15,16 @@ describe 'building products' do
   after { Stripe::Products.send(:remove_const, :PRIMO) }
 
   it 'is accessible via id' do
-    Stripe::Products::PRIMO.wont_be_nil
+    _(Stripe::Products::PRIMO).wont_be_nil
   end
 
   it 'is accessible via collection' do
-    Stripe::Products.all.must_include Stripe::Products::PRIMO
+    _(Stripe::Products.all).must_include Stripe::Products::PRIMO
   end
 
   it 'is accessible via hash lookup (symbol/string agnostic)' do
-    Stripe::Products[:primo].must_equal  Stripe::Products::PRIMO
-    Stripe::Products['primo'].must_equal Stripe::Products::PRIMO
+    _(Stripe::Products[:primo]).must_equal  Stripe::Products::PRIMO
+    _(Stripe::Products['primo']).must_equal Stripe::Products::PRIMO
   end
 
   describe '.put!' do
@@ -63,42 +63,42 @@ describe 'building products' do
   describe 'validations' do
     describe 'with missing mandatory values' do
       it 'raises an exception after configuring it' do
-        lambda { Stripe.product(:bad){} }.must_raise Stripe::InvalidConfigurationError
+        _(lambda { Stripe.product(:bad){} }).must_raise Stripe::InvalidConfigurationError
       end
     end
 
     describe 'invalid type' do
       it 'raises an exception during configuration' do
-        lambda {
+        _(lambda {
           Stripe.product :broken do |product|
             product.name = 'Acme as a service BROKEN'
             product.type = 'anything'
           end
-        }.must_raise Stripe::InvalidConfigurationError
+        }).must_raise Stripe::InvalidConfigurationError
       end
     end
 
     describe 'when using an attribute only for goods' do
       it 'raises an exception during configuration' do
-        lambda {
+        _(lambda {
           Stripe.product :broken do |product|
             product.name        = 'Broken Service'
             product.type        = 'service'
             product.caption     = 'So good it is Primo'
           end
-        }.must_raise Stripe::InvalidConfigurationError
+        }).must_raise Stripe::InvalidConfigurationError
       end
     end
 
     describe 'when using an attribute only for services' do
       it 'raises an exception during configuration' do
-        lambda {
+        _(lambda {
           Stripe.product :broken do |product|
             product.name        = 'Broken Good'
             product.type        = 'good'
             product.statement_descriptor = 'SERVICE'
           end
-        }.must_raise Stripe::InvalidConfigurationError
+        }).must_raise Stripe::InvalidConfigurationError
       end
     end
   end

data/test/stripe_initializers_spec.rb

@@ -12,23 +12,24 @@ describe "Configuring the stripe engine" do
   def rerun_initializers!; initializers.each{|init| init.run(app) }; end
 
   after do
-    Stripe.api_version = nil
-    Stripe.api_base    = 'https://api.stripe.com'
-    Stripe.api_key     = 'XYZ'
+    Stripe.api_version       = nil
+    Stripe.api_base          = 'https://api.stripe.com'
+    Stripe.api_key           = 'XYZ'
+    ENV['STRIPE_SECRET_KEY'] = 'XYZ'
   end
 
   describe 'Stripe configurations' do
     it "will have valid default values" do
-      Stripe.api_base.must_equal          'https://api.stripe.com'
-      Stripe.api_key.must_equal           'XYZ'
-      Stripe.api_version.must_be_nil
-      Stripe.verify_ssl_certs.must_equal  true
-      Stripe.open_timeout.must_equal      30
-      Stripe.read_timeout.must_equal      80
-
-      app.config.stripe.endpoint.must_equal   '/stripe'
-      app.config.stripe.auto_mount.must_equal true
-      app.config.stripe.debug_js.must_equal   false
+      _(Stripe.api_base).must_equal          'https://api.stripe.com'
+      _(Stripe.api_key).must_equal           'XYZ'
+      _(Stripe.api_version).must_be_nil
+      _(Stripe.verify_ssl_certs).must_equal  true
+      _(Stripe.open_timeout).must_equal      30
+      _(Stripe.read_timeout).must_equal      80
+
+      _(app.config.stripe.endpoint).must_equal   '/stripe'
+      _(app.config.stripe.auto_mount).must_equal true
+      _(app.config.stripe.debug_js).must_equal   false
     end
 
     subject do
@@ -40,20 +41,30 @@ describe "Configuring the stripe engine" do
       app.config.stripe.open_timeout      = 33
       app.config.stripe.read_timeout      = 88
       rerun_initializers!
-    end 
+    end
 
     it "reads values that is set in the environment" do
       subject
 
-      Stripe.api_base.must_equal          'http://localhost:5000'
-      Stripe.api_key.must_equal           'SECRET_XYZ'
-      Stripe.verify_ssl_certs.must_equal  false
-      Stripe.api_version.must_equal       '2015-10-16'
-      Stripe.open_timeout.must_equal      33
-      Stripe.read_timeout.must_equal      88
+      _(Stripe.api_base).must_equal          'http://localhost:5000'
+      _(Stripe.api_key).must_equal           'SECRET_XYZ'
+      _(Stripe.verify_ssl_certs).must_equal  false
+      _(Stripe.api_version).must_equal       '2015-10-16'
+      _(Stripe.open_timeout).must_equal      33
+      _(Stripe.read_timeout).must_equal      88
+
+      _(app.config.stripe.signing_secret).must_equal 'SIGNING_SECRET_XYZ'
+      _(app.config.stripe.signing_secrets.length).must_equal 1
+    end
+
+    it "supports nil signing_secret" do
+      subject
+
+      app.config.stripe.signing_secret    = nil
+      rerun_initializers!
 
-      app.config.stripe.signing_secret.must_equal 'SIGNING_SECRET_XYZ'
-      app.config.stripe.signing_secrets.length.must_equal 1
+      _(app.config.stripe.signing_secret).must_equal nil
+      _(app.config.stripe.signing_secrets).must_equal nil
     end
 
     it "supports multiple signing secrets" do
@@ -62,8 +73,8 @@ describe "Configuring the stripe engine" do
       app.config.stripe.signing_secrets    = ['SIGNING_SECRET_XYZ', 'SIGNING_SECRET_XYZ_CONNECT']
       rerun_initializers!
 
-      app.config.stripe.signing_secret.must_equal 'SIGNING_SECRET_XYZ'
-      app.config.stripe.signing_secrets.length.must_equal 2
+      _(app.config.stripe.signing_secret).must_equal 'SIGNING_SECRET_XYZ'
+      _(app.config.stripe.signing_secrets.length).must_equal 2
     end
 
   end
@@ -77,8 +88,8 @@ describe "Configuring the stripe engine" do
     it 'should be eager loaded' do
       subject
 
-      Dummy.const_defined?(:ModelWithCallbacks).must_equal  true
-      Dummy.const_defined?(:ModuleWithCallbacks).must_equal true
+      _(Dummy.const_defined?(:ModelWithCallbacks)).must_equal  true
+      _(Dummy.const_defined?(:ModuleWithCallbacks)).must_equal true
     end
   end
 
@@ -87,7 +98,39 @@ describe "Configuring the stripe engine" do
     let(:warning_msg) { "[DEPRECATION] to align with stripe nomenclature, stripe.api_key has been renamed to config.stripe.secret_key\n" }
 
     it 'should output a warning' do
-      -> { subject }.must_output '', warning_msg
+      _(-> { subject }).must_output '', warning_msg
+    end
+  end
+
+  describe 'missing stripe.secret_key' do
+    subject do
+      ENV['STRIPE_SECRET_KEY'] = nil
+      Stripe.api_key = nil
+      app.config.stripe.secret_key = nil
+      rerun_initializers!
+    end
+    let(:warning_msg) { /No stripe.com API key was configured for environment test!/ }
+
+    it 'should output a warning' do
+      _(-> { subject }).must_output '', warning_msg
+    end
+  end
+
+  describe 'stripe.ignore_missing_secret_key' do
+    subject do
+      ENV['STRIPE_SECRET_KEY'] = nil
+      Stripe.api_key = nil
+      app.config.stripe.secret_key = nil
+      app.config.stripe.ignore_missing_secret_key = true
+      rerun_initializers!
+    end
+
+    after do
+      app.config.stripe.ignore_missing_secret_key = false
+    end
+
+    it 'should not output a warning' do
+      _(-> { subject }).must_output '', ''
     end
   end
 end

data/test/support/application_system_test_case.rb

@@ -1,8 +1,3 @@
-require File.expand_path("null_system_test_case", __dir__)
-
-# For Rails 4 compat
-SystemTestCaseKlass = defined?(ActionDispatch::SystemTestCase) ? ActionDispatch::SystemTestCase : NullSystemTestCase
-
-class ApplicationSystemTestCase < SystemTestCaseKlass
+class ApplicationSystemTestCase < ActionDispatch::SystemTestCase
   driven_by :selenium_chrome_headless
-end
+end

data/test/testing_spec.rb

@@ -28,8 +28,8 @@ describe "Testing" do
 
       it 'the callback must run' do
         subject
-        event.wont_be_nil
-        event.type.must_equal "invoice.payment_succeeded"
+        _(event).wont_be_nil
+        _(event.type).must_equal "invoice.payment_succeeded"
       end
     end
 
@@ -38,7 +38,7 @@ describe "Testing" do
 
       it 'the callback must not run' do
         subject
-        event.must_be_nil
+        _(event).must_be_nil
       end
     end
 
@@ -49,11 +49,11 @@ describe "Testing" do
 
       it 'the callback should run with overwritten properties' do
         subject
-        event.wont_be_nil
-        event.type.must_equal "invoice.payment_succeeded"
-        target.subtotal.must_equal 500
-        target.total.must_equal 1000
-        target.currency.must_equal "eur"
+        _(event).wont_be_nil
+        _(event.type).must_equal "invoice.payment_succeeded"
+        _(target.subtotal).must_equal 500
+        _(target.total).must_equal 1000
+        _(target.currency).must_equal "eur"
       end
     end
   end

metadata

@@ -1,16 +1,16 @@
 --- !ruby/object:Gem::Specification
 name: stripe-rails
 version: !ruby/object:Gem::Version
-  version: 1.10.0
+  version: 2.1.0
 platform: ruby
 authors:
 - Charles Lowell
 - Nola Stowe
 - SengMing Tan
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-03-31 00:00:00.000000000 Z
+date: 2020-10-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -18,28 +18,28 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3'
+        version: '5.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3'
+        version: '5.1'
 - !ruby/object:Gem::Dependency
   name: stripe
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.36.2
+        version: 3.15.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.36.2
+        version: 3.15.0
 - !ruby/object:Gem::Dependency
   name: responders
   requirement: !ruby/object:Gem::Requirement
@@ -78,16 +78,15 @@ files:
 - app/assets/stripe/stripe_elements.js
 - app/controllers/stripe/application_controller.rb
 - app/controllers/stripe/events_controller.rb
-- app/controllers/stripe/pings_controller.rb
 - app/helpers/stripe/javascript_helper.rb
 - app/models/stripe/event_dispatch.rb
-- app/models/stripe/ping.rb
 - app/views/stripe/_elements.html.erb
 - app/views/stripe/_elements_js.html.erb
 - app/views/stripe/_js.html.erb
 - config/locales/en.yml
 - config/routes.rb
-- gemfiles/rails4.gemfile
+- gemfiles/rails51.gemfile
+- gemfiles/rails52.gemfile
 - lib/generators/stripe/install_generator.rb
 - lib/generators/templates/coupons.rb
 - lib/generators/templates/plans.rb
@@ -156,7 +155,6 @@ files:
 - test/fixtures/stripe_plans_headers_2017.json
 - test/invoice.json
 - test/javascript_helper_spec.rb
-- test/pings_controller_spec.rb
 - test/plan_builder_spec.rb
 - test/product_builder_spec.rb
 - test/spec_helper.rb
@@ -164,13 +162,12 @@ files:
 - test/support/application_system_test_case.rb
 - test/support/callback_helpers.rb
 - test/support/fixture_loader.rb
-- test/support/null_system_test_case.rb
 - test/testing_spec.rb
 homepage: https://github.com/tansengming/stripe-rails
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -185,8 +182,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.1.2
+signing_key:
 specification_version: 4
 summary: A gem to integrate stripe into your rails app
 test_files:
@@ -239,7 +236,6 @@ test_files:
 - test/fixtures/stripe_plans_headers_2017.json
 - test/invoice.json
 - test/javascript_helper_spec.rb
-- test/pings_controller_spec.rb
 - test/plan_builder_spec.rb
 - test/product_builder_spec.rb
 - test/spec_helper.rb
@@ -247,5 +243,4 @@ test_files:
 - test/support/application_system_test_case.rb
 - test/support/callback_helpers.rb
 - test/support/fixture_loader.rb
-- test/support/null_system_test_case.rb
 - test/testing_spec.rb

data/app/controllers/stripe/pings_controller.rb

@@ -1,10 +0,0 @@
-module Stripe
-  class PingsController < ::Stripe::ApplicationController
-    respond_to :json
-
-    def show
-      @ping = Ping.new
-      respond_with @ping
-    end
-  end
-end

data/app/models/stripe/ping.rb

@@ -1,9 +0,0 @@
-module Stripe
-  class Ping
-    attr_reader :message
-
-    def initialize
-      @message = "Your sound card works perfectly!"
-    end
-  end
-end

data/test/pings_controller_spec.rb

@@ -1,18 +0,0 @@
-require 'spec_helper'
-
-describe Stripe::PingsController do
-  parallelize_me!
-  include Rack::Test::Methods
-
-  let(:app) { Rails.application }
-  before do
-    header 'Accept', 'application/json'
-    header 'Content-Type', 'application/json'
-  end
-
-  describe 'the ping interface' do
-    subject { get '/stripe/ping' }
-
-    it { subject.must_be :ok? }
-  end
-end

data/test/support/null_system_test_case.rb

@@ -1,11 +0,0 @@
-class NullSystemTestCase
-  def self.driven_by(*_)
-  end
-
-  def self.setup
-  end
-
-  def self.test(_)
-    warn 'WARNING: Skipping system test because this version of Rails does not support it!'
-  end
-end