stripe-rails 1.1.1 → 1.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 03a407b7ba74c65f266f9443496bc69251355f84
-  data.tar.gz: 5af8f232370df1d3547932002028600954e18666
+  metadata.gz: 2cc993299fe82d531d563a6d8f77c06792290c4b
+  data.tar.gz: 507fc54438accfc9cfa335d092eb4ee668ccdd2c
 SHA512:
-  metadata.gz: 4600d4ae6231a38189c80504f86acbb08672aaf36ac29df556eefa4f1e255627b5d23109c05c974b7ea2ef7c89587e77a175599650ff472b8d44c1bb36075f94
-  data.tar.gz: ae40a99a4a73dfebba3a76292a734fcf6928ac11dd61d7607b35838fbb4314a0e11a3247f802708d69030fa74b168dd48fe7934d4ad2344ac17410c6349e8315
+  metadata.gz: 6c1b44936c15c60b524b05e133cf16524eb2f2e234548e0ab7bb3393fb99f140c6faaac7ba843cdcf7085758288cf52bd9b727d72c20ba83d7e60cdb4deaac4e
+  data.tar.gz: '04678d354150020a4af4e56ee4f84e94444867548a442208bffbb943a2274be6215a06ac1e6e7eba6b31d8f1688250ad6081f717712a5af0a95807b5b8ecc485'

data/Changelog.md

@@ -1,3 +1,7 @@
+## 1.1.2 (2017-10-25)
+
+* Fixes js partial crash if stripe_js_version is not defined
+
 ## 1.1.1 (2017-08-31)
 
 * Make stripe-ruby-mock an optional dependency (thanks @gaffneyc)

data/app/helpers/stripe/javascript_helper.rb

@@ -1,6 +1,8 @@
 module Stripe
   module JavascriptHelper
-    def stripe_javascript_tag(stripe_js_version = 'v3')
+    DEFAULT_STRIPE_JS_VERSION = 'v3'
+
+    def stripe_javascript_tag(stripe_js_version = DEFAULT_STRIPE_JS_VERSION)
       stripe_js_version = stripe_js_version.to_s.downcase
 
       render 'stripe/js', stripe_js_version: stripe_js_version

data/app/views/stripe/_js.html.erb

@@ -1,4 +1,5 @@
-<%- case (stripe_js_version || 'v3') %>
+<%- stripe_js_version = Stripe::JavascriptHelper::DEFAULT_STRIPE_JS_VERSION if (!defined?(stripe_js_version) || stripe_js_version.nil?) %>
+<%- case stripe_js_version %>
 <%- when 'v1', 'v2' %>
   <%- if ::Rails.application.config.stripe.debug_js %>
     <script type="text/javascript" src="https://js.stripe.com/<%=stripe_js_version%>/stripe-debug.js"></script>

data/lib/generators/templates/coupons.rb

@@ -7,8 +7,7 @@
 # Stripe::Coupons::Gold25 #=> 'gold25'
 
 # Stripe.coupon :gold25 do |coupon|
-#
-#   # specify if this coupon is useable 'once', 'forever', or 'repeating
+#   # specify if this coupon is useable 'once', 'forever', or 'repeating'
 #   coupon.duration = 'repeating'
 #
 #   # absolute amount, in cents, to discount
@@ -24,7 +23,7 @@
 #   coupon.percent_off = 25
 #
 #   UTC timestamp specifying the last time at which the coupon can be redeemed
-#   coupon.reedem_by = (Time.now + 15.days).utc
+#   coupon.redeem_by = (Time.now + 15.days).utc
 #
 #   # How many times can this coupon be redeemed?
 #   coupon.max_redemptions = 10
@@ -36,4 +35,4 @@
 #
 # This will export any new coupons to stripe.com so that you can
 # begin using them in your API calls. Any coupons found that are not in this
-# file will be left as-is.
+# file will be left as-is.

data/lib/generators/templates/plans.rb

@@ -4,7 +4,6 @@
 # Stripe::Plans::PRIMO #=> 'primo'
 
 # Stripe.plan :primo do |plan|
-#
 #   # plan name as it will appear on credit card statements
 #   plan.name = 'Acme as a service PRIMO'
 #

data/lib/stripe/rails/version.rb

@@ -1,5 +1,5 @@
 module Stripe
   module Rails
-    VERSION = '1.1.1'
+    VERSION = '1.1.2'
   end
 end

data/test/javascript_helper_spec.rb

@@ -32,4 +32,20 @@ describe Stripe::JavascriptHelper do
       end
     end
   end
+
+  describe "render :partial => 'stripe/js'" do
+    subject { view.render :partial => 'stripe/js' }
+
+    it 'should render correctly' do
+      subject.must_include 'https://js.stripe.com/v3/'
+    end
+  end
+
+  describe "render :partial => 'stripe/js', local: {stripe_js_version: 'v2'}" do
+    subject { view.render :partial => 'stripe/js', locals: {stripe_js_version: 'v2'} }
+
+    it 'should render correctly' do
+      subject.must_include 'https://js.stripe.com/v2/'
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: stripe-rails
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.1.2
 platform: ruby
 authors:
 - Charles Lowell
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-08-31 00:00:00.000000000 Z
+date: 2017-10-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -170,7 +170,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 2.6.13
 signing_key: 
 specification_version: 4
 summary: A gem to integrate stripe into your rails app