stripe-rails 1.0.1 → 1.0.2

data/Changelog.md

@@ -1,3 +1,9 @@
+## 1.0.2 (2017-08-15)
+
+* Remove authenticity token check (thanks @lewispb)
+* Adding timeout options to config (thanks @rgerard)
+* Add 'day' as possible plan interval (thanks @vdragsic and @artemave)
+
 ## 1.0.1 (2017-08-08)
 
 * Fixes a bug with Stripe JS V3, i.e. `Stripe.setPublishableKey` is no longer a function. Thanks to @kartikluke for reporting this.

data/README.md

@@ -2,6 +2,7 @@
 [![Gem Version](https://badge.fury.io/rb/stripe-rails.png)](http://badge.fury.io/rb/stripe-rails)
 [![Build Status](https://travis-ci.org/Everapps/stripe-rails.png?branch=master)](https://travis-ci.org/Everapps/stripe-rails)
 [![Code Climate](https://codeclimate.com/github/Everapps/stripe-rails/badges/gpa.svg)](https://codeclimate.com/github/Everapps/stripe-rails)
+[![Test Coverage](https://codeclimate.com/github/Everapps/stripe-rails/badges/coverage.svg)](https://codeclimate.com/github/Everapps/stripe-rails/coverage)
 [![Dependency Status](https://gemnasium.com/thefrontside/stripe-rails.png)](https://gemnasium.com/thefrontside/stripe-rails)
 
 
@@ -362,7 +363,12 @@ See the [complete listing of all stripe events][5], and the [webhook tutorial][6
 
 <a href="http://frontside.io">![Frontside](http://frontside.io/images/logo.svg)</a>
 
-`Stripe::Rails` was originally developed with love and fondess by your friends at [Frontside][7]. They are available for your custom software development needs, including integration with stripe.com.
+`Stripe::Rails` was originally developed with love and fondness by your friends at [Frontside][7]. They are available for your custom software development needs, including integration with stripe.com.
+
+<a href="https://www.evercondo.com">![Evercondo](https://dl.dropboxusercontent.com/s/m3ma9356uelep53/evercondo.png)</a>
+
+`Stripe::Rails` has also been supported by the fine folks at [Evercondo][11], the next generation condo management software.
+
 
 [1]: https://stripe.com/docs/stripe.js
 [2]: https://manage.stripe.com/#account/apikeys
@@ -374,6 +380,7 @@ See the [complete listing of all stripe events][5], and the [webhook tutorial][6
 [8]: https://stripe.com/docs/api?lang=ruby#customers
 [9]: https://stripe.com/docs/api?lang=ruby#invoices
 [10]: https://stripe.com/docs/api?lang=ruby#charges
+[11]: https://www.evercondo.com
 
 
 ## Code of Conduct

data/app/controllers/stripe/application_controller.rb

@@ -1,5 +1,6 @@
 module Stripe
   class ApplicationController < ActionController::Base
+    skip_before_action(:verify_authenticity_token) if protect_from_forgery.any?
     # is anything stripe wide?
   end
 end

data/lib/generators/templates/plans.rb

@@ -14,7 +14,7 @@
 #   # currency to use for the plan (default 'usd')
 #   plan.currency = 'usd'
 #
-#   # interval must be either 'week', 'month' or 'year'
+#   # interval must be either 'day', 'week', 'month' or 'year'
 #   plan.interval = 'month'
 #
 #   # only bill once every three months (default 1)

data/lib/stripe/engine.rb

@@ -8,7 +8,7 @@ module Stripe
       attr_accessor :testing
     end
 
-    stripe_config = config.stripe = Struct.new(:api_base, :api_version, :secret_key, :verify_ssl_certs, :publishable_key, :endpoint, :debug_js, :auto_mount, :eager_load).new
+    stripe_config = config.stripe = Struct.new(:api_base, :api_version, :secret_key, :verify_ssl_certs, :publishable_key, :endpoint, :debug_js, :auto_mount, :eager_load, :open_timeout, :read_timeout).new
 
     def stripe_config.api_key=(key)
       warn "[DEPRECATION] to align with stripe nomenclature, stripe.api_key has been renamed to config.stripe.secret_key"
@@ -27,7 +27,7 @@ module Stripe
     end
 
     initializer 'stripe.configure' do |app|
-      [:api_base, :verify_ssl_certs, :api_version].each do |key|
+      [:api_base, :verify_ssl_certs, :api_version, :open_timeout, :read_timeout].each do |key|
         value = app.config.stripe.send(key)
         Stripe.send("#{key}=", value) unless value.nil?
       end

data/lib/stripe/plans.rb

@@ -8,8 +8,8 @@ module Stripe
 
       validates_presence_of :id, :amount, :currency, :name
 
-      validates_inclusion_of :interval, :in => %w(week month year),
-        :message => "'%{value}' is not one of 'week', 'month' or 'year'"
+      validates_inclusion_of :interval, :in => %w(day week month year),
+        :message => "'%{value}' is not one of 'day', 'week', 'month' or 'year'"
 
       validates :statement_descriptor, :length => { :maximum => 22 }
 

data/lib/stripe/rails/version.rb

@@ -1,5 +1,5 @@
 module Stripe
   module Rails
-    VERSION = '1.0.1'
+    VERSION = '1.0.2'
   end
 end

data/test/callbacks_spec.rb

@@ -1,4 +1,3 @@
-require 'minitest/autorun'
 require 'spec_helper'
 
 describe Stripe::Callbacks do
@@ -174,10 +173,13 @@ describe Stripe::Callbacks do
     end
   end
 
-  describe 'when there are eager loaded callbacks in the configuration (config/environment/test.rb)' do
-    it 'should be eager loaded' do
-      Dummy.const_defined?(:ModelWithCallbacks).must_equal true
-      Dummy.const_defined?(:ModuleWithCallbacks).must_equal true
+  describe 'with forgery protection enabled' do
+    before do
+      ActionController::Base.allow_forgery_protection = true
+      ActionController::Base.protect_from_forgery with: :exception
     end
+    after { ActionController::Base.allow_forgery_protection = false }
+
+    it { subject } # must_not raise error
   end
 end

data/test/coupon_builder_spec.rb

@@ -1,4 +1,3 @@
-require 'minitest/autorun'
 require 'spec_helper'
 
 describe 'building coupons' do

data/test/dummy/config/environments/test.rb

@@ -1,10 +1,4 @@
 Dummy::Application.configure do
-
-  config.stripe.api_base = 'http://localhost:5000'
-  config.stripe.verify_ssl_certs = false
-  config.stripe.eager_load = 'dummy/model_with_callbacks', 'dummy/module_with_callbacks'
-  config.stripe.api_version = '2015-10-16'
-
   # Settings specified here will take precedence over those in config/application.rb
 
   # The test environment is used exclusively to run your application's

data/test/javascript_helper_spec.rb

@@ -1,4 +1,3 @@
-require 'minitest/autorun'
 require 'spec_helper'
 
 describe Stripe::JavascriptHelper do
@@ -21,6 +20,7 @@ describe Stripe::JavascriptHelper do
 
     describe 'when the debug flag is enabled' do
       before { Rails.application.config.stripe.debug_js = true }
+      after  { Rails.application.config.stripe.debug_js = false }
       it 'should render the debug js' do
         view.stripe_javascript_tag(:v1).must_include 'https://js.stripe.com/v1/stripe-debug.js'
       end

data/test/pings_controller_spec.rb

@@ -1,4 +1,3 @@
-require 'minitest/autorun'
 require 'spec_helper'
 
 describe Stripe::PingsController do

data/test/plan_builder_spec.rb

@@ -1,4 +1,3 @@
-require 'minitest/autorun'
 require 'spec_helper'
 
 describe 'building plans' do
@@ -32,6 +31,16 @@ describe 'building plans' do
       Stripe::Plans['primo'].must_equal Stripe::Plans::PRIMO
     end
 
+    it 'accepts a billing interval of a day' do
+      Stripe.plan :daily do |plan|
+        plan.name = 'Acme as a service daily'
+        plan.amount = 100
+        plan.interval = 'day'
+      end
+
+      Stripe::Plans::DAILY.wont_be_nil
+    end
+
     it 'accepts a billing interval of a week' do
       Stripe.plan :weekly do |plan|
         plan.name = 'Acme as a service weekly'

data/test/spec_helper.rb

@@ -1,5 +1,9 @@
 require "simplecov"
-SimpleCov.start
+SimpleCov.start do
+  add_filter "/test/"
+end
+
+require 'minitest/autorun'
 
 # Configure Rails Environment
 ENV["RAILS_ENV"] = "test"

data/test/stripe_initializers_spec.rb

@@ -0,0 +1,63 @@
+require 'spec_helper'
+
+describe "Configuring the stripe engine" do
+  i_suck_and_my_tests_are_order_dependent! # the default test must be run first!
+
+  # NOTE: skipped `stripe.plans_and_coupons` to prevent warnings about constants
+  STRIPE_INITIALIZER_NAMES = %w{ stripe.configure.defaults stripe.configure stripe.callbacks.eager_load stripe.javascript_helper }
+
+  let(:app)           { Rails.application }
+  let(:initializers)  { STRIPE_INITIALIZER_NAMES.map{|name| app.initializers.find{|ini| ini.name == name } } }
+
+  def rerun_initializers!; initializers.each{|init| init.run(app) }; end
+
+  describe 'Stripe configurations' do
+    it "will have valid default values" do
+      Stripe.api_base.must_equal          'https://api.stripe.com'
+      Stripe.api_key.must_equal           'XYZ'
+      Stripe.api_version.must_be_nil
+      Stripe.verify_ssl_certs.must_equal  true
+      Stripe.open_timeout.must_equal      30
+      Stripe.read_timeout.must_equal      80
+
+      app.config.stripe.endpoint.must_equal   '/stripe'
+      app.config.stripe.auto_mount.must_equal true
+      app.config.stripe.debug_js.must_equal   false
+    end
+
+    subject do
+      app.config.stripe.api_base          = 'http://localhost:5000'
+      app.config.stripe.secret_key        = 'SECRET_XYZ'
+      app.config.stripe.verify_ssl_certs  = false
+      app.config.stripe.api_version       = '2015-10-16'
+      app.config.stripe.open_timeout      = 33
+      app.config.stripe.read_timeout      = 88
+      rerun_initializers!
+    end
+
+    it "reads values that is set in the environment" do
+      subject
+
+      Stripe.api_base.must_equal          'http://localhost:5000'
+      Stripe.api_key.must_equal           'SECRET_XYZ'
+      Stripe.verify_ssl_certs.must_equal  false
+      Stripe.api_version.must_equal       '2015-10-16'
+      Stripe.open_timeout.must_equal      33
+      Stripe.read_timeout.must_equal      88
+    end
+  end
+
+  describe 'eager loaded callbacks' do
+    subject do
+      app.config.stripe.eager_load = 'dummy/model_with_callbacks', 'dummy/module_with_callbacks'
+      rerun_initializers!
+    end
+
+    it 'should be eager loaded' do
+      subject
+
+      Dummy.const_defined?(:ModelWithCallbacks).must_equal  true
+      Dummy.const_defined?(:ModuleWithCallbacks).must_equal true
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: stripe-rails
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - Charles Lowell
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-08-08 00:00:00.000000000 Z
+date: 2017-08-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -60,7 +60,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".codeclimate.yml"
 - ".gitignore"
+- ".rubocop.yml"
 - ".travis.yml"
 - CODE_OF_CONDUCT.md
 - Changelog.md
@@ -139,7 +141,7 @@ files:
 - test/pings_controller_spec.rb
 - test/plan_builder_spec.rb
 - test/spec_helper.rb
-- test/stripe_rails_spec.rb
+- test/stripe_initializers_spec.rb
 - test/support/application_system_test_case.rb
 - test/support/callback_helpers.rb
 - test/support/null_system_test_case.rb
@@ -215,7 +217,7 @@ test_files:
 - test/pings_controller_spec.rb
 - test/plan_builder_spec.rb
 - test/spec_helper.rb
-- test/stripe_rails_spec.rb
+- test/stripe_initializers_spec.rb
 - test/support/application_system_test_case.rb
 - test/support/callback_helpers.rb
 - test/support/null_system_test_case.rb

data/test/stripe_rails_spec.rb

@@ -1,11 +0,0 @@
-require 'minitest/autorun'
-require 'spec_helper'
-
-describe "Configuring the stripe engine" do
-  it "reads the api key that is set in the environment" do
-    Stripe.api_base.must_equal 'http://localhost:5000'
-    Stripe.api_key.must_equal 'XYZ'
-    Stripe.api_version.must_equal '2015-10-16'
-    Stripe.verify_ssl_certs.must_equal false
-  end
-end