stripe-rails 0.3.1 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2093ec1a3bd46eb90811710db16bdfe309312e1c
-  data.tar.gz: 4b3f402cf1327a22688bd5bf6b6cd051be1d23f0
+  metadata.gz: cf523c4372b35910caae685adc46a1dd3b1d5ca2
+  data.tar.gz: e0f4eed537157fd9076bfb1348e6844d1b2f43a6
 SHA512:
-  metadata.gz: 98d339c9a0a0f858af220470bc722c39fc23707dd9a786a9fbc0788cfbb0b0ff71258d6c6b5b31f4b807493da274d63485d15e12083c6ec1357eb3693bb94f3e
-  data.tar.gz: ee4d0b67c1932dbdc05f287f0502d5ff7a49e7bc3497187c9c8f18642703316a6407ad51533cbcf6d49868f834790d7de3166752b8db44cb1eb37916a635ad23
+  metadata.gz: 554e570b3c5bc128e69b66f5ea0ca18865df88d9d72d1ca80c4dbf559d63584d72d125a503821c13c9ba39c5663583da34a52a1b676ec2dec8607ede586e6662
+  data.tar.gz: f19160a1340d2b3c0681f9fbd597ed7aa9656addce661526f919ca7188c69c9a0620083033f89685967706572d19612cd6da0afe322332dfaeb2f1a6ed4d68b4

data/.travis.yml

@@ -1,7 +1,6 @@
 language: ruby
 rvm:
-  - 2.0.0
-  - 1.9.3
+  - 2.3.3
 notifications:
   email:
     recipients:

data/CODE_OF_CONDUCT.md

@@ -0,0 +1,50 @@
+# Contributor Code of Conduct
+
+As contributors and maintainers of this project, and in the interest of
+fostering an open and welcoming community, we pledge to respect all people who
+contribute through reporting issues, posting feature requests, updating
+documentation, submitting pull requests or patches, and other activities.
+
+We are committed to making participation in this project a harassment-free
+experience for everyone, regardless of level of experience, gender, gender
+identity and expression, sexual orientation, disability, personal appearance,
+body size, race, ethnicity, age, religion, or nationality.
+
+Examples of unacceptable behavior by participants include:
+
+* The use of sexualized language or imagery
+* Personal attacks
+* Trolling or insulting/derogatory comments
+* Public or private harassment
+* Publishing other's private information, such as physical or electronic
+  addresses, without explicit permission
+* Other unethical or unprofessional conduct
+
+Project maintainers have the right and responsibility to remove, edit, or
+reject comments, commits, code, wiki edits, issues, and other contributions
+that are not aligned to this Code of Conduct, or to ban temporarily or
+permanently any contributor for other behaviors that they deem inappropriate,
+threatening, offensive, or harmful.
+
+By adopting this Code of Conduct, project maintainers commit themselves to
+fairly and consistently applying these principles to every aspect of managing
+this project. Project maintainers who do not follow or enforce the Code of
+Conduct may be permanently removed from the project team.
+
+This Code of Conduct applies both within project spaces and in public spaces
+when an individual is representing the project or its community.
+
+Instances of abusive, harassing, or otherwise unacceptable behavior may be
+reported by contacting a project maintainer at code-of-conduct@frontside.io. All
+complaints will be reviewed and investigated and will result in a response that
+is deemed necessary and appropriate to the circumstances. Maintainers are
+obligated to maintain confidentiality with regard to the reporter of an
+incident.
+
+
+This Code of Conduct is adapted from the [Contributor Covenant][homepage],
+version 1.3.0, available at
+[http://contributor-covenant.org/version/1/3/0/][version]
+
+[homepage]: http://contributor-covenant.org
+[version]: http://contributor-covenant.org/version/1/3/0/

data/Changelog.md

@@ -1,3 +1,10 @@
+## 0.4.0 (2017-05-24)
+* Support alternate versions of stripe js
+
+## 0.3.2 (2017-03-06)
+* add `responders` gem as dependency to support `respond_to` method
+* fix unit tests with Rails 4.2 and Rails 5.0
+
 ## 0.3.1 (2014-08-07)
 * add `eager_load` option to load callbacks into classes in non-eager-loaded enviroments
 

data/Gemfile

@@ -8,3 +8,4 @@ gem "rake"
 gem 'tzinfo'
 gem 'mocha'
 gem 'pry'
+gem 'responders', '~> 2.0' # to support Rails 4.2

data/LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) 2012-2013 The Frontside Software, Inc.
+Copyright (c) 2012-2017 The Frontside Software, Inc.
 
 MIT License
 
@@ -19,4 +19,4 @@ MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
 NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
 LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
 OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
-WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

data/README.md

@@ -26,22 +26,31 @@ stripe-rails provides a helper to make this easy:
 ```erb
 <%= stripe_javascript_tag %>
 ```
+
 or, you can render it as a partial:
 
 ```erb
 <%= render :partial => 'stripe/js' %>
 ```
+
 In both cases, stripe-rails will choose a version of stripe.js appropriate for your
 development environment and automatically configure it to use
 your publishable API key. By default it uses `stripe-debug.js` for your `development`
 environment and `stripe.js` for everything else, but you can manually configure it
-per environment
+per environment.
 
 ```ruby
 config.stripe.debug_js = true  # use stripe-debug.js
 config.stripe.debug_js = false # use stripe.js
 ```
 
+By default the helper renders the `v1` version of `stripe.js`. You can provide an
+alternate version to the helper to generate the appropriate tag:
+
+```erb
+<%= stripe_javascript_tag(:v3) %>
+```
+
 ### Setup your API keys.
 
 You will need to configure your application to authenticate with stripe.com
@@ -73,7 +82,7 @@ rake stripe:verify
 ```
 
 If you are going to be using stripe.js, then you will also need to set the value of your
-publishiable key. A nice way to do it is to set your test publishable for all environments:
+publishable key. A nice way to do it is to set your test publishable for all environments:
 
 ```ruby
 # config/application.rb
@@ -159,7 +168,7 @@ NOTE: You must destroy plans manually from your stripe dashboard.
 ## Webhooks
 
 Stripe::Rails automatically sets up your application to receive webhooks from stripe.com whenever
-an payment event is generated. To enable this, you will need to configure your [stripe webhooks][3] to
+a payment event is generated. To enable this, you will need to configure your [stripe webhooks][3] to
 point back to your application. By default, the webhook controller is mounted at '/stripe/events' so
 you would want to enter in `http://myproductionapp.com/stripe/events` as your url for live mode,
 and `http://mystagingapp.com/stripe/events` for your test mode.
@@ -232,7 +241,7 @@ class InvoiceMailer < ActionMailer::Base
 end
 ```
 
-**Note:** `Stripe::Callbacks` won't get included until the including class has been loaded. This is usually not an issue in the production environment as eager loading is enabled by default (`config.eager_load = true`). You may run into an issue in your development environment where eager loading is disabled by default. 
+**Note:** `Stripe::Callbacks` won't get included until the including class has been loaded. This is usually not an issue in the production environment as eager loading is enabled by default (`config.eager_load = true`). You may run into an issue in your development environment where eager loading is disabled by default.
 
 If you don't wish to enable eager loading in development, you can configure the classes to be eager loaded like so
 
@@ -240,7 +249,7 @@ If you don't wish to enable eager loading in development, you can configure the
 # in your application's config/environments/development.rb
 config.stripe.eager_load = 'account', 'module/some_class', 'etc'
 ```
-This will ensure that callbacks will get loaded in those configured classes if eager loading is disabled. 
+This will ensure that callbacks will get loaded in those configured classes if eager loading is disabled.
 
 The naming convention for the callback events is after__{callback_name}! where `callback_name`
 is name of the stripe event with all `.` characters substituted with underscores. So, for
@@ -351,7 +360,14 @@ needs, including integration with stripe.com.
 [4]: https://stripe.com/docs/api?lang=ruby#events
 [5]: https://stripe.com/docs/api?lang=ruby#event_types
 [6]: https://stripe.com/docs/webhooks
-[7]: http://thefrontside.net
+[7]: http://frontside.io
 [8]: https://stripe.com/docs/api?lang=ruby#customers
 [9]: https://stripe.com/docs/api?lang=ruby#invoices
 [10]: https://stripe.com/docs/api?lang=ruby#charges
+
+
+## Code of Conduct
+Please note that this project is released with a Contributor Code of
+Conduct. By participating in this project you agree to abide by its
+terms, which can be found in the `CODE_OF_CONDUCT.md` file in this
+repository.

data/app/helpers/stripe/javascript_helper.rb

@@ -1,7 +1,9 @@
 module Stripe
   module JavascriptHelper
-    def stripe_javascript_tag
-      render :partial => 'stripe/js'
+    def stripe_javascript_tag(stripe_js_version = 'v1')
+      stripe_js_version = stripe_js_version.to_s.downcase
+
+      render 'stripe/js', stripe_js_version: stripe_js_version
     end
   end
 end

data/app/views/stripe/_js.html.erb

@@ -1,8 +1,13 @@
-<% if Rails.application.config.stripe.debug_js %>
-<script type="text/javascript" src="https://js.stripe.com/v1/stripe-debug.js"></script>
-<% else %>
-<script type="text/javascript" src="https://js.stripe.com/v1/"></script>
-<% end %>
+<%- case (stripe_js_version || 'v1') %>
+<%- when 'v1', 'v2' %>
+<%- if ::Rails.application.config.stripe.debug_js %>
+<script type="text/javascript" src="https://js.stripe.com/<%=stripe_js_version%>/stripe-debug.js"></script>
+<%- else %>
+<script type="text/javascript" src="https://js.stripe.com/<%=stripe_js_version%>/"></script>
+<%- end %>
+<%- when 'v3' # the debug js for v3 isn't available %>
+<script type="text/javascript" src="https://js.stripe.com/<%=stripe_js_version%>/"></script>
+<%- end %>
 <script type="text/javascript">
 Stripe.setPublishableKey("<%= Rails.application.config.stripe.publishable_key or fail 'No stripe.com publishable key found. Please set config.stripe.publishable_key in config/application.rb to one of your publishable keys, which can be found here: https://manage.stripe.com/#account/apikeys' %>")
 </script>

data/lib/stripe/callbacks/builder.rb

@@ -42,8 +42,9 @@ module Stripe
             when Array, Set
               stringified_keys = only.map(&:to_s)
               proc do |target, evt|
-                intersection =  evt.data.previous_attributes.keys - stringified_keys
-                block.call(target, evt) if intersection != evt.data.previous_attributes.keys
+                stringified_previous_attributes_keys = evt.data.previous_attributes.keys.map(&:to_s)
+                intersection =  stringified_previous_attributes_keys - stringified_keys
+                block.call(target, evt) if intersection != stringified_previous_attributes_keys
               end
             when nil
               block

data/lib/stripe/plans.rb

@@ -3,7 +3,7 @@ module Stripe
     include ConfigurationBuilder
 
     configuration_for :plan do
-      attr_accessor :name, :amount, :interval, :interval_count, :trial_period_days, :currency
+      attr_accessor :name, :amount, :interval, :interval_count, :trial_period_days, :currency, :metadata
 
       validates_presence_of :id, :name, :amount
       validates_inclusion_of :interval, :in => %w(week month year), :message => "'%{value}' is not one of 'week', 'month' or 'year'"
@@ -22,7 +22,8 @@ module Stripe
           :amount => @amount,
           :interval => @interval,
           :interval_count => @interval_count,
-          :trial_period_days => @trial_period_days
+          :trial_period_days => @trial_period_days,
+          :metadata => @metadata
         }
       end
     end

data/lib/stripe/rails/version.rb

@@ -1,5 +1,5 @@
 module Stripe
   module Rails
-    VERSION = '0.3.1'
+    VERSION = '0.4.0'
   end
 end

data/stripe-rails.gemspec

@@ -2,11 +2,12 @@
 require File.expand_path('../lib/stripe/rails/version', __FILE__)
 
 Gem::Specification.new do |gem|
-  gem.authors       = ["rubygeek"]
-  gem.email         = ["nola@rubygeek.com"]
+  gem.authors       = ["Charles Lowell", "Nola Stowe"]
+  gem.email         = ["cowboyd@frontside.io"]
   gem.description   = "A gem to integrate stripe into your rails app"
   gem.summary       = "A gem to integrate stripe into your rails app"
-  gem.homepage      = ""
+  gem.homepage      = "https://github.com/Everapps/stripe-rails"
+  gem.license       = 'MIT'
 
   gem.files         = `git ls-files`.split($\)
   gem.executables   = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) }
@@ -15,5 +16,6 @@ Gem::Specification.new do |gem|
   gem.require_paths = ["lib"]
   gem.version       = Stripe::Rails::VERSION
   gem.add_dependency 'rails', '>= 3'
-  gem.add_dependency 'stripe'
+  gem.add_dependency 'stripe', '< 2'
+  gem.add_dependency 'responders', '~> 2.0'
 end

data/test/callbacks_spec.rb

@@ -156,7 +156,7 @@ describe Stripe::Callbacks do
     describe 'specified as a lambda' do
       before do
         @observer.class_eval do
-          after_invoice_updated :only => proc {|target, evt| evt.data.previous_attributes.has_key? "closed"} do |i,e|
+          after_invoice_updated :only => proc {|target, evt| evt.data.previous_attributes.to_hash.has_key? :closed} do |i,e|
             events << e
           end
         end

data/test/dummy/config/environments/test.rb

@@ -14,7 +14,6 @@ Dummy::Application.configure do
 
   # Configure static asset server for tests with Cache-Control for performance
   config.serve_static_assets = true
-  config.static_cache_control = "public, max-age=3600"
 
   # Show full error reports and disable caching
   config.consider_all_requests_local       = true

data/test/javascript_helper_spec.rb

@@ -0,0 +1,39 @@
+require 'minitest/autorun'
+require 'spec_helper'
+
+describe Stripe::JavascriptHelper do
+  before do
+    Rails.application.config.stripe.publishable_key = 'pub_xxxx'
+
+    @controller = ActionView::TestCase::TestController.new
+    @view       = @controller.view_context
+    @view.singleton_class.include(Stripe::JavascriptHelper)
+  end
+
+  describe '#stripe_javascript_tag' do
+    describe 'when no options are passed' do
+      it 'should default to v1' do
+        @view.stripe_javascript_tag.must_include 'https://js.stripe.com/v1/'
+      end
+    end
+
+    describe 'when the v3 option is passed' do
+      it 'should default to v3' do
+        @view.stripe_javascript_tag(:v3).must_include 'https://js.stripe.com/v3/'
+      end
+    end
+
+    describe 'when the debug flag is enabled' do
+      before { Rails.application.config.stripe.debug_js = true }
+      it 'should render the debug js' do
+        @view.stripe_javascript_tag.must_include 'https://js.stripe.com/v1/stripe-debug.js'
+      end
+
+      describe 'when v3 is selected' do
+        it 'should not render debug js' do
+          @view.stripe_javascript_tag(:v3).wont_include 'https://js.stripe.com/v1/stripe-debug.js'
+        end
+      end
+    end
+  end
+end

data/test/plan_builder_spec.rb

@@ -10,6 +10,7 @@ describe 'building plans' do
         plan.interval = 'month'
         plan.interval_count = 3
         plan.trial_period_days = 30
+        plan.metadata = {:number_of_awesome_things => 5}
       end
     end
     after do
@@ -83,7 +84,8 @@ describe 'building plans' do
             :amount => 699,
             :interval => 'month',
             :interval_count => 1,
-            :trial_period_days => 0
+            :trial_period_days => 0,
+            :metadata => nil
           )
           Stripe::Plans::GOLD.put!
         end
@@ -96,7 +98,8 @@ describe 'building plans' do
             :amount => 699,
             :interval => 'month',
             :interval_count => 1,
-            :trial_period_days => 0
+            :trial_period_days => 0,
+            :metadata => nil
           )
           Stripe::Plans::ALTERNATIVE_CURRENCY.put!
         end

metadata

@@ -1,52 +1,68 @@
 --- !ruby/object:Gem::Specification
 name: stripe-rails
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.4.0
 platform: ruby
 authors:
-- rubygeek
+- Charles Lowell
+- Nola Stowe
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-14 00:00:00.000000000 Z
+date: 2017-05-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '3'
 - !ruby/object:Gem::Dependency
   name: stripe
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2'
+- !ruby/object:Gem::Dependency
+  name: responders
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.0'
 description: A gem to integrate stripe into your rails app
 email:
-- nola@rubygeek.com
+- cowboyd@frontside.io
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .travis.yml
+- ".gitignore"
+- ".travis.yml"
+- CODE_OF_CONDUCT.md
 - Changelog.md
 - Gemfile
 - LICENSE
@@ -74,7 +90,6 @@ files:
 - lib/stripe/rails/tasks.rake
 - lib/stripe/rails/version.rb
 - stripe-rails.gemspec
-- test/.DS_Store
 - test/all.rb
 - test/callbacks_spec.rb
 - test/coupon_builder_spec.rb
@@ -114,11 +129,13 @@ files:
 - test/dummy/public/favicon.ico
 - test/dummy/script/rails
 - test/invoice_payment_succeeded.json
+- test/javascript_helper_spec.rb
 - test/plan_builder_spec.rb
 - test/spec_helper.rb
 - test/stripe_rails_spec.rb
-homepage: ''
-licenses: []
+homepage: https://github.com/Everapps/stripe-rails
+licenses:
+- MIT
 metadata: {}
 post_install_message: 
 rdoc_options: []
@@ -126,22 +143,21 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
 summary: A gem to integrate stripe into your rails app
 test_files:
-- test/.DS_Store
 - test/all.rb
 - test/callbacks_spec.rb
 - test/coupon_builder_spec.rb
@@ -181,6 +197,7 @@ test_files:
 - test/dummy/public/favicon.ico
 - test/dummy/script/rails
 - test/invoice_payment_succeeded.json
+- test/javascript_helper_spec.rb
 - test/plan_builder_spec.rb
 - test/spec_helper.rb
 - test/stripe_rails_spec.rb