stringyfi 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 796dc3f1361b70dbb6c86d6f7ef77639796d12e5
-  data.tar.gz: f7ce1efbc6ead2e92c99b37f629540cc69d6f5db
+SHA256:
+  metadata.gz: 2504e7e1f7968f25505c18c985b8fa910e65f2508505ae43c9df9f63e96ff8f2
+  data.tar.gz: f8ae2eb44c809c6510935bc0c51b7707da561b9012abad46b945e75282f815e8
 SHA512:
-  metadata.gz: 92a250942f88d6ee07ff351ce5a4fd7a2998a675f8773b1782a913cc94fc5bde540a98fcdbf2bc40b0d5d6baba3a0f1c142c4708eb776d6c3dc666f067a68c7e
-  data.tar.gz: 07ea32854390d1bcb07065ef3f5a44609399d56f1dbc04df387bd44044f66c5451ad9573c6965440b954653dfb353039f2889671a148cb744fc6a22d0f3485e4
+  metadata.gz: 0f1dca73381e9bfbce3004d2da120020855bab46b740745d81c07a4ae6addd1695be10ab84ca383ffff2758e57b8b413726f62b6c4eb738c71a9a334c8226827
+  data.tar.gz: 78d71c3f0424a5be29291753e546e7e06271ffb05af6d30fd832fc592e69e3ab81c422c6d07afb97f1a9f6c9dd7ac9a4f02c054eeedaed25eef8da0df320f1f2

data/.github/workflows/ruby-tests.yml

@@ -0,0 +1,32 @@
+name: Ruby Tests
+
+on:
+  push:
+    branches:
+      - main
+  pull_request:
+    branches:
+      - main
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+
+    steps:
+    - name: Checkout code
+      uses: actions/checkout@v3
+
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: 3.3
+        bundler-cache: true
+
+    - name: Install dependencies
+      run: bundle install
+
+    - name: Run tests
+      run: bundle exec rspec
+
+    - name: Run rubocop
+      run: bundle exec rubocop

data/.rubocop.yml

@@ -0,0 +1,53 @@
+AllCops:
+  NewCops: disable
+  SuggestExtensions: false
+  TargetRubyVersion: 3.0
+
+Layout/FirstArrayElementIndentation:
+  EnforcedStyle: consistent
+
+Layout/FirstHashElementIndentation:
+  EnforcedStyle: consistent
+
+Layout/LineLength:
+  Max: 125
+
+Metrics/AbcSize:
+  Max: 46
+
+Metrics/BlockLength:
+  Max: 150
+
+Metrics/ClassLength:
+  Max: 150
+
+Metrics/CyclomaticComplexity:
+  Max: 9
+
+Metrics/MethodLength:
+  Max: 30
+
+Metrics/ParameterLists:
+  MaxOptionalParameters: 4
+
+Metrics/PerceivedComplexity:
+  Max: 9
+
+Style/BlockComments:
+  Exclude:
+    - 'spec/spec_helper.rb'
+
+Style/ClassAndModuleChildren:
+  EnforcedStyle: compact
+
+Style/Documentation:
+  Exclude:
+    - 'spec/**/*'
+
+Style/SoleNestedConditional:
+  Exclude:
+    - 'lib/stringyfi/converter.rb'
+
+Style/StderrPuts:
+  Exclude:
+    - 'lib/stringyfi/converter.rb'

data/.ruby-version

@@ -1 +1 @@
-2.4.1
+3.3.3

data/Gemfile

@@ -1,4 +1,14 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
-# Specify your gem's dependencies in amuse.gemspec
+# Specify gem dependencies in stringyfi.gemspec
 gemspec
+
+# development dependencies
+gem 'bundler', '>= 2.2.33'
+gem 'guard-rspec'
+gem 'guard-rubocop'
+gem 'rake'
+gem 'rspec'
+gem 'rubocop', require: false

data/Guardfile

@@ -1,18 +1,13 @@
-# A sample Guardfile
-# More info at https://github.com/guard/guard#readme
+# frozen_string_literal: true
 
-# Note: The cmd option is now required due to the increasing number of ways
-#       rspec may be run, below are examples of the most common uses.
-#  * bundler: 'bundle exec rspec'
-#  * bundler binstubs: 'bin/rspec'
-#  * spring: 'bin/rsspec' (This will use spring if running and you have
-#                          installed the spring binstubs per the docs)
-#  * zeus: 'zeus rspec' (requires the server to be started separetly)
-#  * 'just' rspec: 'rspec'
+# More info at https://github.com/guard/guard#readme
 guard :rspec, cmd: 'bundle exec rspec' do
   watch(%r{^spec/.+_spec\.rb$})
-  watch(%r{^lib/stringyfi/(.+)\.rb$})     { |m| "spec/unit/#{m[1]}_spec.rb" }
-  watch('spec/spec_helper.rb')  { "spec" }
-
+  watch(%r{^lib/stringyfi/(.+)\.rb$}) { |m| "spec/unit/#{m[1]}_spec.rb" }
+  watch('spec/spec_helper.rb') { 'spec' }
 end
 
+guard :rubocop, cli: ['--display-cop-names'] do
+  watch(/.+\.rb$/)
+  watch(%r{(?:.+/)?\.rubocop(?:_todo)?\.yml$}) { |m| File.dirname(m[0]) }
+end

data/README.md

@@ -2,7 +2,7 @@
 
 Convert MusicXML to PIC assembler for running on the Boldport Club Stringy.
 
-[![Build Status](https://travis-ci.org/tardate/stringyfi.svg?branch=master)](https://travis-ci.org/tardate/stringyfi)
+[![Ruby Tests](https://github.com/tardate/stringyfi/actions/workflows/ruby-tests.yml/badge.svg)](https://github.com/tardate/stringyfi/actions/workflows/ruby-tests.yml)
 
 ## About the Stringy
 
@@ -36,11 +36,11 @@ Add this line to your application's Gemfile:
 
 And then execute:
 
-    $ bundle
+    bundle
 
 Or install it yourself as:
 
-    $ gem install stringyfi
+    gem install stringyfi
 
 ## Usage
 
@@ -49,7 +49,7 @@ and emits the assembler source on STDOUT (so it can be redirected as appropriate
 
 For example:
 
-    $ stringyfi ./spec/fixtures/music_xml/chromatic.xml > ../CustomDemo.X/demo.tun
+    stringyfi ./spec/fixtures/music_xml/chromatic.xml > ../CustomDemo.X/demo.tun
 
 The
 [spec/fixtures](./spec/fixtures/music_xml)

data/Rakefile

@@ -1,12 +1,13 @@
-require "bundler/gem_tasks"
-require "rspec/core/rake_task"
+# frozen_string_literal: true
+
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
 
 RSpec::Core::RakeTask.new(:spec)
 
-task :default => :spec
+task default: :spec
 
-desc "Open an irb session preloaded with this library"
+desc 'Open an irb session preloaded with this library'
 task :console do
-  sh "irb -rubygems -I lib -r stringyfi.rb"
+  sh 'irb -rubygems -I lib -r stringyfi.rb'
 end
-

data/bin/stringyfi

@@ -1,4 +1,6 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
+
 $LOAD_PATH.unshift File.join(File.dirname(__FILE__), '..', 'lib')
 
 require 'stringyfi'

data/lib/stringyfi/converter.rb

@@ -1,11 +1,14 @@
+# frozen_string_literal: true
+
 require 'nokogiri'
 
+# Main controller for the conversion process
 class StringyFi::Converter
-
   INITIAL_OCTAVE = 1        # setup by the stringy firmware
   OCTAVE_OFFSET = 3         # how many octaves to offset the source
 
-  attr_accessor :filename, :xml_doc
+  attr_accessor :filename
+  attr_writer :xml_doc
 
   def initialize(filename)
     self.filename = filename
@@ -21,40 +24,40 @@ class StringyFi::Converter
     puts score_body(shortest_fractional_duration)
     puts score_coda
 
-    $stderr.puts ".. done."
+    $stderr.puts '.. done.'
   end
 
   def score_preamble
-    <<-EOS
-;**************************************************************************
-;** Title: #{title}
-;** Tempo: #{tempo}
-;** Encoded: #{encoding_date} with #{encoding_software}
-;** Stringyfied: #{Time.now}
-;**************************************************************************
+    <<~PREAMBLE
+      ;**************************************************************************
+      ;** Title: #{title}
+      ;** Tempo: #{tempo}
+      ;** Encoded: #{encoding_date} with #{encoding_software}
+      ;** Stringyfied: #{Time.now}
+      ;**************************************************************************
 
-\ttstart DemoTune
-EOS
+      \ttstart DemoTune
+    PREAMBLE
   end
 
   def score_coda
-    <<-EOS
-\ttrest 8
-\ttstop
-EOS
+    <<~CODA
+      \ttrest 8
+      \ttstop
+    CODA
   end
 
   def score_body(shortest_fractional_duration)
     lines = []
     current_octave = INITIAL_OCTAVE + OCTAVE_OFFSET
     measures.each_with_index do |measure, measure_index|
-      lines << "\t; measure #{measure_index+1}"
+      lines << "\t; measure #{measure_index + 1}"
       measure.each do |note|
         unless note.rest?
           if note.octave != current_octave
             delta = note.octave - current_octave
-            sign = delta > 0 ? "+" : "-"
-            (delta.abs).times do
+            sign = delta.positive? ? '+' : '-'
+            delta.abs.times do
               lines << "\ttoctave #{sign}1"
             end
             current_octave = note.octave
@@ -62,15 +65,15 @@ EOS
         end
         short_repeats, medium_repeats, long_repeats, very_long_repeats = note.stringy_durations(shortest_fractional_duration)
         if note.rest?
-          (short_repeats).times     { lines << "\ttrest 1" }
-          (medium_repeats).times    { lines << "\ttrest 2" }
-          (long_repeats).times      { lines << "\ttrest 3" }
-          (very_long_repeats).times { lines << "\ttrest 4" }
+          short_repeats.times     { lines << "\ttrest 1" }
+          medium_repeats.times    { lines << "\ttrest 2" }
+          long_repeats.times      { lines << "\ttrest 3" }
+          very_long_repeats.times { lines << "\ttrest 4" }
         else
-          (short_repeats).times     { lines << "\ttnote #{note.to_stringy(current_octave)},1,0  ; #{note.to_note_id}" }
-          (medium_repeats).times    { lines << "\ttnote #{note.to_stringy(current_octave)},2,0  ; #{note.to_note_id}" }
-          (long_repeats).times      { lines << "\ttnote #{note.to_stringy(current_octave)},3,0  ; #{note.to_note_id}" }
-          (very_long_repeats).times { lines << "\ttnote #{note.to_stringy(current_octave)},4,0  ; #{note.to_note_id}" }
+          short_repeats.times     { lines << "\ttnote #{note.to_stringy(current_octave)},1,0  ; #{note.to_note_id}" }
+          medium_repeats.times    { lines << "\ttnote #{note.to_stringy(current_octave)},2,0  ; #{note.to_note_id}" }
+          long_repeats.times      { lines << "\ttnote #{note.to_stringy(current_octave)},3,0  ; #{note.to_note_id}" }
+          very_long_repeats.times { lines << "\ttnote #{note.to_stringy(current_octave)},4,0  ; #{note.to_note_id}" }
         end
       end
     end
@@ -104,8 +107,9 @@ EOS
       }
     }
   end
+
   def part_list
-    xml_doc.xpath('//part-list/score-part').each_with_object([]) do |part,memo|
+    xml_doc.xpath('//part-list/score-part').each_with_object([]) do |part, memo|
       h = {}
       h[:id] = part.attr('id')
       memo << h
@@ -126,16 +130,15 @@ EOS
       part.xpath('measure').each_with_index do |part_measure, m|
         measures[m] ||= []
         part_measure.xpath('note').each_with_object(measures[m]) do |note, memo|
-          next unless note.xpath("staff").text == "1"
-          next unless note.xpath("voice").text == "1"
-          pitch = note.xpath("pitch")
-          duration = note.xpath("duration").text.to_i
-          actual_notes = note.xpath("actual-notes").text.to_i
-          normal_notes = note.xpath("normal-notes").text.to_i
-          if actual_notes > 0 and normal_notes > 0
-            duration = duration * 1.0 * normal_notes / actual_notes
-          end
-          duration_type = note.xpath("type").text
+          next unless note.xpath('staff').text == '1'
+          next unless note.xpath('voice').text == '1'
+
+          pitch = note.xpath('pitch')
+          duration = note.xpath('duration').text.to_i
+          actual_notes = note.xpath('actual-notes').text.to_i
+          normal_notes = note.xpath('normal-notes').text.to_i
+          duration = duration * 1.0 * normal_notes / actual_notes if actual_notes.positive? && normal_notes.positive?
+          duration_type = note.xpath('type').text
           memo << StringyFi::Note.new(
             pitch.xpath('step').text,
             pitch.xpath('octave').text,
@@ -160,5 +163,4 @@ EOS
   def io_stream
     File.open(filename).read
   end
-
-end
+end

data/lib/stringyfi/measures.rb

@@ -1,5 +1,7 @@
-class StringyFi::Measures < Array
+# frozen_string_literal: true
 
+# extend Array with methods for working with measures
+class StringyFi::Measures < Array
   def shortest_fractional_duration
     result = 1
     each do |measure|
@@ -11,10 +13,11 @@ class StringyFi::Measures < Array
   end
 
   def octave_range
-    lo =  hi = nil
+    lo = hi = nil
     each do |measure|
       measure.each do |note|
         next if note.rest?
+
         lo ||= note.octave
         hi ||= note.octave
         lo = note.octave if note.octave < lo
@@ -23,5 +26,4 @@ class StringyFi::Measures < Array
     end
     [lo, hi]
   end
-
 end

data/lib/stringyfi/note.rb

@@ -1,41 +1,44 @@
-class StringyFi::Note
+# frozen_string_literal: true
 
-  attr_accessor :name, :octave, :alter
-  attr_accessor :tempo
-  attr_accessor :fractional_duration
+# Represents a musical note
+class StringyFi::Note
+  attr_accessor :name, :octave, :alter, :tempo, :fractional_duration
 
-  def initialize(name, octave=4, alter=nil, duration=1, duration_type="quarter")
-    self.name = "#{name}".upcase
-    self.octave = "#{octave}".to_i
-    self.alter = alter.to_i rescue 0
+  def initialize(name, octave = 4, alter = nil, duration = 1, duration_type = 'quarter')
+    self.name = name.to_s.upcase
+    self.octave = octave.to_s.to_i
+    self.alter = begin
+      alter.to_i
+    rescue StandardError
+      0
+    end
     self.fractional_duration = calculate_fractional_duration(duration, duration_type)
   end
 
   def rest?
-    name == ""
+    name == ''
   end
 
   def calculate_fractional_duration(duration, duration_type)
     divisor = {
-      "half" => 2.0,
-      "quarter" => 4.0,
-      "eighth" => 8.0,
-      "16th" => 16.0,
-      "32nd" =>  32.0
+      'half' => 2.0,
+      'quarter' => 4.0,
+      'eighth' => 8.0,
+      '16th' => 16.0,
+      '32nd' => 32.0
     }[duration_type] || 1.0
-    duration/divisor
+    duration / divisor
   end
 
-  # retrun [short, medium, long, very_long] repeats for the note
+  # return [short, medium, long, very_long] repeats for the note
   # TODO: scale medium, long, very_long durations correctly
   def stringy_durations(shortest_fractional_duration)
     time_units = (fractional_duration / shortest_fractional_duration).to_i
-    case
-    when time_units >= 8
+    if time_units >= 8
       [0, 0, 0, 1]
-    when time_units >= 4
+    elsif time_units >= 4
       [0, 0, 1, 0]
-    when time_units >= 2
+    elsif time_units >= 2
       [0, 1, 0, 0]
     else
       [1, 0, 0, 0]
@@ -53,7 +56,7 @@ class StringyFi::Note
         'E' => 'D',
         'A' => 'G',
         'D' => 'C',
-        'G' => 'F',
+        'G' => 'F'
       }[name]
       "#{sharpy_name}#{relative_octave}S"
     else
@@ -91,7 +94,6 @@ class StringyFi::Note
   end
 
   def <=>(other)
-    self.to_note_id <=> other.to_note_id
+    to_note_id <=> other.to_note_id
   end
-
 end

data/lib/stringyfi/shell.rb

@@ -1,8 +1,10 @@
-class StringyFi::Shell
+# frozen_string_literal: true
 
+# CLI support
+class StringyFi::Shell
   attr_accessor :converter
 
-  def initialize(args=[])
+  def initialize(args = [])
     filename = args.first || File.join(File.dirname(__FILE__), '..', '..', 'spec', 'fixtures', 'music_xml', 'chromatic.xml')
     self.converter = StringyFi::Converter.new(filename)
   end
@@ -10,4 +12,4 @@ class StringyFi::Shell
   def convert!
     converter.convert!
   end
-end
+end

data/lib/stringyfi/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module StringyFi
-  VERSION = "0.0.1"
+  VERSION = '0.0.2'
 end

data/lib/stringyfi.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'stringyfi/version'
 require 'stringyfi/shell'
 require 'stringyfi/note'

data/spec/spec_helper.rb

@@ -1,9 +1,10 @@
+# frozen_string_literal: true
+
 require 'stringyfi'
 
 # Requires supporting files with custom matchers and macros, etc,
 # in ./support/ and its subdirectories.
-Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each {|f| require f}
-
+Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each { |f| require f }
 
 # This file was generated by the `rspec --init` command. Conventionally, all
 # specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.

data/spec/support/fixtures_helper.rb

@@ -1,6 +1,7 @@
-module FixturesHelper
+# frozen_string_literal: true
 
-  def xml_sample_path(name='chromatic.xml')
+module FixturesHelper
+  def xml_sample_path(name = 'chromatic.xml')
     File.join(xml_samples_path, name)
   end
 
@@ -11,4 +12,4 @@ end
 
 RSpec.configure do |conf|
   conf.include FixturesHelper
-end
+end

data/spec/unit/converter_spec.rb

@@ -1,89 +1,91 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe StringyFi::Converter do
   subject(:converter) { described_class.new(filename) }
 
-  context "with chromatic.xml sample" do
+  context 'with chromatic.xml sample' do
     let(:filename) { xml_sample_path }
 
-    describe "#xml_doc" do
+    describe '#xml_doc' do
       subject { converter.xml_doc }
-      it "returns the XML doc" do
+      it 'returns the XML doc' do
         expect(subject).to be_a(Nokogiri::XML::Document)
       end
     end
 
-    describe "#identification" do
+    describe '#identification' do
       subject(:identification) { converter.identification }
-      it "returns expected metadata" do
+      it 'returns expected metadata' do
         expect(subject).to eql({
-          title: "chromatic scale",
+          title: 'chromatic scale',
           encoding: {
-            date: "2017-10-15",
-            software: "Guitar Pro 7.0.6"
+            date: '2017-10-15',
+            software: 'Guitar Pro 7.0.6'
           }
         })
       end
     end
 
-    describe "#part_list" do
+    describe '#part_list' do
       subject(:part_list) { converter.part_list }
-      it "returns an array of parts" do
+      it 'returns an array of parts' do
         expect(part_list).to eql([
-          {id: "P1"}
+          { id: 'P1' }
         ])
       end
     end
 
-    describe "#parts" do
+    describe '#parts' do
       subject(:parts) { converter.parts }
-      it "returns parts corresponding to parts list" do
+      it 'returns parts corresponding to parts list' do
         expect(parts.count).to eql(converter.part_list.count)
       end
     end
 
-    describe "#measures" do
+    describe '#measures' do
       subject(:measures) { converter.measures }
-      it "has the correct number of measures" do
+      it 'has the correct number of measures' do
         expect(measures).to be_a(StringyFi::Measures)
         expect(measures.count).to eql(7)
       end
     end
 
-    describe "#measure" do
+    describe '#measure' do
       subject(:measure) { converter.measure(measure_id) }
-      context "with first measure" do
+      context 'with first measure' do
         let(:measure_id) { 0 }
-        it "has the correct note info" do
+        it 'has the correct note info' do
           expect(measure).to be_an(Array)
           expect(measure.size).to eql(1)
           expect(measure[0]).to be_a(StringyFi::Note)
-          expect(measure[0].to_str).to eql("3:E:0")
+          expect(measure[0].to_str).to eql('3:E:0')
         end
       end
     end
 
-    describe "#score_preamble" do
+    describe '#score_preamble' do
       subject { converter.score_preamble }
-      it "includes the expected identification" do
+      it 'includes the expected identification' do
         expect(subject).to include(';** Title: chromatic scale')
       end
-      it "includes the tstart" do
+      it 'includes the tstart' do
         expect(subject).to include("\ttstart DemoTune")
       end
     end
 
-    describe "#score_coda" do
+    describe '#score_coda' do
       subject { converter.score_coda }
-      it "includes a rest and tstop" do
+      it 'includes a rest and tstop' do
         expect(subject).to include("\ttrest 8")
         expect(subject).to include("\ttstop")
       end
     end
 
-    describe "#score_body" do
-      subject { converter.score_body(1/32.0) }
-      it "returns the expected conversion" do
+    describe '#score_body' do
+      subject { converter.score_body(1 / 32.0) }
+      it 'returns the expected conversion' do
         expect(subject).to eql([
           "\t; measure 1",
           "\ttoctave -1",
@@ -150,9 +152,9 @@ describe StringyFi::Converter do
       end
     end
 
-    describe "#convert!" do
+    describe '#convert!' do
       subject { converter.convert! }
-      it "calls all the necessary bits" do
+      it 'calls all the necessary bits' do
         expect(converter).to receive(:score_preamble)
         expect(converter).to receive(:score_body)
         expect(converter).to receive(:score_coda)
@@ -161,6 +163,5 @@ describe StringyFi::Converter do
         subject
       end
     end
-
   end
 end

data/spec/unit/measures_spec.rb

@@ -1,34 +1,34 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe StringyFi::Measures do
-
   let(:note_class) { StringyFi::Note }
   let(:measures) { described_class.new }
 
   before do
     measures << [
-      note_class.new('G', 4, 1, 1, "half"),
-      note_class.new('G', 2, 0, 1, "quarter")
+      note_class.new('G', 4, 1, 1, 'half'),
+      note_class.new('G', 2, 0, 1, 'quarter')
     ]
     measures << [
-      note_class.new('G', 3, 0, 1, "whole"),
-      note_class.new('A', 4, 0, 1, "32nd"),
-      note_class.new('G', 4, 1, 1, "eighth")
+      note_class.new('G', 3, 0, 1, 'whole'),
+      note_class.new('A', 4, 0, 1, '32nd'),
+      note_class.new('G', 4, 1, 1, 'eighth')
     ]
   end
 
-  describe "#shortest_fractional_duration" do
+  describe '#shortest_fractional_duration' do
     subject { measures.shortest_fractional_duration }
-    it "returns the shortest of any note" do
-      expect(subject).to eql(1/32.0)
+    it 'returns the shortest of any note' do
+      expect(subject).to eql(1 / 32.0)
     end
   end
 
-  describe "#octave_range" do
+  describe '#octave_range' do
     subject { measures.octave_range }
-    it "returns the lowest and highest as an array" do
+    it 'returns the lowest and highest as an array' do
       expect(subject).to eql([2, 4])
     end
   end
-
-end
+end

data/spec/unit/note_spec.rb

@@ -1,51 +1,52 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe StringyFi::Note do
-
   let(:name) { 'G' }
   let(:octave) { '4' }
   let(:alter) { nil }
   let(:duration) { 1 }
-  let(:duration_type) { "quarter" }
+  let(:duration_type) { 'quarter' }
   subject(:note) { described_class.new(name, octave, alter, duration, duration_type) }
 
-
-  describe "#stringy_durations" do
-    subject { note.stringy_durations(shortest_fractional_duration)}
-    context "when quarter is shortest" do
-      let(:shortest_fractional_duration) { 1/4.0 }
+  describe '#stringy_durations' do
+    subject { note.stringy_durations(shortest_fractional_duration) }
+    context 'when quarter is shortest' do
+      let(:shortest_fractional_duration) { 1 / 4.0 }
       [
-        {duration: 1, duration_type: "quarter", expect: [1, 0, 0, 0]},
-        {duration: 2, duration_type: "quarter", expect: [0, 1, 0, 0]},
-        {duration: 3, duration_type: "quarter", expect: [0, 1, 0, 0]},
-        {duration: 4, duration_type: "quarter", expect: [0, 0, 1, 0]},
-        {duration: 5, duration_type: "quarter", expect: [0, 0, 1, 0]},
-        {duration: 6, duration_type: "quarter", expect: [0, 0, 1, 0]},
-        {duration: 7, duration_type: "quarter", expect: [0, 0, 1, 0]},
-        {duration: 1, duration_type: "half",    expect: [0, 1, 0, 0]},
-        {duration: 4, duration_type: "half",    expect: [0, 0, 0, 1]},
-        {duration: 1, duration_type: "whole",   expect: [0, 0, 1, 0]},
-        {duration: 2, duration_type: "whole",   expect: [0, 0, 0, 1]},
+        { duration: 1, duration_type: 'quarter', expect: [1, 0, 0, 0] },
+        { duration: 2, duration_type: 'quarter', expect: [0, 1, 0, 0] },
+        { duration: 3, duration_type: 'quarter', expect: [0, 1, 0, 0] },
+        { duration: 4, duration_type: 'quarter', expect: [0, 0, 1, 0] },
+        { duration: 5, duration_type: 'quarter', expect: [0, 0, 1, 0] },
+        { duration: 6, duration_type: 'quarter', expect: [0, 0, 1, 0] },
+        { duration: 7, duration_type: 'quarter', expect: [0, 0, 1, 0] },
+        { duration: 1, duration_type: 'half',    expect: [0, 1, 0, 0] },
+        { duration: 4, duration_type: 'half',    expect: [0, 0, 0, 1] },
+        { duration: 1, duration_type: 'whole',   expect: [0, 0, 1, 0] },
+        { duration: 2, duration_type: 'whole',   expect: [0, 0, 0, 1] }
       ].each do |options|
         context "and duration=#{options[:duration]}-#{options[:duration_type]}" do
           let(:duration) { options[:duration] }
           let(:duration_type) { options[:duration_type] }
-          it "returns expected repeats/remainder" do
+          it 'returns expected repeats/remainder' do
             expect(subject).to eql(options[:expect])
           end
         end
       end
     end
-    context "when 32nd is shortest" do
-      let(:shortest_fractional_duration) { 1/32.0 }
+
+    context 'when 32nd is shortest' do
+      let(:shortest_fractional_duration) { 1 / 32.0 }
       [
-        {duration: 1, duration_type: "32nd",    expect: [1, 0, 0, 0]},
-        {duration: 1, duration_type: "quarter", expect: [0, 0, 0, 1]},
+        { duration: 1, duration_type: '32nd',    expect: [1, 0, 0, 0] },
+        { duration: 1, duration_type: 'quarter', expect: [0, 0, 0, 1] }
       ].each do |options|
         context "and duration=#{options[:duration]}-#{options[:duration_type]}" do
           let(:duration) { options[:duration] }
           let(:duration_type) { options[:duration_type] }
-          it "returns expected repeats/remainder" do
+          it 'returns expected repeats/remainder' do
             expect(subject).to eql(options[:expect])
           end
         end
@@ -53,54 +54,53 @@ describe StringyFi::Note do
     end
   end
 
-  describe "#to_s" do
+  describe '#to_s' do
     subject { note.to_s }
-    context "when not altered" do
-      it { should eql('G')}
+    context 'when not altered' do
+      it { should eql('G') }
     end
-    context "when altered up" do
+    context 'when altered up' do
       let(:alter) { 1 }
-      it { should eql('G#')}
+      it { should eql('G#') }
     end
-    context "when altered down" do
+    context 'when altered down' do
       let(:alter) { -1 }
-      it { should eql('Gb')}
+      it { should eql('Gb') }
     end
   end
 
-  describe "#to_str" do
+  describe '#to_str' do
     subject { note.to_str }
-    context "when not altered" do
-      it { should eql('4:G:0')}
+    context 'when not altered' do
+      it { should eql('4:G:0') }
     end
-    context "when altered up" do
+    context 'when altered up' do
       let(:alter) { 1 }
-      it { should eql('4:G:1')}
+      it { should eql('4:G:1') }
     end
-    context "when altered down" do
+    context 'when altered down' do
       let(:alter) { -1 }
-      it { should eql('4:G:-1')}
+      it { should eql('4:G:-1') }
     end
   end
 
-  describe "#<=>" do
+  describe '#<=>' do
     let(:other_name) { name }
     let(:other_octave) { octave }
     let(:other_alter) { alter }
     let(:other_note) { described_class.new(other_name, other_octave, other_alter) }
 
     subject { note <=> other_note }
-    context "when same" do
+    context 'when same' do
       it { should eql(0) }
     end
-    context "when vary by alter up" do
+    context 'when vary by alter up' do
       let(:other_alter) { 1 }
       it { should eql(-1) }
     end
-    context "when vary by octave down" do
+    context 'when vary by octave down' do
       let(:other_octave) { 3 }
       it { should eql(1) }
     end
   end
-
 end

data/spec/unit/shell_spec.rb

@@ -1,12 +1,14 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe StringyFi::Shell do
   subject(:shell) { described_class.new }
 
-  context "when no args passed" do
-    it "initialises with sample fixture" do
+  context 'when no args passed' do
+    it 'initialises with sample fixture' do
       expect(subject).to be_a(described_class)
-      expect(subject.converter.filename).to include("chromatic.xml")
+      expect(subject.converter.filename).to include('chromatic.xml')
     end
   end
-end
+end

data/spec/unit/version_spec.rb

@@ -1,9 +1,9 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe StringyFi do
-
-  it "has a version" do
+  it 'has a version' do
     expect(described_class::VERSION).to match(/\d+\.\d+\.\d+/)
   end
-
-end
+end

data/stringyfi.gemspec

@@ -1,31 +1,23 @@
-# coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
+# frozen_string_literal: true
+
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'stringyfi/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "stringyfi"
+  spec.name          = 'stringyfi'
   spec.version       = StringyFi::VERSION
-  spec.authors       = ["Paul Gallagher"]
-  spec.email         = ["gallagher.paul@gmail.com"]
-  spec.summary       = "Convert MusicXML to PIC assembler for the Boldport Stringy"
-  spec.homepage      = "https://github.com/tardate/stringyfi"
-  spec.license       = "MIT"
+  spec.authors       = ['Paul Gallagher']
+  spec.email         = ['gallagher.paul@gmail.com']
+  spec.summary       = 'Convert MusicXML to PIC assembler for the Boldport Stringy'
+  spec.homepage      = 'https://github.com/tardate/stringyfi'
+  spec.license       = 'MIT'
 
   spec.files         = `git ls-files -z`.split("\x0")
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
-  spec.require_paths = ["lib"]
-
-  spec.add_runtime_dependency "nokogiri", "~> 1.8"
-
-  spec.add_development_dependency "bundler", "~> 1.6"
-  spec.add_development_dependency "rake"
-  spec.add_development_dependency "rspec"
+  spec.require_paths = ['lib']
 
-  # guard versions are pegged to avoid issue with ruby_dep requires Ruby version >= 2.2.5, ~> 2.2.
-  spec.add_development_dependency "guard-rspec", "4.6.4"
-  spec.add_development_dependency "rb-fsevent", "0.9.6"
-  spec.add_development_dependency "rb-inotify", "0.9.5"
-  spec.add_development_dependency "pry-coolline", "0.2.5" # avoid readline dependency
+  spec.required_ruby_version = '>= 3.0'
+  spec.add_runtime_dependency 'nokogiri', '~> 1.18'
 end

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: stringyfi
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Paul Gallagher
-autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-16 00:00:00.000000000 Z
+date: 2025-07-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -16,113 +15,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.8'
+        version: '1.18'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.8'
-- !ruby/object:Gem::Dependency
-  name: bundler
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.6'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.6'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: guard-rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '='
-      - !ruby/object:Gem::Version
-        version: 4.6.4
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '='
-      - !ruby/object:Gem::Version
-        version: 4.6.4
-- !ruby/object:Gem::Dependency
-  name: rb-fsevent
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '='
-      - !ruby/object:Gem::Version
-        version: 0.9.6
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '='
-      - !ruby/object:Gem::Version
-        version: 0.9.6
-- !ruby/object:Gem::Dependency
-  name: rb-inotify
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '='
-      - !ruby/object:Gem::Version
-        version: 0.9.5
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '='
-      - !ruby/object:Gem::Version
-        version: 0.9.5
-- !ruby/object:Gem::Dependency
-  name: pry-coolline
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '='
-      - !ruby/object:Gem::Version
-        version: 0.2.5
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '='
-      - !ruby/object:Gem::Version
-        version: 0.2.5
-description: 
+        version: '1.18'
 email:
 - gallagher.paul@gmail.com
 executables:
@@ -130,11 +30,11 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/ruby-tests.yml"
 - ".gitignore"
-- ".rspec"
+- ".rubocop.yml"
 - ".ruby-gemset"
 - ".ruby-version"
-- ".travis.yml"
 - Gemfile
 - Guardfile
 - LICENSE.txt
@@ -163,7 +63,6 @@ homepage: https://github.com/tardate/stringyfi
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -171,16 +70,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '3.0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.12
-signing_key: 
+rubygems_version: 3.6.2
 specification_version: 4
 summary: Convert MusicXML to PIC assembler for the Boldport Stringy
 test_files:

data/.rspec

@@ -1,2 +0,0 @@
---color
---format documentation

data/.travis.yml

@@ -1,5 +0,0 @@
-# These are specific configuration settings required for travis-ci
-# see http://travis-ci.org/tardate/stringyfi
-language: ruby
-rvm:
-  - 2.4.1