strelka 0.9.0 → 0.9.1

data/spec/helpers.rb

@@ -104,7 +104,6 @@ end
 RSpec.configure do |config|
 	include Strelka::TestConstants
 
-	config.treat_symbols_as_metadata_keys_with_true_values = true
 	config.run_all_when_everything_filtered = true
 	config.filter_run :focus
 	config.order = 'random'

data/spec/strelka/app/auth_spec.rb

@@ -20,14 +20,9 @@ require 'strelka/behavior/plugin'
 describe Strelka::App::Auth do
 
 	before( :all ) do
-		setup_logging( :fatal )
 		@request_factory = Mongrel2::RequestFactory.new( route: '/api/v1' )
 	end
 
-	after( :all ) do
-		reset_logging()
-	end
-
 
 	it_should_behave_like( "A Strelka Plugin" )
 
@@ -430,6 +425,19 @@ describe Strelka::App::Auth do
 			expect( app.required_perms_for(req) ).to eq( [ :write_access ] )
 		end
 
+		it "ensures required permissions are not retained between requests" do
+			@app.require_perms_for( %r{.*} ){|req| :basic_access }
+			app = @app.new
+
+			req = @request_factory.get( '/api/v1/accounts' )
+
+			expect {
+				app.required_perms_for( req )
+			}.to_not change {
+				@app.positive_perms_criteria.first[ 2 ]
+			}
+		end
+
 		it "adds specific required permissions returned by the block to argument permissions" do
 			@app.require_perms_for( %r{.*}, :basic_access ) do |req|
 				:write_access if req.verb != :GET
@@ -466,7 +474,6 @@ describe Strelka::App::Auth do
 			expect( app.required_perms_for(req) ).to include( :basic_access, :write_access, :is_handsome )
 		end
 
-
 		it "allows negative perms criteria to be declared with a string" do
 			@app.no_perms_for( '/string' )
 			app = @app.new

data/spec/strelka/app/errors_spec.rb

@@ -21,14 +21,9 @@ require 'strelka/behavior/plugin'
 describe Strelka::App::Errors do
 
 	before( :all ) do
-		setup_logging( :fatal )
 		@request_factory = Mongrel2::RequestFactory.new( route: '' )
 	end
 
-	after( :all ) do
-		reset_logging()
-	end
-
 
 	it_should_behave_like( "A Strelka Plugin" )
 

data/spec/strelka/app/filters_spec.rb

@@ -20,14 +20,9 @@ require 'strelka/behavior/plugin'
 describe Strelka::App::Filters do
 
 	before( :all ) do
-		setup_logging( :fatal )
 		@request_factory = Mongrel2::RequestFactory.new( route: '' )
 	end
 
-	after( :all ) do
-		reset_logging()
-	end
-
 
 	it_should_behave_like( "A Strelka Plugin" )
 

data/spec/strelka/app/negotiation_spec.rb

@@ -20,14 +20,9 @@ describe Strelka::App::Negotiation do
 
 
 	before( :all ) do
-		setup_logging( :fatal )
 		@request_factory = Mongrel2::RequestFactory.new( route: '/service/user' )
 	end
 
-	after( :all ) do
-		reset_logging()
-	end
-
 
 	it_should_behave_like( "A Strelka Plugin" )
 

data/spec/strelka/app/parameters_spec.rb

@@ -19,14 +19,9 @@ require 'strelka/behavior/plugin'
 describe Strelka::App::Parameters do
 
 	before( :all ) do
-		setup_logging( :fatal )
 		@request_factory = Mongrel2::RequestFactory.new( route: '/user' )
 	end
 
-	after( :all ) do
-		reset_logging()
-	end
-
 
 	it_should_behave_like( "A Strelka Plugin" )
 

data/spec/strelka/app/restresources_spec.rb

@@ -22,7 +22,6 @@ describe Strelka::App::RestResources do
 	include Mongrel2::Config::DSL
 
 	before( :all ) do
-		setup_logging()
 		setup_config_db()
 
 		@request_factory = Mongrel2::RequestFactory.new( route: '/api/v1' )
@@ -37,10 +36,6 @@ describe Strelka::App::RestResources do
 		Mongrel2::Config::Server.dataset_module( name_selection )
 	end
 
-	after( :all ) do
-		reset_logging()
-	end
-
 
 	it_should_behave_like( "A Strelka Plugin" )
 

data/spec/strelka/app/routing_spec.rb

@@ -20,14 +20,9 @@ require 'strelka/behavior/plugin'
 describe Strelka::App::Routing do
 
 	before( :all ) do
-		setup_logging( :fatal )
 		@request_factory = Mongrel2::RequestFactory.new( route: '' )
 	end
 
-	after( :all ) do
-		reset_logging()
-	end
-
 
 	it_should_behave_like( "A Strelka Plugin" )
 

data/spec/strelka/app/sessions_spec.rb

@@ -18,14 +18,9 @@ require 'strelka/behavior/plugin'
 describe Strelka::App::Sessions do
 
 	before( :all ) do
-		setup_logging( :fatal )
 		@request_factory = Mongrel2::RequestFactory.new( route: '' )
 	end
 
-	after( :all ) do
-		reset_logging()
-	end
-
 
 	it_should_behave_like( "A Strelka Plugin" )
 

data/spec/strelka/app/templating_spec.rb

@@ -21,14 +21,12 @@ require 'strelka/behavior/plugin'
 describe Strelka::App::Templating do
 
 	before( :all ) do
-		setup_logging()
 		@request_factory = Mongrel2::RequestFactory.new( route: '/user' )
 		@original_template_paths = Inversion::Template.template_paths.dup
 	end
 
 	after( :all ) do
 		Inversion::Template.template_paths.replace( @original_template_paths )
-		reset_logging()
 	end
 
 

data/spec/strelka/app_spec.rb

@@ -19,7 +19,6 @@ require 'strelka/app'
 describe Strelka::App do
 
 	before( :all ) do
-		setup_logging( :fatal )
 		@initial_registry = Strelka::App.loaded_plugins.dup
 		@request_factory = Mongrel2::RequestFactory.new( route: '/mail' )
 		Mongrel2::Config.db = Mongrel2::Config.in_memory_db
@@ -52,7 +51,6 @@ describe Strelka::App do
 
 	after( :all ) do
 		Strelka::App.loaded_plugins = @initial_registry
-		reset_logging()
 	end
 
 

data/spec/strelka/authprovider/basic_spec.rb

@@ -18,7 +18,6 @@ describe Strelka::AuthProvider::Basic do
 
 	before( :all ) do
 		@request_factory = Mongrel2::RequestFactory.new( route: '/admin' )
-		setup_logging( :fatal )
 	end
 
 	before( :each ) do
@@ -38,10 +37,6 @@ describe Strelka::AuthProvider::Basic do
 		described_class.realm = nil
 	end
 
-	after( :all ) do
-		reset_logging()
-	end
-
 
 	#
 	# Helpers

data/spec/strelka/authprovider/hostaccess_spec.rb

@@ -18,7 +18,6 @@ describe Strelka::AuthProvider::HostAccess do
 
 	before( :all ) do
 		@request_factory = Mongrel2::RequestFactory.new( route: '/admin' )
-		setup_logging( :fatal )
 	end
 
 	before( :each ) do
@@ -26,10 +25,6 @@ describe Strelka::AuthProvider::HostAccess do
 		@provider = Strelka::AuthProvider.create( :hostaccess, @app )
 	end
 
-	after( :all ) do
-		reset_logging()
-	end
-
 
 	it "knows what its allowed netblocks are" do
 		expect( @provider.allowed_netblocks ).to be_an( Array )

data/spec/strelka/authprovider_spec.rb

@@ -17,11 +17,6 @@ describe Strelka::AuthProvider do
 
 	before( :all ) do
 		@request_factory = Mongrel2::RequestFactory.new( route: '/admin' )
-		setup_logging( :fatal )
-	end
-
-	after( :all ) do
-		reset_logging()
 	end
 
 

data/spec/strelka/cookie_spec.rb

@@ -15,14 +15,6 @@ require 'strelka/cookie'
 
 describe Strelka::Cookie do
 
-	before( :all ) do
-		setup_logging( :fatal )
-	end
-
-	after( :all ) do
-		reset_logging()
-	end
-
 	it "parses a 'nil' Cookie header field as an empty Hash" do
 		expect( Strelka::Cookie.parse( nil ) ).to eq( {} )
 	end

data/spec/strelka/discovery_spec.rb

@@ -19,7 +19,6 @@ require 'strelka/discovery'
 describe Strelka::Discovery do
 
 	before( :all ) do
-		setup_logging()
 		Mongrel2::Config.db = Mongrel2::Config.in_memory_db
 		Mongrel2::Config.init_database
 
@@ -31,10 +30,6 @@ describe Strelka::Discovery do
 
 	end
 
-	after( :all ) do
-		reset_logging()
-	end
-
 
 	let( :discoverable_class ) { Class.new {extend Strelka::Discovery} }
 

data/spec/strelka/exceptions_spec.rb

@@ -19,14 +19,9 @@ require 'strelka/exceptions'
 describe Strelka, "exception classes" do
 
 	before( :all ) do
-		setup_logging( :fatal )
 		@request_factory = Mongrel2::RequestFactory.new( route: '/exceptions' )
 	end
 
-	after( :all ) do
-		reset_logging()
-	end
-
 
 	describe Strelka::RequestError do
 

data/spec/strelka/httprequest/acceptparams_spec.rb

@@ -16,14 +16,6 @@ require 'strelka/httprequest/acceptparams'
 
 describe Strelka::HTTPRequest, "accept params" do
 
-	before( :all ) do
-		setup_logging( :fatal )
-	end
-
-	after( :all ) do
-		reset_logging()
-	end
-
 
 	describe Strelka::HTTPRequest::MediaType do
 

data/spec/strelka/httprequest/auth_spec.rb

@@ -16,14 +16,9 @@ require 'strelka/httprequest/auth'
 describe Strelka::HTTPRequest::Auth do
 
 	before( :all ) do
-		setup_logging( :fatal )
 		@request_factory = Mongrel2::RequestFactory.new( route: '/service/user' )
 	end
 
-	after( :all ) do
-		reset_logging()
-	end
-
 	before( :each ) do
 		@req = @request_factory.get( '/service/user/estark' )
 		@req.extend( described_class )

data/spec/strelka/httprequest/negotiation_spec.rb

@@ -18,14 +18,9 @@ require 'strelka/httpresponse/negotiation'
 describe Strelka::HTTPRequest::Negotiation do
 
 	before( :all ) do
-		setup_logging( :fatal )
 		@request_factory = Mongrel2::RequestFactory.new( route: '/service/user' )
 	end
 
-	after( :all ) do
-		reset_logging()
-	end
-
 
 	before( :each ) do
 		@req = @request_factory.get( '/service/user/estark' )

data/spec/strelka/httprequest/session_spec.rb

@@ -18,7 +18,6 @@ require 'strelka/session/default'
 describe Strelka::HTTPRequest::Session, "-extended request" do
 
 	before( :all ) do
-		setup_logging( :fatal )
 		@request_factory = Mongrel2::RequestFactory.new( route: '/service/user' )
 		Strelka::App::Sessions.configure( session_class: 'default' )
 	end
@@ -32,10 +31,6 @@ describe Strelka::HTTPRequest::Session, "-extended request" do
 		Strelka::Session::Default.sessions.clear
 	end
 
-	after( :all ) do
-		reset_logging()
-	end
-
 
 	it "has a session_namespace attribute" do
 		expect( @req ).to respond_to( :session_namespace )

data/spec/strelka/httprequest_spec.rb

@@ -17,13 +17,9 @@ require 'strelka/cookie'
 describe Strelka::HTTPRequest do
 
 	before( :all ) do
-		setup_logging()
 		@request_factory = Mongrel2::RequestFactory.new( route: '/directory' )
 	end
 
-	after( :all ) do
-		reset_logging()
-	end
 
 	context "instance" do
 

data/spec/strelka/httpresponse/negotiation_spec.rb

@@ -17,14 +17,9 @@ require 'strelka/httpresponse/negotiation'
 describe Strelka::HTTPResponse::Negotiation do
 
 	before( :all ) do
-		setup_logging( :fatal )
 		@request_factory = Mongrel2::RequestFactory.new( route: '/service/user' )
 	end
 
-	after( :all ) do
-		reset_logging()
-	end
-
 
 	before( :each ) do
 		@app = Class.new( Strelka::App ) { plugins :negotiation }

data/spec/strelka/httpresponse/session_spec.rb

@@ -19,7 +19,6 @@ require 'strelka/session/default'
 describe Strelka::HTTPResponse::Session, "-extended response" do
 
 	before( :all ) do
-		setup_logging( :fatal )
 		@request_factory = Mongrel2::RequestFactory.new( route: '/service/user' )
 		Strelka::App::Sessions.configure( session_class: 'default' )
 	end
@@ -35,10 +34,6 @@ describe Strelka::HTTPResponse::Session, "-extended response" do
 		Strelka::Session::Default.sessions.clear
 	end
 
-	after( :all ) do
-		reset_logging()
-	end
-
 
 	it "has a session_namespace attribute" do
 		expect( @res ).to respond_to( :session_namespace )

data/spec/strelka/httpresponse_spec.rb

@@ -14,7 +14,6 @@ require 'strelka/httpresponse'
 describe Strelka::HTTPResponse do
 
 	before( :all ) do
-		setup_logging( :fatal )
 		@request_factory = Mongrel2::RequestFactory.new( route: '/glossary' )
 	end
 
@@ -23,10 +22,6 @@ describe Strelka::HTTPResponse do
 		@res = @req.response
 	end
 
-	after( :all ) do
-		reset_logging()
-	end
-
 
 	it "adds a charset to the response's content-type header if it's text/* and one is explicitly set" do
 		@res.content_type = 'text/html'

data/spec/strelka/mixins_spec.rb

@@ -61,13 +61,6 @@ describe Strelka, "mixins" do
 
 	describe Strelka::Delegation do
 
-		before( :all ) do
-			setup_logging( :fatal )
-		end
-		after( :all ) do
-			reset_logging()
-		end
-
 		describe "method delegation" do
 			before( :all ) do
 				@testclass = Class.new do