streamsend 1.0.0.rc4 → 1.0.0.rc5

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    OWQwZjQyNTdiY2E1OThiYWExZGRmOGUzNzQ0ODFmZGM4MmY3ZDNjNQ==
+    M2EyMzFiNThlZWQ1YjRjNDQxMjE3YWNmOTIxZGEyMmY1M2E1ZGYxNw==
   data.tar.gz: !binary |-
-    YTk3MTc1NzM2NDFlMGZiYjM2MTEwYmQ3ZjAwZjkxYzFlZGNiZmM2NA==
+    MGI4ODQ4NTkyNjc2MWMyZGNlNjdjYWQ5OTEzZmY4ZGFkYmM5OTdkNQ==
 SHA512:
   metadata.gz: !binary |-
-    Yjc2OWMzZDQ0NjA1ZDg3ZGMyNTFmZmU3NTE4MDAwODhkZWQwMWVkZTEyYjg3
-    NDY4ZjEwYjI0ZmY0YjFhM2VhYjM3ZGE2ZTRhY2ZiNDUyNjNjNWRjYmE5ODQ0
-    NjA1M2E0YjA4NzFlZDNjZWQ1ZTRiMzMxMzI5OGE2OGIwY2FkOWY=
+    YzU2ZDM1Zjk4NDI5YjM2YTUwYWQyOWRiMWFiY2M5YmQ0ZTY3YjQyZmM5Zjk3
+    NjY0OTg1NGI0N2Q4MjRiNjhjZWI3OTc2MGFkNTMwZTljNTc3MmM0YWU4NzY2
+    NTRmNjk5OGU4ODlhMDEwMDA2OTU3ZmFkZTVjMzY3NzVkN2FkOGY=
   data.tar.gz: !binary |-
-    YWIzOTAzN2VlYjI3YmFkZTU5ZDAzMGE2OTA1NWY4MGZkNTBiMDM2OTJhM2Jl
-    ODlkMTUxZTYwMzkyMjM0YTk5ZmI1MGFjYzQzN2QyOWEwNWU4MDk2NzdjYzYz
-    NzlkZDRiYzYzZjYzOTQ1Yjc1ZTJkZThjMGQ5ZDYwMjhmZDI1MjA=
+    MzEzYWVlYmZhNWJiZTgxMmRlNjNhYWVjNDYyYzEwZjA0ODhiNzdkZmUzNmY5
+    MTRjNzEzYjJiM2M1NGYzYjNkOTg0MjYxODUxNTdlNmJlYTZkY2Y0ZGE5NDJl
+    NDNiNDU1ZTUxNjI1NTlmZTNmYmYyZmJjYWM4ZjZjMTY4MTIzMzE=

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    streamsend (1.0.0.rc3)
+    streamsend (1.0.0.rc4)
       activesupport (~> 3.2)
       builder
       httmultiparty

data/lib/streamsend/api/base/base_call.rb

@@ -54,6 +54,19 @@ module StreamSend
         def audiences_uri
           "#{base_audience_uri}.xml"
         end
+
+        private
+
+        def get_error_from response
+          message = "Unprocessable Entity"
+          if response.parsed_response["request"]
+            message = response.parsed_response["request"]["errors"]
+          elsif response.parsed_response["errors"]
+            message = response.parsed_response["errors"]["error"]
+          elsif response["errors"]
+            message = response["errors"]
+          end
+        end
       end
     end
   end

data/lib/streamsend/api/base/create.rb

@@ -21,17 +21,6 @@ module StreamSend
         def uri
           "#{base_uri}.xml"
         end
-
-        def get_error_from response
-          message = "Unprocessable Entity"
-          if response.parsed_response["request"]
-            message = response.parsed_response["request"]["errors"]
-          elsif response.parsed_response["errors"]
-            message = response.parsed_response["errors"]["error"]
-          elsif response["errors"]
-            message = response["errors"]
-          end
-        end
       end
 
       class AudienceCreate < StreamSend::Api::Call::Create

data/lib/streamsend/api/base/update.rb

@@ -6,10 +6,11 @@ module StreamSend
           @id = object_id
           response = session.put(uri, :body => object_hash)
           case response.code
-          when 200
-            true
+          when 200 then true
+          when 401 then raise StreamSend::Api::UnauthorizedException
+          when 422 then raise StreamSend::Api::SemanticException.new(get_error_from(response))
           else
-            false
+            raise StreamSend::Api::Exception.new("Could not create the #{namespace}. (#{response.code})")
           end
         end
 

data/lib/streamsend/version.rb

@@ -1,3 +1,3 @@
 module StreamSend
-  VERSION = "1.0.0.rc4"
+  VERSION = "1.0.0.rc5"
 end

data/spec/lib/streamsend/api/integration/person_spec.rb

@@ -150,7 +150,7 @@ module StreamSend
             person = shower.execute(id)
             person.email_address = "me+#{randomish}@you.too"
             updater = Update.new(session)
-            updater.execute(id, person.marshal_dump)
+            updater.execute(id, :person => person.marshal_dump)
             person_updated = shower.execute(id)
             expect(person_updated.email_address).to eq(person_hash[:person][:email_address])
             expect(person_updated.id).to eq(id)

data/spec/lib/streamsend/api/integration/user_spec.rb

@@ -54,7 +54,7 @@ module StreamSend
             user = shower.execute(id)
             user.first_name = "newer namers!"
             updater = Update.new(session)
-            updater.execute(id, user.marshal_dump)
+            updater.execute(id, :user => user.marshal_dump)
             user_updated = shower.execute(id)
             expect(user_updated.name).to eq(user_hash[:user][:name])
             expect(user_updated.id).to eq(id)

data/spec/lib/streamsend/api/unit/base/update_spec.rb

@@ -9,16 +9,50 @@ module StreamSend
         let(:session){ StreamSend::Api::Session.new("test", "password", "http://default.base") }
         let(:updater){ Update.new(session) }
 
-        it "returns true when the object is updated successfully" do
-          stub_request(:put, "http://test:password@default.base/calls/123.xml").
-            to_return(:status => 200, :body => "", :headers => {})
-          expect(updater.execute(id, obj_hash)).to eq(true)
+        context "when the update is successful" do
+          it "returns true" do
+            stub_request(:put, "http://test:password@default.base/calls/123.xml").
+              to_return(:status => 200, :body => "", :headers => {})
+            expect(updater.execute(id, obj_hash)).to be_true
+          end
         end
 
-        it "returns true when the object is updated successfully" do
-          stub_request(:put, "http://test:password@default.base/calls/123.xml").
-            to_return(:status => 404, :body => "", :headers => {})
-          expect(updater.execute(id, obj_hash)).to eq(false)
+        context "when invalid credentials are provided" do
+          it "returns an unathorized exception" do
+            stub_request(:put, "http://test:password@default.base/calls/123.xml").to_return(:status => 401, :body => "" )
+            expect do
+              updater.execute(id, {})
+            end.to raise_error(UnauthorizedException)
+          end
+        end
+
+        context "when the request is invalid" do
+          let(:non_existent_person_id) { 42 }
+          let(:error_response) do
+            response_xml = <<-XML
+            <request>
+              <errors type='array'>
+                <message>Invalid Owner ID</message>
+              </errors>
+            </request>
+            XML
+          end
+
+          it "returns a semantic error with a meaningful error message" do
+            stub_request(:put, "http://test:password@default.base/calls/#{non_existent_person_id}.xml").to_return(:status => 422, :body => error_response, :headers => { :content_type => "application/xml" })
+            expect do
+              updater.execute(non_existent_person_id, {})
+            end.to raise_error(StreamSend::Api::SemanticException, /Invalid Owner ID/)
+          end
+        end
+
+        context "when the status is a 404" do
+          it "builds an error message with the namespace name" do
+            stub_request(:put, "http://test:password@default.base/calls/123.xml").to_return(:status => 404, :body => "")
+            expect do
+              updater.execute(id, {})
+            end.to raise_error(StreamSend::Api::Exception, "Could not create the calls. (404)")
+          end
         end
 
         it "creates a uri for updating using the id" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: streamsend
 version: !ruby/object:Gem::Version
-  version: 1.0.0.rc4
+  version: 1.0.0.rc5
 platform: ruby
 authors:
 - Bob Yeo
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-29 00:00:00.000000000 Z
+date: 2013-11-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httmultiparty
@@ -246,7 +246,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.1
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.1.9
+rubygems_version: 2.1.10
 signing_key: 
 specification_version: 4
 summary: Ruby wrapper for the StreamSend API.