streamsend 1.0.0.rc16 → 1.0.0.rc19

data/spec/lib/streamsend/api/integration/owner_spec.rb

@@ -27,36 +27,43 @@ module StreamSend
         after do
           WebMock.enable!
         end
+        let(:owner_id_1) do
+          creator = StreamSend::Api::Owner::Create.new(session)
+          id = creator.execute({:owner => owner_hash})
+        end
 
-        def create_owners
+        let(:owner_id_2) do
           creator = StreamSend::Api::Owner::Create.new(session)
           owner_hash2 = owner_hash.clone
           owner_hash2[:owner_name] = franchise_code2
           owner_hash2[:owner_id] = franchise_code2
+          creator.execute({:owner => owner_hash2})
+        end
 
+        let(:owner_id_3) do
+          creator = StreamSend::Api::Owner::Create.new(session)
           owner_hash3 = owner_hash.clone
           owner_hash3[:owner_name] = franchise_code3
           owner_hash3[:owner_id] = franchise_code3
-
-          creator.execute({:owner => owner_hash})
-          creator.execute({:owner => owner_hash2})
           creator.execute({:owner => owner_hash3})
         end
 
-        def delete_owners
+        def create_owners
+          [owner_id_1, owner_id_2, owner_id_3]
+        end
+
+        def delete_owners(owner_ids)
           destroyer = StreamSend::Api::Owner::Destroy.new(session)
-          destroyer.execute(franchise_code)
-          destroyer.execute(franchise_code2)
-          destroyer.execute(franchise_code3)
+          owner_ids.each{ |id| destroyer.execute(id) }
         end
 
         describe Index do
           context "without pagination" do
             it "creates, display, then destroy the owner(s)" do
-              create_owners
+              ids = create_owners
               owners = StreamSend::Api::Owner::Index.new(session).execute
               expect(owners.count).to be > 0
-              delete_owners
+              delete_owners(ids)
             end
           end
 
@@ -64,29 +71,29 @@ module StreamSend
             let(:per_page) { 2 }
 
             it "creates, display, then destroy the owner(s)" do
-              create_owners
+              ids = create_owners
               owners = StreamSend::Api::Owner::Index.new(session).execute(:page =>1, :per_page => per_page)
               expect(owners.count).to be per_page
-              delete_owners
+              delete_owners(ids)
             end
           end
         end
 
         describe Show do
           it "shows a owner by id" do
-            create_owners
-            owner = StreamSend::Api::Owner::Show.new(session).execute(franchise_code)
+            ids = create_owners
+            owner = StreamSend::Api::Owner::Show.new(session).execute(ids.first)
             expect(owner.owner_id).to eq(franchise_code)
-            delete_owners
+            delete_owners(ids)
           end
         end
 
         describe Destroy do
           it "deletes an owner by owner id" do
-            StreamSend::Api::Owner::Create.new(session).execute({:owner => owner_hash})
-            StreamSend::Api::Owner::Destroy.new(session).execute(franchise_code)
+            id = StreamSend::Api::Owner::Create.new(session).execute({:owner => owner_hash})
+            StreamSend::Api::Owner::Destroy.new(session).execute(id)
             expect do
-              StreamSend::Api::Owner::Show.new(session).execute(franchise_code)
+              StreamSend::Api::Owner::Show.new(session).execute(id)
             end.to raise_error(StreamSend::Api::Exception, "Could not find any owners with the specified id. (404)")
           end
         end

data/spec/lib/streamsend/api/integration/person_spec.rb

@@ -54,10 +54,13 @@ module StreamSend
             emailer = EmailAddress.new(session)
             results = emailer.execute(person_hash[:person][:email_address])
             expect(results.count).to be > 0
+
+            destroyer = Destroy.new(session)
+            destroyer.execute(id)
           end
 
           it "returns an index by email address and owner id" do
-            # pending "Owner is not accessible via API -- relies on owner fixture in account"
+            pending "Owner is not accessible via API -- relies on owner fixture in account"
             owner_id = "ID 1373999841"
             person_hash[:person][:owner_id] = owner_id
             id = creator.execute(person_hash)
@@ -73,10 +76,13 @@ module StreamSend
             tracker = TrackingHash.new(session)
             results = tracker.execute(person.tracking_hash)
             expect(results.count).to be > 0
+
+            destroyer = Destroy.new(session)
+            destroyer.execute(id)
           end
 
           it "returns an index by owner id" do
-            # pending "Owner is not accessible via API -- relies on owner fixture in account"
+            pending "Owner is not accessible via API -- relies on owner fixture in account"
             owner_id = "ID 1373999841"
             person_hash[:person][:owner_id] = owner_id
             id = creator.execute(person_hash)
@@ -92,20 +98,24 @@ module StreamSend
           let(:blast_id) { 70361 }
           let(:link_id) { 27581 }
           it "returns an array of people" do
+            pending "Can't create a click through API"
             people = peopler.execute(blast_id)
             expect(people.count).to be > 0
           end
 
           it "returns an array of people for a link click by link id" do
+            pending "Can't create view through API"
             people = peopler.execute(blast_id, link_id)
             expect(people.count).to be > 0
           end
         end
 
         describe View do
+          pending "Can't create a view through API"
           let(:viewer){ View.new(session) }
           let(:blast_id) { 72761 }
           it "returns an array of people" do
+            pending "Can't create view through API"
             people = viewer.execute(blast_id)
             expect(people.count).to be > 0
           end

data/spec/lib/streamsend/api/integration/unsubscribe_spec.rb

@@ -17,6 +17,7 @@ module StreamSend
 
         describe Index do
           it "returns an array of unsubscribes" do
+            pending "Can't create unsubsscribes through api"
             indexer = Index.new(session)
             unsubs = indexer.execute(blast_id)
             expect(unsubs.count).to be > 0
@@ -25,6 +26,7 @@ module StreamSend
 
         describe Manual do
           it "returns an array of manual unsubscribes" do
+            pending "Can't create unsubsscribes through api"
             manualer = Manual.new(session)
             unsubs = manualer.execute(blast_id)
             expect(unsubs.count).to be > 0

data/spec/lib/streamsend/api/integration/view_spec.rb

@@ -17,6 +17,7 @@ module StreamSend
 
         describe Index do
           it "returns an array of views" do
+            pending "Can't create view from API"
             indexer = Index.new(session)
             expect(indexer.execute(blast_id).count).to be > 0
           end

data/spec/lib/streamsend/api/unit/base/count_spec.rb

@@ -0,0 +1,57 @@
+require "spec_helper"
+
+module StreamSend
+  module Api
+    module Call
+      describe Count do
+        let(:session){ StreamSend::Api::Session.new("test", "password", "http://default.base") }
+        let(:count_request){ Count.new(session) }
+        let(:xml){ "<?xml version=\"1.0\" encoding=\"UTF-8\"?><count type=\"integer\">10</count>" }
+
+        describe "#uris" do
+          before do
+            stub_request(:get, "http://test:password@default.base/calls/count.xml").
+              to_return(:status => 200, :body => xml, headers: { 'Accept' => 'text/xml', 'Content-type' => 'text/xml' })
+          end
+
+          it "builds a count uri" do
+            count_request.execute
+            expect(count_request.uri).to eq("http://default.base/calls/count.xml")
+          end
+        end
+
+        describe "#execute" do
+          it "returns a count integer" do
+            stub_request(:get, "http://test:password@default.base/calls/count.xml").
+              to_return(:status => 200, :body => xml, :headers => {'Content-type' => 'application/xml'})
+            expect(count_request.execute).to eq(10)
+          end
+
+          it "throws a ApiException for 400 errors" do
+            stub_request(:get, "http://test:password@default.base/calls/count.xml").
+              to_return(:status => 400, :body => xml, :headers => {'Content-type' => 'application/xml'})
+            expect do
+              count_request.execute
+            end.to raise_error ::StreamSend::Api::ApiException
+          end
+
+          it "throws a UnauthorizedException for 401 errors" do
+            stub_request(:get, "http://test:password@default.base/calls/count.xml").
+              to_return(:status => 401, :body => xml, :headers => {'Content-type' => 'application/xml'})
+            expect do
+              count_request.execute
+            end.to raise_error ::StreamSend::Api::UnauthorizedException
+          end
+
+          it "throws a Exception for all other errors" do
+            stub_request(:get, "http://test:password@default.base/calls/count.xml").
+              to_return(:status => 500, :body => xml, :headers => {'Content-type' => 'application/xml'})
+            expect do
+              count_request.execute
+            end.to raise_error ::StreamSend::Api::Exception
+          end
+        end
+      end
+    end
+  end
+end

data/spec/lib/streamsend/api/unit/base/index_spec.rb

@@ -9,7 +9,7 @@ module StreamSend
         let(:options){ {:page => 2, :per_page => 10} }
         let(:xml){ "<?xml version=\"1.0\" encoding=\"UTF-8\"?><calls type=\"array\"><call><test type=\"integer\">1</test></call></calls>" }
 
-        describe "Uris" do
+        describe "#uris" do
           before do
             stub_request(:get, "http://test:password@default.base/calls.xml").
               to_return(:status => 200, :body => xml, headers: { 'Accept' => 'text/xml', 'Content-type' => 'text/xml' })
@@ -19,20 +19,6 @@ module StreamSend
             indexer.execute
             expect(indexer.uri).to eq("http://default.base/calls.xml")
           end
-
-          describe "#paging_query_string" do
-            it "returns paging parameters with the options provided" do
-              stub_request(:get, "http://test:password@default.base/calls.xml?page=2&per_page=10").
-                to_return(:status => 200, :body => xml, headers: { 'Accept' => 'text/xml', 'Content-type' => 'text/xml' })
-              indexer.execute(options)
-              expect(indexer.paging_query_string).to eq("?page=2&per_page=10")
-            end
-
-            it "returns default paging parameters if no options are provided." do
-              indexer.execute
-              expect(indexer.paging_query_string).to eq("?page=1&per_page=100")
-            end
-          end
         end
 
         describe "#execute" do
@@ -48,6 +34,45 @@ module StreamSend
               indexer.execute
             end.to raise_error(StreamSend::Api::Exception, "Could not find any calls. (404)")
           end
+
+          context "with options" do
+            let(:session) { double(:get => double(:code => 200, :parsed_response => { "calls" => [] } ), :base_uri => "http://boohoo.com") }
+            context "with headers attribute" do
+              let(:options) { {:headers =>{:location => "http://me.com"}, :owner_id => 99  } }
+
+              it "makes get request with options" do
+                session.should_receive(:get).with("http://boohoo.com/calls.xml", options)
+                indexer.execute(options)
+              end
+            end
+
+            context "with query attributes" do
+              let(:options) { {:query => {:page => 5, :per_page => 66}, :owner_id => 99 } }
+
+              it "makes get request with options" do
+                session.should_receive(:get).with("http://boohoo.com/calls.xml", options)
+                indexer.execute(options)
+              end
+            end
+
+            context "with attributes only" do
+              let(:options) { {:page => 3, :per_page => 33, :owner_id => 99}  }
+
+              it "makes get request with options in a query hash" do
+                session.should_receive(:get).with("http://boohoo.com/calls.xml", {:query => options})
+                indexer.execute(options)
+              end
+            end
+          end
+
+          context "with no options" do
+            let(:session) { double(:get => double(:code => 200, :parsed_response => { "calls" => [] } ), :base_uri => "http://boohoo.com") }
+            let(:options) { {} }
+            it "makes get request with options that is an empty hash" do
+              session.should_receive(:get).with("http://boohoo.com/calls.xml", {})
+              indexer.execute(options)
+            end
+          end
         end
       end
 
@@ -81,10 +106,9 @@ module StreamSend
         let(:blast_id){ 1432 }
 
         it "overrides uri and returns a uri based on the provided blast_id and appends paging" do
-          stub_request(:get, "http://test:password@default.base/blasts/1432/calls.xml?page=1&per_page=100").
-            to_return(:status => 200, :body => xml, headers: { 'Accept' => 'text/xml', 'Content-type' => 'text/xml' })
+          stub_request(:get, "http://test:password@default.base/blasts/1432/calls.xml").to_return(:status => 200, :body => xml, headers: { 'Accept' => 'text/xml', 'Content-type' => 'text/xml' })
           indexer.execute(blast_id)
-          expect(indexer.uri).to eq("http://default.base/blasts/1432/calls.xml?page=1&per_page=100")
+          expect(indexer.uri).to eq("http://default.base/blasts/1432/calls.xml")
         end
       end
     end

data/spec/lib/streamsend/api/unit/blast_spec.rb

@@ -12,10 +12,9 @@ module StreamSend
 
           it "returns the scheduled blast uri" do
             session.stub(:audience_id).and_return(1)
-            stub_request(:get, "http://test:password@default.base/audiences/1/blasts.xml?page=1&per_page=100").
-              to_return(:status => 200, :body => xml, :headers => {'Content-Type' => 'text/xml'})
+            stub_request(:get, "http://test:password@default.base/audiences/1/blasts.xml").to_return(:status => 200, :body => xml, :headers => {'Content-Type' => 'text/xml'})
             indexer.execute
-            expect(indexer.uri).to eq("http://default.base/audiences/1/blasts.xml?page=1&per_page=100")
+            expect(indexer.uri).to eq("http://default.base/audiences/1/blasts.xml")
           end
         end
 
@@ -24,13 +23,12 @@ module StreamSend
 
           before do
             session.stub(:audience_id).and_return(1)
-            stub_request(:get, "http://test:password@default.base/audiences/1/blasts/scheduled.xml?page=1&per_page=100").
-              to_return(:status => 200, :body => xml, :headers => {'Content-Type' => 'text/xml'})
+            stub_request(:get, "http://test:password@default.base/audiences/1/blasts/scheduled.xml").to_return(:status => 200, :body => xml, :headers => {'Content-Type' => 'text/xml'})
             scheduler.execute
           end
 
           it "returns the scheduled blast uri" do
-            expect(scheduler.uri).to eq("http://default.base/audiences/1/blasts/scheduled.xml?page=1&per_page=100")
+            expect(scheduler.uri).to eq("http://default.base/audiences/1/blasts/scheduled.xml")
           end
         end
 
@@ -39,13 +37,12 @@ module StreamSend
 
           before do
             session.stub(:audience_id).and_return(1)
-            stub_request(:get, "http://test:password@default.base/audiences/1/blasts/sent.xml?page=1&per_page=100").
-              to_return(:status => 200, :body => xml, :headers => {'Content-Type' => 'text/xml'})
+            stub_request(:get, "http://test:password@default.base/audiences/1/blasts/sent.xml").to_return(:status => 200, :body => xml, :headers => {'Content-Type' => 'text/xml'})
             scheduler.execute
           end
 
           it "returns the sent blast uri" do
-            expect(scheduler.uri).to eq("http://default.base/audiences/1/blasts/sent.xml?page=1&per_page=100")
+            expect(scheduler.uri).to eq("http://default.base/audiences/1/blasts/sent.xml")
           end
         end
 

data/spec/lib/streamsend/api/unit/bounce_spec.rb

@@ -11,23 +11,21 @@ module StreamSend
         let(:xml){ "<?xml version=\"1.0\" encoding=\"UTF-8\"?><bounces type=\"array\"><bounce><test type=\"integer\">1</test></bounce></bounces>" }
 
         before do
-          stub_request(:get, "http://test:password@default.base/blasts/15/bounces/soft.xml?page=1&per_page=100").
-              to_return(:status => 200, :body => xml, :headers => {'Content-Type' => 'text/xml'})
-          stub_request(:get, "http://test:password@default.base/blasts/15/bounces/hard.xml?page=1&per_page=100").
-              to_return(:status => 200, :body => xml, :headers => {'Content-Type' => 'text/xml'})
-          soft_bounce.execute(blast_id)
+          stub_request(:get, "http://test:password@default.base/blasts/15/bounces/soft.xml").to_return(:status => 200, :body => xml, :headers => {'Content-Type' => 'text/xml'})
+          stub_request(:get, "http://test:password@default.base/blasts/15/bounces/hard.xml").to_return(:status => 200, :body => xml, :headers => {'Content-Type' => 'text/xml'})
           hard_bounce.execute(blast_id)
+          soft_bounce.execute(blast_id)
         end
 
         describe Soft do
           it "returns a uri for soft bounces" do
-            expect(soft_bounce.uri).to eq("http://default.base/blasts/15/bounces/soft.xml?page=1&per_page=100")
+            expect(soft_bounce.uri).to eq("http://default.base/blasts/15/bounces/soft.xml")
           end
         end
 
         describe Hard do
           it "returns a url for hard bounces" do
-            expect(hard_bounce.uri).to eq("http://default.base/blasts/15/bounces/hard.xml?page=1&per_page=100")
+            expect(hard_bounce.uri).to eq("http://default.base/blasts/15/bounces/hard.xml")
           end
         end
       end

data/spec/lib/streamsend/api/unit/click_spec.rb

@@ -11,21 +11,21 @@ module StreamSend
         let(:xml){ "<?xml version=\"1.0\" encoding=\"UTF-8\"?><clicks type=\"array\"><click><test type=\"integer\">1</test></click></clicks>" }
 
         before do
-          stub_request(:get, "https://test:pass@default.base/blasts/1/links/1/clicks.xml?page=1&per_page=100").
+          stub_request(:get, "https://test:pass@default.base/blasts/1/links/1/clicks.xml").
               to_return(:status => 200, :body => xml, :headers => {'Content-Type' => 'text/xml'})
-          stub_request(:get, "https://test:pass@default.base/blasts/1/clicks.xml?page=1&per_page=100").
+          stub_request(:get, "https://test:pass@default.base/blasts/1/clicks.xml").
               to_return(:status => 200, :body => xml, :headers => {'Content-Type' => 'text/xml'})
         end
 
         describe Index do
           it "creates a uri for blast clicks" do
             indexer.execute(blast_id)
-            expect(indexer.uri).to eq("https://default.base/blasts/#{blast_id}/clicks.xml?page=1&per_page=100")
+            expect(indexer.uri).to eq("https://default.base/blasts/#{blast_id}/clicks.xml")
           end
 
           it "creates a uri for a link click if link id is provided" do
             indexer.execute(blast_id, link_id)
-            expect(indexer.uri).to eq("https://default.base/blasts/#{blast_id}/links/#{link_id}/clicks.xml?page=1&per_page=100")
+            expect(indexer.uri).to eq("https://default.base/blasts/#{blast_id}/links/#{link_id}/clicks.xml")
           end
         end
       end

data/spec/lib/streamsend/api/unit/hash_xml_serializer_spec.rb

@@ -0,0 +1,63 @@
+require "spec_helper"
+
+module StreamSend
+  module Api
+    describe HashXmlSerializer do
+      describe "#serialize" do
+        let(:hash_serializer) { HashXmlSerializer.new }
+        let(:simple_hash) { { :simple_hash => { :id => 101, :name => "test" } } }
+        let(:nested_hash) { { :nested_hash => { :parent_hash => { :child_hash => { :child_value => "Valuable!" }, :child_array => [1,2,3] } } } }
+
+        before do
+          @simple_xml =<<-XML
+<?xml version="1.0" encoding="UTF-8"?>
+<simple-hash>
+  <id>101</id>
+  <name>test</name>
+</simple-hash>
+        XML
+
+        @nested_xml =<<-XML
+<?xml version="1.0" encoding="UTF-8"?>
+<nested-hash>
+  <parent-hash>
+    <child-hash>
+      <child-value>Valuable!</child-value>
+    </child-hash>
+    <child-array>1, 2, 3</child-array>
+  </parent-hash>
+</nested-hash>
+          XML
+        end
+
+
+        it "serializes a simple hash" do
+          xml = hash_serializer.serialize(simple_hash)
+          xml.should ==  @simple_xml
+        end
+
+        it "serializes a nested hash" do
+          xml = hash_serializer.serialize(nested_hash)
+          xml.should ==  @nested_xml
+        end
+
+        it "adds an attribute for nil valued tags" do
+          simple_hash[:simple_hash][:something_nilly] = nil
+          xml = hash_serializer.serialize(simple_hash)
+          xml.should include("<something-nilly nil=\"true\"/>")
+        end
+
+        it "uses the root option value for naming the root tag" do
+          xml = hash_serializer.serialize(simple_hash, {:root => "crazy"})
+          xml.should include("<crazy>")
+          xml.should include("</crazy>")
+        end
+
+        it "doesn't add a instruct tag before the xml result if instruct! set to false" do
+          xml = hash_serializer.serialize(simple_hash, {:skip_instruct => true})
+          xml.should_not include("<?xml version=\"1.0\" encoding=\"UTF-8\"?>")
+        end
+      end
+    end
+  end
+end

data/spec/lib/streamsend/api/unit/link_spec.rb

@@ -13,10 +13,10 @@ module StreamSend
 
       describe Index do
         it "creates a uri for blast links" do
-          stub_request(:get, "https://test:password@default.base/blasts/1/links.xml?page=1&per_page=100").
+          stub_request(:get, "https://test:password@default.base/blasts/1/links.xml").
               to_return(:status => 200, :body => xml, :headers => {'Content-Type' => 'text/xml'})
           indexer.execute(blast_id)
-          expect(indexer.uri).to eq("https://default.base/blasts/#{blast_id}/links.xml?page=1&per_page=100")
+          expect(indexer.uri).to eq("https://default.base/blasts/#{blast_id}/links.xml")
         end
       end
 

data/spec/lib/streamsend/api/unit/membership_spec.rb

@@ -17,27 +17,41 @@ module StreamSend
 
         describe Index do
           it "returns a uri for an index of memberships" do
-            stub_request(:get, "https://test:password@default.base/audiences/1/people/123/memberships.xml?page=1&per_page=100").
-              to_return(:status => 200, :body => xml, :headers => {'Content-Type' => 'text/xml'})
+            stub_request(:get, "https://test:password@default.base/audiences/1/people/123/memberships.xml").to_return(:status => 200, :body => xml, :headers => {'Content-Type' => 'text/xml'})
             indexer = Index.new(session)
             indexer.execute(person_id)
-            expect(indexer.uri).to eq("https://default.base/audiences/#{audience_id}/people/#{person_id}/memberships.xml?page=1&per_page=100")
+            expect(indexer.uri).to eq("https://default.base/audiences/#{audience_id}/people/#{person_id}/memberships.xml")
           end
 
           it "returns a uri for an index of memberships with custom paging" do
-            stub_request(:get, "https://test:password@default.base/audiences/1/people/123/memberships.xml?page=12&per_page=200").
-              to_return(:status => 200, :body => xml, :headers => {'Content-Type' => 'text/xml'})
+            stub_request(:get, "https://test:password@default.base/audiences/1/people/123/memberships.xml?page=12&per_page=200").to_return(:status => 200, :body => xml, :headers => {'Content-Type' => 'text/xml'})
             indexer = Index.new(session)
             indexer.execute(person_id, nil, options)
-            expect(indexer.uri).to eq("https://default.base/audiences/#{audience_id}/people/#{person_id}/memberships.xml?page=12&per_page=200")
+            expect(indexer.uri).to eq("https://default.base/audiences/#{audience_id}/people/#{person_id}/memberships.xml")
           end
 
           it "returns a uri for an index of memberships by list id" do
-            stub_request(:get, "https://test:password@default.base/audiences/1/people/123/lists/456/memberships.xml?page=1&per_page=100").
-              to_return(:status => 200, :body => xml, :headers => {'Content-Type' => 'text/xml'})
+            stub_request(:get, "https://test:password@default.base/audiences/1/people/123/lists/456/memberships.xml").to_return(:status => 200, :body => xml, :headers => {'Content-Type' => 'text/xml'})
             indexer = Index.new(session)
             indexer.execute(person_id, list_id)
-            expect(indexer.uri).to eq("https://default.base/audiences/#{audience_id}/people/#{person_id}/lists/#{list_id}/memberships.xml?page=1&per_page=100")
+            expect(indexer.uri).to eq("https://default.base/audiences/#{audience_id}/people/#{person_id}/lists/#{list_id}/memberships.xml")
+          end
+        end
+
+        describe Count do
+          it "builds a people count URI" do
+            stub_request(:get, "https://test:password@default.base/audiences/1/people/123/memberships/count.xml").to_return(:status => 200, :body => xml, :headers => {'Content-Type' => 'text/xml'})
+            counter = Count.new(session)
+            counter.execute(person_id)
+            expect(counter.uri).to eq("https://default.base/audiences/#{audience_id}/people/#{person_id}/memberships/count.xml")
+          end
+
+          it "builds a lists count URI" do
+            stub_request(:get, "https://test:password@default.base/audiences/1/lists/456/memberships/count.xml").to_return(:status => 200, :body => xml, :headers => {'Content-Type' => 'text/xml'})
+            counter = Count.new(session)
+            counter.execute(nil, list_id)
+            expect(counter.uri).to eq("https://default.base/audiences/#{audience_id}/lists/#{list_id}/memberships/count.xml")
+
           end
         end
       end

data/spec/lib/streamsend/api/unit/person_spec.rb

@@ -22,17 +22,16 @@ module StreamSend
 
         describe Index do
           it "returns a uri for a person index" do
-            stub_request(:get, "https://test:password@default.base/audiences/1/people.xml?page=1&per_page=100").
+            stub_request(:get, "https://test:password@default.base/audiences/1/people.xml").
               to_return(:status => 200, :body => xml, :headers => {'Content-Type' => 'text/xml'})
             indexer.execute
-            expect(indexer.uri).to eq("https://default.base/audiences/1/people.xml?page=1&per_page=100")
+            expect(indexer.uri).to eq("https://default.base/audiences/1/people.xml")
           end
 
           it "returns a uri with custom paging" do
-            stub_request(:get, "https://test:password@default.base/audiences/1/people.xml?page=12&per_page=222").
-              to_return(:status => 200, :body => xml, :headers => {'Content-Type' => 'text/xml'})
+            stub_request(:get, "https://test:password@default.base/audiences/1/people.xml?page=12&per_page=222").to_return(:status => 200, :body => xml, :headers => {'Content-Type' => 'text/xml'})
             indexer.execute(nil, options)
-            expect(indexer.uri).to eq("https://default.base/audiences/1/people.xml?page=12&per_page=222")
+            expect(indexer.uri).to eq("https://default.base/audiences/1/people.xml")
           end
 
           it "returns a uri with a scoping by list" do
@@ -46,17 +45,17 @@ module StreamSend
         describe Click do
           let(:clicker){ StreamSend::Api::Person::Click.new(session) }
           it "creates a uri for blast click people" do
-            stub_request(:get, "https://test:password@default.base/blasts/1/clicks/people.xml?page=1&per_page=100").
+            stub_request(:get, "https://test:password@default.base/blasts/1/clicks/people.xml").
               to_return(:status => 200, :body => xml, :headers => {'Content-Type' => 'text/xml'})
             clicker.execute(blast_id)
-            expect(clicker.uri).to eq("https://default.base/blasts/#{blast_id}/clicks/people.xml?page=1&per_page=100")
+            expect(clicker.uri).to eq("https://default.base/blasts/#{blast_id}/clicks/people.xml")
           end
 
           it "creates  uri for specific link click people" do
-            stub_request(:get, "https://test:password@default.base/blasts/1/links/1/clicks/people.xml?page=1&per_page=100").
+            stub_request(:get, "https://test:password@default.base/blasts/1/links/1/clicks/people.xml").
               to_return(:status => 200, :body => xml, :headers => {"Content-type" => "text/xml"})
             clicker.execute(blast_id, link_id)
-            expect(clicker.uri).to eq("https://default.base/blasts/#{blast_id}/links/#{link_id}/clicks/people.xml?page=1&per_page=100")
+            expect(clicker.uri).to eq("https://default.base/blasts/#{blast_id}/links/#{link_id}/clicks/people.xml")
           end
         end
 
@@ -67,10 +66,10 @@ module StreamSend
         let(:blast_id){ 1 }
 
           it "creates a uri for blast view people" do
-            stub_request(:get, "https://test:password@default.base/blasts/1/views/people.xml?page=1&per_page=100").
+            stub_request(:get, "https://test:password@default.base/blasts/1/views/people.xml").
               to_return(:status => 200, :body => xml, :headers => {"Content-type" => "text/xml"})
             peopler.execute(blast_id)
-            expect(peopler.uri).to eq("https://default.base/blasts/#{blast_id}/views/people.xml?page=1&per_page=100")
+            expect(peopler.uri).to eq("https://default.base/blasts/#{blast_id}/views/people.xml")
           end
         end