streamingly 0.2.6 → 0.2.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: eb1beb209148a563eaf9fc4f4d635607aceeebe3
-  data.tar.gz: 8631b810159e70ad32b5b2f34d5c811f1867cec5
+  metadata.gz: fc109e04512bb35ddda55ac4c5fb3382de3721a0
+  data.tar.gz: db45a7738730ee44d8e81cb8af84d65e84c8a70a
 SHA512:
-  metadata.gz: 50b045493f03acd398b1ab93955472b93c07842b01e6446bd338250c224652b0d4a5d4a1f14e04c8d476ecb63a16954fc356742f82e16b55877f2ddbeb6e2988
-  data.tar.gz: 959f72ea4361803e7439dd7241b8f666f23bc39b0334c9d4f2b9cebf531b627b3bea2046b05773f4104127056535954c661c22b9638f27ca41b1b5c7573cfeaa
+  metadata.gz: e84efeb36af91513a007fea9649576449a90b210bbc4794933e6f87eae06eb04e6b39115afc8c50bf69e63b116c607e8844d9dc0a1dbc8254f2518d4239a3028
+  data.tar.gz: 282203153fb041b9ca631255b2b6069b28d91050868a9f5dbfebb828e6f5dc2d8350628406695ea5d0663f700cbefa5255106d5fc2448a111c7552cfdc57e3ba

data/lib/streamingly/reducer.rb

@@ -20,7 +20,12 @@ module Streamingly
 
     end
 
-  private
+    def on_error(error, error_context)
+      raise error unless @error_callback_defined && !@accumulator.nil?
+      @accumulator.on_error(error, error_context)
+    end
+
+    private
 
     def flush
       @accumulator ? (@accumulator.flush || []).compact : []
@@ -52,11 +57,6 @@ module Streamingly
       []
     end
 
-    def on_error(error, error_context)
-      raise error unless @error_callback_defined && !@accumulator.nil?
-      @accumulator.on_error(error, error_context)
-    end
-
     def new_accumulator(key)
       if @accumulator_options
         @accumulator_class.new(key, @accumulator_options)

data/lib/streamingly/serde_iterable.rb

@@ -14,7 +14,7 @@ module Streamingly
           yield Streamingly::SerDe.from_tabbed_csv(line)
         rescue => error
           if @error_callback_defined
-            @error_handler.send(:on_error, error, line: line)
+            @error_handler.on_error(error, line: line)
           else
             raise error
           end

data/lib/streamingly/version.rb

@@ -1,3 +1,3 @@
 module Streamingly
-  VERSION = '0.2.6'
+  VERSION = '0.2.7'
 end

data/spec/streamingly/reducer_spec.rb

@@ -41,6 +41,12 @@ describe Streamingly::Reducer do
   let(:accumulator_class) { double(:accumulator_class, :method_defined? => true) }
   subject { described_class.new(accumulator_class) }
 
+  describe '#on_error' do
+    it 'is exposed as public method' do
+      expect(subject).to respond_to(:on_error)
+    end
+  end
+
   describe "#reduce_over" do
 
     context "given records with the same key" do

data/spec/streamingly/serde_iterable_spec.rb

@@ -1,5 +1,11 @@
 require 'spec_helper'
 
+class TestErrorHandler
+  def on_error(error, context)
+    nil
+  end
+end
+
 describe Streamingly::SerDeIterable do
   let(:iterable) { [1] }
   let(:error) { StandardError.new('error') }
@@ -17,7 +23,7 @@ describe Streamingly::SerDeIterable do
   end
 
   describe 'given custom error handler' do
-    let(:error_handler) { double(:error_handler, respond_to?: true) }
+    let(:error_handler) { TestErrorHandler.new }
     subject { described_class.new(iterable, error_handler) }
 
     it 'calls on_error method of provided handler' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: streamingly
 version: !ruby/object:Gem::Version
-  version: 0.2.6
+  version: 0.2.7
 platform: ruby
 authors:
 - Matt Gillooly