streamingly 0.2.4 → 0.2.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 457684ce6e8d5dcbfcdd75109553506abad640f0
-  data.tar.gz: c6164ac662cac7e76bde51fed2815b70dbeb3d70
+  metadata.gz: eb1beb209148a563eaf9fc4f4d635607aceeebe3
+  data.tar.gz: 8631b810159e70ad32b5b2f34d5c811f1867cec5
 SHA512:
-  metadata.gz: 349c229ca5a8e0d843675b472232331d23d98ddd4570fcbeb18c1d9e09ef35d188252ab550aca1f42ec5208b437f35dfa99b961f7f81dcad9d1e1200c746813d
-  data.tar.gz: 576499b30eca318bea397c193321003f1e896ff9127425e48e24a4d1488deafbc92e017165810973c05787a75330aaa7e92a9babe548c081d105419b018465a2
+  metadata.gz: 50b045493f03acd398b1ab93955472b93c07842b01e6446bd338250c224652b0d4a5d4a1f14e04c8d476ecb63a16954fc356742f82e16b55877f2ddbeb6e2988
+  data.tar.gz: 959f72ea4361803e7439dd7241b8f666f23bc39b0334c9d4f2b9cebf531b627b3bea2046b05773f4104127056535954c661c22b9638f27ca41b1b5c7573cfeaa

data/.travis.yml

@@ -0,0 +1,3 @@
+language: ruby
+rvm:
+  - 2.2.2

data/lib/streamingly/serde_iterable.rb

@@ -1,13 +1,24 @@
 module Streamingly
 
   class SerDeIterable
-    def initialize(iterable)
+    def initialize(iterable, error_handler = nil)
       @iterable = iterable
+      @error_handler = error_handler
+      @error_callback_defined = @error_handler &&
+                                @error_handler.respond_to?(:on_error)
     end
 
     def each
       @iterable.each do |line|
-        yield Streamingly::SerDe.from_tabbed_csv(line)
+        begin
+          yield Streamingly::SerDe.from_tabbed_csv(line)
+        rescue => error
+          if @error_callback_defined
+            @error_handler.send(:on_error, error, line: line)
+          else
+            raise error
+          end
+        end
       end
     end
   end

data/lib/streamingly/version.rb

@@ -1,3 +1,3 @@
 module Streamingly
-  VERSION = '0.2.4'
+  VERSION = '0.2.6'
 end

data/spec/spec_helper.rb

@@ -7,7 +7,6 @@ require 'streamingly'
 #
 # See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
 RSpec.configure do |config|
-  config.treat_symbols_as_metadata_keys_with_true_values = true
   config.run_all_when_everything_filtered = true
   config.filter_run :focus
 

data/spec/streamingly/reducer_spec.rb

@@ -58,12 +58,13 @@ describe Streamingly::Reducer do
       let(:accumulator) { double(:accumulator, :flush => []) }
 
       before do
-        accumulator_class.stub(:new).with(key) { accumulator }
+        allow(accumulator_class).to \
+          receive(:new).with(key).and_return(accumulator)
       end
 
       it "combines them into the same accumulator" do
-        accumulator.should_receive(:apply_value).with(value1)
-        accumulator.should_receive(:apply_value).with(value2)
+        expect(accumulator).to receive(:apply_value).with(value1)
+        expect(accumulator).to receive(:apply_value).with(value2)
 
         subject.reduce_over(records)
       end
@@ -86,13 +87,15 @@ describe Streamingly::Reducer do
       let(:accumulator2) { double(:accumulator, :flush => []) }
 
       before do
-        accumulator_class.stub(:new).with(key1) { accumulator1 }
-        accumulator_class.stub(:new).with(key2) { accumulator2 }
+        allow(accumulator_class).to \
+          receive(:new).with(key1).and_return(accumulator1)
+        allow(accumulator_class).to \
+          receive(:new).with(key2).and_return(accumulator2)
       end
 
       it "sends them to different accumulators" do
-        accumulator1.should_receive(:apply_value).with(value1)
-        accumulator2.should_receive(:apply_value).with(value2)
+        expect(accumulator1).to receive(:apply_value).with(value1)
+        expect(accumulator2).to receive(:apply_value).with(value2)
 
         subject.reduce_over(records)
       end
@@ -111,11 +114,12 @@ describe Streamingly::Reducer do
       let(:accumulator) { double(:accumulator, :flush => []) }
 
       before do
-        accumulator_class.stub(:new).with(key) { accumulator }
+        allow(accumulator_class).to \
+          receive(:new).with(key).and_return(accumulator)
       end
 
       it "treats only the first tab as the key/value delimiter and leaves the value untouched" do
-        accumulator.should_receive(:apply_value).with(value)
+        expect(accumulator).to receive(:apply_value).with(value)
 
         subject.reduce_over(records)
       end
@@ -136,7 +140,8 @@ describe Streamingly::Reducer do
 
       context "with error callback specified" do
         before do
-          accumulator_class.stub(:new).with(key) { accumulator }
+          allow(accumulator_class).to \
+            receive(:new).with(key).and_return(accumulator)
         end
 
         it "keeps processing after error applying value" do
@@ -163,7 +168,8 @@ describe Streamingly::Reducer do
         subject { described_class.new(accumulator_class) }
 
         before do
-            accumulator_class.stub(:new).with(key) { accumulator }
+          allow(accumulator_class).to \
+            receive(:new).with(key).and_return(accumulator)
         end
 
         it "stops processing after error applying value" do
@@ -193,8 +199,10 @@ describe Streamingly::Reducer do
 
       context "with error callback specified" do
         before do
-          accumulator_class.stub(:new).with(key1) { accumulator1 }
-          accumulator_class.stub(:new).with(key2) { accumulator2 }
+          allow(accumulator_class).to \
+            receive(:new).with(key1).and_return(accumulator1)
+          allow(accumulator_class).to \
+            receive(:new).with(key2).and_return(accumulator2)
         end
 
         it "keeps processing after error applying value" do
@@ -224,8 +232,10 @@ describe Streamingly::Reducer do
         subject { described_class.new(accumulator_class) }
 
         before do
-          accumulator_class.stub(:new).with(key1) { accumulator1 }
-          accumulator_class.stub(:new).with(key2) { accumulator2 }
+          allow(accumulator_class).to \
+            receive(:new).with(key1).and_return(accumulator1)
+          allow(accumulator_class).to \
+            receive(:new).with(key2).and_return(accumulator2)
         end
 
         it "stops processing after error applying value" do
@@ -256,11 +266,12 @@ describe Streamingly::Reducer do
       let(:accumulator) { double(:accumulator, :flush => []) }
 
       before do
-        accumulator_class.stub(:new).with(key, accumulator_options) { accumulator }
+        allow(accumulator_class).to \
+          receive(:new).with(key, accumulator_options).and_return(accumulator)
       end
 
       it "uses the accumulator_options to initialize each accumulator" do
-        accumulator.should_receive(:apply_value).with(value)
+        expect(accumulator).to receive(:apply_value).with(value)
 
         subject.reduce_over(records)
       end

data/spec/streamingly/serde_iterable_spec.rb

@@ -0,0 +1,28 @@
+require 'spec_helper'
+
+describe Streamingly::SerDeIterable do
+  let(:iterable) { [1] }
+  let(:error) { StandardError.new('error') }
+
+  before do
+    allow(Streamingly::SerDe).to receive(:from_tabbed_csv).and_raise(error)
+  end
+
+  describe 'no error handler given' do
+    subject { described_class.new(iterable) }
+
+    it 'raises error when calling each' do
+      expect { subject.each }.to raise_error(StandardError)
+    end
+  end
+
+  describe 'given custom error handler' do
+    let(:error_handler) { double(:error_handler, respond_to?: true) }
+    subject { described_class.new(iterable, error_handler) }
+
+    it 'calls on_error method of provided handler' do
+      expect(error_handler).to receive(:on_error).with(error, line: 1)
+      expect { subject.each }.to_not raise_error
+    end
+  end
+end

data/streamingly.gemspec

@@ -18,8 +18,8 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_development_dependency "bundler", "~> 1.3"
+  spec.add_development_dependency "bundler", "~> 1.10"
   spec.add_development_dependency "pry"
   spec.add_development_dependency "rake"
-  spec.add_development_dependency "rspec", "~> 2.11"
+  spec.add_development_dependency "rspec", "~> 3.4.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: streamingly
 version: !ruby/object:Gem::Version
-  version: 0.2.4
+  version: 0.2.6
 platform: ruby
 authors:
 - Matt Gillooly
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-08-19 00:00:00.000000000 Z
+date: 2016-01-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '1.10'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '1.10'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
@@ -58,14 +58,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.11'
+        version: 3.4.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.11'
+        version: 3.4.0
 description: Helpful classes for writing streaming Hadoop jobs in Ruby
 email:
 - matt@swipely.com
@@ -75,6 +75,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".travis.yml"
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -87,6 +88,7 @@ files:
 - lib/streamingly/version.rb
 - spec/spec_helper.rb
 - spec/streamingly/reducer_spec.rb
+- spec/streamingly/serde_iterable_spec.rb
 - spec/streamingly/serde_spec.rb
 - streamingly.gemspec
 homepage: http://github.com/swipely/streamingly
@@ -116,4 +118,5 @@ summary: Helpful classes for writing streaming Hadoop jobs in Ruby
 test_files:
 - spec/spec_helper.rb
 - spec/streamingly/reducer_spec.rb
+- spec/streamingly/serde_iterable_spec.rb
 - spec/streamingly/serde_spec.rb