strata-cli 0.1.3.beta → 0.1.5.beta

data/lib/strata/cli/utils/import_manager.rb

@@ -16,9 +16,9 @@ module Strata
         LOCK_FILE = "strata.lock"
 
         def validate_import_path(import_path)
-          if Pathname.new(import_path).absolute?
-            raise Strata::InvalidImportPathError, "Import paths must be relative, not absolute: #{import_path}"
-          end
+          return unless Pathname.new(import_path).absolute?
+
+          raise Strata::InvalidImportPathError, "Import paths must be relative, not absolute: #{import_path}"
         end
 
         def track_external_import(import_path, resolved_path, project_path)
@@ -58,9 +58,7 @@ module Strata
 
           resolved_path = File.expand_path(import_path, base_dir)
 
-          unless File.exist?(resolved_path)
-            raise Strata::MissingImportError, "Import file not found: #{import_path}"
-          end
+          raise Strata::MissingImportError, "Import file not found: #{import_path}" unless File.exist?(resolved_path)
 
           # Track external imports in lock file
           track_external_import(import_path, resolved_path, project_path)
@@ -77,14 +75,14 @@ module Strata
             next unless entry["source"] && File.exist?(entry["source"])
 
             current_hash = file_hash(entry["source"])
-            if current_hash != entry["hash"]
-              changed << {
-                path: entry["path"],
-                source: entry["source"],
-                old_hash: entry["hash"],
-                new_hash: current_hash
-              }
-            end
+            next unless current_hash != entry["hash"]
+
+            changed << {
+              path: entry["path"],
+              source: entry["source"],
+              old_hash: entry["hash"],
+              new_hash: current_hash
+            }
           end
 
           changed
@@ -99,15 +97,15 @@ module Strata
             next unless entry["source"] && File.exist?(entry["source"])
 
             current_hash = file_hash(entry["source"])
-            if current_hash != entry["hash"]
-              entry["hash"] = current_hash
-              entry["imported_at"] = Time.now.utc.iso8601
-              refreshed << {
-                path: entry["path"],
-                source: entry["source"],
-                hash: current_hash
-              }
-            end
+            next unless current_hash != entry["hash"]
+
+            entry["hash"] = current_hash
+            entry["imported_at"] = Time.now.utc.iso8601
+            refreshed << {
+              path: entry["path"],
+              source: entry["source"],
+              hash: current_hash
+            }
           end
 
           save_lock_file(project_path, lock_data) if refreshed.any?

data/lib/strata/cli/utils/test_reporter.rb

@@ -58,15 +58,15 @@ module Strata
           failed = tests.count { |t| t["status"] == "failed" }
           errors = tests.count { |t| t["status"] == "error" }
 
-          say "\n" + "=" * 60, :border unless skip_opening_divider
+          say "\n#{"=" * 60}", :border unless skip_opening_divider
           say "\n Tests ran: #{total} total, #{passed} passed", :info
-          say "   #{failed} failed, #{errors} error#{"s" if errors != 1}" if failed > 0 || errors > 0
-          say "\n" + "=" * 60, :border
+          say "   #{failed} failed, #{errors} error#{"s" if errors != 1}" if failed.positive? || errors.positive?
+          say "\n#{"=" * 60}", :border
         end
 
         def display_failures(test_results)
           tests = test_results["tests"] || []
-          failed_tests = tests.select { |t| t["status"] == "failed" || t["status"] == "error" }
+          failed_tests = tests.select { |t| %w[failed error].include?(t["status"]) }
 
           return if failed_tests.empty?
 
@@ -89,41 +89,32 @@ module Strata
           end
 
           # Display assertion failure details
-          if test["assertion_type"]
-            say "   Assertion failed: #{test["assertion_type"]}", :error
-          end
+          say "   Assertion failed: #{test["assertion_type"]}", :error if test["assertion_type"]
 
-          if test["message"]
-            say "   #{test["message"]}", :error
-          end
+          say "   #{test["message"]}", :error if test["message"]
 
           # Show expected vs generated SQL for debugging
-          if test["expected_sql"]
-            say "   Expected: #{truncate(test["expected_sql"], 100)}", :error
-          end
+          say "   Expected: #{truncate(test["expected_sql"], 100)}", :error if test["expected_sql"]
 
-          if test["pattern"]
-            say "   Pattern: #{test["pattern"]}", :error
-          end
+          say "   Pattern: #{test["pattern"]}", :error if test["pattern"]
 
-          if test["generated_sql"]
-            say "   Generated: #{truncate(test["generated_sql"], 200)}", :error
-          end
+          say "   Generated: #{truncate(test["generated_sql"], 200)}", :error if test["generated_sql"]
 
-          if test["failing_values"]&.is_a?(Array) && test["failing_values"].any?
-            sample_values = test["failing_values"].first(5)
-            say "   Sample failing values: #{sample_values.inspect}", :error
-          end
+          return unless test["failing_values"].is_a?(Array) && test["failing_values"].any?
+
+          sample_values = test["failing_values"].first(5)
+          say "   Sample failing values: #{sample_values.inspect}", :error
         end
 
         def truncate(str, max_length)
           return str if str.nil? || str.length <= max_length
-          str[0, max_length] + "..."
+
+          "#{str[0, max_length]}..."
         end
 
         def has_failures?(test_results)
           tests = test_results["tests"] || []
-          tests.any? { |t| t["status"] == "failed" || t["status"] == "error" }
+          tests.any? { |t| %w[failed error].include?(t["status"]) }
         end
       end
     end

data/lib/strata/cli/utils/version_checker.rb

@@ -14,7 +14,7 @@ module Strata
         module_function
 
         GEM_NAME = "strata-cli"
-        RUBYGEMS_API_URL = "https://rubygems.org/api/v1/gems/#{GEM_NAME}.json"
+        RUBYGEMS_API_URL = "https://rubygems.org/api/v1/gems/#{GEM_NAME}.json".freeze
         CACHE_FILE = File.join(ENV.fetch("TMPDIR", "/tmp"), "strata-cli-version-check-cache")
         CACHE_DURATION = 86_400 # 24 hours in seconds
 
@@ -24,9 +24,7 @@ module Strata
           latest_version = fetch_latest_version
           return unless latest_version
 
-          if newer_version_available?(current_version, latest_version)
-            display_update_message(latest_version)
-          end
+          display_update_message(latest_version) if newer_version_available?(current_version, latest_version)
 
           update_cache
         rescue
@@ -40,8 +38,8 @@ module Strata
 
           # Simple version comparison (assumes semantic versioning)
           # Convert non-numeric parts (like "beta") to 0 for comparison
-          current_parts = current.split(".").map { |p| p.to_i }
-          latest_parts = latest.split(".").map { |p| p.to_i }
+          current_parts = current.split(".").map(&:to_i)
+          latest_parts = latest.split(".").map(&:to_i)
 
           # Pad with zeros if needed
           max_length = [current_parts.length, latest_parts.length].max

data/lib/strata/cli/utils/yaml_import_resolver.rb

@@ -15,7 +15,10 @@ module Strata
           return {} unless File.exist?(file_path)
 
           absolute_path = File.expand_path(file_path)
-          raise Strata::CircularImportError, "Circular import detected: #{format_cycle(visited, absolute_path)}" if visited.include?(absolute_path)
+          if visited.include?(absolute_path)
+            raise Strata::CircularImportError,
+              "Circular import detected: #{format_cycle(visited, absolute_path)}"
+          end
 
           visited.add(absolute_path)
           content = YAML.safe_load_file(file_path, permitted_classes: [Date, Time], aliases: true)
@@ -24,7 +27,7 @@ module Strata
           resolved_content = content.dup
           resolved_content.delete("imports")
 
-          if content["imports"]&.is_a?(Array)
+          if content["imports"].is_a?(Array)
             merged_fields = resolve_imports(content["imports"], file_path, project_path, visited)
             resolved_content["fields"] = merge_fields(merged_fields, content["fields"] || [])
           else

data/lib/strata/cli/utils.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Strata
   module CLI
     module Utils

data/lib/strata/cli/version.rb

@@ -2,6 +2,6 @@
 
 module Strata
   module CLI
-    VERSION = "0.1.3.beta"
+    VERSION = "0.1.5.beta"
   end
 end

data/lib/strata/cli.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "thor"
 require "dwh"
 require_relative "cli/version"
@@ -6,6 +8,7 @@ require_relative "cli/main"
 require_relative "cli/utils"
 require_relative "cli/utils/git"
 require_relative "cli/utils/version_checker"
+require_relative "cli/error_reporter"
 
 module Strata
   class StrataError < StandardError; end
@@ -36,6 +39,11 @@ module Strata
       rescue TTY::Reader::InputInterrupt
         warn "\nCancelled."
         exit(1)
+      rescue => e
+        ErrorReporter.log_error(e, context: "strata #{args.join(" ")}")
+        warn "ERROR: #{ErrorReporter.user_message_for(e)}"
+        warn "Hint: See #{ErrorReporter.log_relative_path} for details."
+        exit(1)
       end
 
       Utils::VersionChecker.check_and_notify_if_needed(VERSION, args)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: strata-cli
 version: !ruby/object:Gem::Version
-  version: 0.1.3.beta
+  version: 0.1.5.beta
 platform: ruby
 authors:
 - Ajo Abraham
@@ -25,7 +25,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 0.1.0
 - !ruby/object:Gem::Dependency
-  name: pg
+  name: aws-sdk-athena
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
@@ -39,63 +39,63 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '1.0'
 - !ruby/object:Gem::Dependency
-  name: mysql2
+  name: aws-sdk-s3
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.5'
+        version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.5'
+        version: '1.0'
 - !ruby/object:Gem::Dependency
-  name: tiny_tds
+  name: faraday
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
-  name: trino-client
+  name: mysql2
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '0.5'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '0.5'
 - !ruby/object:Gem::Dependency
-  name: aws-sdk-athena
+  name: pastel
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '0.8'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '0.8'
 - !ruby/object:Gem::Dependency
-  name: aws-sdk-s3
+  name: pg
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
@@ -109,19 +109,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '1.0'
 - !ruby/object:Gem::Dependency
-  name: faraday
+  name: ruby_llm
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
@@ -137,47 +137,47 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '2.0'
 - !ruby/object:Gem::Dependency
-  name: pastel
+  name: thor
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: 1.3.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: 1.3.2
 - !ruby/object:Gem::Dependency
-  name: ruby_llm
+  name: tiny_tds
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '3.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
-  name: thor
+  name: trino-client
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.3.2
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.3.2
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: tty-prompt
   requirement: !ruby/object:Gem::Requirement
@@ -233,6 +233,7 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
+- ".rubocop.yml"
 - ".standard.yml"
 - CHANGELOG.md
 - CLAUDE.md
@@ -260,6 +261,7 @@ files:
 - lib/strata/cli/descriptions/deploy/deploy.txt
 - lib/strata/cli/descriptions/deploy/status.txt
 - lib/strata/cli/descriptions/init.txt
+- lib/strata/cli/error_reporter.rb
 - lib/strata/cli/generators/datasource.rb
 - lib/strata/cli/generators/group.rb
 - lib/strata/cli/generators/migration.rb
@@ -330,7 +332,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.9
+rubygems_version: 3.6.7
 specification_version: 4
 summary: Command-line interface for the Strata Semantic Analytics System
 test_files: []