stp_client 0.3.0 → 0.4.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b35312a692c39818b9fb03f02b10dae9ed44de79d1333b64ef7da23bbdb4e638
-  data.tar.gz: 65902abc627a5de9e20e37e213744f0f77c8c44571d8c5000c4a75151a4e5741
+  metadata.gz: 4013736c66bd4b1905fdc7393826500b44bd0c14d0e84be0ff4279185a24d993
+  data.tar.gz: 404bf60f4fc4b46329715d7688f0d6477f0dc05b2935102cd52f0fa18e87737d
 SHA512:
-  metadata.gz: 675889febf324cfbca754443c114b0c99ca3499142ecf471bbe61588c07adf19e6dc7f8aaf7f4989ba79b126216d4d2790447a6f9c12fe1613b8b785394c58bc
-  data.tar.gz: d1f14ac8556e19d1677e34d2c37d98eb6b86c51f88f157e4a2333c2dde26136e1e2e06af4349b26777469fd9b629170107328708f88d5844262268ecb000d92a
+  metadata.gz: f20436a5e1744208f2d215f12842b840f7c998c87020f671997e705c3e95d59abb1e6e02cf5df3db75320eaf613d26d65b5d0af0f7aa47a58385bef8b41fdf1e
+  data.tar.gz: 5d0eabdea19253004e4cdd1b6d82d791fd30b5b61f4eebb162ab94125bf07a1e337aa6b19e5b49dcad1bc8c5c8dac860729534275c884a166b73ee4fe75ba60d

data/Gemfile.lock

@@ -1,16 +1,16 @@
 PATH
   remote: .
   specs:
-    stp_client (0.2.1)
+    stp_client (0.4.3)
       crypto_yellowme (~> 0.4)
       faraday (~> 1.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activemodel (5.2.4.1)
-      activesupport (= 5.2.4.1)
-    activesupport (5.2.4.1)
+    activemodel (5.2.4.3)
+      activesupport (= 5.2.4.3)
+    activesupport (5.2.4.3)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 0.7, < 2)
       minitest (~> 5.1)
@@ -18,7 +18,7 @@ GEM
     addressable (2.7.0)
       public_suffix (>= 2.0.2, < 5.0)
     bcrypt (3.1.13)
-    concurrent-ruby (1.1.5)
+    concurrent-ruby (1.1.6)
     crack (0.4.3)
       safe_yaml (~> 1.0.0)
     crypto_yellowme (0.4.0)
@@ -29,13 +29,13 @@ GEM
     docile (1.3.2)
     faker (2.10.0)
       i18n (>= 1.6, < 1.8)
-    faraday (1.0.0)
+    faraday (1.0.1)
       multipart-post (>= 1.2, < 3)
     hashdiff (1.0.1)
-    i18n (1.7.0)
+    i18n (1.7.1)
       concurrent-ruby (~> 1.0)
     json (2.3.0)
-    minitest (5.13.0)
+    minitest (5.14.1)
     multipart-post (2.1.1)
     public_suffix (4.0.3)
     rspec (3.9.0)
@@ -58,7 +58,7 @@ GEM
       simplecov-html (~> 0.10.0)
     simplecov-html (0.10.2)
     thread_safe (0.3.6)
-    tzinfo (1.2.6)
+    tzinfo (1.2.7)
       thread_safe (~> 0.1)
     webmock (3.4.2)
       addressable (>= 2.3.6)
@@ -76,4 +76,4 @@ DEPENDENCIES
   webmock (~> 3.4.2)
 
 BUNDLED WITH
-   2.0.2
+   2.1.2

data/lib/stp.rb

@@ -5,7 +5,8 @@ require 'stp/structs/account'
 require 'stp/structs/payment_order'
 require 'stp/account'
 require 'stp/payment_order'
-require 'stp/stp_error'
+require 'stp/errors/stp_error'
+require 'stp/errors/account_already_exists'
 
 module STP
   def self.config
@@ -43,4 +44,12 @@ module STP
   def self.company
     @company
   end
+
+  def self.verbose
+    @verbose
+  end
+
+  def self.verbose=(verbose)
+    @verbose = verbose
+  end
 end

data/lib/stp/account.rb

@@ -8,8 +8,10 @@ module STP
         req.headers['Content-Type'] = 'application/json'
         req.body = account.to_json
       end
+      puts response.body if STP.verbose
       hash = JSON.parse(response.body)
-      raise STP::STPError.new(hash['message']) unless hash['id'] == 0
+      raise STP::Errors::AccountAlreadyExists.new(hash['id'], hash['descripcion']) if hash['id'] == 1 && hash['descripcion'] == 'Cuenta Duplicada'
+      raise STP::Errors::STPError.new(hash['id'], hash['descripcion']) unless hash['id'] == 0
     end
 
     def self.delete(account)
@@ -20,8 +22,9 @@ module STP
         req.headers['Content-Type'] = 'application/json'
         req.body = account.to_json
       end
+      puts response.body if STP.verbose
       hash = JSON.parse(response.body)
-      raise STP::STPError.new(hash['message']) unless hash['id'] == 0
+      raise STP::Errors::STPError.new(hash['id'], hash['descripcion']) unless hash['id'] == 0
     end
   end
 end

data/lib/stp/errors/account_already_exists.rb

@@ -0,0 +1,6 @@
+module STP
+  module Errors
+    class AccountAlreadyExists < STPError
+    end
+  end
+end

data/lib/stp/errors/stp_error.rb

@@ -0,0 +1,18 @@
+module STP
+  module Errors
+    class STPError < StandardError
+      def initialize(code = nil, message = nil)
+        @code = code
+        @message = message
+      end
+
+      def to_h
+        { code: @code, message: @message }
+      end
+
+      def to_s
+        to_h.to_s
+      end
+    end
+  end
+end

data/lib/stp/structs/account.rb

@@ -13,7 +13,7 @@ module STP
                     :economic_activity,                  # actividadEconomica
                     :street,                             # calle
                     :exterior_number,                    # numeroExterior
-                    :interior_nunmber,                   # numeroInterior
+                    :interior_number,                    # numeroInterior
                     :neighborhood,                       # colonia
                     :municipality,                       # alcaldiaMunicipio
                     :zip_code,                           # cp
@@ -34,12 +34,15 @@ module STP
       end
 
       def as_json(_options = {})
+        name = @name.present? ? I18n.transliterate(@name) : nil,
+        paternal_surname = @paternal_surname.present? ? I18n.transliterate(@paternal_surname) : nil,
+        maternal_surname = @maternal_surname.present? ? I18n.transliterate(@maternal_surname) : nil,
         {
           cuenta: @account,
           empresa: @company,
-          nombre: @name,
-          apellidoPaterno: @paternal_surname,
-          apellidoMaterno: @maternal_surname,
+          nombre: name,
+          apellidoPaterno: paternal_surname,
+          apellidoMaterno: maternal_surname,
           rfcCurp: @rfc,
           fechaNacimiento: @birthdate,
           genero: @sex,
@@ -47,7 +50,7 @@ module STP
           actividadEconomica: @economic_activity,
           calle: @street,
           numeroExterior: @exterior_number,
-          numeroInterior: @interior_nunmber,
+          numeroInterior: @interior_number,
           colonia: @neighborhood,
           alcaldiaMunicipio: @municipality,
           cp: @zip_code,

data/lib/stp/version.rb

@@ -1,3 +1,3 @@
 module STP
-  VERSION = '0.3.0'
+  VERSION = '0.4.4'
 end

data/spec/stp/account_create_spec.rb

@@ -21,7 +21,7 @@ RSpec.describe STP::Account do
           account.economic_activity = 'programador'
           account.street = Faker::Address.street_name
           account.exterior_number = Faker::Address.building_number
-          account.interior_nunmber = Faker::Address.building_number
+          account.interior_number = Faker::Address.building_number
           account.neighborhood = Faker::Address.community
           account.municipality = Faker::Address.community
           account.zip_code = Faker::Number.number(digits: 5)
@@ -61,7 +61,7 @@ RSpec.describe STP::Account do
     end
 
     context 'fails when' do
-      context 'repeating account and rfcCurp' do
+      context 'random error' do
         let(:account_obj) do
           account = STP::Structs::Account.new
           account.account = '01010101'
@@ -75,7 +75,7 @@ RSpec.describe STP::Account do
           account.economic_activity = 'programador'
           account.street = Faker::Address.street_name
           account.exterior_number = Faker::Address.building_number
-          account.interior_nunmber = Faker::Address.building_number
+          account.interior_number = Faker::Address.building_number
           account.neighborhood = Faker::Address.community
           account.municipality = Faker::Address.community
           account.zip_code = Faker::Number.number(digits: 5)
@@ -92,7 +92,41 @@ RSpec.describe STP::Account do
           )
         end
 
-        it { expect {subject}.to raise_error(STP::STPError) }
+        it { expect {subject}.to raise_error(STP::Errors::STPError) }
+      end
+
+      context 'repeating account and rfcCurp' do
+        let(:account_obj) do
+          account = STP::Structs::Account.new
+          account.account = '01010101'
+          account.name = Faker::Name.first_name
+          account.paternal_surname = Faker::Name.last_name
+          account.maternal_surname = Faker::Name.last_name
+          account.rfc = 'RFC'
+          account.birthdate = Faker::Date.birthday(min_age: 6, max_age: 65)
+          account.sex = 'male'
+          account.state = 'Mérida'
+          account.economic_activity = 'programador'
+          account.street = Faker::Address.street_name
+          account.exterior_number = Faker::Address.building_number
+          account.interior_number = Faker::Address.building_number
+          account.neighborhood = Faker::Address.community
+          account.municipality = Faker::Address.community
+          account.zip_code = Faker::Number.number(digits: 5)
+          account.country = 'México'
+          account.email = Faker::Internet.email
+          account.identification_id = 'id'
+          account.phone = Faker::PhoneNumber.phone_number
+          account
+        end
+        
+        before do
+          stub_request(:put, "#{STP.api_uri}/cuentaModule/fisica").to_return(
+            body: JSON.dump(STPTestHelpers::ACCOUNT_CREATE_MOCK_ERROR(1, 'Cuenta Duplicada')), status: 200
+          )
+        end
+
+        it { expect {subject}.to raise_error(STP::Errors::AccountAlreadyExists) }
       end
     end
   end

data/spec/stp/account_delete_spec.rb

@@ -21,7 +21,7 @@ RSpec.describe STP::Account do
           account.economic_activity = 'programador'
           account.street = Faker::Address.street_name
           account.exterior_number = Faker::Address.building_number
-          account.interior_nunmber = Faker::Address.building_number
+          account.interior_number = Faker::Address.building_number
           account.neighborhood = Faker::Address.community
           account.municipality = Faker::Address.community
           account.zip_code = Faker::Number.number(digits: 5)
@@ -41,7 +41,7 @@ RSpec.describe STP::Account do
           allow(STP::Account).to receive(:create).
             and_return(STPTestHelpers::ACCOUNT_DELETE_MOCK_SUCCESS())
         end
-        
+
         before do
           stub_request(:delete, "#{STP.api_uri}/cuentaModule/fisica").to_return(
             body: JSON.dump(STPTestHelpers::ACCOUNT_DELETE_MOCK_SUCCESS()), status: 200
@@ -59,7 +59,7 @@ RSpec.describe STP::Account do
           account.rfc = 'RFCURP'
           account
         end
-        
+
         before do
           stub_request(:delete, "#{STP.api_uri}/cuentaModule/fisica").to_return(
             body: JSON.dump(STPTestHelpers::ACCOUNT_DELETE_MOCK_SUCCESS()), status: 200
@@ -85,7 +85,7 @@ RSpec.describe STP::Account do
           account.economic_activity = 'programador'
           account.street = Faker::Address.street_name
           account.exterior_number = Faker::Address.building_number
-          account.interior_nunmber = Faker::Address.building_number
+          account.interior_number = Faker::Address.building_number
           account.neighborhood = Faker::Address.community
           account.municipality = Faker::Address.community
           account.zip_code = Faker::Number.number(digits: 5)
@@ -95,14 +95,14 @@ RSpec.describe STP::Account do
           account.phone = Faker::PhoneNumber.phone_number
           account
         end
-        
+
         before do
           stub_request(:delete, "#{STP.api_uri}/cuentaModule/fisica").to_return(
             body: JSON.dump(STPTestHelpers::ACCOUNT_DELETE_MOCK_ERROR(-2)), status: 200
           )
         end
 
-        it { expect {subject}.to raise_error(STP::STPError) }
+        it { expect {subject}.to raise_error(STP::Errors::STPError) }
       end
     end
   end

data/spec/stp/payment_order_spec.rb

@@ -96,7 +96,7 @@ RSpec.describe STP::PaymentOrder do
         end
 
         it { expect(subject['id']).to eq -2 }
-        it { expect(subject['descripcionError']).not_to be_nil }
+        it { expect(subject['descripcion']).not_to be_nil }
       end
     end
   end

data/spec/support/stp_test_helpers.rb

@@ -1,7 +1,7 @@
 module STPTestHelpers
   def self.PAYMENT_ORDER_MOCK_ERROR(error_code)
     {
-      'descripcionError' => 'regular error msg',
+      'descripcion' => 'regular error msg',
       'id' => error_code,
     }
   end
@@ -16,9 +16,9 @@ module STPTestHelpers
     }
   end
 
-  def self.ACCOUNT_CREATE_MOCK_ERROR(error_code)
+  def self.ACCOUNT_CREATE_MOCK_ERROR(error_code, message='regular error msg')
     {
-      'descripcionError' => 'regular error msg',
+      'descripcion' => message,
       'id' => error_code,
     }
   end
@@ -32,7 +32,7 @@ module STPTestHelpers
 
   def self.ACCOUNT_DELETE_MOCK_ERROR(error_code)
     {
-      'descripcionError' => 'regular error msg',
+      'descripcion' => 'regular error msg',
       'id' => error_code,
     }
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: stp_client
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.4
 platform: ruby
 authors:
 - Yellowme
@@ -109,8 +109,9 @@ files:
 - Rakefile
 - lib/stp.rb
 - lib/stp/account.rb
+- lib/stp/errors/account_already_exists.rb
+- lib/stp/errors/stp_error.rb
 - lib/stp/payment_order.rb
-- lib/stp/stp_error.rb
 - lib/stp/structs/account.rb
 - lib/stp/structs/payment_order.rb
 - lib/stp/version.rb
@@ -141,8 +142,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: STP Client is a ruby integration to STP services

data/lib/stp/stp_error.rb

@@ -1,4 +0,0 @@
-module STP
-  class STPError < StandardError
-  end
-end