stp_client 0.2.1 → 0.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bc5b27b5570c48f3fe21db14b7ebbd0131d89d143c677b9ecb75a4d301923bf1
-  data.tar.gz: cc579b5ec5d1c93077d1c17d4a6e65f2945f3fbcc741c5937bc576f428114139
+  metadata.gz: 261c9f866c7ceb1621dcfd05ebc51a2a23fa73f816c30089b34745a1e8f16458
+  data.tar.gz: 897297e8713a5a081dc11d6a0642dd86299e09256d551217e426b514fee95e17
 SHA512:
-  metadata.gz: 3c613cab091aa0cbf59a5c807fa5d04ba12286e4f7c70e0178b190d7d847bca243a2ff3784c4516af972bb97a2ba9041cf5604dfa49dc800b555a5f2efabda69
-  data.tar.gz: b757d4944f474c1319cb1c66d5ab7234c269707b386bd0804245fc740edaf073b0c3b5788a4b73aa066508c9c27fe0dfdd58e7cc663fedc9754c973c16a6cd82
+  metadata.gz: b269d1b5c55ca547639b53ff7a2f3b11a6e99900ed87f794e7143702f8934a84337577b975ed94674794a0d3e0b3e85174ff4993f2520ac80528b486dda9421a
+  data.tar.gz: f49256bcb78005b6c0debe661eae877f77bb5dc9070cebcfa1f70701de40a7f0c77920f423373b36326b50495b196353155451f0912086e971e0157f9e115efc

data/Gemfile.lock

@@ -1,22 +1,26 @@
 PATH
   remote: .
   specs:
-    stp_client (0.2.1)
+    stp_client (0.4.2)
       crypto_yellowme (~> 0.4)
       faraday (~> 1.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activemodel (5.2.4.1)
-      activesupport (= 5.2.4.1)
-    activesupport (5.2.4.1)
+    activemodel (5.2.4.3)
+      activesupport (= 5.2.4.3)
+    activesupport (5.2.4.3)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 0.7, < 2)
       minitest (~> 5.1)
       tzinfo (~> 1.1)
+    addressable (2.7.0)
+      public_suffix (>= 2.0.2, < 5.0)
     bcrypt (3.1.13)
-    concurrent-ruby (1.1.5)
+    concurrent-ruby (1.1.6)
+    crack (0.4.3)
+      safe_yaml (~> 1.0.0)
     crypto_yellowme (0.4.0)
       activemodel (~> 5.2)
       activesupport (~> 5.0)
@@ -27,11 +31,13 @@ GEM
       i18n (>= 1.6, < 1.8)
     faraday (1.0.0)
       multipart-post (>= 1.2, < 3)
-    i18n (1.7.0)
+    hashdiff (1.0.1)
+    i18n (1.7.1)
       concurrent-ruby (~> 1.0)
     json (2.3.0)
-    minitest (5.13.0)
+    minitest (5.14.1)
     multipart-post (2.1.1)
+    public_suffix (4.0.3)
     rspec (3.9.0)
       rspec-core (~> 3.9.0)
       rspec-expectations (~> 3.9.0)
@@ -45,14 +51,19 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.9.0)
     rspec-support (3.9.2)
+    safe_yaml (1.0.5)
     simplecov (0.17.1)
       docile (~> 1.1)
       json (>= 1.8, < 3)
       simplecov-html (~> 0.10.0)
     simplecov-html (0.10.2)
     thread_safe (0.3.6)
-    tzinfo (1.2.6)
+    tzinfo (1.2.7)
       thread_safe (~> 0.1)
+    webmock (3.4.2)
+      addressable (>= 2.3.6)
+      crack (>= 0.3.2)
+      hashdiff
 
 PLATFORMS
   ruby
@@ -62,6 +73,7 @@ DEPENDENCIES
   rspec (~> 3.8)
   simplecov (~> 0.17)
   stp_client!
+  webmock (~> 3.4.2)
 
 BUNDLED WITH
    2.0.2

data/lib/stp.rb

@@ -5,6 +5,8 @@ require 'stp/structs/account'
 require 'stp/structs/payment_order'
 require 'stp/account'
 require 'stp/payment_order'
+require 'stp/errors/stp_error'
+require 'stp/errors/account_already_exists'
 
 module STP
   def self.config
@@ -42,4 +44,12 @@ module STP
   def self.company
     @company
   end
+
+  def self.verbose
+    @verbose
+  end
+
+  def self.verbose=(verbose)
+    @verbose = verbose
+  end
 end

data/lib/stp/account.rb

@@ -8,8 +8,10 @@ module STP
         req.headers['Content-Type'] = 'application/json'
         req.body = account.to_json
       end
+      puts response.body if STP.verbose
       hash = JSON.parse(response.body)
-      hash
+      raise STP::Errors::AccountAlreadyExists.new(hash['id'], hash['descripcion']) if hash['id'] == 1 && hash['descripcion'] == 'Cuenta Duplicada'
+      raise STP::Errors::STPError.new(hash['id'], hash['descripcion']) unless hash['id'] == 0
     end
 
     def self.delete(account)
@@ -20,8 +22,9 @@ module STP
         req.headers['Content-Type'] = 'application/json'
         req.body = account.to_json
       end
+      puts response.body if STP.verbose
       hash = JSON.parse(response.body)
-      hash
+      raise STP::Errors::STPError.new(hash['id'], hash['descripcion']) unless hash['id'] == 0
     end
   end
 end

data/lib/stp/errors/account_already_exists.rb

@@ -0,0 +1,6 @@
+module STP
+  module Errors
+    class AccountAlreadyExists < STPError
+    end
+  end
+end

data/lib/stp/errors/stp_error.rb

@@ -0,0 +1,18 @@
+module STP
+  module Errors
+    class STPError < StandardError
+      def initialize(code = nil, message = nil)
+        @code = code
+        @message = message
+      end
+
+      def to_h
+        { code: @code, message: @message }
+      end
+
+      def to_s
+        to_h.to_s
+      end
+    end
+  end
+end

data/lib/stp/structs/account.rb

@@ -13,7 +13,7 @@ module STP
                     :economic_activity,                  # actividadEconomica
                     :street,                             # calle
                     :exterior_number,                    # numeroExterior
-                    :interior_nunmber,                   # numeroInterior
+                    :interior_number,                    # numeroInterior
                     :neighborhood,                       # colonia
                     :municipality,                       # alcaldiaMunicipio
                     :zip_code,                           # cp
@@ -37,9 +37,9 @@ module STP
         {
           cuenta: @account,
           empresa: @company,
-          nombre: @name,
-          apellidoPaterno: @paternal_surname,
-          apellidoMaterno: @maternal_surname,
+          nombre: I18n.transliterate(@name),
+          apellidoPaterno: I18n.transliterate(@paternal_surname),
+          apellidoMaterno: I18n.transliterate(@maternal_surname),
           rfcCurp: @rfc,
           fechaNacimiento: @birthdate,
           genero: @sex,
@@ -47,7 +47,7 @@ module STP
           actividadEconomica: @economic_activity,
           calle: @street,
           numeroExterior: @exterior_number,
-          numeroInterior: @interior_nunmber,
+          numeroInterior: @interior_number,
           colonia: @neighborhood,
           alcaldiaMunicipio: @municipality,
           cp: @zip_code,

data/lib/stp/version.rb

@@ -1,3 +1,3 @@
 module STP
-  VERSION = '0.2.1'
+  VERSION = '0.4.3'
 end

data/spec/spec_helper.rb

@@ -1,27 +1,28 @@
 require 'rspec'
 require 'simplecov'
 require 'faker'
+require 'webmock/rspec'
 
 require 'stp'
 
 STP.config do |c|
-  c.api_uri = 'xxxxx'
+  c.api_uri = 'https://demo_url.com:8080/'
   c.private_key = %q(
-  -----BEGIN RSA PRIVATE KEY-----
-  MIICXgIBAAKBgQDO6dcS4k8Sz//09ISLLCIqHjCYNpHUbtauyu4+N3bvTOxgyX9R
-  fC9hQ0HyL6VjcAoY67BNF1gvLPTRB0ijwMPpl2uEyv2y1pPwxmDoH4dH0aoRrWUW
-  zSejnfVn4NoHIchiu8umIofDFuGb/cIDnVBikKNFBTf6HxPePUW2p35Q9wIDAQAB
-  AoGBAJm4jqmf6mEumJkyw/nlauhhj3a2K/dn9STc7MzaRgkY3BA4AtfV7BlVb3vv
-  O+85QLcs+sj7S++YdbWJtMS7pI/jYQPEiR2pQ9aHx/Hacor92Oi7zEzn6QLr/VKA
-  K2qPAiRicPItrY4zWkrEwmwX0SBUPjAD3Ffjf8T6cETE8puxAkEA7aijTnkK8FzM
-  TxXDl6UMxSwjcJeP/vJcN+im+aphliIGJykL1kcXT5B9R3OUyqsbySgmjsG2yNEm
-  psCEd/rZKQJBAN7hxnVGAeVl1q2NWgL+lCgvgwaoPqE2NzcFsIxs5EOpKXn0fZuR
-  oH7l09Giv61NmdNAJT1oMxdLVQ9QJ1UNfR8CQQC9ACr3Yk2vv6z/i+hjte/E8ogw
-  p2ftsaJjGBOKY9R9yAsqo3r1as4ACYGIDEQdNRzAybx4NVf+tk5NuLbgj86ZAkEA
-  h3BpmgA1zMHK5+H6rdEoFRdyJsx8api4it4RP/Q37gnQ44Q4BB5Find89WpR0i1S
-  6bWUK7GzQleL0+dgT2YH/wJAByKN5rEvP/XLiwSu68lQtloDAJxQfD4CSHlC97Mw
-  9bIAmsKrvYVL4B40Nb3jPNXCKm8zRqFu//WX/G1uy5Q6nQ==
-  -----END RSA PRIVATE KEY-----
+-----BEGIN RSA PRIVATE KEY-----
+MIICXgIBAAKBgQDO6dcS4k8Sz//09ISLLCIqHjCYNpHUbtauyu4+N3bvTOxgyX9R
+fC9hQ0HyL6VjcAoY67BNF1gvLPTRB0ijwMPpl2uEyv2y1pPwxmDoH4dH0aoRrWUW
+zSejnfVn4NoHIchiu8umIofDFuGb/cIDnVBikKNFBTf6HxPePUW2p35Q9wIDAQAB
+AoGBAJm4jqmf6mEumJkyw/nlauhhj3a2K/dn9STc7MzaRgkY3BA4AtfV7BlVb3vv
+O+85QLcs+sj7S++YdbWJtMS7pI/jYQPEiR2pQ9aHx/Hacor92Oi7zEzn6QLr/VKA
+K2qPAiRicPItrY4zWkrEwmwX0SBUPjAD3Ffjf8T6cETE8puxAkEA7aijTnkK8FzM
+TxXDl6UMxSwjcJeP/vJcN+im+aphliIGJykL1kcXT5B9R3OUyqsbySgmjsG2yNEm
+psCEd/rZKQJBAN7hxnVGAeVl1q2NWgL+lCgvgwaoPqE2NzcFsIxs5EOpKXn0fZuR
+oH7l09Giv61NmdNAJT1oMxdLVQ9QJ1UNfR8CQQC9ACr3Yk2vv6z/i+hjte/E8ogw
+p2ftsaJjGBOKY9R9yAsqo3r1as4ACYGIDEQdNRzAybx4NVf+tk5NuLbgj86ZAkEA
+h3BpmgA1zMHK5+H6rdEoFRdyJsx8api4it4RP/Q37gnQ44Q4BB5Find89WpR0i1S
+6bWUK7GzQleL0+dgT2YH/wJAByKN5rEvP/XLiwSu68lQtloDAJxQfD4CSHlC97Mw
+9bIAmsKrvYVL4B40Nb3jPNXCKm8zRqFu//WX/G1uy5Q6nQ==
+-----END RSA PRIVATE KEY-----
   )
   c.private_key_password = '12345678'
   c.company = 'xxxxx'

data/spec/stp/account_create_spec.rb

@@ -2,8 +2,7 @@ require 'support/stp_test_helpers'
 
 RSpec.describe STP::Account do
   subject do
-    response = STP::Account.create(account_obj)
-    response
+    STP::Account.create(account_obj)
   end
 
   describe 'account create' do
@@ -22,7 +21,7 @@ RSpec.describe STP::Account do
           account.economic_activity = 'programador'
           account.street = Faker::Address.street_name
           account.exterior_number = Faker::Address.building_number
-          account.interior_nunmber = Faker::Address.building_number
+          account.interior_number = Faker::Address.building_number
           account.neighborhood = Faker::Address.community
           account.municipality = Faker::Address.community
           account.zip_code = Faker::Number.number(digits: 5)
@@ -32,18 +31,14 @@ RSpec.describe STP::Account do
           account.phone = Faker::PhoneNumber.phone_number
           account
         end
-
+        
         before do
-          allow(STP::Account).to receive(:create).
-            and_return(STPTestHelpers::ACCOUNT_CREATE_MOCK_SUCCESS())
+          stub_request(:put, "#{STP.api_uri}/cuentaModule/fisica").to_return(
+            body: JSON.dump(STPTestHelpers::ACCOUNT_CREATE_MOCK_SUCCESS()), status: 200
+          )
         end
 
-        it do
-          response = subject
-          expect(response['id']).not_to be_nil
-          expect(response['id']).to be 0
-          expect(response['descripcionError']).to be_nil
-        end
+        it { expect{subject}.not_to raise_error }
       end
 
       context 'with minimal data' do
@@ -54,23 +49,19 @@ RSpec.describe STP::Account do
           account.rfc = 'RFCURP'
           account
         end
-
+        
         before do
-          allow(STP::Account).to receive(:create).
-            and_return(STPTestHelpers::ACCOUNT_CREATE_MOCK_SUCCESS())
+          stub_request(:put, "#{STP.api_uri}/cuentaModule/fisica").to_return(
+            body: JSON.dump(STPTestHelpers::ACCOUNT_CREATE_MOCK_SUCCESS()), status: 200
+          )
         end
 
-        it do
-          response = subject
-          expect(response['id']).not_to be_nil
-          expect(response['id']).to be 0
-          expect(response['descripcionError']).to be_nil
-        end
+        it { expect{subject}.not_to raise_error }
       end
     end
 
     context 'fails when' do
-      context 'repeating account and rfcCurp' do
+      context 'random error' do
         let(:account_obj) do
           account = STP::Structs::Account.new
           account.account = '01010101'
@@ -84,7 +75,7 @@ RSpec.describe STP::Account do
           account.economic_activity = 'programador'
           account.street = Faker::Address.street_name
           account.exterior_number = Faker::Address.building_number
-          account.interior_nunmber = Faker::Address.building_number
+          account.interior_number = Faker::Address.building_number
           account.neighborhood = Faker::Address.community
           account.municipality = Faker::Address.community
           account.zip_code = Faker::Number.number(digits: 5)
@@ -94,14 +85,48 @@ RSpec.describe STP::Account do
           account.phone = Faker::PhoneNumber.phone_number
           account
         end
+        
+        before do
+          stub_request(:put, "#{STP.api_uri}/cuentaModule/fisica").to_return(
+            body: JSON.dump(STPTestHelpers::ACCOUNT_CREATE_MOCK_ERROR(1)), status: 200
+          )
+        end
+
+        it { expect {subject}.to raise_error(STP::Errors::STPError) }
+      end
 
+      context 'repeating account and rfcCurp' do
+        let(:account_obj) do
+          account = STP::Structs::Account.new
+          account.account = '01010101'
+          account.name = Faker::Name.first_name
+          account.paternal_surname = Faker::Name.last_name
+          account.maternal_surname = Faker::Name.last_name
+          account.rfc = 'RFC'
+          account.birthdate = Faker::Date.birthday(min_age: 6, max_age: 65)
+          account.sex = 'male'
+          account.state = 'Mérida'
+          account.economic_activity = 'programador'
+          account.street = Faker::Address.street_name
+          account.exterior_number = Faker::Address.building_number
+          account.interior_number = Faker::Address.building_number
+          account.neighborhood = Faker::Address.community
+          account.municipality = Faker::Address.community
+          account.zip_code = Faker::Number.number(digits: 5)
+          account.country = 'México'
+          account.email = Faker::Internet.email
+          account.identification_id = 'id'
+          account.phone = Faker::PhoneNumber.phone_number
+          account
+        end
+        
         before do
-          allow(STP::Account).to receive(:create).
-            and_return(STPTestHelpers::ACCOUNT_CREATE_MOCK_ERROR(-2))
+          stub_request(:put, "#{STP.api_uri}/cuentaModule/fisica").to_return(
+            body: JSON.dump(STPTestHelpers::ACCOUNT_CREATE_MOCK_ERROR(1, 'Cuenta Duplicada')), status: 200
+          )
         end
 
-        it { expect(subject['id']).to eq -2 }
-        it { expect(subject['descripcionError']).not_to be_nil }
+        it { expect {subject}.to raise_error(STP::Errors::AccountAlreadyExists) }
       end
     end
   end

data/spec/stp/account_delete_spec.rb

@@ -2,8 +2,7 @@ require 'support/stp_test_helpers'
 
 RSpec.describe STP::Account do
   subject do
-    response = STP::Account.delete(account_obj)
-    response
+    STP::Account.delete(account_obj)
   end
 
   describe 'account delete' do
@@ -22,7 +21,7 @@ RSpec.describe STP::Account do
           account.economic_activity = 'programador'
           account.street = Faker::Address.street_name
           account.exterior_number = Faker::Address.building_number
-          account.interior_nunmber = Faker::Address.building_number
+          account.interior_number = Faker::Address.building_number
           account.neighborhood = Faker::Address.community
           account.municipality = Faker::Address.community
           account.zip_code = Faker::Number.number(digits: 5)
@@ -38,12 +37,18 @@ RSpec.describe STP::Account do
             and_return(STPTestHelpers::ACCOUNT_DELETE_MOCK_SUCCESS())
         end
 
-        it do
-          response = subject
-          expect(response['id']).not_to be_nil
-          expect(response['id']).to be 0
-          expect(response['descripcionError']).to be_nil
+        before do
+          allow(STP::Account).to receive(:create).
+            and_return(STPTestHelpers::ACCOUNT_DELETE_MOCK_SUCCESS())
+        end
+        
+        before do
+          stub_request(:delete, "#{STP.api_uri}/cuentaModule/fisica").to_return(
+            body: JSON.dump(STPTestHelpers::ACCOUNT_DELETE_MOCK_SUCCESS()), status: 200
+          )
         end
+
+        it { expect{subject}.not_to raise_error }
       end
 
       context 'with minimal data' do
@@ -54,18 +59,14 @@ RSpec.describe STP::Account do
           account.rfc = 'RFCURP'
           account
         end
-
+        
         before do
-          allow(STP::Account).to receive(:delete).
-            and_return(STPTestHelpers::ACCOUNT_DELETE_MOCK_SUCCESS())
+          stub_request(:delete, "#{STP.api_uri}/cuentaModule/fisica").to_return(
+            body: JSON.dump(STPTestHelpers::ACCOUNT_DELETE_MOCK_SUCCESS()), status: 200
+          )
         end
 
-        it do
-          response = subject
-          expect(response['id']).not_to be_nil
-          expect(response['id']).to be 0
-          expect(response['descripcionError']).to be_nil
-        end
+        it { expect{subject}.not_to raise_error }
       end
     end
 
@@ -84,7 +85,7 @@ RSpec.describe STP::Account do
           account.economic_activity = 'programador'
           account.street = Faker::Address.street_name
           account.exterior_number = Faker::Address.building_number
-          account.interior_nunmber = Faker::Address.building_number
+          account.interior_number = Faker::Address.building_number
           account.neighborhood = Faker::Address.community
           account.municipality = Faker::Address.community
           account.zip_code = Faker::Number.number(digits: 5)
@@ -94,14 +95,14 @@ RSpec.describe STP::Account do
           account.phone = Faker::PhoneNumber.phone_number
           account
         end
-
+        
         before do
-          allow(STP::Account).to receive(:delete).
-            and_return(STPTestHelpers::ACCOUNT_DELETE_MOCK_ERROR(-2))
+          stub_request(:delete, "#{STP.api_uri}/cuentaModule/fisica").to_return(
+            body: JSON.dump(STPTestHelpers::ACCOUNT_DELETE_MOCK_ERROR(-2)), status: 200
+          )
         end
 
-        it { expect(subject['id']).to eq -2 }
-        it { expect(subject['descripcionError']).not_to be_nil }
+        it { expect {subject}.to raise_error(STP::Errors::STPError) }
       end
     end
   end

data/spec/stp/payment_order_spec.rb

@@ -96,7 +96,7 @@ RSpec.describe STP::PaymentOrder do
         end
 
         it { expect(subject['id']).to eq -2 }
-        it { expect(subject['descripcionError']).not_to be_nil }
+        it { expect(subject['descripcion']).not_to be_nil }
       end
     end
   end

data/spec/support/stp_test_helpers.rb

@@ -1,7 +1,7 @@
 module STPTestHelpers
   def self.PAYMENT_ORDER_MOCK_ERROR(error_code)
     {
-      'descripcionError' => 'regular error msg',
+      'descripcion' => 'regular error msg',
       'id' => error_code,
     }
   end
@@ -16,9 +16,9 @@ module STPTestHelpers
     }
   end
 
-  def self.ACCOUNT_CREATE_MOCK_ERROR(error_code)
+  def self.ACCOUNT_CREATE_MOCK_ERROR(error_code, message='regular error msg')
     {
-      'descripcionError' => 'regular error msg',
+      'descripcion' => message,
       'id' => error_code,
     }
   end
@@ -32,7 +32,7 @@ module STPTestHelpers
 
   def self.ACCOUNT_DELETE_MOCK_ERROR(error_code)
     {
-      'descripcionError' => 'regular error msg',
+      'descripcion' => 'regular error msg',
       'id' => error_code,
     }
   end

data/stp_client.gemspec

@@ -24,4 +24,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rspec", "~> 3.8"
   spec.add_development_dependency "faker", "~> 2.0"
   spec.add_development_dependency "simplecov", "~> 0.17"
+  spec.add_development_dependency "webmock", "~> 3.4.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: stp_client
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.4.3
 platform: ruby
 authors:
 - Yellowme
@@ -80,6 +80,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.17'
+- !ruby/object:Gem::Dependency
+  name: webmock
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 3.4.2
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 3.4.2
 description: STP Client is a lib for consuming STP services
 email: hola@yellowme.mx
 executables: []
@@ -95,6 +109,8 @@ files:
 - Rakefile
 - lib/stp.rb
 - lib/stp/account.rb
+- lib/stp/errors/account_already_exists.rb
+- lib/stp/errors/stp_error.rb
 - lib/stp/payment_order.rb
 - lib/stp/structs/account.rb
 - lib/stp/structs/payment_order.rb
@@ -126,8 +142,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: STP Client is a ruby integration to STP services