stp_client 0.2.1 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bc5b27b5570c48f3fe21db14b7ebbd0131d89d143c677b9ecb75a4d301923bf1
-  data.tar.gz: cc579b5ec5d1c93077d1c17d4a6e65f2945f3fbcc741c5937bc576f428114139
+  metadata.gz: b35312a692c39818b9fb03f02b10dae9ed44de79d1333b64ef7da23bbdb4e638
+  data.tar.gz: 65902abc627a5de9e20e37e213744f0f77c8c44571d8c5000c4a75151a4e5741
 SHA512:
-  metadata.gz: 3c613cab091aa0cbf59a5c807fa5d04ba12286e4f7c70e0178b190d7d847bca243a2ff3784c4516af972bb97a2ba9041cf5604dfa49dc800b555a5f2efabda69
-  data.tar.gz: b757d4944f474c1319cb1c66d5ab7234c269707b386bd0804245fc740edaf073b0c3b5788a4b73aa066508c9c27fe0dfdd58e7cc663fedc9754c973c16a6cd82
+  metadata.gz: 675889febf324cfbca754443c114b0c99ca3499142ecf471bbe61588c07adf19e6dc7f8aaf7f4989ba79b126216d4d2790447a6f9c12fe1613b8b785394c58bc
+  data.tar.gz: d1f14ac8556e19d1677e34d2c37d98eb6b86c51f88f157e4a2333c2dde26136e1e2e06af4349b26777469fd9b629170107328708f88d5844262268ecb000d92a

data/Gemfile.lock

@@ -15,8 +15,12 @@ GEM
       i18n (>= 0.7, < 2)
       minitest (~> 5.1)
       tzinfo (~> 1.1)
+    addressable (2.7.0)
+      public_suffix (>= 2.0.2, < 5.0)
     bcrypt (3.1.13)
     concurrent-ruby (1.1.5)
+    crack (0.4.3)
+      safe_yaml (~> 1.0.0)
     crypto_yellowme (0.4.0)
       activemodel (~> 5.2)
       activesupport (~> 5.0)
@@ -27,11 +31,13 @@ GEM
       i18n (>= 1.6, < 1.8)
     faraday (1.0.0)
       multipart-post (>= 1.2, < 3)
+    hashdiff (1.0.1)
     i18n (1.7.0)
       concurrent-ruby (~> 1.0)
     json (2.3.0)
     minitest (5.13.0)
     multipart-post (2.1.1)
+    public_suffix (4.0.3)
     rspec (3.9.0)
       rspec-core (~> 3.9.0)
       rspec-expectations (~> 3.9.0)
@@ -45,6 +51,7 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.9.0)
     rspec-support (3.9.2)
+    safe_yaml (1.0.5)
     simplecov (0.17.1)
       docile (~> 1.1)
       json (>= 1.8, < 3)
@@ -53,6 +60,10 @@ GEM
     thread_safe (0.3.6)
     tzinfo (1.2.6)
       thread_safe (~> 0.1)
+    webmock (3.4.2)
+      addressable (>= 2.3.6)
+      crack (>= 0.3.2)
+      hashdiff
 
 PLATFORMS
   ruby
@@ -62,6 +73,7 @@ DEPENDENCIES
   rspec (~> 3.8)
   simplecov (~> 0.17)
   stp_client!
+  webmock (~> 3.4.2)
 
 BUNDLED WITH
    2.0.2

data/lib/stp.rb

@@ -5,6 +5,7 @@ require 'stp/structs/account'
 require 'stp/structs/payment_order'
 require 'stp/account'
 require 'stp/payment_order'
+require 'stp/stp_error'
 
 module STP
   def self.config

data/lib/stp/account.rb

@@ -9,7 +9,7 @@ module STP
         req.body = account.to_json
       end
       hash = JSON.parse(response.body)
-      hash
+      raise STP::STPError.new(hash['message']) unless hash['id'] == 0
     end
 
     def self.delete(account)
@@ -21,7 +21,7 @@ module STP
         req.body = account.to_json
       end
       hash = JSON.parse(response.body)
-      hash
+      raise STP::STPError.new(hash['message']) unless hash['id'] == 0
     end
   end
 end

data/lib/stp/stp_error.rb

@@ -0,0 +1,4 @@
+module STP
+  class STPError < StandardError
+  end
+end

data/lib/stp/version.rb

@@ -1,3 +1,3 @@
 module STP
-  VERSION = '0.2.1'
+  VERSION = '0.3.0'
 end

data/spec/spec_helper.rb

@@ -1,27 +1,28 @@
 require 'rspec'
 require 'simplecov'
 require 'faker'
+require 'webmock/rspec'
 
 require 'stp'
 
 STP.config do |c|
-  c.api_uri = 'xxxxx'
+  c.api_uri = 'https://demo_url.com:8080/'
   c.private_key = %q(
-  -----BEGIN RSA PRIVATE KEY-----
-  MIICXgIBAAKBgQDO6dcS4k8Sz//09ISLLCIqHjCYNpHUbtauyu4+N3bvTOxgyX9R
-  fC9hQ0HyL6VjcAoY67BNF1gvLPTRB0ijwMPpl2uEyv2y1pPwxmDoH4dH0aoRrWUW
-  zSejnfVn4NoHIchiu8umIofDFuGb/cIDnVBikKNFBTf6HxPePUW2p35Q9wIDAQAB
-  AoGBAJm4jqmf6mEumJkyw/nlauhhj3a2K/dn9STc7MzaRgkY3BA4AtfV7BlVb3vv
-  O+85QLcs+sj7S++YdbWJtMS7pI/jYQPEiR2pQ9aHx/Hacor92Oi7zEzn6QLr/VKA
-  K2qPAiRicPItrY4zWkrEwmwX0SBUPjAD3Ffjf8T6cETE8puxAkEA7aijTnkK8FzM
-  TxXDl6UMxSwjcJeP/vJcN+im+aphliIGJykL1kcXT5B9R3OUyqsbySgmjsG2yNEm
-  psCEd/rZKQJBAN7hxnVGAeVl1q2NWgL+lCgvgwaoPqE2NzcFsIxs5EOpKXn0fZuR
-  oH7l09Giv61NmdNAJT1oMxdLVQ9QJ1UNfR8CQQC9ACr3Yk2vv6z/i+hjte/E8ogw
-  p2ftsaJjGBOKY9R9yAsqo3r1as4ACYGIDEQdNRzAybx4NVf+tk5NuLbgj86ZAkEA
-  h3BpmgA1zMHK5+H6rdEoFRdyJsx8api4it4RP/Q37gnQ44Q4BB5Find89WpR0i1S
-  6bWUK7GzQleL0+dgT2YH/wJAByKN5rEvP/XLiwSu68lQtloDAJxQfD4CSHlC97Mw
-  9bIAmsKrvYVL4B40Nb3jPNXCKm8zRqFu//WX/G1uy5Q6nQ==
-  -----END RSA PRIVATE KEY-----
+-----BEGIN RSA PRIVATE KEY-----
+MIICXgIBAAKBgQDO6dcS4k8Sz//09ISLLCIqHjCYNpHUbtauyu4+N3bvTOxgyX9R
+fC9hQ0HyL6VjcAoY67BNF1gvLPTRB0ijwMPpl2uEyv2y1pPwxmDoH4dH0aoRrWUW
+zSejnfVn4NoHIchiu8umIofDFuGb/cIDnVBikKNFBTf6HxPePUW2p35Q9wIDAQAB
+AoGBAJm4jqmf6mEumJkyw/nlauhhj3a2K/dn9STc7MzaRgkY3BA4AtfV7BlVb3vv
+O+85QLcs+sj7S++YdbWJtMS7pI/jYQPEiR2pQ9aHx/Hacor92Oi7zEzn6QLr/VKA
+K2qPAiRicPItrY4zWkrEwmwX0SBUPjAD3Ffjf8T6cETE8puxAkEA7aijTnkK8FzM
+TxXDl6UMxSwjcJeP/vJcN+im+aphliIGJykL1kcXT5B9R3OUyqsbySgmjsG2yNEm
+psCEd/rZKQJBAN7hxnVGAeVl1q2NWgL+lCgvgwaoPqE2NzcFsIxs5EOpKXn0fZuR
+oH7l09Giv61NmdNAJT1oMxdLVQ9QJ1UNfR8CQQC9ACr3Yk2vv6z/i+hjte/E8ogw
+p2ftsaJjGBOKY9R9yAsqo3r1as4ACYGIDEQdNRzAybx4NVf+tk5NuLbgj86ZAkEA
+h3BpmgA1zMHK5+H6rdEoFRdyJsx8api4it4RP/Q37gnQ44Q4BB5Find89WpR0i1S
+6bWUK7GzQleL0+dgT2YH/wJAByKN5rEvP/XLiwSu68lQtloDAJxQfD4CSHlC97Mw
+9bIAmsKrvYVL4B40Nb3jPNXCKm8zRqFu//WX/G1uy5Q6nQ==
+-----END RSA PRIVATE KEY-----
   )
   c.private_key_password = '12345678'
   c.company = 'xxxxx'

data/spec/stp/account_create_spec.rb

@@ -2,8 +2,7 @@ require 'support/stp_test_helpers'
 
 RSpec.describe STP::Account do
   subject do
-    response = STP::Account.create(account_obj)
-    response
+    STP::Account.create(account_obj)
   end
 
   describe 'account create' do
@@ -32,18 +31,14 @@ RSpec.describe STP::Account do
           account.phone = Faker::PhoneNumber.phone_number
           account
         end
-
+        
         before do
-          allow(STP::Account).to receive(:create).
-            and_return(STPTestHelpers::ACCOUNT_CREATE_MOCK_SUCCESS())
+          stub_request(:put, "#{STP.api_uri}/cuentaModule/fisica").to_return(
+            body: JSON.dump(STPTestHelpers::ACCOUNT_CREATE_MOCK_SUCCESS()), status: 200
+          )
         end
 
-        it do
-          response = subject
-          expect(response['id']).not_to be_nil
-          expect(response['id']).to be 0
-          expect(response['descripcionError']).to be_nil
-        end
+        it { expect{subject}.not_to raise_error }
       end
 
       context 'with minimal data' do
@@ -54,18 +49,14 @@ RSpec.describe STP::Account do
           account.rfc = 'RFCURP'
           account
         end
-
+        
         before do
-          allow(STP::Account).to receive(:create).
-            and_return(STPTestHelpers::ACCOUNT_CREATE_MOCK_SUCCESS())
+          stub_request(:put, "#{STP.api_uri}/cuentaModule/fisica").to_return(
+            body: JSON.dump(STPTestHelpers::ACCOUNT_CREATE_MOCK_SUCCESS()), status: 200
+          )
         end
 
-        it do
-          response = subject
-          expect(response['id']).not_to be_nil
-          expect(response['id']).to be 0
-          expect(response['descripcionError']).to be_nil
-        end
+        it { expect{subject}.not_to raise_error }
       end
     end
 
@@ -94,14 +85,14 @@ RSpec.describe STP::Account do
           account.phone = Faker::PhoneNumber.phone_number
           account
         end
-
+        
         before do
-          allow(STP::Account).to receive(:create).
-            and_return(STPTestHelpers::ACCOUNT_CREATE_MOCK_ERROR(-2))
+          stub_request(:put, "#{STP.api_uri}/cuentaModule/fisica").to_return(
+            body: JSON.dump(STPTestHelpers::ACCOUNT_CREATE_MOCK_ERROR(1)), status: 200
+          )
         end
 
-        it { expect(subject['id']).to eq -2 }
-        it { expect(subject['descripcionError']).not_to be_nil }
+        it { expect {subject}.to raise_error(STP::STPError) }
       end
     end
   end

data/spec/stp/account_delete_spec.rb

@@ -2,8 +2,7 @@ require 'support/stp_test_helpers'
 
 RSpec.describe STP::Account do
   subject do
-    response = STP::Account.delete(account_obj)
-    response
+    STP::Account.delete(account_obj)
   end
 
   describe 'account delete' do
@@ -38,12 +37,18 @@ RSpec.describe STP::Account do
             and_return(STPTestHelpers::ACCOUNT_DELETE_MOCK_SUCCESS())
         end
 
-        it do
-          response = subject
-          expect(response['id']).not_to be_nil
-          expect(response['id']).to be 0
-          expect(response['descripcionError']).to be_nil
+        before do
+          allow(STP::Account).to receive(:create).
+            and_return(STPTestHelpers::ACCOUNT_DELETE_MOCK_SUCCESS())
+        end
+        
+        before do
+          stub_request(:delete, "#{STP.api_uri}/cuentaModule/fisica").to_return(
+            body: JSON.dump(STPTestHelpers::ACCOUNT_DELETE_MOCK_SUCCESS()), status: 200
+          )
         end
+
+        it { expect{subject}.not_to raise_error }
       end
 
       context 'with minimal data' do
@@ -54,18 +59,14 @@ RSpec.describe STP::Account do
           account.rfc = 'RFCURP'
           account
         end
-
+        
         before do
-          allow(STP::Account).to receive(:delete).
-            and_return(STPTestHelpers::ACCOUNT_DELETE_MOCK_SUCCESS())
+          stub_request(:delete, "#{STP.api_uri}/cuentaModule/fisica").to_return(
+            body: JSON.dump(STPTestHelpers::ACCOUNT_DELETE_MOCK_SUCCESS()), status: 200
+          )
         end
 
-        it do
-          response = subject
-          expect(response['id']).not_to be_nil
-          expect(response['id']).to be 0
-          expect(response['descripcionError']).to be_nil
-        end
+        it { expect{subject}.not_to raise_error }
       end
     end
 
@@ -94,14 +95,14 @@ RSpec.describe STP::Account do
           account.phone = Faker::PhoneNumber.phone_number
           account
         end
-
+        
         before do
-          allow(STP::Account).to receive(:delete).
-            and_return(STPTestHelpers::ACCOUNT_DELETE_MOCK_ERROR(-2))
+          stub_request(:delete, "#{STP.api_uri}/cuentaModule/fisica").to_return(
+            body: JSON.dump(STPTestHelpers::ACCOUNT_DELETE_MOCK_ERROR(-2)), status: 200
+          )
         end
 
-        it { expect(subject['id']).to eq -2 }
-        it { expect(subject['descripcionError']).not_to be_nil }
+        it { expect {subject}.to raise_error(STP::STPError) }
       end
     end
   end

data/stp_client.gemspec

@@ -24,4 +24,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rspec", "~> 3.8"
   spec.add_development_dependency "faker", "~> 2.0"
   spec.add_development_dependency "simplecov", "~> 0.17"
+  spec.add_development_dependency "webmock", "~> 3.4.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: stp_client
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.3.0
 platform: ruby
 authors:
 - Yellowme
@@ -80,6 +80,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.17'
+- !ruby/object:Gem::Dependency
+  name: webmock
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 3.4.2
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 3.4.2
 description: STP Client is a lib for consuming STP services
 email: hola@yellowme.mx
 executables: []
@@ -96,6 +110,7 @@ files:
 - lib/stp.rb
 - lib/stp/account.rb
 - lib/stp/payment_order.rb
+- lib/stp/stp_error.rb
 - lib/stp/structs/account.rb
 - lib/stp/structs/payment_order.rb
 - lib/stp/version.rb