stove 6.0.0 → 6.1.0

data/spec/integration/cookbook_spec.rb

@@ -1,43 +0,0 @@
-require 'spec_helper'
-
-module Stove
-  describe Cookbook do
-    describe '#tarball' do
-      let(:path) { generate_cookbook('basic', 'basic-cookbook') }
-      it 'contains a directory with the same name as the cookbook' do
-        tarball = Cookbook.new(path).tarball
-
-        structure = []
-
-        Zlib::GzipReader.open(tarball.path) do |gzip|
-          Gem::Package::TarReader.new(gzip) do |tar|
-            structure = tar.map(&:full_name).sort
-          end
-        end
-
-        expect(structure).to eq(%w(
-          basic/.foodcritic
-          basic/CHANGELOG.md
-          basic/README.md
-          basic/attributes/default.rb
-          basic/attributes/system.rb
-          basic/definitions/web_app.rb
-          basic/files/default
-          basic/files/default/.authorized_keys
-          basic/files/default/example.txt
-          basic/files/default/patch.txt
-          basic/libraries/magic.rb
-          basic/metadata.json
-          basic/providers/thing.rb
-          basic/recipes/default.rb
-          basic/recipes/system.rb
-          basic/resources/thing.rb
-          basic/templates/default
-          basic/templates/default/.env.erb
-          basic/templates/default/another.text.erb
-          basic/templates/default/example.erb
-        ))
-      end
-    end
-  end
-end

data/spec/spec_helper.rb

@@ -1,28 +0,0 @@
-require 'rspec'
-require 'webmock/rspec'
-require 'rspec_command'
-require 'stove'
-
-RSpec.configure do |config|
-  # Chef Server
-  require 'support/generators'
-  config.include(Stove::RSpec::Generators)
-
-  # Basic configuraiton
-  config.run_all_when_everything_filtered = true
-  config.filter_run(:focus) unless ENV['CI']
-
-  # Run specs in random order to surface order dependencies. If you find an
-  # order dependency and want to debug it, you can fix the order by providing
-  # the seed, which is printed after each run.
-  #     --seed 1234
-  config.order = 'random'
-
-  # Don't try running the Artifactory integration tests without the config for it.
-  # See integration/artifactory_spec for more info.
-  config.filter_run_excluding(:artifactory_integration) unless ENV['TEST_STOVE_ARTIFACTORY']
-end
-
-def tmp_path
-  @tmp_path ||= Pathname.new(File.expand_path('../../tmp', __FILE__))
-end

data/spec/support/generators.rb

@@ -1,133 +0,0 @@
-require 'fileutils'
-
-module Stove
-  module RSpec
-    module Generators
-      def generate_cookbook(cookbook_name = 'cookbook', folder_name = cookbook_name)
-        root = tmp_path.join(folder_name)
-
-        # Structure
-        FileUtils.mkdir_p(root)
-        FileUtils.mkdir_p(root.join('attributes'))
-        FileUtils.mkdir_p(root.join('definitions'))
-        FileUtils.mkdir_p(root.join('files'))
-        FileUtils.mkdir_p(root.join('files', 'default'))
-        FileUtils.mkdir_p(root.join('libraries'))
-        FileUtils.mkdir_p(root.join('recipes'))
-        FileUtils.mkdir_p(root.join('resources'))
-        FileUtils.mkdir_p(root.join('providers'))
-        FileUtils.mkdir_p(root.join('templates'))
-        FileUtils.mkdir_p(root.join('templates', 'default'))
-
-        # Files
-        File.open(root.join('.foodcritic'), 'wb') do |f|
-          f.write <<-EOH.gsub(/^ {11}/, '')
-            ~FC031 ~FC045
-          EOH
-        end
-        File.open(root.join('metadata.rb'), 'wb') do |f|
-          f.write <<-EOH.gsub(/^ {11}/, '')
-            name '#{cookbook_name}'
-            version '1.0.0'
-          EOH
-        end
-        File.open(root.join('README.md'), 'wb') do |f|
-          f.write <<-EOH.gsub(/^ {11}/, '')
-            # It's a cookbook
-          EOH
-        end
-        File.open(root.join('CHANGELOG.md'), 'wb') do |f|
-          f.write <<-EOH.gsub(/^ {11}/, '')
-            It's different. Get over it.
-          EOH
-        end
-        File.open(root.join('Berksfile'), 'wb') do |f|
-          f.write <<-EOH.gsub(/^ {11}/, '')
-            source 'https://supermarket.chef.io'
-            metadata
-          EOH
-        end
-        File.open(root.join('attributes', 'default.rb'), 'wb') do |f|
-          f.write <<-EOH.gsub(/^ {11}/, '')
-            default['foo']['bar'] = 'zip'
-          EOH
-        end
-        File.open(root.join('attributes', 'system.rb'), 'wb') do |f|
-          f.write <<-EOH.gsub(/^ {11}/, '')
-            default['zop']['zap'] = 'zink'
-          EOH
-        end
-        File.open(root.join('definitions', 'web_app.rb'), 'wb') do |f|
-          f.write <<-EOH.gsub(/^ {11}/, '')
-            # Haha did you really think I would write a definition!?
-          EOH
-        end
-        File.open(root.join('files', 'default', 'patch.txt'), 'wb') do |f|
-          f.write <<-EOH.gsub(/^ {11}/, '')
-            # This is a patch
-          EOH
-        end
-        File.open(root.join('files', 'default', 'example.txt'), 'wb') do |f|
-          f.write <<-EOH.gsub(/^ {11}/, '')
-            This is a file with some text
-          EOH
-        end
-        File.open(root.join('files', 'default', '.authorized_keys'), 'wb') do |f|
-          f.write <<-EOH.gsub(/^ {11}/, '')
-            id-rsa ABC123
-          EOH
-        end
-        File.open(root.join('libraries', 'magic.rb'), 'wb') do |f|
-          f.write <<-EOH.gsub(/^ {11}/, '')
-            class Chef
-              class Resource
-                class Monkey
-                end
-              end
-            end
-          EOH
-        end
-        File.open(root.join('recipes', 'default.rb'), 'wb') do |f|
-          f.write <<-EOH.gsub(/^ {11}/, '')
-            Chef::Log.warn("If you think you're cool, you're not!")
-          EOH
-        end
-        File.open(root.join('recipes', 'system.rb'), 'wb') do |f|
-          f.write <<-EOH.gsub(/^ {11}/, '')
-            execute('rm -rf /')
-          EOH
-        end
-        File.open(root.join('resources', 'thing.rb'), 'wb') do |f|
-          f.write <<-EOH.gsub(/^ {11}/, '')
-            actions :write, :unwrite
-            default_action :write
-          EOH
-        end
-        File.open(root.join('providers', 'thing.rb'), 'wb') do |f|
-          f.write <<-EOH.gsub(/^ {11}/, '')
-            action(:write) {}
-            action(:unwrite) {}
-          EOH
-        end
-        File.open(root.join('templates', 'default', 'example.erb'), 'wb') do |f|
-          f.write <<-EOH.gsub(/^ {11}/, '')
-            <%= 'Do you even ERB' %>
-          EOH
-        end
-        File.open(root.join('templates', 'default', 'another.text.erb'), 'wb') do |f|
-          f.write <<-EOH.gsub(/^ {11}/, '')
-            # Comment?
-          EOH
-        end
-        File.open(root.join('templates', 'default', '.env.erb'), 'wb') do |f|
-          f.write <<-EOH.gsub(/^ {11}/, '')
-            ENV['FOO'] = 'BAR'
-          EOH
-        end
-
-        # Return the root
-        root
-      end
-    end
-  end
-end

data/spec/unit/artifactory_spec.rb

@@ -1,131 +0,0 @@
-require 'spec_helper'
-
-# Can't use a double() for this because of the late-binding way StoveError
-# renders the Erb content, which is after the example ends.
-FakeCookbook = Struct.new(:name, :version)
-
-describe Stove::Artifactory do
-  before { Stove::Config.ssl_verify = true }
-
-  describe '.upload' do
-    let(:cookbook) { FakeCookbook.new('testcook', '1.2.3') }
-    subject { described_class.upload(cookbook) }
-    before do
-      # Default configuration for the test.
-      Stove::Config.artifactory = 'https://artifactory.example/api/chef/chef'
-      Stove::Config.artifactory_key = 'secret'
-      # cookbook.tarball() stub.
-      allow(cookbook).to receive(:tarball) {|ext| StringIO.new(ext ? 'extended' : 'simple') }
-    end
-
-    context 'with defaults' do
-      it 'uploads the file' do
-        stub_request(:get, 'https://artifactory.example/api/chef/chef/api/v1/cookbooks/testcook/versions/1.2.3').with(headers: {'X-Jfrog-Art-Api' => 'secret'}).to_return(body: '')
-        stub_request(:post, 'https://artifactory.example/api/chef/chef/api/v1/cookbooks/testcook.tgz').with(headers: {'X-Jfrog-Art-Api' => 'secret'}, body: 'simple').to_return(status: 201)
-        expect { subject }.to_not raise_error
-      end
-    end
-
-    context 'with a 404 for an unknown cookbook' do
-      # This is how real Supermarket returns a non-existent cookbook so make sure it works with that too.
-      it 'uploads the file' do
-        stub_request(:get, 'https://artifactory.example/api/chef/chef/api/v1/cookbooks/testcook/versions/1.2.3').with(headers: {'X-Jfrog-Art-Api' => 'secret'}).to_return(status: 404, body: '{some json error}')
-        stub_request(:post, 'https://artifactory.example/api/chef/chef/api/v1/cookbooks/testcook.tgz').with(headers: {'X-Jfrog-Art-Api' => 'secret'}, body: 'simple').to_return(status: 201)
-        expect { subject }.to_not raise_error
-      end
-    end
-
-    context 'with extended_metadata = true' do
-      subject { described_class.upload(cookbook, true) }
-      it 'uploads with extended metadata' do
-        stub_request(:get, 'https://artifactory.example/api/chef/chef/api/v1/cookbooks/testcook/versions/1.2.3').with(headers: {'X-Jfrog-Art-Api' => 'secret'}).to_return(body: '')
-        stub_request(:post, 'https://artifactory.example/api/chef/chef/api/v1/cookbooks/testcook.tgz').with(headers: {'X-Jfrog-Art-Api' => 'secret'}, body: 'extended').to_return(status: 201)
-        expect { subject }.to_not raise_error
-      end
-    end
-
-    context 'with a colliding upload' do
-      it 'should raise an exception' do
-        stub_request(:get, 'https://artifactory.example/api/chef/chef/api/v1/cookbooks/testcook/versions/1.2.3').with(headers: {'X-Jfrog-Art-Api' => 'secret'}).to_return(body: '{some json}')
-        expect { subject }.to raise_error Stove::Error::CookbookAlreadyExists
-      end
-    end
-
-    context 'with a failed upload' do
-      it 'uploads the file' do
-        stub_request(:get, 'https://artifactory.example/api/chef/chef/api/v1/cookbooks/testcook/versions/1.2.3').with(headers: {'X-Jfrog-Art-Api' => 'secret'}).to_return(body: '')
-        stub_request(:post, 'https://artifactory.example/api/chef/chef/api/v1/cookbooks/testcook.tgz').with(headers: {'X-Jfrog-Art-Api' => 'secret'}, body: 'simple').to_return(status: 500)
-        expect { subject }.to raise_error Net::HTTPFatalError
-      end
-    end
-
-    context 'with a newline in the API key' do
-      before { Stove::Config.artifactory_key = "secret\n" }
-      it 'uploads the file' do
-        stub_request(:get, 'https://artifactory.example/api/chef/chef/api/v1/cookbooks/testcook/versions/1.2.3').with(headers: {'X-Jfrog-Art-Api' => 'secret'}).to_return(body: '')
-        stub_request(:post, 'https://artifactory.example/api/chef/chef/api/v1/cookbooks/testcook.tgz').with(headers: {'X-Jfrog-Art-Api' => 'secret'}, body: 'simple').to_return(status: 201)
-        expect { subject }.to_not raise_error
-      end
-    end
-
-  end
-
-  # Break encapsulation a bit to test the ssl_verify configuration.
-  describe '#connection' do
-    let(:url) { 'https://artifactory.example/api/chef/chef' }
-    let(:http) { double('Net::HTTP') }
-    # Make sure we don't use the singleton instance so this stub HTTP object
-    # doesn't get cached on it.
-    subject { described_class.send(:new).send(:connection) }
-    before do
-      allow(http).to receive(:start).and_return(http)
-      Stove::Config.artifactory = url
-    end
-
-    context 'with an HTTPS URI' do
-      it 'enables TLS' do
-        expect(Net::HTTP).to receive(:new).with('artifactory.example', 443).and_return(http)
-        expect(http).to receive(:use_ssl=).with(true)
-        expect(subject).to eq http
-      end
-    end
-
-    context 'with an HTTP URI' do
-      let(:url) { 'http://artifactory.example/api/chef/chef' }
-      it 'does not enable TLS' do
-        expect(Net::HTTP).to receive(:new).with('artifactory.example', 80).and_return(http)
-        expect(http).to_not receive(:use_ssl=)
-        expect(subject).to eq http
-      end
-    end
-
-    context 'with Config.ssl_verify = false' do
-      before { Stove::Config.ssl_verify = false }
-      it 'sets verify mode VERIFY_NONE' do
-        expect(Net::HTTP).to receive(:new).with('artifactory.example', 443).and_return(http)
-        expect(http).to receive(:use_ssl=).with(true)
-        expect(http).to receive(:verify_mode=).with(OpenSSL::SSL::VERIFY_NONE)
-        expect(subject).to eq http
-      end
-    end
-
-    context 'with $STOVE_NO_SSL_VERIFY' do
-      around do |ex|
-        old_value = ENV['STOVE_NO_SSL_VERIFY']
-        ENV['STOVE_NO_SSL_VERIFY'] = 'true'
-        begin
-          ex.run
-        ensure
-          ENV['STOVE_NO_SSL_VERIFY'] = old_value
-        end
-      end
-      it 'sets verify mode VERIFY_NONE' do
-        expect(Net::HTTP).to receive(:new).with('artifactory.example', 443).and_return(http)
-        expect(http).to receive(:use_ssl=).with(true)
-        expect(http).to receive(:verify_mode=).with(OpenSSL::SSL::VERIFY_NONE)
-        expect(subject).to eq http
-      end
-    end
-
-  end
-end

data/spec/unit/cookbook/metadata_spec.rb

@@ -1,176 +0,0 @@
-require 'spec_helper'
-
-class Stove::Cookbook
-  describe Metadata do
-    describe '#to_hash' do
-      context 'when the extra metadata is not included' do
-        it 'does not include the new metadata fields' do
-          hash = subject.to_hash(false)
-          expect(hash).to_not include('issues_url')
-          expect(hash).to_not include('source_url')
-          expect(hash).to_not include('chef')
-        end
-      end
-
-      context 'when the extra metadata is included' do
-        it 'includes the new metadata fields' do
-          subject.source_url('http://foo.example.com')
-          subject.issues_url('http://bar.example.com')
-          subject.gem('rspec')
-          hash = subject.to_hash(true)
-          expect(hash).to include('issues_url')
-          expect(hash['source_url']).to eq 'http://foo.example.com'
-          expect(hash).to include('source_url')
-          expect(hash['issues_url']).to eq 'http://bar.example.com'
-          expect(hash).to include('gems')
-          expect(hash['gems']).to eq([['rspec']])
-        end
-      end
-
-      context 'when the extra metadata is not defined' do
-        it 'does not include the new metadata fields' do
-          hash = subject.to_hash(true)
-          expect(hash).not_to include('source_url')
-          expect(hash).not_to include('issues_url')
-          expect(hash).not_to include('gems')
-        end
-      end
-
-      context 'when only some of the extra metadata is defined' do
-        it 'only includes the source_url if issues_url is empty' do
-          subject.source_url('http://foo.example.com')
-          hash = subject.to_hash(true)
-          expect(hash).to include('source_url')
-          expect(hash['source_url']).to eq 'http://foo.example.com'
-          expect(hash).not_to include('issues_url')
-        end
-
-        it 'only includes the issues_url if source_url is empty' do
-          subject.issues_url('http://bar.example.com')
-          hash = subject.to_hash(true)
-          expect(hash).to include('issues_url')
-          expect(hash['issues_url']).to eq 'http://bar.example.com'
-          expect(hash).not_to include('source_url')
-        end
-
-        it 'only includes the gems' do
-          subject.gem('rspec')
-          hash = subject.to_hash(true)
-          expect(hash).to include('gems')
-          expect(hash['gems']).to eq([['rspec']])
-          expect(hash).not_to include('source_url')
-          expect(hash).not_to include('issues_url')
-        end
-      end
-    end
-
-    describe '#chef_version' do
-      let(:hash_version) { subject.to_hash(true)['chef_version'] }
-
-      context 'with no chef_version line' do
-        it 'returns []' do
-          expect(subject.chef_version).to eq []
-          expect(hash_version).to eq []
-        end
-      end
-
-      context 'with a single chef_version requirement' do
-        it 'returns [[req]]' do
-          subject.chef_version('>= 12.0')
-          expect(subject.chef_version).to eq [['>= 12.0']]
-          expect(hash_version).to eq [['>= 12.0']]
-        end
-      end
-
-      context 'with a multi-part chef_version requirement' do
-        it 'returns [[req1, req2]]' do
-          subject.chef_version('>= 12.0', '< 14.0')
-          expect(subject.chef_version).to eq [['>= 12.0', '< 14.0']]
-          expect(hash_version).to eq [['< 14.0', '>= 12.0',]]
-        end
-      end
-
-      context 'with multiple chef_version requirements' do
-        it 'returns [[req1], [req2]]' do
-          subject.chef_version('< 12')
-          subject.chef_version('> 14')
-          expect(subject.chef_version).to eq [['< 12'], ['> 14']]
-          expect(hash_version).to eq [['< 12'], ['> 14']]
-        end
-      end
-    end
-
-    describe '#ohai_version' do
-      let(:hash_version) { subject.to_hash(true)['ohai_version'] }
-
-      context 'with no ohai_version line' do
-        it 'returns []' do
-          expect(subject.ohai_version).to eq []
-          expect(hash_version).to eq []
-        end
-      end
-
-      context 'with a single ohai_version requirement' do
-        it 'returns [[req]]' do
-          subject.ohai_version('>= 12.0')
-          expect(subject.ohai_version).to eq [['>= 12.0']]
-          expect(hash_version).to eq [['>= 12.0']]
-        end
-      end
-
-      context 'with a multi-part ohai_version requirement' do
-        it 'returns [[req1, req2]]' do
-          subject.ohai_version('>= 12.0', '< 14.0')
-          expect(subject.ohai_version).to eq [['>= 12.0', '< 14.0']]
-          expect(hash_version).to eq [['< 14.0', '>= 12.0',]]
-        end
-      end
-
-      context 'with multiple ohai_version requirements' do
-        it 'returns [[req1], [req2]]' do
-          subject.ohai_version('< 12')
-          subject.ohai_version('> 14')
-          expect(subject.ohai_version).to eq [['< 12'], ['> 14']]
-          expect(hash_version).to eq [['< 12'], ['> 14']]
-        end
-      end
-    end
-
-    describe '#gem' do
-      let(:hash_gems) { subject.to_hash(true)['gems'] }
-
-      context 'with no gem line' do
-        it 'returns []' do
-          expect(subject.gems).to eq []
-          expect(hash_gems).to be_nil
-        end
-      end
-
-      context 'with a single gem dependency' do
-        it 'returns [[gem]]' do
-          subject.gem('nokogiri')
-          expect(subject.gems).to eq [['nokogiri']]
-          expect(hash_gems).to eq [['nokogiri']]
-        end
-      end
-
-      context 'with a gem dependency with a version specifier' do
-        it 'returns [[gem, ver]]' do
-          subject.gem('nokogiri', '>= 1.2.3')
-          expect(subject.gems).to eq [['nokogiri', '>= 1.2.3']]
-          expect(hash_gems).to eq [['nokogiri', '>= 1.2.3']]
-        end
-      end
-
-      context 'with multiple gem dependencies' do
-        it 'returns [[gem1], [gem2]]' do
-          subject.gem('nokogiri')
-          subject.gem('rack')
-          expect(subject.gems).to eq [['nokogiri'], ['rack']]
-          expect(hash_gems).to eq [['nokogiri'], ['rack']]
-        end
-      end
-    end
-
-  end
-end