store_configurable 3.2.5 → 4.0.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: d61bb9df70dd5012cf9cde13b68df65aad18c70c
+  data.tar.gz: a69008e6cc5a32f28a37498f26b840c2c0d9c8ca
+SHA512:
+  metadata.gz: f3c8818369b854dd0f183fc921869726057ecbdb73f0a753535e3850e1a058080f45160e971138aa06b7dc81420e2f27575feb67d4abd10259a52d4d5dab991b
+  data.tar.gz: 2695771a7c648d5369c3ff7754a42de79036d2547802bd403ae96f0b3f72bb701178d5d177eb7386c99e0bcf88a1d3a14a9c7080e4d4ae7e808a6cc8bd8666cd

data/.travis.yml

@@ -1,4 +1,4 @@
 rvm:
-  - 1.8.7
   - 1.9.3
-  - ree
+  - 2.0.0
+  - 2.1.0

data/Appraisals

@@ -0,0 +1,8 @@
+
+appraise 'activerecord40' do
+  gem 'activerecord', '~> 4.0.0'
+end
+
+appraise 'activerecord41' do
+  gem 'activerecord', '~> 4.1.0'
+end

data/Gemfile

@@ -1,2 +1,2 @@
-source :rubygems
+source 'https://rubygems.org'
 gemspec

data/README.md

@@ -1,4 +1,3 @@
-
 # StoreConfigurable
 
 A zero-configuration recursive Hash for storing a tree of options in a serialized ActiveRecord column. Includes self aware hooks that delegate dirty/changed state to your configs owner. Read my article [*A Lesson In Recursion In Ruby*](http://metaskills.net/2012/03/12/store-configurable-a-lesson-in-recursion-in-ruby/) if you are interested in how this library works.
@@ -12,9 +11,11 @@ A zero-configuration recursive Hash for storing a tree of options in a serialize
 Install the gem with bundler. We follow a semantic versioning format that tracks ActiveRecord's minor version. So this means to use the latest 3.2.x version of StoreConfigurable with any ActiveRecord 3.2 version.
 
 ```ruby
-gem 'store_configurable', '~> 3.2.0'
+gem 'store_configurable', '~> 4.0.0'
 ```
 
+Our `4.0.x` versions target both Rails 4.0 and 4.1 only.
+
 
 ## Setup
 
@@ -125,8 +126,25 @@ StoreConfigurable persists your configuration data in YAML format to the `_confi
 * [StoreField](https://github.com/kenn/store_field) - Similar approach but no dirty tracking and still requires manual key configs.
 
 
+## Contributing
+
+StoreConfigurable is fully tested with ActiveRecord 3.2 to 4.0 and upward. If you detect a problem, open up a github issue or fork the repo and help out. After you fork or clone the repository, the following commands will get you up and running on the test suite.
+
+```shell
+$ bundle install
+$ bundle exec appraisal update
+$ bundle exec appraisal rake test
+```
+
+We use the [appraisal](https://github.com/thoughtbot/appraisal) gem from Thoughtbot to help us generate the individual gemfiles for each ActiveSupport version and to run the tests locally against each generated Gemfile. The `rake appraisal test` command actually runs our test suite against all ActiveRecord versions in our `Appraisal` file. If you want to run the tests for a specific ActiveRecord version, use `rake -T` for a list. For example, the following command will run the tests for Rails 3.2 only.
+
+```shell
+$ bundle exec appraisal activerecord40 rake test
+```
+
+
 ## License
 
 * Released under the MIT license thanks to Decisiv, Inc.
-* Copyright (c) 2011 Ken Collins
+* Copyright (c) 2014 Ken Collins
 

data/Rakefile

@@ -1,13 +1,9 @@
-require 'bundler'
+require 'bundler/gem_tasks'
 require 'rake/testtask'
 
-Bundler::GemHelper.install_tasks
-
-desc 'Test the StoreConfigurable gem.'
-Rake::TestTask.new do |t|
+Rake::TestTask.new   do |t|
   t.libs = ['lib','test']
-  t.test_files = Dir.glob("test/**/*_test.rb").sort
+  t.test_files = Dir.glob('test/**/*_test.rb').sort
   t.verbose = true
 end
 
-task :default => [:test]

data/gemfiles/activerecord32.gemfile

@@ -0,0 +1,7 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "activerecord", "~> 3.2.0"
+
+gemspec :path => "../"

data/gemfiles/activerecord32.gemfile.lock

@@ -0,0 +1,44 @@
+PATH
+  remote: ../
+  specs:
+    store_configurable (3.2.5)
+      activerecord (>= 3.2)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    activemodel (3.2.16)
+      activesupport (= 3.2.16)
+      builder (~> 3.0.0)
+    activerecord (3.2.16)
+      activemodel (= 3.2.16)
+      activesupport (= 3.2.16)
+      arel (~> 3.0.2)
+      tzinfo (~> 0.3.29)
+    activesupport (3.2.16)
+      i18n (~> 0.6, >= 0.6.4)
+      multi_json (~> 1.0)
+    appraisal (1.0.0)
+      bundler
+      rake
+      thor (>= 0.14.0)
+    arel (3.0.3)
+    builder (3.0.4)
+    i18n (0.6.9)
+    minitest (5.3.3)
+    multi_json (1.9.2)
+    rake (10.3.0)
+    sqlite3 (1.3.9)
+    thor (0.19.1)
+    tzinfo (0.3.39)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  activerecord (~> 3.2.0)
+  appraisal
+  minitest
+  rake
+  sqlite3
+  store_configurable!

data/gemfiles/activerecord40.gemfile

@@ -0,0 +1,7 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "activerecord", "~> 4.0.0"
+
+gemspec :path => "../"

data/gemfiles/activerecord40.gemfile.lock

@@ -0,0 +1,60 @@
+PATH
+  remote: ../
+  specs:
+    store_configurable (4.0.0)
+      activerecord (>= 4.0, < 4.2)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    activemodel (4.0.12)
+      activesupport (= 4.0.12)
+      builder (~> 3.1.0)
+    activerecord (4.0.12)
+      activemodel (= 4.0.12)
+      activerecord-deprecated_finders (~> 1.0.2)
+      activesupport (= 4.0.12)
+      arel (~> 4.0.0)
+    activerecord-deprecated_finders (1.0.3)
+    activesupport (4.0.12)
+      i18n (~> 0.6, >= 0.6.9)
+      minitest (~> 4.2)
+      multi_json (~> 1.3)
+      thread_safe (~> 0.1)
+      tzinfo (~> 0.3.37)
+    appraisal (1.0.2)
+      bundler
+      rake
+      thor (>= 0.14.0)
+    arel (4.0.2)
+    builder (3.1.4)
+    coderay (1.1.0)
+    i18n (0.6.11)
+    method_source (0.8.2)
+    minitest (4.7.5)
+    minitest-focus (1.1.0)
+      minitest (>= 4, < 6)
+    multi_json (1.10.1)
+    pry (0.10.1)
+      coderay (~> 1.1.0)
+      method_source (~> 0.8.1)
+      slop (~> 3.4)
+    rake (10.4.1)
+    slop (3.6.0)
+    sqlite3 (1.3.10)
+    thor (0.19.1)
+    thread_safe (0.3.4)
+    tzinfo (0.3.42)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  activerecord (~> 4.0.0)
+  appraisal
+  minitest
+  minitest-focus
+  pry
+  rake
+  sqlite3
+  store_configurable!

data/gemfiles/activerecord41.gemfile

@@ -0,0 +1,7 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "activerecord", "~> 4.1.0"
+
+gemspec :path => "../"

data/gemfiles/activerecord41.gemfile.lock

@@ -0,0 +1,59 @@
+PATH
+  remote: ../
+  specs:
+    store_configurable (4.0.0)
+      activerecord (>= 4.0, < 4.2)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    activemodel (4.1.8)
+      activesupport (= 4.1.8)
+      builder (~> 3.1)
+    activerecord (4.1.8)
+      activemodel (= 4.1.8)
+      activesupport (= 4.1.8)
+      arel (~> 5.0.0)
+    activesupport (4.1.8)
+      i18n (~> 0.6, >= 0.6.9)
+      json (~> 1.7, >= 1.7.7)
+      minitest (~> 5.1)
+      thread_safe (~> 0.1)
+      tzinfo (~> 1.1)
+    appraisal (1.0.2)
+      bundler
+      rake
+      thor (>= 0.14.0)
+    arel (5.0.1.20140414130214)
+    builder (3.2.2)
+    coderay (1.1.0)
+    i18n (0.6.11)
+    json (1.8.1)
+    method_source (0.8.2)
+    minitest (5.4.3)
+    minitest-focus (1.1.0)
+      minitest (>= 4, < 6)
+    pry (0.10.1)
+      coderay (~> 1.1.0)
+      method_source (~> 0.8.1)
+      slop (~> 3.4)
+    rake (10.4.1)
+    slop (3.6.0)
+    sqlite3 (1.3.10)
+    thor (0.19.1)
+    thread_safe (0.3.4)
+    tzinfo (1.2.2)
+      thread_safe (~> 0.1)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  activerecord (~> 4.1.0)
+  appraisal
+  minitest
+  minitest-focus
+  pry
+  rake
+  sqlite3
+  store_configurable!

data/lib/store_configurable.rb

@@ -3,5 +3,5 @@ require 'store_configurable/version'
 require 'store_configurable/dirty_options'
 require 'store_configurable/object'
 require 'store_configurable/serialization'
-require 'store_configurable/read'
+require 'store_configurable/behavior'
 require 'store_configurable/base'

data/lib/store_configurable/base.rb

@@ -2,14 +2,14 @@ require 'active_support/concern'
 
 module StoreConfigurable
   module Base
-    
+
     extend ActiveSupport::Concern
-    
+
     module ClassMethods
-      
+
       # To use StoreConfigurable, you must create create a +_config+ colun in the mdoel's table.
       # Make sure that you declare this column as a text type, so there's plenty of room.
-      # 
+      #
       #   class AddStoreConfigurableField < ActiveRecord::Migration
       #     def up
       #       add_column :users, :_config, :text
@@ -18,20 +18,21 @@ module StoreConfigurable
       #       remove_column :users, :_config
       #     end
       #   end
-      # 
+      #
       # Next declare that your model uses StoreConfigurable with the +store_configurable+ method.
       # Please read the +config+ documentation for usage examples.
-      # 
+      #
       #   class User < ActiveRecord::Base
       #     store_configurable
       #   end
+      #
       def store_configurable
         serialize '_config', StoreConfigurable::Object
-        include Read
+        include StoreConfigurable::Behavior
       end
-      
+
     end
-    
+
   end
 end
 

data/lib/store_configurable/{read.rb → behavior.rb}

@@ -1,66 +1,65 @@
 module StoreConfigurable
-  module Read
+  module Behavior
 
-    # Our main syntatic interface to the underlying +_config+ store. This method ensures that 
-    # +self+, the store's owner, will allways be set in the config object. Hence allowing all 
+    # Our main syntatic interface to the underlying +_config+ store. This method ensures that
+    # +self+, the store's owner, will allways be set in the config object. Hence allowing all
     # other recursive options to get a handle back to the owner.
-    # 
-    # The config object can be treated as a Hash but in actuality is an enhanced subclass of 
-    # +ActiveSupport::OrderedOptions+ that does two important things. First, it allows you to 
+    #
+    # The config object can be treated as a Hash but in actuality is an enhanced subclass of
+    # +ActiveSupport::OrderedOptions+ that does two important things. First, it allows you to
     # dynamically define any nested namespace property. Second, it hooks back into your parent
     # object to notify it of change via ActiveRecord's dirty support.
-    # 
+    #
     # Example:
-    # 
+    #
     #   class User < ActiveRecord::Base
     #     store_configurable
     #   end
-    #   
+    #
     #   user = User.find(42)
     #   user.config.remember_me = true
     #   user.config.sortable_tables.products.sort_on = 'created_at'
     #   user.config.sortable_tables.products.direction = 'asc'
     #   user.changed?        # => true
     #   user.config_changed? # => true
+    #
     def config
       _config.__store_configurable_owner__ = self
       _config
     end
-    
+
     # Simple delegation to the underlying data attribute's changed query method.
+    #
     def config_changed?
       _config_changed?
     end
-    
+
     # Simple delegation to the underlying data attribute's change array.
+    #
     def config_change
       _config_change
     end
-    
+
     # An override to ActiveRecord's accessor for the sole purpoes of injecting +Serialization+
-    # behavior so that we can set the context of this owner and ensure we pass that down to 
-    # the YAML coder. Doing this on a per instance basis keeps us from trumping all other 
+    # behavior so that we can set the context of this owner and ensure we pass that down to
+    # the YAML coder. Doing this on a per instance basis keeps us from trumping all other
     # +ActiveRecord::AttributeMethods::Serialization::Attribute+ objects.
+    #
     def _config
       attrib = @attributes['_config']
       unless attrib.respond_to?(:__store_configurable_owner__)
-        attrib.extend Serialization 
+        attrib.extend Serialization
         attrib.__store_configurable_owner__ = self
       end
       super
     end
-    
-    # An override to ActiveRecord's low level read_attribute so we can setup the config object.
-    def read_attribute(attr_name)
-      config
-      super
-    end
 
-    # We never want the `_config` key in the list of attributes. This keeps practically keeps
-    # ActiveRecord from always saving this serialized column too
+    # We never want the `_config` key in the list of attributes. This keeps ActiveRecord
+    # from always saving this serialized column too.
+    #
     def attributes
       super.tap { |x| x.delete('_config') }
     end
-    
+
   end
 end

data/lib/store_configurable/dirty_options.rb

@@ -1,79 +1,81 @@
 require 'active_support/ordered_options'
 
 module StoreConfigurable
-  
+
   # The heart of StoreConfigurable's data store is this subclass of ActiveSupport's OrderedOptions.
   # They are the heart of Rails' configurations and allow you to dynamically set and get hash keys
-  # and values using dot property notation vs the +[]+ hash accessors. 
-  # 
-  # However, instances of DirtyTrackingOrderedOptions use a recursive lambda via Hash's block 
+  # and values using dot property notation vs the +[]+ hash accessors.
+  #
+  # However, instances of DirtyTrackingOrderedOptions use a recursive lambda via Hash's block
   # initialization syntax so that you get a dynamic and endless scope on config data. Instances of
   # DirtyTrackingOrderedOptions also make sure that every sub instance of it self also has a handle
-  # back to your store's owner. In this way when config attributes are added or values change, 
+  # back to your store's owner. In this way when config attributes are added or values change,
   # we can mark your ActiveRecord object as dirty/changed.
+  #
   class DirtyTrackingOrderedOptions < ::ActiveSupport::OrderedOptions
-    
+
     Recursive = lambda { |h,k| h[k] = h.class.new(h.__store_configurable_owner__) }
-    
+
     attr_accessor :__store_configurable_owner__
-    
+
     def initialize(owner)
       @__store_configurable_owner__ = owner
       super(&Recursive)
     end
-    
+
     def []=(key, value)
       _config_may_change!(key, value)
       super
     end
-      
+
     def delete(key)
       name = key.to_sym
       _config_will_change! if has_key?(name)
       super
     end
-      
+
     def delete_if
       _with_config_keys_may_change! { super }
     end
-      
+
     def dup
       raise NotImplementedError, 'the StoreConfigurable::Object does not support making a copy'
     end
     alias_method :reject, :dup
-    
+
     def merge(other)
       dup
     end
-      
+
     def reject!
       _with_config_keys_may_change! { super }
     end
-      
+
     def clear
       _config_will_change!
       super
     end
-    
-    
+
+
     protected
-    
+
     def _with_config_keys_may_change!
       starting_keys = keys.dup
       yield
       _config_will_change! if starting_keys != keys
       self
     end
-      
+
     def _config_may_change!(key, value)
       name = key.to_sym
       _config_will_change! unless has_key?(name) && self[name] == value
     end
-      
+
     def _config_will_change!
+      return unless __store_configurable_owner__
       __store_configurable_owner__._config_will_change!
     end
-    
+
   end
-  
-end
+
+end

data/lib/store_configurable/object.rb

@@ -1,75 +1,86 @@
-require 'active_support/basic_object'
+require 'active_support/proxy_object'
 
 module StoreConfigurable
-  
+
   # The is the object returned by the +config+ method. It does nothing more than delegate
   # all calls to a tree of +DirtyTrackingOrderedOptions+ objects which are basically hashes.
-  class Object < ::ActiveSupport::BasicObject
-    
-    # Class methods so the +StoreConfigurable::Object+ responds to +dump+ and +load+ which 
-    # allows it to conform to ActiveRecord's coder requirement via its serialize method 
-    # that we use. 
-    # 
-    # The +dump+ method serializes the raw data behind the +StoreConfigurable::Object+ proxy 
-    # object. This means that we only store pure ruby primitives in the datbase, not our 
+  #
+  class Object < ::ActiveSupport::ProxyObject
+
+    OMAP_CONVERTER = lambda do |config|
+      ::ActiveSupport::OrderedHash[config.to_a].tap do |omap|
+        omap.each { |k,v| omap[k] = OMAP_CONVERTER.call(v) if v.is_a?(::Hash) }
+      end
+    end
+
+    YAML_LOADER = lambda do |options, key, value|
+      value.is_a?(::Hash) ? value.each { |k,v| YAML_LOADER.call(options.send(:[],key), k, v) } :
+        options.send(:[]=, key, value)
+    end
+
+    # Class methods so the +StoreConfigurable::Object+ responds to +dump+ and +load+ which
+    # allows it to conform to ActiveRecord's coder requirement via its serialize method
+    # that we use.
+    #
+    # The +dump+ method serializes the raw data behind the +StoreConfigurable::Object+ proxy
+    # object. This means that we only store pure ruby primitives in the datbase, not our
     # proxy object's YAML type.
-    # 
-    # The +load+ method mimics +ActiveRecord::Coders::YAMLColumn+ internals by retuning a 
-    # new object when needed as well as making sure that the YAML we are process if of the 
-    # same type. When reconstituting  a +StoreConfigurable::Object+ we must set the store's 
-    # owner as this does. That way as our recursive  lambda loader regenerates the tree of 
-    # config data, we always have a handle for each +DirtyTrackingOrderedOptions+ object to 
-    # report state changes back to the owner. Finally, after each load we make sure to clear 
+    #
+    # The +load+ method mimics +ActiveRecord::Coders::YAMLColumn+ internals by retuning a
+    # new object when needed as well as making sure that the YAML we are process if of the
+    # same type. When reconstituting  a +StoreConfigurable::Object+ we must set the store's
+    # owner as this does. That way as our recursive  lambda loader regenerates the tree of
+    # config data, we always have a handle for each +DirtyTrackingOrderedOptions+ object to
+    # report state changes back to the owner. Finally, after each load we make sure to clear
     # out changes so reloaded objects are not marked as dirty.
+    #
     module Coding
-      
+
       def dump(value)
-        YAML.dump value.__config__
+        config = (value.nil? ? StoreConfigurable::Object.new : value).__config__
+        YAML.dump OMAP_CONVERTER.call(config)
       end
-      
-      def load(yaml, owner)
+
+      def load(yaml, owner=nil)
         return StoreConfigurable::Object.new if yaml.blank?
         return yaml unless yaml.is_a?(String) && yaml =~ /^---/
         stored_data = YAML.load(yaml)
         unless stored_data.is_a?(Hash)
-          raise ActiveRecord::SerializationTypeMismatch, 
+          raise ActiveRecord::SerializationTypeMismatch,
            "Attribute was supposed to be a Hash, but was a #{stored_data.class}"
         end
         config = StoreConfigurable::Object.new
         config.__store_configurable_owner__ = owner
-        loader = lambda do |options, key, value|
-          value.is_a?(Hash) ? value.each { |k,v| loader.call(options.send(:[],key), k, v) } : 
-            options.send(:[]=, key, value)
-        end
-        stored_data.each { |k,v| loader.call(config, k, v) }
-        owner.changed_attributes.delete('_config')
+        stored_data.each { |k,v| YAML_LOADER.call(config, k, v) }
+        owner.changed_attributes.delete('_config') if owner
         config
       end
-      
+
     end
-    
-    # Instance methods for +StoreConfigurable::Object+ defined and included in a module so 
+
+    # Instance methods for +StoreConfigurable::Object+ defined and included in a module so
     # that if you ever wanted to, you could redefine these methods and +super+ up.
+    #
     module Behavior
-      
+
       attr_accessor :__store_configurable_owner__
-      
+
       def __config__
         @__config__ ||= DirtyTrackingOrderedOptions.new(@__store_configurable_owner__)
       end
-      
+
       private
 
       def method_missing(method, *args, &block)
         __config__.__send__ method, *args, &block
       end
-      
+
     end
-    
+
     extend Coding
     include Behavior
-    
+
   end
-  
+
 end
 

data/lib/store_configurable/serialization.rb

@@ -1,18 +1,19 @@
 module StoreConfigurable
-  
+
   # This module's behavior is injected into +ActiveRecord::AttributeMethods::Serialization::Attribute+
   # class which is a mini state machine for serialized objects. It allows us to both set the store's
-  # owner as well as overwrite the +unserialize+ method to give the coder both the YAML and owner 
+  # owner as well as overwrite the +unserialize+ method to give the coder both the YAML and owner
   # context. This is done via the +_config+ attribute reader override.
+  #
   module Serialization
-    
+
     attr_accessor :__store_configurable_owner__
-    
-    def unserialize
+
+    def unserialize(v)
       self.state = :unserialized
-      self.value = coder.load(value, __store_configurable_owner__)
+      self.value = coder.load(v, __store_configurable_owner__)
     end
-    
+
   end
-  
+
 end

data/lib/store_configurable/version.rb

@@ -1,6 +1,7 @@
 module StoreConfigurable
-  
+
   # We track ActiveRecord's major and minor version and follow semantic versioning.
-  VERSION = '3.2.5'
-  
+  #
+  VERSION = '4.0.0'
+
 end

data/test/cases/base_test.rb

@@ -1,37 +1,39 @@
 require 'helper'
 
 class StoreConfigurable::BaseTest < StoreConfigurable::TestCase
-  
+
   it 'is never blank' do
     new_user.config.wont_be_nil
   end
-  
+
   it 'can inspect a new user' do
     new_user.inspect
   end
-  
+
   it 'can set and get root attributes' do
     new_user.config.foo = 'foo'
     new_user.config.foo.must_equal 'foo'
   end
-  
+
   it 'can set and get adhoc nested options' do
     options = {:this => 'that'}
     new_user.config.foo.bar.options = options
     new_user.config.foo.bar.options.must_equal options
   end
-  
+
   it 'can serialize to yaml' do
     user_ken.config.foo = 'bar'
-    user_ken.config.to_yaml.must_include '--- !omap'
-    user_ken.config.to_yaml.must_include ':foo: bar'
+    user_ken.save!
+    raw_config = User.connection.select_value "SELECT _config FROM users WHERE id = #{user_ken.id}"
+    raw_config.must_include '--- !omap'
+    raw_config.must_include ':foo: bar'
   end
-  
+
   it 'wont mark owner as dirty after initial read from database with no existing config' do
     user_ken.config
     user_ken.wont_be :config_changed?
   end
-  
+
   it 'can use uncool hash syntax if you want with varying techniques of strings, symbols and calls' do
     user_ken.config.color = 'black'
     user_ken.config['remember_me'] = true
@@ -45,16 +47,16 @@ class StoreConfigurable::BaseTest < StoreConfigurable::TestCase
     user_ken.config.sortable_tables[:direction].must_equal 'asc'
     user_ken.config[:sortable_tables][:column].must_equal 'updated_at'
   end
-  
+
   it 'must mark owner as dirty after missing getter since that inits a new namespace' do
     user_ken.config.bar
     user_ken.must_be :config_changed?
   end
-  
+
   it 'does not support dup, reject, merge' do
-    lambda{ user_ken.config.dup }.must_raise(NotImplementedError) 
+    lambda{ user_ken.config.dup }.must_raise(NotImplementedError)
     lambda{ user_ken.config.reject{} }.must_raise(NotImplementedError)
-    lambda{ user_ken.config.merge({}) }.must_raise(NotImplementedError) 
+    lambda{ user_ken.config.merge({}) }.must_raise(NotImplementedError)
   end
 
   it 'can save unsafe keys' do
@@ -62,14 +64,14 @@ class StoreConfigurable::BaseTest < StoreConfigurable::TestCase
     user_ken.config.sortable_tables[:posts][:sort].dir = 'asc'
     user_ken.save!
   end
-  
+
   describe 'existing data' do
-    
+
     let(:color)       { '#c1c1c1' }
     let(:remember)    { true }
     let(:deep_value)  { StorableObject.new('test') }
     let(:plugin_opts) { Hash[:sort,'asc',:on,true] }
-    
+
     before do
       user_ken.config.color = color
       user_ken.config.remember_me = remember
@@ -95,14 +97,14 @@ class StoreConfigurable::BaseTest < StoreConfigurable::TestCase
       assert_queries(1) { @user.save! }
       User.find(@user.id).config.color.must_equal new_color
     end
-    
+
     it 'can reconsitute saved values' do
       @user.config.color.must_equal color
       @user.config.remember_me.must_equal remember
       @user.config.plugin.options.must_equal plugin_opts
       @user.config.you.should.never.need.to.do.this.must_equal deep_value
     end
-    
+
     it 'wont be dirty after reading saved configs' do
       @user.config.color
       @user.config.remember_me
@@ -110,7 +112,7 @@ class StoreConfigurable::BaseTest < StoreConfigurable::TestCase
       @user.config.you.should.never.need.to.do.this
       @user.wont_be :config_changed?
     end
-    
+
     it 'wont be dirty when setting same config values' do
       @user.config.color = color
       @user.config.remember_me = remember
@@ -118,65 +120,98 @@ class StoreConfigurable::BaseTest < StoreConfigurable::TestCase
       @user.config.you.should.never.need.to.do.this = deep_value
       @user.wont_be :config_changed?
     end
-    
+
     it 'must be marked dirty when values change' do
       @user.config.color = 'black'
       @user.must_be :config_changed?
       @user.save!
       @user.config.color.must_equal 'black'
     end
-    
+
     it 'must be marked dirty when clearing' do
       @user.config.clear
       @user.must_be :config_changed?
       @user.save!
       @user.config.must_be :blank?
     end
-    
+
     it 'must be marked dirty when deleting a key' do
       @user.config.delete :color
       @user.must_be :config_changed?
       @user.save!
       @user.config.has_key?(:color).must_equal false
     end
-    
+
     it 'wont be marked dirty when deleting a non-existent key' do
       @user.config.delete :doesnotexist
       @user.wont_be :config_changed?
     end
-    
+
     it 'must be marked dirty when using delete_if' do
       @user.config.delete_if { |k,v| true }
       @user.must_be :config_changed?
       @user.config.must_be :blank?
     end
-    
+
     it 'wont be marked dirty when using delete_if and nothing happens' do
       @user.config.delete_if { |k,v| false }
       @user.wont_be :config_changed?
       @user.config.you.should.never.need.to.do.this = deep_value
     end
-    
+
     it 'must be marked dirty when using reject! on true' do
       @user.config.reject! { |k,v| true }
       @user.must_be :config_changed?
       @user.config.must_be :blank?
     end
-    
+
     it 'can pass off nodes and still work properly' do
       need = @user.config.you.should.never.need
       need.moar = 'winning'
       @user.must_be :config_changed?
     end
-    
+
     it 'can resave unsafe keys' do
       @user.config.sortable_tables[:comments][:sort].on = 'title'
       @user.config.sortable_tables[:comments][:sort].dir = 'asc'
       @user.save!
     end
-    
+
+  end
+
+  describe 'legacy data' do
+
+    let(:omap_yaml) { omap_yaml_string.strip }
+
+    it 'can use omap yaml' do
+      conn = User.connection
+      conn.execute "UPDATE users SET _config=#{conn.quote(omap_yaml)} WHERE id=#{user_ken.id}"
+      user = User.find(user_ken.id)
+      user.config.sortable_tables.column.must_equal 'created_at'
+    end
+
+  end
+
+
+
+  private
+
+  def omap_yaml_string
+    <<YAML
+--- !omap
+- :remember_me: true
+- :sortable_tables: !omap
+  - :column: created_at
+  - :direction: asc
+- :you: !omap
+  - :should: !omap
+    - :never: !omap
+      - :need: !omap
+        - :to: !omap
+          - :do: !omap
+            - :this: deep_value
+YAML
   end
 
-  
 end
 

data/test/helper.rb

@@ -1,55 +1,46 @@
-require 'rubygems'
-require 'bundler'
-require 'bundler/setup'
-Bundler.require
+require 'bundler' ; Bundler.require :development, :test
 require 'store_configurable'
-require 'active_record/base'
 require 'support/activerecord'
 require 'minitest/autorun'
 require 'logger'
 
-
-ActiveRecord::Base.logger = Logger.new(File.join(File.dirname(__FILE__),'debug.log'))
+ActiveRecord::Base.logger = Logger.new('/dev/null')
 ActiveRecord::Base.establish_connection :adapter => 'sqlite3', :database => ':memory:'
 
-
 module StoreConfigurable
   class TestCase < MiniTest::Spec
 
     include ActiveRecordTestHelper
-    
+
     before { setup_environment }
-    
+
     let(:new_user) { User.new }
-    let(:user_ken) { User.find_by_email('ken@metaskills.net') }
-    let(:post_sc)  { Post.find_by_title('StoreConfigurable') }
-    
+    let(:user_ken) { User.where(:email => 'ken@metaskills.net').first }
+
     def setup_environment
       setup_database
       setup_data
     end
-    
+
     protected
 
     def setup_database
       ActiveRecord::Base.class_eval do
-        silence do
-          connection.create_table :users, :force => true do |t|
-            t.string  :name, :email
-            t.text    :_config
-          end
-          connection.create_table :posts, :force => true do |t|
-            t.string  :title, :body
-          end
+        connection.create_table :users, :force => true do |t|
+          t.string  :name, :email
+          t.text    :_config
+        end
+        connection.create_table :posts, :force => true do |t|
+          t.string  :title, :body
         end
       end
     end
-    
+
     def setup_data
       User.create :name => 'Ken Collins', :email => 'ken@metaskills.net'
       Post.create :title => 'StoreConfigurable', :body => 'test'
     end
-    
+
   end
 end
 
@@ -63,5 +54,5 @@ class User < ActiveRecord::Base
   store_configurable
 end
 
-class Post < ActiveRecord::Base  
+class Post < ActiveRecord::Base
 end

data/test/support/activerecord.rb

@@ -4,7 +4,7 @@ module StoreConfigurable
     protected
 
     class SQLCounter
-      
+
       class << self
         attr_accessor :ignored_sql, :log
       end
@@ -23,7 +23,7 @@ module StoreConfigurable
         return if 'CACHE' == values[:name] || ignore =~ sql
         self.class.log << sql
       end
-      
+
     end
 
     def assert_sql(*patterns_to_match)
@@ -48,4 +48,4 @@ module StoreConfigurable
     ActiveSupport::Notifications.subscribe 'sql.active_record', SQLCounter.new
 
   end
-end
+end

metadata

@@ -1,80 +1,119 @@
 --- !ruby/object:Gem::Specification
 name: store_configurable
 version: !ruby/object:Gem::Version
-  version: 3.2.5
-  prerelease: 
+  version: 4.0.0
 platform: ruby
 authors:
 - Ken Collins
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-09-25 00:00:00.000000000 Z
+date: 2014-12-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 3.2.0
+        version: '4.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '4.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '4.0'
+    - - "<"
       - !ruby/object:Gem::Version
-        version: 3.2.0
+        version: '4.2'
+- !ruby/object:Gem::Dependency
+  name: appraisal
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.9.2
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.9.2
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: minitest-focus
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 2.8.1
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 2.8.1
+        version: '0'
 description: Grown up ActiveRecord::Store config options!
 email:
 - ken@metaskills.net
@@ -82,18 +121,25 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .travis.yml
+- ".gitignore"
+- ".travis.yml"
+- Appraisals
 - CHANGELOG
 - Gemfile
 - MIT-LICENSE
 - README.md
 - Rakefile
+- gemfiles/activerecord32.gemfile
+- gemfiles/activerecord32.gemfile.lock
+- gemfiles/activerecord40.gemfile
+- gemfiles/activerecord40.gemfile.lock
+- gemfiles/activerecord41.gemfile
+- gemfiles/activerecord41.gemfile.lock
 - lib/store_configurable.rb
 - lib/store_configurable/base.rb
+- lib/store_configurable/behavior.rb
 - lib/store_configurable/dirty_options.rb
 - lib/store_configurable/object.rb
-- lib/store_configurable/read.rb
 - lib/store_configurable/serialization.rb
 - lib/store_configurable/version.rb
 - test/cases/base_test.rb
@@ -101,32 +147,30 @@ files:
 - test/support/activerecord.rb
 homepage: http://github.com/metaskills/store_configurable/
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options:
-- --charset=UTF-8
+- "--charset=UTF-8"
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.23
+rubygems_version: 2.4.2
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: A zero-configuration recursive Hash for storing a tree of options in a serialized
   ActiveRecord column.
 test_files:
 - test/cases/base_test.rb
 - test/helper.rb
 - test/support/activerecord.rb
-has_rdoc: