stoplight 2.2.1 → 3.0.1

data/spec/stoplight/data_store/memory_spec.rb

@@ -1,4 +1,4 @@
-# coding: utf-8
+# frozen_string_literal: true
 
 require 'spec_helper'
 
@@ -130,4 +130,30 @@ RSpec.describe Stoplight::DataStore::Memory do
       expect(data_store.get_state(light)).to eql(Stoplight::State::UNLOCKED)
     end
   end
+
+  describe '#with_notification_lock' do
+    context 'when notification is already sent' do
+      before do
+        data_store.with_notification_lock(light, Stoplight::Color::GREEN, Stoplight::Color::RED) {}
+      end
+
+      it 'does not yield passed block' do
+        expect do |b|
+          data_store.with_notification_lock(light, Stoplight::Color::GREEN, Stoplight::Color::RED, &b)
+        end.not_to yield_control
+      end
+    end
+
+    context 'when notification is not already sent' do
+      before do
+        data_store.with_notification_lock(light, Stoplight::Color::GREEN, Stoplight::Color::RED) {}
+      end
+
+      it 'yields passed block' do
+        expect do |b|
+          data_store.with_notification_lock(light, Stoplight::Color::RED, Stoplight::Color::GREEN, &b)
+        end.to yield_control
+      end
+    end
+  end
 end

data/spec/stoplight/data_store/redis_spec.rb

@@ -1,17 +1,16 @@
-# coding: utf-8
+# frozen_string_literal: true
 
 require 'spec_helper'
-require 'fakeredis'
+require 'mock_redis'
 
 RSpec.describe Stoplight::DataStore::Redis do
-  let(:data_store) { described_class.new(redis) }
-  let(:redis) { Redis.new }
+  let(:data_store) { described_class.new(redis, redlock: redlock) }
+  let(:redis) { MockRedis.new }
+  let(:redlock) { instance_double(Redlock::Client) }
   let(:light) { Stoplight::Light.new(name) {} }
   let(:name) { ('a'..'z').to_a.shuffle.join }
   let(:failure) { Stoplight::Failure.new('class', 'message', Time.new) }
 
-  before { Redis::Connection::Memory.reset_all_databases }
-
   it 'is a class' do
     expect(described_class).to be_a(Class)
   end
@@ -143,4 +142,36 @@ RSpec.describe Stoplight::DataStore::Redis do
       expect(data_store.get_state(light)).to eql(Stoplight::State::UNLOCKED)
     end
   end
+
+  describe '#with_notification_lock' do
+    let(:lock_key) { "stoplight:notification_lock:#{name}" }
+
+    before do
+      allow(redlock).to receive(:lock).with(lock_key, 2_000).and_yield
+    end
+
+    context 'when notification is already sent' do
+      before do
+        data_store.with_notification_lock(light, Stoplight::Color::GREEN, Stoplight::Color::RED) {}
+      end
+
+      it 'does not yield passed block' do
+        expect do |b|
+          data_store.with_notification_lock(light, Stoplight::Color::GREEN, Stoplight::Color::RED, &b)
+        end.not_to yield_control
+      end
+    end
+
+    context 'when notification is not already sent' do
+      before do
+        data_store.with_notification_lock(light, Stoplight::Color::GREEN, Stoplight::Color::RED) {}
+      end
+
+      it 'yields passed block' do
+        expect do |b|
+          data_store.with_notification_lock(light, Stoplight::Color::RED, Stoplight::Color::GREEN, &b)
+        end.to yield_control
+      end
+    end
+  end
 end

data/spec/stoplight/data_store_spec.rb

@@ -1,4 +1,4 @@
-# coding: utf-8
+# frozen_string_literal: true
 
 require 'spec_helper'
 

data/spec/stoplight/default_spec.rb

@@ -1,4 +1,4 @@
-# coding: utf-8
+# frozen_string_literal: true
 
 require 'spec_helper'
 

data/spec/stoplight/error_spec.rb

@@ -1,4 +1,4 @@
-# coding: utf-8
+# frozen_string_literal: true
 
 require 'spec_helper'
 

data/spec/stoplight/failure_spec.rb

@@ -1,4 +1,4 @@
-# coding: utf-8
+# frozen_string_literal: true
 
 require 'spec_helper'
 

data/spec/stoplight/light/runnable_spec.rb

@@ -1,4 +1,4 @@
-# coding: utf-8
+# frozen_string_literal: true
 
 require 'spec_helper'
 require 'stringio'
@@ -8,7 +8,7 @@ RSpec.describe Stoplight::Light::Runnable do
 
   let(:code) { -> { code_result } }
   let(:code_result) { random_string }
-  let(:fallback) { -> (_) { fallback_result } }
+  let(:fallback) { ->(_) { fallback_result } }
   let(:fallback_result) { random_string }
   let(:name) { random_string }
 
@@ -109,6 +109,38 @@ RSpec.describe Stoplight::Light::Runnable do
           expect(subject.data_store.get_failures(subject).size).to eql(1)
         end
 
+        context 'when we did not send notifications yet' do
+          it 'notifies when transitioning to red' do
+            subject.threshold.times do
+              expect(io.string).to eql('')
+              begin
+                subject.run
+              rescue error.class
+                nil
+              end
+            end
+            expect(io.string).to_not eql('')
+          end
+        end
+
+        context 'when we already sent notifications' do
+          before do
+            subject.data_store.with_notification_lock(subject, Stoplight::Color::GREEN, Stoplight::Color::RED) {}
+          end
+
+          it 'does not send new notifications' do
+            subject.threshold.times do
+              expect(io.string).to eql('')
+              begin
+                subject.run
+              rescue error.class
+                nil
+              end
+            end
+            expect(io.string).to eql('')
+          end
+        end
+
         it 'notifies when transitioning to red' do
           subject.threshold.times do
             expect(io.string).to eql('')
@@ -123,12 +155,10 @@ RSpec.describe Stoplight::Light::Runnable do
 
         context 'with an error handler' do
           let(:result) do
-            begin
-              subject.run
-              expect(false).to be(true)
-            rescue error.class
-              expect(true).to be(true)
-            end
+            subject.run
+            expect(false).to be(true)
+          rescue error.class
+            expect(true).to be(true)
           end
 
           it 'records the failure when the handler does nothing' do
@@ -171,7 +201,7 @@ RSpec.describe Stoplight::Light::Runnable do
 
       context 'when the data store is failing' do
         let(:data_store) { Object.new }
-        let(:error_notifier) { -> (_) {} }
+        let(:error_notifier) { ->(_) {} }
 
         before do
           subject

data/spec/stoplight/light_spec.rb

@@ -1,4 +1,4 @@
-# coding: utf-8
+# frozen_string_literal: true
 
 require 'spec_helper'
 require 'stringio'
@@ -42,7 +42,7 @@ RSpec.describe Stoplight::Light do
     after { described_class.default_error_notifier = @default_error_notifier }
 
     it 'sets the error notifier' do
-      default_error_notifier = -> (_) {}
+      default_error_notifier = ->(_) {}
       described_class.default_error_notifier = default_error_notifier
       expect(described_class.default_error_notifier)
         .to eql(default_error_notifier)
@@ -140,7 +140,7 @@ RSpec.describe Stoplight::Light do
 
   describe '#with_error_handler' do
     it 'sets the error handler' do
-      error_handler = -> (_, _) {}
+      error_handler = ->(_, _) {}
       light.with_error_handler(&error_handler)
       expect(light.error_handler).to eql(error_handler)
     end
@@ -148,7 +148,7 @@ RSpec.describe Stoplight::Light do
 
   describe '#with_error_notifier' do
     it 'sets the error notifier' do
-      error_notifier = -> (_) {}
+      error_notifier = ->(_) {}
       light.with_error_notifier(&error_notifier)
       expect(light.error_notifier).to eql(error_notifier)
     end
@@ -156,7 +156,7 @@ RSpec.describe Stoplight::Light do
 
   describe '#with_fallback' do
     it 'sets the fallback' do
-      fallback = -> (_) {}
+      fallback = ->(_) {}
       light.with_fallback(&fallback)
       expect(light.fallback).to eql(fallback)
     end

data/spec/stoplight/notifier/base_spec.rb

@@ -1,4 +1,4 @@
-# coding: utf-8
+# frozen_string_literal: true
 
 require 'spec_helper'
 

data/spec/stoplight/notifier/bugsnag_spec.rb

@@ -1,4 +1,4 @@
-# coding: utf-8
+# frozen_string_literal: true
 
 require 'spec_helper'
 

data/spec/stoplight/notifier/generic_spec.rb

@@ -1,4 +1,4 @@
-# coding: utf-8
+# frozen_string_literal: true
 
 require 'spec_helper'
 

data/spec/stoplight/notifier/honeybadger_spec.rb

@@ -1,4 +1,4 @@
-# coding: utf-8
+# frozen_string_literal: true
 
 require 'spec_helper'
 

data/spec/stoplight/notifier/io_spec.rb

@@ -1,4 +1,4 @@
-# coding: utf-8
+# frozen_string_literal: true
 
 require 'spec_helper'
 require 'stringio'

data/spec/stoplight/notifier/logger_spec.rb

@@ -1,4 +1,4 @@
-# coding: utf-8
+# frozen_string_literal: true
 
 require 'spec_helper'
 require 'logger'

data/spec/stoplight/notifier/pagerduty_spec.rb

@@ -1,4 +1,4 @@
-# coding: utf-8
+# frozen_string_literal: true
 
 require 'spec_helper'
 require 'pagerduty'

data/spec/stoplight/notifier/raven_spec.rb

@@ -1,4 +1,4 @@
-# coding: utf-8
+# frozen_string_literal: true
 
 require 'spec_helper'
 

data/spec/stoplight/notifier/rollbar_spec.rb

@@ -1,4 +1,4 @@
-# coding: utf-8
+# frozen_string_literal: true
 
 require 'spec_helper'
 

data/spec/stoplight/notifier/slack_spec.rb

@@ -1,12 +1,11 @@
-# coding: utf-8
+# frozen_string_literal: true
 
 require 'spec_helper'
 
 # require 'slack-notifier'
 module Slack
   class Notifier
-    def initialize(*)
-    end
+    def initialize(*); end
   end
 end
 

data/spec/stoplight/notifier_spec.rb

@@ -1,4 +1,4 @@
-# coding: utf-8
+# frozen_string_literal: true
 
 require 'spec_helper'
 

data/spec/stoplight/state_spec.rb

@@ -1,4 +1,4 @@
-# coding: utf-8
+# frozen_string_literal: true
 
 require 'spec_helper'
 

data/spec/stoplight/version_spec.rb

@@ -1,4 +1,4 @@
-# coding: utf-8
+# frozen_string_literal: true
 
 require 'spec_helper'
 

data/spec/stoplight_spec.rb

@@ -1,4 +1,4 @@
-# coding: utf-8
+# frozen_string_literal: true
 
 require 'spec_helper'
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: stoplight
 version: !ruby/object:Gem::Version
-  version: 2.2.1
+  version: 3.0.1
 platform: ruby
 authors:
 - Cameron Desautels
@@ -10,92 +10,92 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-07-16 00:00:00.000000000 Z
+date: 2022-12-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: benchmark-ips
+  name: redlock
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.3'
-  type: :development
+        version: '1.0'
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.3'
+        version: '1.0'
 - !ruby/object:Gem::Dependency
-  name: bugsnag
+  name: benchmark-ips
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: '2.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: '2.3'
 - !ruby/object:Gem::Dependency
-  name: coveralls
+  name: bugsnag
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: '4.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: '4.0'
 - !ruby/object:Gem::Dependency
   name: fakeredis
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.5'
+        version: '0.8'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.5'
+        version: '0.8'
 - !ruby/object:Gem::Dependency
-  name: hipchat
+  name: honeybadger
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.5'
+        version: '2.5'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.5'
+        version: '2.5'
 - !ruby/object:Gem::Dependency
-  name: honeybadger
+  name: mock_redis
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.5'
+        version: '0.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.5'
+        version: '0.3'
 - !ruby/object:Gem::Dependency
   name: pagerduty
   requirement: !ruby/object:Gem::Requirement
@@ -116,56 +116,56 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '11.1'
+        version: '13.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '11.1'
+        version: '13.0'
 - !ruby/object:Gem::Dependency
   name: redis
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.2'
+        version: '4.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.2'
+        version: '4.1'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.3'
+        version: '3.11'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.3'
+        version: '3.11'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.40.0
+        version: 1.0.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.40.0
+        version: 1.0.0
 - !ruby/object:Gem::Dependency
   name: sentry-raven
   requirement: !ruby/object:Gem::Requirement
@@ -180,6 +180,34 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.2'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.21'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.21'
+- !ruby/object:Gem::Dependency
+  name: simplecov-lcov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.8'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.8'
 - !ruby/object:Gem::Dependency
   name: slack-notifier
   requirement: !ruby/object:Gem::Requirement
@@ -200,14 +228,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: '0.9'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: '0.9'
 description: An implementation of the circuit breaker pattern.
 email:
 - camdez@gmail.com
@@ -235,7 +263,6 @@ files:
 - lib/stoplight/notifier/base.rb
 - lib/stoplight/notifier/bugsnag.rb
 - lib/stoplight/notifier/generic.rb
-- lib/stoplight/notifier/hip_chat.rb
 - lib/stoplight/notifier/honeybadger.rb
 - lib/stoplight/notifier/io.rb
 - lib/stoplight/notifier/logger.rb
@@ -259,7 +286,6 @@ files:
 - spec/stoplight/notifier/base_spec.rb
 - spec/stoplight/notifier/bugsnag_spec.rb
 - spec/stoplight/notifier/generic_spec.rb
-- spec/stoplight/notifier/hip_chat_spec.rb
 - spec/stoplight/notifier/honeybadger_spec.rb
 - spec/stoplight/notifier/io_spec.rb
 - spec/stoplight/notifier/logger_spec.rb
@@ -271,7 +297,7 @@ files:
 - spec/stoplight/state_spec.rb
 - spec/stoplight/version_spec.rb
 - spec/stoplight_spec.rb
-homepage: https://github.com/orgsync/stoplight
+homepage: https://github.com/bolshakov/stoplight
 licenses:
 - MIT
 metadata: {}
@@ -283,41 +309,40 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.1'
+      version: '2.6'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.3.7
 signing_key:
 specification_version: 4
 summary: Traffic control for code.
 test_files:
 - spec/spec_helper.rb
-- spec/stoplight_spec.rb
+- spec/stoplight/color_spec.rb
+- spec/stoplight/data_store/base_spec.rb
+- spec/stoplight/data_store/memory_spec.rb
+- spec/stoplight/data_store/redis_spec.rb
+- spec/stoplight/data_store_spec.rb
+- spec/stoplight/default_spec.rb
 - spec/stoplight/error_spec.rb
 - spec/stoplight/failure_spec.rb
-- spec/stoplight/notifier/pagerduty_spec.rb
-- spec/stoplight/notifier/raven_spec.rb
+- spec/stoplight/light/runnable_spec.rb
+- spec/stoplight/light_spec.rb
+- spec/stoplight/notifier/base_spec.rb
+- spec/stoplight/notifier/bugsnag_spec.rb
+- spec/stoplight/notifier/generic_spec.rb
+- spec/stoplight/notifier/honeybadger_spec.rb
 - spec/stoplight/notifier/io_spec.rb
 - spec/stoplight/notifier/logger_spec.rb
-- spec/stoplight/notifier/honeybadger_spec.rb
-- spec/stoplight/notifier/generic_spec.rb
-- spec/stoplight/notifier/slack_spec.rb
+- spec/stoplight/notifier/pagerduty_spec.rb
+- spec/stoplight/notifier/raven_spec.rb
 - spec/stoplight/notifier/rollbar_spec.rb
-- spec/stoplight/notifier/base_spec.rb
-- spec/stoplight/notifier/bugsnag_spec.rb
-- spec/stoplight/notifier/hip_chat_spec.rb
-- spec/stoplight/version_spec.rb
-- spec/stoplight/state_spec.rb
+- spec/stoplight/notifier/slack_spec.rb
 - spec/stoplight/notifier_spec.rb
-- spec/stoplight/color_spec.rb
-- spec/stoplight/default_spec.rb
-- spec/stoplight/data_store_spec.rb
-- spec/stoplight/data_store/memory_spec.rb
-- spec/stoplight/data_store/redis_spec.rb
-- spec/stoplight/data_store/base_spec.rb
-- spec/stoplight/light/runnable_spec.rb
-- spec/stoplight/light_spec.rb
+- spec/stoplight/state_spec.rb
+- spec/stoplight/version_spec.rb
+- spec/stoplight_spec.rb