stoplight 0.5.0 → 0.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ad268d747b85be7b3a0d773d9aeec70b1b22c25a
-  data.tar.gz: 56c5c8f88361a3c9d705212d9725251017097ddb
+  metadata.gz: 9619bee3f557017bc7b877349a5a2b5985e535ce
+  data.tar.gz: 5dec1f7bce5d8373cea3747e8dc587e0795e19c2
 SHA512:
-  metadata.gz: 043418c2e767031b2a229ad2e22d378c52101d342cdec3bb600bec88c5c46238c345eadb558d779ccedb8f60122b81b5cddf969dfb7dbf475e7bfe3e0cb7b3c2
-  data.tar.gz: 8a9952d663eb04f03e05736f3541ac09b69e69776c80265116d43a7c4c4e2e8d699691598ef8ae35d1c0018b5bc7880f73614894d79e194987961e857c2f7016
+  metadata.gz: 9f12b3bbf04f13f74c91ef78c3c85909a720e15003808609bb9d06e5886643a52d17a83e37263e1dc10666dd286f8e3fdb2784652b553b35eafc47f920368d76
+  data.tar.gz: 4437c4f2618ac10732bdccd600699590780d1d162d8f6523206115a283d0d616e389a58fbe7ea56c07010f087768ed9918fbd2f092177e9944ea33fc6b142bc0

data/CHANGELOG.md

@@ -2,6 +2,12 @@
 
 This project uses [Semantic Versioning][1].
 
+## v0.5.1 (2014-11-19)
+
+- Fixed a logic bug that incorrectly determined red lights to be yellow.
+
+## v0.5.0 (2014-11-19)
+
 - Data stores and notifiers can be configured on a per-stoplight basis. This
   allows stoplights to use stoplights internally.
 - Stoplights use stoplights internally to wrap calls to data stores and

data/README.md

@@ -33,7 +33,7 @@ Check out [stoplight-admin][12] for controlling your stoplights.
 Add it to your Gemfile:
 
 ``` rb
-gem 'stoplight', '~> 0.5.0'
+gem 'stoplight', '~> 0.5.1'
 ```
 
 Or install it manually:

data/lib/stoplight/light/runnable.rb

@@ -5,13 +5,13 @@ module Stoplight
     module Runnable
       def color
         failures, state = failures_and_state
-        now = Time.new
+        failure = failures.first
 
         case
         when state == State::LOCKED_GREEN then Color::GREEN
         when state == State::LOCKED_RED then Color::RED
         when failures.size < threshold then Color::GREEN
-        when failures.any? { |f| now - f.time >= timeout } then Color::YELLOW
+        when failure && Time.new - failure.time >= timeout then Color::YELLOW
         else Color::RED
         end
       end

data/spec/stoplight/light/runnable_spec.rb

@@ -58,6 +58,16 @@ describe Stoplight::Light::Runnable do
       subject.data_store.record_failure(subject, other)
       expect(subject.color).to eql(Stoplight::Color::YELLOW)
     end
+
+    it 'is red when the least recent failure is old' do
+      other = Stoplight::Failure.new(
+        error.class.name, error.message, Time.new - subject.timeout)
+      subject.data_store.record_failure(subject, other)
+      (subject.threshold - 1).times do
+        subject.data_store.record_failure(subject, failure)
+      end
+      expect(subject.color).to eql(Stoplight::Color::RED)
+    end
   end
 
   describe '#run' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: stoplight
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.5.1
 platform: ruby
 authors:
 - Cameron Desautels
@@ -218,7 +218,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.3
+rubygems_version: 2.4.4
 signing_key: 
 specification_version: 4
 summary: Traffic control for code.