stoplight 0.4.1 → 0.5.0

data/spec/stoplight/notifier/io_spec.rb

@@ -3,32 +3,60 @@
 require 'spec_helper'
 
 describe Stoplight::Notifier::IO do
-  subject(:notifier) { described_class.new(io, formatter) }
-  let(:io) { StringIO.new }
-  let(:formatter) { nil }
+  it 'is a class' do
+    expect(described_class).to be_a(Module)
+  end
+
+  it 'is a subclass of Base' do
+    expect(described_class).to be < Stoplight::Notifier::Base
+  end
+
+  describe '#formatter' do
+    it 'is initially the default' do
+      expect(described_class.new(nil).formatter)
+        .to eql(Stoplight::Default::FORMATTER)
+    end
+
+    it 'reads the formatter' do
+      formatter = proc {}
+      expect(described_class.new(nil, formatter).formatter)
+        .to eql(formatter)
+    end
+  end
+
+  describe '#io' do
+    it 'reads the IO' do
+      io = StringIO.new
+      expect(described_class.new(io).io).to eql(io)
+    end
+  end
 
   describe '#notify' do
-    subject(:result) { notifier.notify(light, from_color, to_color) }
-    let(:light) { Stoplight::Light.new(light_name, &light_code) }
-    let(:light_name) { SecureRandom.hex }
-    let(:light_code) { -> {} }
-    let(:from_color) { Stoplight::DataStore::COLOR_GREEN }
-    let(:to_color) { Stoplight::DataStore::COLOR_RED }
-
-    it 'emits the message as a warning' do
-      result
-      expect(io.string)
-        .to eql("Switching #{light.name} from #{from_color} to #{to_color}\n")
+    let(:light) { Stoplight::Light.new(name, &code) }
+    let(:name) { ('a'..'z').to_a.shuffle.join }
+    let(:code) { -> {} }
+    let(:from_color) { Stoplight::Color::GREEN }
+    let(:to_color) { Stoplight::Color::RED }
+    let(:notifier) { described_class.new(io) }
+    let(:io) { StringIO.new }
+
+    it 'returns the message' do
+      error = nil
+      expect(notifier.notify(light, from_color, to_color, error))
+        .to eql(notifier.formatter.call(light, from_color, to_color, error))
     end
 
-    context 'with a formatter' do
-      let(:formatter) { ->(l, f, t) { "#{l.name} #{f} #{t}" } }
+    it 'returns the message with an error' do
+      error = ZeroDivisionError.new('divided by 0')
+      expect(notifier.notify(light, from_color, to_color, error))
+        .to eql(notifier.formatter.call(light, from_color, to_color, error))
+    end
 
-      it 'formats the message' do
-        result
-        expect(io.string)
-          .to eql("#{light.name} #{from_color} #{to_color}\n")
-      end
+    it 'writes the message' do
+      error = nil
+      notifier.notify(light, from_color, to_color, error)
+      message = notifier.formatter.call(light, from_color, to_color, error)
+      expect(io.string).to eql("#{message}\n")
     end
   end
 end

data/spec/stoplight/notifier_spec.rb

@@ -3,4 +3,7 @@
 require 'spec_helper'
 
 describe Stoplight::Notifier do
+  it 'is a module' do
+    expect(described_class).to be_a(Module)
+  end
 end

data/spec/stoplight/state_spec.rb

@@ -0,0 +1,39 @@
+# coding: utf-8
+
+require 'spec_helper'
+
+describe Stoplight::State do
+  it 'is a module' do
+    expect(described_class).to be_a(Module)
+  end
+
+  describe '::UNLOCKED' do
+    it 'is a string' do
+      expect(Stoplight::State::UNLOCKED).to be_a(String)
+    end
+
+    it 'is frozen' do
+      expect(Stoplight::State::UNLOCKED).to be_frozen
+    end
+  end
+
+  describe '::LOCKED_GREEN' do
+    it 'is a string' do
+      expect(Stoplight::State::LOCKED_GREEN).to be_a(String)
+    end
+
+    it 'is frozen' do
+      expect(Stoplight::State::LOCKED_GREEN).to be_frozen
+    end
+  end
+
+  describe '::LOCKED_RED' do
+    it 'is a string' do
+      expect(Stoplight::State::LOCKED_RED).to be_a(String)
+    end
+
+    it 'is frozen' do
+      expect(Stoplight::State::LOCKED_RED).to be_frozen
+    end
+  end
+end

data/spec/stoplight_spec.rb

@@ -3,70 +3,7 @@
 require 'spec_helper'
 
 describe Stoplight do
-  let(:name) { SecureRandom.hex }
-
-  describe '::VERSION' do
-    subject(:result) { described_class.const_get(:VERSION) }
-
-    it 'is a Gem::Version' do
-      expect(result).to be_a(Gem::Version)
-    end
-  end
-
-  describe '.data_store' do
-    subject(:result) { described_class.data_store }
-
-    it 'uses the default data store' do
-      expect(result).to be_a(Stoplight::DataStore::Memory)
-    end
-
-    it 'memoizes the result' do
-      expect(result).to be described_class.data_store
-    end
-
-    context 'with a custom data store' do
-      let(:data_store) { double }
-
-      before do
-        @data_store = described_class.data_store
-        described_class.data_store = data_store
-      end
-
-      after { described_class.data_store = @data_store }
-
-      it 'returns the data store' do
-        expect(result).to eql(data_store)
-      end
-    end
-  end
-
-  describe '.notifiers' do
-    subject(:result) { described_class.notifiers }
-
-    it 'uses the default notifier' do
-      expect(result).to be_an(Array)
-      expect(result.size).to eql(1)
-      expect(result.first).to be_a(Stoplight::Notifier::IO)
-    end
-
-    it 'memoizes the result' do
-      expect(result).to be described_class.notifiers
-    end
-
-    context 'with custom notifiers' do
-      let(:notifiers) { [notifier] }
-      let(:notifier) { double }
-
-      before do
-        @notifiers = described_class.notifiers
-        described_class.notifiers = notifiers
-      end
-
-      after { described_class.notifiers = @notifiers }
-
-      it 'returns the notifiers' do
-        expect(result).to eql(notifiers)
-      end
-    end
+  it 'is a module' do
+    expect(described_class).to be_a(Module)
   end
 end

metadata

@@ -1,15 +1,16 @@
 --- !ruby/object:Gem::Specification
 name: stoplight
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.5.0
 platform: ruby
 authors:
 - Cameron Desautels
 - Taylor Fausak
+- Justin Steffy
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-03 00:00:00.000000000 Z
+date: 2014-11-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: benchmark-ips
@@ -17,14 +18,14 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '2.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '2.1'
 - !ruby/object:Gem::Dependency
   name: coveralls
   requirement: !ruby/object:Gem::Requirement
@@ -59,14 +60,14 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '1.4'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '1.4'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -81,6 +82,20 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: '10.3'
+- !ruby/object:Gem::Dependency
+  name: redis
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '3.1'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '3.1'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -101,14 +116,28 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '0.26'
+        version: '0.27'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '0.26'
+        version: '0.27'
+- !ruby/object:Gem::Dependency
+  name: timecop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '0.7'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '0.7'
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
@@ -123,12 +152,11 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: '0.8'
-description: |
-  Traffic control for code. An implementation of the circuit breaker pattern
-  in Ruby.
+description: An implementation of the circuit breaker pattern.
 email:
 - camdez@gmail.com
 - taylor@fausak.me
+- steffy@orgsync.com
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -138,33 +166,39 @@ files:
 - LICENSE.md
 - README.md
 - lib/stoplight.rb
+- lib/stoplight/color.rb
 - lib/stoplight/data_store.rb
 - lib/stoplight/data_store/base.rb
 - lib/stoplight/data_store/memory.rb
 - lib/stoplight/data_store/redis.rb
+- lib/stoplight/default.rb
 - lib/stoplight/error.rb
 - lib/stoplight/failure.rb
 - lib/stoplight/light.rb
+- lib/stoplight/light/runnable.rb
 - lib/stoplight/notifier.rb
 - lib/stoplight/notifier/base.rb
 - lib/stoplight/notifier/hip_chat.rb
 - lib/stoplight/notifier/io.rb
+- lib/stoplight/state.rb
 - spec/spec_helper.rb
+- spec/stoplight/color_spec.rb
 - spec/stoplight/data_store/base_spec.rb
 - spec/stoplight/data_store/memory_spec.rb
 - spec/stoplight/data_store/redis_spec.rb
 - spec/stoplight/data_store_spec.rb
+- spec/stoplight/default_spec.rb
+- spec/stoplight/error_spec.rb
 - spec/stoplight/failure_spec.rb
+- spec/stoplight/light/runnable_spec.rb
 - spec/stoplight/light_spec.rb
 - spec/stoplight/notifier/base_spec.rb
 - spec/stoplight/notifier/hip_chat_spec.rb
 - spec/stoplight/notifier/io_spec.rb
 - spec/stoplight/notifier_spec.rb
+- spec/stoplight/state_spec.rb
 - spec/stoplight_spec.rb
-- spec/support/data_store.rb
-- spec/support/fakeredis.rb
-- spec/support/hipchat.rb
-homepage: http://orgsync.github.io/stoplight
+homepage: https://github.com/orgsync/stoplight
 licenses:
 - MIT
 metadata: {}
@@ -184,24 +218,26 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.1
+rubygems_version: 2.4.3
 signing_key: 
 specification_version: 4
 summary: Traffic control for code.
 test_files:
 - spec/spec_helper.rb
+- spec/stoplight/color_spec.rb
 - spec/stoplight/data_store/base_spec.rb
 - spec/stoplight/data_store/memory_spec.rb
 - spec/stoplight/data_store/redis_spec.rb
 - spec/stoplight/data_store_spec.rb
+- spec/stoplight/default_spec.rb
+- spec/stoplight/error_spec.rb
 - spec/stoplight/failure_spec.rb
+- spec/stoplight/light/runnable_spec.rb
 - spec/stoplight/light_spec.rb
 - spec/stoplight/notifier/base_spec.rb
 - spec/stoplight/notifier/hip_chat_spec.rb
 - spec/stoplight/notifier/io_spec.rb
 - spec/stoplight/notifier_spec.rb
+- spec/stoplight/state_spec.rb
 - spec/stoplight_spec.rb
-- spec/support/data_store.rb
-- spec/support/fakeredis.rb
-- spec/support/hipchat.rb
 has_rdoc: 

data/spec/support/data_store.rb

@@ -1,36 +0,0 @@
-# coding: utf-8
-# rubocop:disable Metrics/LineLength
-
-shared_examples_for 'a data store' do
-  let(:name) { SecureRandom.hex }
-  let(:failure) { Stoplight::Failure.new(error, time) }
-  let(:error) { error_class.new }
-  let(:error_class) { Class.new(StandardError) }
-  let(:time) { Time.now }
-  let(:state) { Stoplight::DataStore::STATES.to_a.sample }
-  let(:threshold) { 1 + rand(100) }
-  let(:timeout) { rand(100) }
-
-  it { expect(data_store.names).to eql([]) }
-  it { expect(data_store.get_color(name)).to eql(Stoplight::DataStore::COLOR_GREEN) }
-  it { expect(data_store.green?(name)).to eql(true) }
-  it { expect(data_store.yellow?(name)).to eql(false) }
-  it { expect(data_store.red?(name)).to eql(false) }
-  it { expect(data_store.get_attempts(name)).to eql(Stoplight::DataStore::DEFAULT_ATTEMPTS) }
-  it { expect(data_store.record_attempt(name)).to eql(1) }
-  it { expect(data_store.get_failures(name)).to eql(Stoplight::DataStore::DEFAULT_FAILURES) }
-  it { expect(data_store.record_failure(name, failure)).to eql(failure) }
-  it { expect(data_store.get_state(name)).to eql(Stoplight::DataStore::DEFAULT_STATE) }
-  it { expect(data_store.set_state(name, state)).to eql(state) }
-  it { expect(data_store.get_threshold(name)).to eql(Stoplight::DataStore::DEFAULT_THRESHOLD) }
-  it { expect(data_store.set_threshold(name, threshold)).to eql(threshold) }
-  it { expect(data_store.get_timeout(name)).to eql(Stoplight::DataStore::DEFAULT_TIMEOUT) }
-  it { expect(data_store.set_timeout(name, timeout)).to eql(timeout) }
-
-  it 'clears stale lights' do
-    data_store.sync(name)
-    expect(data_store.names).to include(name)
-    data_store.clear_stale
-    expect(data_store.names).to_not include(name)
-  end
-end

data/spec/support/fakeredis.rb

@@ -1,3 +0,0 @@
-# coding: utf-8
-
-require 'fakeredis/rspec'

data/spec/support/hipchat.rb

@@ -1,3 +0,0 @@
-# coding: utf-8
-
-require 'hipchat'