stockpot 0.2.1 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2683178878bc312393087331178faa1770530da412e17fdfbf17df3a25b11d38
-  data.tar.gz: de6f99f3fb93c4679d752ea699fd5be7110caf2a9d1de5963670435f9285bd49
+  metadata.gz: a7a4bf31bbaa54851f7afefe9140678b0290c3dee2fe80bfe577d23d9871f2e3
+  data.tar.gz: df5053bd8857e38ff7b17fafd70d3a5641b45193289a7e645f00ac7de499bd9a
 SHA512:
-  metadata.gz: 71a3938561c28cf45fc99e7a90fdb452be47660978269677f41e369b4881c06b5a1c376845a7fce24b73bf8e0e77abe3be7dc250336f305552de5b192dc7e492
-  data.tar.gz: e28cc6b970e452adf4b3a311ffa33b2a0cff9e5cf7f4183919d4b21f6620f169c73fbc85eb1d8104c7594a458290b261fb29922e9cc5b51d8860c24d914500aa
+  metadata.gz: 8c2921f3892e44849c6b437d44a9fc071146e490a8577a3e04430efc1d313152814c435e8f41a051dc8cbc87d2346eb6d698a328442fbadaf78191a90a4b4b20
+  data.tar.gz: 9087bfcde46a56ac1e733ac045b1199afc08023c27bec695d99dcc5b7a29f6a5448221025aa2a00b9b08561c2ce5d2c1adb8809a996d7b6c1ad5e539be8c35ae

data/app/controllers/stockpot/application_controller.rb

@@ -1,7 +1,12 @@
 # frozen_string_literal: true
-
 module Stockpot
   class ApplicationController < ActionController::API
+    include ActiveSupport::Rescuable
+    include Helper::Errors
+
+    rescue_from StandardError do |exception|
+      render rescue_error(exception)
+    end
     # protect_from_forgery with: :exception
   end
 end

data/app/controllers/stockpot/database_cleaner_controller.rb

@@ -2,8 +2,6 @@
 
 require "database_cleaner"
 
-require_dependency "stockpot/application_controller"
-
 module Stockpot
   class DatabaseCleanerController < ApplicationController
     # Clean database before, between, and after tests by clearing Rails

data/app/controllers/stockpot/healthz_controller.rb

@@ -1,7 +1,4 @@
 # frozen_string_literal: true
-
-require_dependency "stockpot/application_controller"
-
 module Stockpot
   class HealthzController < ApplicationController
     def index

data/app/controllers/stockpot/helper/errors.rb

@@ -0,0 +1,26 @@
+# frozen_string_literal: true
+module Stockpot
+  module Helper
+    module Errors
+      def rescue_error(error)
+        logger = Logger.new(STDERR)
+        logger.warn(error)
+
+        case error
+        when NameError
+          return_error(error.to_s, error.backtrace.first(5), :bad_request)
+        when PG::Error
+          return_error("Postgres error: #{error}", error.backtrace.first(5), :server_error)
+        when ActiveRecord::RecordInvalid, ActiveRecord::Validations
+          return_error("ActiveRecord error: #{error}", error.backtrace.first(5), :server_error)
+        else
+          return_error(error.to_s, error.backtrace.first(5),:server_error)
+        end
+      end
+
+      def return_error(message, backtrace, status)
+        { json: { error: { status: status, backtrace: backtrace, message: message }}, status: status }
+      end
+    end
+  end
+end

data/app/controllers/stockpot/records_controller.rb

@@ -1,78 +1,81 @@
 # frozen_string_literal: true
-
-require_dependency "stockpot/application_controller"
-
 require "factory_bot_rails"
 
 module Stockpot
   class RecordsController < ApplicationController
     include ActiveSupport::Inflector
+    include ActiveRecord::Transactions
 
-    def index
-      return_error("You need to provide at least one model name as an argument", 400) && return if params.dig(:models).blank?
+    before_action only: %i[index destroy update] do
+      return_error("You need to provide at least one model name as an argument", 400) if params.dig(:models).blank?
+    end
+    before_action only: %i[create] do
+      return_error("You need to provide at least one factory name as an argument", 400) if params.dig(:factory).blank?
+    end
 
+    def index
       obj = {}
       models.each_with_index do |element, i|
         model = element[:model].to_s
-        obj[pluralize(model).camelize(:lower)] = model.camelize.constantize.where(models[i].except(:model))
+        class_name = find_correct_class_name(model)
+
+        obj[pluralize(model).camelize(:lower)] = class_name.constantize.where(models[i].except(:model))
       end
 
       render json: obj, status: :ok
     end
 
     def create
-      return_error("You need to provide at least one factory name as an argument", 400) && return if params.dig(:factory).blank?
-
       list = params[:list] || 1
-      list.times do |n|
-        if params[:traits].present? && params[:attributes].present?
-          FactoryBot.create(factory, *traits, attributes[n])
-        elsif params[:traits].blank? && params[:attributes].blank?
-          # rubocop:disable Rails/SaveBang
-          FactoryBot.create(factory)
-          # rubocop:enable Rails/SaveBang
-        elsif params[:attributes].blank?
-          FactoryBot.create(factory, *traits)
-        elsif params[:traits].blank?
-          FactoryBot.create(factory, attributes[n])
+      ActiveRecord::Base.transaction do
+        list.times do |n|
+          all_parameters = [ factory, *traits, attributes(n) ].compact
+          @factory = FactoryBot.create(*all_parameters)
         end
       end
-      obj = factory.to_s.camelize.constantize.last(list)
+      obj = @factory.class.name.constantize.last(list)
+
       render json: obj, status: :created
     end
 
     def destroy
-      return_error("You need to provide at least one model name as an argument", 400) && return if params.dig(:models).blank?
-
       obj = {}
-      models.each_with_index do |element, i|
-        model = element[:model].to_s
-        obj[pluralize(model).camelize(:lower)] = model.camelize.constantize.where(models[i].except(:model)).destroy_all
+      ActiveRecord::Base.transaction do
+        models.each_with_index do |element, i|
+          model = element[:model].to_s
+          class_name = find_correct_class_name(model)
+          obj[pluralize(model).camelize(:lower)] = class_name.constantize.where(models[i].except(:model)).destroy_all
+        end
       end
 
       render json: obj, status: :accepted
     end
 
     def update
-      return_error("You need to provide at least one model name as an argument", 400) && return if params.dig(:models).blank?
-
       obj = {}
-      models.each_with_index do |element, i|
-        model = element[:model].to_s
-        update_params = params.permit![:models][i][:update].to_h
-        obj[pluralize(model).camelize(:lower)] = model.camelize.constantize.where(models[i].except(:model, :update)).update(update_params)
+      ActiveRecord::Base.transaction do
+        models.each_with_index do |element, i|
+          model = element[:model].to_s
+          class_name = find_correct_class_name(model)
+          update_params = params.permit![:models][i][:update].to_h
+          obj[pluralize(model).camelize(:lower)] = class_name.constantize.where(models[i].except(:model, :update)).update(update_params)
+        end
       end
-
       render json: obj, status: :accepted
     end
 
     private
 
-    def return_error(message, status)
-      render json: { "error": { "status": status, "message": message }}.to_json, status: status
+    def find_correct_class_name(model)
+      # We are getting the class name from the factory or we default to whatever we send in.
+      # Something to keep in mind "module/class_name".camelize will translate into "Module::ClassName"
+      # which is perfect for namespaces in case there is no factory associated with a specific model
+      FactoryBot.factories.registered?(model) ? FactoryBot.build_stubbed(model).class.name : model.camelize
     end
 
     def traits
+      return if params[:traits].blank?
+
       params[:traits].map(&:to_sym)
     end
 
@@ -80,8 +83,12 @@ module Stockpot
       params[:factory].to_sym
     end
 
-    def attributes
-      params.permit![:attributes].map(&:to_h)
+    # rubocop:disable Naming/UncommunicativeMethodParamName
+    def attributes(n)
+      # rubocop:enable Naming/UncommunicativeMethodParamName
+      return if params[:attributes].blank?
+
+      params.permit![:attributes][n].to_h
     end
 
     def models

data/app/controllers/stockpot/redis_controller.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
-
 module Stockpot
-  class RedisController < ActionController::Base
+  class RedisController < ApplicationController
     def index
       if params[:field].present?
         # Returns the value associated with :field in the hash stored at :key

data/lib/stockpot.rb

@@ -2,6 +2,4 @@
 
 require "stockpot/engine"
 
-module Stockpot
-  # Your code goes here...
-end
+module Stockpot; end

data/lib/stockpot/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Stockpot
-  VERSION = "0.2.1"
+  VERSION = "0.3.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: stockpot
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.3.0
 platform: ruby
 authors:
 - Jayson Smith
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-11-04 00:00:00.000000000 Z
+date: 2020-02-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -100,61 +100,55 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.3'
+        version: '13.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 12.3.3
+        version: 13.0.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.3'
+        version: '13.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 12.3.3
+        version: 13.0.1
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.8'
+        version: '3.9'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.8'
+        version: '3.9'
 - !ruby/object:Gem::Dependency
   name: rspec-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.8'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 3.8.2
+        version: '3.9'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.8'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 3.8.2
+        version: '3.9'
 - !ruby/object:Gem::Dependency
   name: spicerack-styleguide
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.16.2
+        version: 0.21.0
     - - "<"
       - !ruby/object:Gem::Version
         version: '1.0'
@@ -164,7 +158,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.16.2
+        version: 0.21.0
     - - "<"
       - !ruby/object:Gem::Version
         version: '1.0'
@@ -216,6 +210,7 @@ files:
 - app/controllers/stockpot/application_controller.rb
 - app/controllers/stockpot/database_cleaner_controller.rb
 - app/controllers/stockpot/healthz_controller.rb
+- app/controllers/stockpot/helper/errors.rb
 - app/controllers/stockpot/records_controller.rb
 - app/controllers/stockpot/redis_controller.rb
 - config/routes.rb
@@ -245,7 +240,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.6
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: Makes setting up test data in your Rails database from an external resource