stockpile 1.1 → 2.0

data/test/test_stockpile_base.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'minitest_config'
 
 describe Stockpile::Base do
@@ -20,19 +21,17 @@ describe Stockpile::Base do
   }
 
   describe 'constructor' do
-    it "uses the default connection width by default" do
+    it 'uses the default connection width by default' do
       stub ::Stockpile, :narrow?, lambda { false } do
-        refute Stockpile::Base.new.narrow?,
-          "should be narrow, but is not"
+        refute Stockpile::Base.new.narrow?, 'should be narrow, but is not'
       end
 
       stub ::Stockpile, :narrow?, lambda { true } do
-        assert Stockpile::Base.new.narrow?,
-          "is not narrow, but should be"
+        assert Stockpile::Base.new.narrow?, 'is not narrow, but should be'
       end
     end
 
-    it "can be told which connection width to use explicitly" do
+    it 'can be told which connection width to use explicitly' do
       stub ::Stockpile, :narrow?, lambda { false } do
         assert mem_narrow.narrow?
       end
@@ -42,7 +41,7 @@ describe Stockpile::Base do
       end
     end
 
-    it "passes settings through to the client" do
+    it 'passes settings through to the client' do
       options = {
         url: 'test://xyz/'
       }
@@ -50,54 +49,60 @@ describe Stockpile::Base do
       assert_equal 'test://xyz/', mem.connect.options[:url]
     end
 
-    it "has no clients by default" do
+    it 'has no clients by default' do
       assert_clients [], ::Stockpile::Memory.new
     end
+
+    it 'works with an OpenStruct provided as options' do
+      require 'ostruct'
+      mem = ::Stockpile::Memory.new(OpenStruct.new(url: 'test://xyz/'))
+      assert_equal 'test://xyz/', mem.connect.options[:url]
+    end
   end
 
-  describe "#connect" do
-    it "raises NotImplementedError unless #client_connect is implemented" do
+  describe '#connect' do
+    it 'raises NotImplementedError unless #client_connect is implemented' do
       assert_raises NotImplementedError do
         ::Stockpile::Base.new.connect
       end
     end
 
-    it "creates a connection to the client" do
+    it 'creates a connection to the client' do
       assert_nil mem.connection
       refute_nil mem.connect
     end
 
-    it "creates a namespaced connection to the client" do
+    it 'creates a namespaced connection to the client' do
       assert_nil mem_namespace.connection
       refute_nil mem_namespace.connect
     end
 
-    describe "with a wide connection width" do
+    describe 'with a wide connection width' do
       before do
-        mem_wide.connect(:hoge, { quux: {} })
+        mem_wide.connect(:hoge, quux: {})
       end
 
-      it "connects multiple clients" do
+      it 'connects multiple clients' do
         assert_clients [ :hoge, :quux ], mem_wide
       end
 
-      it "connects *different* clients" do
+      it 'connects *different* clients' do
         refute_same mem_wide.connection, mem_wide.connection_for(:hoge)
         refute_same mem_wide.connection, mem_wide.connection_for(:quux)
         refute_same mem_wide.connection_for(:hoge), mem_wide.connection_for(:quux)
       end
     end
 
-    describe "with a narrow connection width" do
+    describe 'with a narrow connection width' do
       before do
         mem_narrow.connect(:hoge, :quux)
       end
 
-      it "appears to connect multiple clients" do
+      it 'appears to connect multiple clients' do
         assert_clients [ :hoge, :quux ], mem_narrow
       end
 
-      it "returns identical clients" do
+      it 'returns identical clients' do
         assert_same mem_narrow.connection, mem_narrow.connection_for(:hoge)
         assert_same mem_narrow.connection, mem_narrow.connection_for(:quux)
         assert_same mem_narrow.connection_for(:hoge), mem_narrow.connection_for(:quux)
@@ -105,8 +110,8 @@ describe Stockpile::Base do
     end
   end
 
-  describe "#connection_for" do
-    it "raises NotImplementedError unless #client_connect is implemented" do
+  describe '#connection_for' do
+    it 'raises NotImplementedError unless #client_connect is implemented' do
       assert_raises NotImplementedError do
         instance_stub ::Stockpile::Base, :connection, -> { true } do
           ::Stockpile::Base.new.connection_for(:foo)
@@ -114,16 +119,16 @@ describe Stockpile::Base do
       end
     end
 
-    describe "with a wide connection width" do
-      it "connects the main client" do
+    describe 'with a wide connection width' do
+      it 'connects the main client' do
         mem_wide.connection_for(:global)
         assert mem_wide.connection
         refute_same mem_wide.connection, mem_wide.connection_for(:global)
       end
     end
 
-    describe "with a narrow connection width" do
-      it "connects the main client" do
+    describe 'with a narrow connection width' do
+      it 'connects the main client' do
         mem_narrow.connection_for(:global)
         assert mem_narrow.connection
         assert_same mem_narrow.connection, mem_narrow.connection_for(:global)
@@ -133,8 +138,8 @@ describe Stockpile::Base do
 
   let(:connection) { Stockpile::Memory::Data }
 
-  describe "#disconnect" do
-    it "raises NotImplementedError unless #client_disconnect is implemented" do
+  describe '#disconnect' do
+    it 'raises NotImplementedError unless #client_disconnect is implemented' do
       base = ::Stockpile::Base.new
       assert_raises NotImplementedError do
         instance_stub ::Stockpile::Base, :connect do
@@ -145,7 +150,7 @@ describe Stockpile::Base do
       end
     end
 
-    describe "with a wide connection width" do
+    describe 'with a wide connection width' do
       let(:global) { mem_wide.connection }
       let(:hoge) { mem_wide.connection_for(:hoge) }
 
@@ -154,18 +159,18 @@ describe Stockpile::Base do
         assert hoge.connected? && global.connected?
       end
 
-      it "disconnects the global client" do
+      it 'disconnects the global client' do
         mem_wide.disconnect
         assert hoge.connected? && !global.connected?
       end
 
-      it "disconnects the redis and global clients" do
+      it 'disconnects the redis and global clients' do
         mem_wide.disconnect(:hoge)
         refute hoge.connected? || global.connected?
       end
     end
 
-    describe "with a narrow connection width" do
+    describe 'with a narrow connection width' do
       let(:global) { mem_narrow.connection }
       let(:hoge) { mem_narrow.connection_for(:hoge) }
 
@@ -174,20 +179,20 @@ describe Stockpile::Base do
         assert hoge.connected? && global.connected?
       end
 
-      it "#disconnect disconnects all clients" do
+      it '#disconnect disconnects all clients' do
         mem_narrow.disconnect
         refute hoge.connected? || global.connected?
       end
 
-      it "#disconnect(:hoge) disconnects all clients" do
+      it '#disconnect(:hoge) disconnects all clients' do
         mem_narrow.disconnect(:hoge)
         refute hoge.connected? || global.connected?
       end
     end
   end
 
-  describe "#reconnect" do
-    it "raises NotImplementedError unless #client_reconnect is implemented" do
+  describe '#reconnect' do
+    it 'raises NotImplementedError unless #client_reconnect is implemented' do
       base = ::Stockpile::Base.new
       assert_raises NotImplementedError do
         instance_stub ::Stockpile::Base, :connect do
@@ -198,7 +203,7 @@ describe Stockpile::Base do
       end
     end
 
-    describe "with a wide connection width" do
+    describe 'with a wide connection width' do
       let(:global) { mem_wide.connection }
       let(:hoge) { mem_wide.connection_for(:hoge) }
 
@@ -209,18 +214,18 @@ describe Stockpile::Base do
         refute hoge.connected? || global.connected?
       end
 
-      it "reconnects the global client" do
+      it 'reconnects the global client' do
         mem_wide.reconnect
         assert !hoge.connected? && global.connected?
       end
 
-      it "reconnects the redis and global clients" do
+      it 'reconnects the redis and global clients' do
         mem_wide.reconnect(:hoge)
         assert hoge.connected? && global.connected?
       end
     end
 
-    describe "with a narrow connection width" do
+    describe 'with a narrow connection width' do
       let(:global) { mem_narrow.connection }
       let(:hoge) { mem_narrow.connection_for(:hoge) }
 
@@ -231,12 +236,12 @@ describe Stockpile::Base do
         refute hoge.connected? || global.connected?
       end
 
-      it "#reconnect reconnects the all clients" do
+      it '#reconnect reconnects the all clients' do
         mem_narrow.reconnect
         assert hoge.connected? && global.connected?
       end
 
-      it "#reconnect(:hoge:) reconnects all clients" do
+      it '#reconnect(:hoge:) reconnects all clients' do
         mem_narrow.reconnect(:hoge)
         assert hoge.connected? && global.connected?
       end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: stockpile
 version: !ruby/object:Gem::Version
-  version: '1.1'
+  version: '2.0'
 platform: ruby
 authors:
 - Austin Ziegler
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-10 00:00:00.000000000 Z
+date: 2016-04-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.5'
+        version: '5.8'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.5'
+        version: '5.8'
 - !ruby/object:Gem::Dependency
   name: rdoc
   requirement: !ruby/object:Gem::Requirement
@@ -95,47 +95,47 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '1.2'
 - !ruby/object:Gem::Dependency
-  name: minitest-around
+  name: minitest-autotest
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.3'
+        version: '1.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.3'
+        version: '1.0'
 - !ruby/object:Gem::Dependency
-  name: minitest-autotest
+  name: minitest-bisect
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '1.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '1.2'
 - !ruby/object:Gem::Dependency
-  name: minitest-bisect
+  name: minitest-bonus-assertions
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.2'
+        version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.2'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: minitest-focus
   requirement: !ruby/object:Gem::Requirement
@@ -212,14 +212,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.13'
+        version: '3.15'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.13'
+        version: '3.15'
 description: |-
   Stockpile is a simple key-value store connection manager framework. Stockpile
   itself does not implement a connection manager, but places expectations for
@@ -229,18 +229,18 @@ description: |-
   Stockpile also provides an adapter so that its functionality can be accessed
   from within a module.
 
-  Release 1.1 fixes an issue with early initialization of an injected Stockpile
-  instance during adaptation
-  ({stockpile#2}[https://githbub.com/halostatue/stockpile/issues/2]). Several
-  small improvements to Stockpile.new, Stockpile#connect, and
-  Stockpile#connection_for have been documented.
+  Release 2.0 fixes an issue when Stockpile options are provided with an
+  OpenStruct, originally reported as
+  {stockpile-redis#1}[https://github.com/halostatue/stockpile-redis/issues/1].
+  Support for Ruby 1.9 has been dropped.
 email:
 - halostatue@gmail.com
 executables: []
 extensions: []
 extra_rdoc_files:
+- Code-of-Conduct.md
 - Contributing.rdoc
-- History.rdoc
+- History.md
 - Licence.rdoc
 - Manifest.txt
 - README.rdoc
@@ -248,10 +248,14 @@ files:
 - ".autotest"
 - ".gemtest"
 - ".minitest.rb"
+- ".rubocop.yml"
+- ".simplecov-prelude.rb"
 - ".travis.yml"
+- ".workenv"
+- Code-of-Conduct.md
 - Contributing.rdoc
 - Gemfile
-- History.rdoc
+- History.md
 - Licence.rdoc
 - Manifest.txt
 - README.rdoc
@@ -276,7 +280,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 1.9.2
+      version: '2.0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -284,7 +288,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Stockpile is a simple key-value store connection manager framework

data/History.rdoc

@@ -1,24 +0,0 @@
-=== 1.1 / 2015-02-10
-
-* 3 minor enhancements
-
-  * Created a base adapter, Stockpile::Base, that implements the core public
-    interface of a connection manager in a consistent way for argument parsing.
-
-  * Created a memory adapter as an example adapter. (This had previously been
-    a test adapter created in the test environment.)
-
-  * Documented changes to how clients can be specified for Stockpile.new,
-    Stockpile#connect, and Stockpile#connection_for.
-
-* 1 bugfix
-
-  * Fix {issue #2}[https://github.com/halostatue/stockpile/issues/2], where
-    the use of the cache adapter causes the Stockpile cache manager to
-    initialize too early.
-
-=== 1.0 / 2015-01-21
-
-* 1 major enhancement
-
-  * Birthday!