stockcruncher 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 82cc9e3595d2f91bded92cbbf001fc8fb76ff3bd0d4604361c24f78c3ef6da01
-  data.tar.gz: 510435224f9e7362f51f692c3b6634d7372adae0db724d9d9545f3d869b53bfa
+  metadata.gz: c1fe544c0ab3e0bb05c2cca11cb4363bce698cf88b565d897098420b3b8206ac
+  data.tar.gz: bc0de76838cf286f9c5400ddc368da33ee2bd748f0a5a29ebed653010e183d8a
 SHA512:
-  metadata.gz: 4a4e42a9068eabbbd9b5da44212d39c98aebce85c2b36add25f5da51853bbb00117cd9d6783d5f3cb2b35789eba7c917fe9020198de54e9bd9c45eff49221a0c
-  data.tar.gz: 191d02a244a4fe2b575a7252824c2c510140072b56f1ea9791ddd62b94da5fda784046f246a812c4feb141e66196c711bfdfa71c951f0c8cac33409c4dacea31
+  metadata.gz: b69c6d91c2160e1e70a339ea68616b27012839b105dcfd0cef5ccf7a9643e3a08fb88738d794cf98e3d4de03e505c32db4a827d45a296d734f7e10d2334eb287
+  data.tar.gz: 44ecc54323e85117c04bb0aa8b9c2ab54421020a2614b01356988700f610264e1e82a07e88d5fd62f62945c1469c508699b3a78c2dad52a73b988e508ce2264d

data/lib/stockcruncher.rb

@@ -10,9 +10,6 @@ module StockCruncher
 
     def start(args = ARGV)
       StockCruncher::CLI.start(args)
-    rescue NotImplementedError => e
-      warn e.message
-      exit(3)
     end
   end
 end

data/lib/stockcruncher/alphavantage.rb

@@ -7,32 +7,34 @@ module StockCruncher
   # This is an data cruncher class for AlphaVantage API.
   class AlphaVantage < Cruncher
     API_URL = 'https://www.alphavantage.co/query?'
-    SERIE = {
-      'daily' => 'TIME_SERIES_DAILY',
-      'quote_endpoint' => 'GLOBAL_QUOTE'
-    }.freeze
 
     # Main method to crunch data.
-    def crunch(symbol, serie, opts)
-      err_msg = "#{serie} does not exist."
-      raise NotImplementedError, err_msg unless SERIE.key?(serie)
+    def crunch_daily(symbol, opts)
+      url = API_URL + parameters(symbol, 'TIME_SERIES_DAILY') + options_d(opts)
+      res = request(url)
+      puts res.body
+    end
 
-      url = API_URL + parameters(symbol, serie) + options(serie, opts)
+    # Main method to crunch data.
+    def crunch_quote(symbol, opts)
+      url = API_URL + parameters(symbol, 'GLOBAL_QUOTE') + options_q(opts)
       res = request(url)
       puts res.body
     end
 
-    def options(serie, opts)
+    def options_d(opts)
+      o = '&datatype=' + (opts['json'] ? 'json' : 'csv')
+      o += '&outputsize=' + (opts['full'] ? 'full' : 'compact')
+      o
+    end
+
+    def options_q(opts)
       o = '&datatype=' + (opts['json'] ? 'json' : 'csv')
-      if serie == 'daily'
-        o += '&outputsize='
-        o += opts['full'] ? 'full' : 'compact'
-      end
       o
     end
 
     def parameters(symbol, serie)
-      p = 'function=' + SERIE[serie]
+      p = 'function=' + serie
       p += '&symbol=' + symbol
       p += '&apikey=' + @config[self.class.name.split('::').last]['apikey']
       p

data/lib/stockcruncher/cli.rb

@@ -11,9 +11,8 @@ module StockCruncher
       puts "StockCruncher version #{StockCruncher::VERSION}"
     end
 
-    desc('crunch SYMBOL TIMESERIES [options]',
-         'Crunch SYMBOL stock market data for time series.' \
-         'Possible timeseries: daily, quote_endpoint.')
+    desc('daily SYMBOL [options]',
+         'Crunch SYMBOL stock market data for daily time series.')
     option(
       :config,
       aliases: ['-c'],
@@ -36,10 +35,33 @@ module StockCruncher
       default: false,
       desc: 'Full data size.'
     )
-    def crunch(symbol, timeserie)
+    def daily(symbol)
       opts = options.dup
       cruncher = StockCruncher::AlphaVantage.new(opts['config'])
-      cruncher.crunch(symbol, timeserie, opts)
+      cruncher.crunch_daily(symbol, opts)
+    end
+
+    desc('quote SYMBOL [options]',
+         'Crunch SYMBOL stock market data for last day quote.')
+    option(
+      :config,
+      aliases: ['-c'],
+      type: :string,
+      default: '/etc/stockcruncher/stockcruncher.yml',
+      desc: 'Yaml formatted config file to load ' \
+            '(default to /etc/stockcruncher/stockcruncher.yml).'
+    )
+    option(
+      :json,
+      aliases: ['-j'],
+      type: :boolean,
+      default: false,
+      desc: 'Json format data (default to csv).'
+    )
+    def quote(symbol)
+      opts = options.dup
+      cruncher = StockCruncher::AlphaVantage.new(opts['config'])
+      cruncher.crunch_quote(symbol, opts)
     end
   end
 end

data/lib/stockcruncher/cruncher.rb

@@ -7,7 +7,7 @@ require 'yaml'
 module StockCruncher
   # This is an data cruncher abstract class.
   class Cruncher
-    # Class abstract constructor method
+    # Class constructor method
     def initialize(file)
       @config = load_conf(file)
     end

data/lib/stockcruncher/version.rb

@@ -2,5 +2,5 @@
 # frozen_string_literal: true
 
 module StockCruncher
-  VERSION = '1.0.1'
+  VERSION = '1.0.2'
 end

data/spec/stockcruncher/alphavantage_spec.rb

@@ -3,14 +3,14 @@
 require 'spec_helper'
 
 describe StockCruncher::AlphaVantage do
-  context 'crunch SYM daily -c spec/files/stockcruncher.yml' do
-    it 'requests a source and get the result.' do
+  context 'daily SYM -c spec/files/stockcruncher.yml' do
+    it 'requests a daily time serie.' do
       expect { start(self) }.to output("{}\n").to_stdout
     end
   end
-  context 'crunch SYM weekly -c spec/files/stockcruncher.yml' do
-    it 'requests a not implemented time serie.' do
-      expect { start(self) }.to raise_error(SystemExit)
+  context 'quote SYM -c spec/files/stockcruncher.yml' do
+    it 'requests a quote endpoint.' do
+      expect { start(self) }.to output("{}\n").to_stdout
     end
   end
 end

data/spec/stockcruncher/cli_spec.rb

@@ -10,7 +10,13 @@ describe StockCruncher::CLI do
     end
   end
 
-  context 'crunch SYM quote_endpoint -c spec/files/stockcruncher.yml' do
+  context 'daily SYM -c spec/files/stockcruncher.yml' do
+    it 'Get the daily time serie for SYM.' do
+      expect { start(self) }.to output("{}\n").to_stdout
+    end
+  end
+
+  context 'quote SYM -c spec/files/stockcruncher.yml' do
     it 'Get the quote for SYM.' do
       expect { start(self) }.to output("{}\n").to_stdout
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: stockcruncher
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - Richard Delaplace
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-07-27 00:00:00.000000000 Z
+date: 2020-07-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler