stockboy 1.1.0 → 1.1.1

data/spec/stockboy/providers_spec.rb

@@ -8,21 +8,21 @@ module Stockboy
 
     describe ".register" do
       it "registers a key and class" do
-        Providers.register(:snailmail, provider).should be provider
+        expect(Providers.register(:snailmail, provider)).to be provider
       end
     end
 
     describe ".find" do
       it "returns a provider class" do
         Providers.register(:snailmail, provider)
-        Providers.find(:snailmail).should be provider
+        expect(Providers.find(:snailmail)).to be provider
       end
     end
 
     describe ".[]" do
       it "returns a provider class" do
         Providers.register(:snailmail, provider)
-        Providers[:snailmail].should be provider
+        expect(Providers[:snailmail]).to be provider
       end
     end
 
@@ -30,7 +30,7 @@ module Stockboy
       it "returns all registered providers" do
         Providers.register(:snailmail, provider)
         Providers.register(:slugmail, provider)
-        Providers.all.should include(snailmail: provider, slugmail: provider)
+        expect(Providers.all).to include(snailmail: provider, slugmail: provider)
       end
     end
 

data/spec/stockboy/readers/csv_spec.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 require 'spec_helper'
 require 'stockboy/readers/csv'
 
@@ -18,7 +20,7 @@ module Stockboy
     describe "initialize" do
       it "configures options with argument hash" do
         reader = Readers::CSV.new(col_sep: '|')
-        reader.col_sep.should == '|'
+        expect(reader.col_sep).to eq '|'
       end
 
       it "configures options with a block" do
@@ -29,9 +31,9 @@ module Stockboy
           skip_footer_rows 1
         end
 
-        reader.col_sep.should == '|'
-        reader.skip_header_rows.should == 2
-        reader.skip_footer_rows.should == 1
+        expect(reader.col_sep).to eq '|'
+        expect(reader.skip_header_rows).to eq 2
+        expect(reader.skip_footer_rows).to eq 1
       end
     end
 
@@ -39,7 +41,7 @@ module Stockboy
       it "returns an array of records" do
         records = reader.parse "id,name\n42,Arthur Dent"
 
-        records[0].should == {"id" => "42", "name" => "Arthur Dent"}
+        expect(records[0]).to eq({"id" => "42", "name" => "Arthur Dent"})
       end
 
       it "strips null bytes from empty fields (MSSQL BCP exports)" do
@@ -47,8 +49,9 @@ module Stockboy
         reader.headers = %w[city state country]
         records = reader.parse "Vancouver|\x00|Canada"
 
-        records.should ==
+        expect(records).to eq(
           [{"city" => "Vancouver", "state" => nil, "country" => "Canada"}]
+        )
       end
 
       it "scrubs invalid encoding characters in Unicode" do
@@ -56,8 +59,9 @@ module Stockboy
         reader.encoding = 'UTF-8'
         garbage = 191.chr.force_encoding('UTF-8')
         data = "Z#{garbage}rich,Genève"
-        reader.parse(data).should ==
+        expect(reader.parse(data)).to eq(
           [{"depart" => "Z\u{FFFD}rich", "arrive" => "Genève"}]
+        )
       end
 
       it "strips preamble header rows" do
@@ -65,12 +69,12 @@ module Stockboy
         data = "IGNORE\r\nCOMMENTS\r\nid,name\r\n42,Arthur Dent"
         records = reader.parse data
 
-        records[0].should == {"id" => "42", "name" => "Arthur Dent"}
+        expect(records[0]).to eq({"id" => "42", "name" => "Arthur Dent"})
       end
 
       it "shares hash key instances between records" do
         records = reader.parse "id,name\n42,Arthur Dent\n999,Zaphod"
-        records[0].keys[0].should be records[1].keys[0]
+        expect(records[0].keys[0]).to be records[1].keys[0]
       end
     end
   end

data/spec/stockboy/readers/fixed_width_spec.rb

@@ -13,7 +13,7 @@ module Stockboy
 
     it "parses based on column widths" do
       reader = described_class.new(headers: [10, 10, 4, 2, 10])
-      reader.parse(data).should == [
+      expect(reader.parse(data)).to eq [
         {0 => "Arthur", 1 => "Dent", 2 => "42", 3 => "M", 4 => "Human"},
         {0 => "Ford", 1 => "Prefect", 2 => "44", 3 => "M", 4 => "Betelgeuse"}
       ]
@@ -21,7 +21,7 @@ module Stockboy
 
     it "parses based on a hash" do
       reader = described_class.new(headers: headers_hash)
-      reader.parse(data).should == [
+      expect(reader.parse(data)).to eq [
         {first: "Arthur", last: "Dent", age: "42", sex: "M", planet: "Human"},
         {first: "Ford", last: "Prefect", age: "44", sex: "M", planet: "Betelgeuse"}
       ]
@@ -30,22 +30,22 @@ module Stockboy
     it "skips blank rows" do
       reader = described_class.new(headers: headers_hash)
       records = reader.parse(blank_row + data + blank_row)
-      records.first[:age].should == '42'
-      records.last[:age].should == '44'
+      expect(records.first[:age]).to eq '42'
+      expect(records.last[:age]).to eq '44'
     end
 
     it "skips number of specified header rows" do
       reader = described_class.new(headers: headers_hash)
       reader.skip_header_rows = 1
       records = reader.parse("REPORT\r\n" + data)
-      records.first[:age].should == '42'
+      expect(records.first[:age]).to eq '42'
     end
 
     it "skips number of specified footer rows" do
       reader = described_class.new(headers: headers_hash)
       reader.skip_footer_rows = 2
       records = reader.parse(data + "SUBTOTAL\r\nTOTAL\r\n")
-      records.last[:age].should == '44'
+      expect(records.last[:age]).to eq '44'
     end
 
   end

data/spec/stockboy/readers/json_spec.rb

@@ -10,7 +10,7 @@ module Stockboy
       it "returns an array of records" do
         records = reader.parse '{"id": "42", "name": "Arthur Dent"}'
 
-        records.should == {"id" => "42", "name" => "Arthur Dent"}
+        expect(records).to eq({"id" => "42", "name" => "Arthur Dent"})
       end
 
     end

data/spec/stockboy/readers/spreadsheet_spec.rb

@@ -21,10 +21,10 @@ module Stockboy
           headers: %w(X Y Z)
         )
 
-        reader.format.should == :xlsx
-        reader.sheet.should  == 'Sheet 42'
-        reader.header_row.should == 5
-        reader.headers.should == %w(X Y Z)
+        expect(reader.format).to eq :xlsx
+        expect(reader.sheet).to  eq 'Sheet 42'
+        expect(reader.header_row).to eq 5
+        expect(reader.headers).to eq %w(X Y Z)
       end
 
       it "configures with a block" do
@@ -35,10 +35,10 @@ module Stockboy
           headers %w(X Y Z)
         end
 
-        reader.format.should == :xlsx
-        reader.sheet.should  == 'Sheet 42'
-        reader.header_row.should == 5
-        reader.headers.should == %w(X Y Z)
+        expect(reader.format).to eq :xlsx
+        expect(reader.sheet).to  eq 'Sheet 42'
+        expect(reader.header_row).to eq 5
+        expect(reader.headers).to eq %w(X Y Z)
       end
     end
 
@@ -52,8 +52,8 @@ module Stockboy
           reader = described_class.new(format: :xls)
           data = reader.parse(content)
 
-          data.should_not be_empty
-          data.each { |i| i.should be_a Hash }
+          expect(data).not_to be_empty
+          data.each { |i| expect(i).to be_a Hash }
         end
       end
 
@@ -64,30 +64,30 @@ module Stockboy
           reader = described_class.new(format: :xls, first_row: 6)
           data = reader.parse(content)
 
-          data.first.values.should == ["Arthur Dent", 42]
+          expect(data.first.values).to eq ["Arthur Dent", 42]
         end
 
         it "ends on the given last row counting backwards" do
           reader = described_class.new(format: :xls, last_row: -3)
           data = reader.parse(content)
 
-          data.last.values.should == ["Marvin", 9999999]
+          expect(data.last.values).to eq ["Marvin", 9999999]
         end
 
         it "ends on the given last row counting upwards" do
           reader = described_class.new(format: :xls, last_row: 9)
           data = reader.parse(content)
 
-          data.last.values.should == ["Ford", 40]
+          expect(data.last.values).to eq ["Ford", 40]
         end
       end
     end
 
-    describe "#sheet", pending: "Hard to test this due to roo. Needs a test case with fixtures" do
+    describe "#sheet", skip: "Hard to test this due to roo. Needs a test case with fixtures" do
       let(:sheets)      { ['Towels', 'Lemons'] }
       let(:be_selected) { receive(:default_sheet=) }
       let(:spreadsheet) { double(:spreadsheet, sheets: sheets) }
-      before { subject.stub!(:with_spreadsheet).and_yield(spreadsheet) }
+      before { allow(subject).to receive(:with_spreadsheet).and_yield(spreadsheet) }
 
       context "with :first" do
         before { expect(spreadsheet).to be_selected.with('Towels') }

data/spec/stockboy/readers/xml_spec.rb

@@ -15,11 +15,11 @@ module Stockboy
           elements:             ['SomeNested', 'Record']
         )
 
-        reader.options[:strip_namespaces].should be true
-        reader.options[:advanced_typecasting].should be true
-        reader.options[:convert_tags_to].should be_a Proc
-        reader.options[:parser].should == :nokogiri
-        reader.elements.should == ['some_nested', 'record']
+        expect(reader.options[:strip_namespaces]).to be true
+        expect(reader.options[:advanced_typecasting]).to be true
+        expect(reader.options[:convert_tags_to]).to be_a Proc
+        expect(reader.options[:parser]).to eq :nokogiri
+        expect(reader.elements).to eq ['some_nested', 'record']
       end
 
       it "configures with a block" do
@@ -32,11 +32,11 @@ module Stockboy
           elements ['SomeNested', 'Record']
         end
 
-        reader.options[:strip_namespaces].should be true
-        reader.options[:advanced_typecasting].should be true
-        reader.options[:convert_tags_to].should be_a Proc
-        reader.options[:parser].should == :nokogiri
-        reader.elements.should == ['some_nested', 'record']
+        expect(reader.options[:strip_namespaces]).to be true
+        expect(reader.options[:advanced_typecasting]).to be true
+        expect(reader.options[:convert_tags_to]).to be_a Proc
+        expect(reader.options[:parser]).to eq :nokogiri
+        expect(reader.elements).to eq ['some_nested', 'record']
       end
     end
 
@@ -52,7 +52,7 @@ module Stockboy
         it "returns element hashes" do
           items = reader.parse data
           output_keys.each do |k|
-            items[0].keys.should include k
+            expect(items[0].keys).to include k
           end
         end
 
@@ -60,7 +60,7 @@ module Stockboy
           items = reader.parse data
           output_keys.each do |key|
             i = items[0].keys.index(key)
-            items[0].keys[i].should be items[1].keys[i]
+            expect(items[0].keys[i]).to be items[1].keys[i]
           end
         end
       end

data/spec/stockboy/readers_spec.rb

@@ -8,21 +8,21 @@ module Stockboy
 
     describe ".register" do
       it "registers a key for a reader class" do
-        Readers.register(:markup, reader_class).should be reader_class
+        expect(Readers.register(:markup, reader_class)).to be reader_class
       end
     end
 
     describe ".find" do
       it "returns a reader class" do
         Readers.register(:markup, reader_class)
-        Readers.find(:markup).should be reader_class
+        expect(Readers.find(:markup)).to be reader_class
       end
     end
 
     describe ".[]" do
       it "returns a reader class" do
         Readers.register(:markup, reader_class)
-        Readers[:markup].should be reader_class
+        expect(Readers[:markup]).to be reader_class
       end
     end
 

data/spec/stockboy/source_record_spec.rb

@@ -9,11 +9,11 @@ module Stockboy
     end
 
     it "accesses initialized fields from hash" do
-      record.full_name.should == 'Arthur Dent'
+      expect(record.full_name).to eq 'Arthur Dent'
     end
 
     it "accesses source field names" do
-      record[3].should == 'Arthur Dent'
+      expect(record[3]).to eq 'Arthur Dent'
     end
   end
 end

data/spec/stockboy/template_file_spec.rb

@@ -12,17 +12,17 @@ module Stockboy
 
     describe ".read" do
       it "returns the template string" do
-        TemplateFile.read("test_job").should match "# file exists!"
+        expect(TemplateFile.read("test_job")).to match "# file exists!"
       end
     end
 
     describe ".template_path" do
       it "returns nil when missing" do
-        TemplateFile.find("not_here").should be nil
+        expect(TemplateFile.find("not_here")).to be nil
       end
 
       it "returns a file path when found" do
-        TemplateFile.find("test_job").should == "#{template_path}/test_job.rb"
+        expect(TemplateFile.find("test_job")).to eq "#{template_path}/test_job.rb"
       end
     end
 

data/spec/stockboy/translations/boolean_spec.rb

@@ -8,7 +8,7 @@ module Stockboy
       def self.it_should_be(actual, arg)
         it "returns #{actual.inspect} for #{arg[:for].inspect}" do
           result = subject.call arg[:for]
-          result.should eq actual
+          expect(result).to eq actual
         end
       end
 

data/spec/stockboy/translations/date_spec.rb

@@ -10,27 +10,27 @@ module Stockboy
     describe "#call" do
       it "returns nil for an empty string" do
         result = subject.call start: ""
-        result.should be nil
+        expect(result).to be nil
       end
 
       it "returns a date unmodified" do
         result = subject.call start: ::Date.new(2012,12,21)
-        result.should == ::Date.new(2012,12,21)
+        expect(result).to eq ::Date.new(2012,12,21)
       end
 
       it "returns a date from a string" do
         result = subject.call start: '2013-12-11'
-        result.should == ::Date.new(2013,12,11)
+        expect(result).to eq ::Date.new(2013,12,11)
       end
 
       it "returns a date from a time" do
         result = subject.call start: ::Time.new(2012,12,21,12,21,12)
-        result.should == ::Date.new(2012,12,21)
+        expect(result).to eq ::Date.new(2012,12,21)
       end
 
       it "returns a date from a DateTime" do
         result = subject.call start: ::DateTime.new(2012,12,21,12,21,12)
-        result.should == ::Date.new(2012,12,21)
+        expect(result).to eq ::Date.new(2012,12,21)
       end
     end
 

data/spec/stockboy/translations/decimal_spec.rb

@@ -9,13 +9,13 @@ module Stockboy
     describe "#call" do
       it "returns nil for an empty string" do
         result = subject.call total: ""
-        result.should be nil
+        expect(result).to be nil
       end
 
       it "returns a decimal" do
         result = subject.call total: "42.42"
-        result.should == 42.42
-        result.should be_a BigDecimal
+        expect(result).to eq 42.42
+        expect(result).to be_a BigDecimal
       end
     end
 

data/spec/stockboy/translations/default_empty_string_spec.rb

@@ -9,22 +9,22 @@ module Stockboy
     describe "#call" do
       it "returns empty string for nil" do
         result = subject.call comment: nil
-        result.should == ""
+        expect(result).to eq ""
       end
 
       it "returns empty string for an empty string" do
         result = subject.call comment: ""
-        result.should == ""
+        expect(result).to eq ""
       end
 
       it "returns original value if present" do
         result = subject.call comment: "asdf"
-        result.should == "asdf"
+        expect(result).to eq "asdf"
       end
 
       it "returns original value when zero" do
         result = subject.call comment: 0
-        result.should == 0
+        expect(result).to eq 0
       end
     end
 

data/spec/stockboy/translations/default_false_spec.rb

@@ -8,7 +8,7 @@ module Stockboy
       def self.it_should_be(actual, arg)
         it "returns #{actual.inspect} for #{arg[:for].inspect}" do
           result = subject.call arg[:for]
-          result.should eq actual
+          expect(result).to eq actual
         end
       end
 

data/spec/stockboy/translations/default_nil_spec.rb

@@ -9,22 +9,22 @@ module Stockboy
     describe "#call" do
       it "returns nil for empty string" do
         result = subject.call email: ""
-        result.should == nil
+        expect(result).to eq nil
       end
 
       it "returns nil for nil" do
         result = subject.call email: nil
-        result.should == nil
+        expect(result).to eq nil
       end
 
       it "returns original value if present" do
         result = subject.call email: "a@example.com"
-        result.should == "a@example.com"
+        expect(result).to eq "a@example.com"
       end
 
       it "returns original value when zero" do
         result = subject.call email: 0
-        result.should == 0
+        expect(result).to eq 0
       end
     end