stockboy 0.6.0 → 0.7.0

data/spec/stockboy/job_spec.rb

@@ -1,11 +1,31 @@
 require 'spec_helper'
 require 'stockboy/job'
 
+class TestProvider
+  attr_reader :data, :errors
+  def initialize(opts)
+    @data = opts[:data] || ""
+    @errors = opts[:errors] || []
+  end
+  def clear
+    @data = nil
+  end
+end
+
+class TestReader
+  def initialize(opts)
+    @parse = opts[:parse] || []
+  end
+  def parse(data)
+    @parse
+  end
+end
+
 module Stockboy
   describe Job do
     let(:jobs_path) { RSpec.configuration.fixture_path.join('jobs') }
-    let(:provider_stub) { double(:ftp).as_null_object }
-    let(:reader_stub)   { double(:csv).as_null_object }
+    let(:provider)  { provider_double }
+    let(:reader)    { reader_double }
 
     let(:job_template) {
       <<-END.gsub(/^ {6}/,'')
@@ -35,8 +55,8 @@ module Stockboy
     before do
       Stockboy.configuration.template_load_paths = [jobs_path]
 
-      allow(Stockboy::Providers).to receive(:find) { provider_stub }
-      allow(Stockboy::Readers).to receive(:find) { reader_stub }
+      allow(Stockboy::Providers).to receive(:find) { TestProvider }
+      allow(Stockboy::Readers).to receive(:find)   { TestReader }
     end
 
     its(:filters) { should be_a Hash }
@@ -65,16 +85,19 @@ module Stockboy
       end
 
       it "assigns a registered provider from a symbol" do
+        Stockboy::Providers.should_receive(:find)
+                           .with(:ftp)
+                           .and_return(TestProvider)
         job = Job.define("test_job")
-        job.provider.should == provider_stub
+        job.provider.should be_a TestProvider
       end
 
       it "assigns a registered reader from a symbol" do
         Stockboy::Readers.should_receive(:find)
                          .with(:csv)
-                         .and_return(reader_stub)
+                         .and_return(TestReader)
         job = Job.define("test_job")
-        job.reader.should == reader_stub
+        job.reader.should be_a TestReader
       end
 
       it "assigns attributes from a block" do
@@ -93,12 +116,11 @@ module Stockboy
       let(:attribute_map) { AttributeMap.new { name } }
 
       subject(:job) do
-        Job.new(provider: double(:provider, data:"", errors:[]),
-                attributes: attribute_map)
+        Job.new(provider: provider, attributes: attribute_map)
       end
 
       it "records total received record count" do
-        job.reader = double(parse: [{"name"=>"A"},{"name"=>"B"}])
+        job.reader = reader_double(parse: [{"name"=>"A"},{"name"=>"B"}])
 
         job.process
         job.total_records.should == 2
@@ -155,8 +177,7 @@ module Stockboy
       let(:attribute_map) { AttributeMap.new { name } }
 
       subject(:job) do
-        Job.new(provider: double(:provider, data:"", errors:[]),
-                attributes: attribute_map)
+        Job.new(provider: provider, attributes: attribute_map)
       end
 
       context "before processing" do
@@ -180,9 +201,7 @@ module Stockboy
 
     describe "#processed?" do
       subject(:job) do
-        Job.new(provider: provider_stub,
-                reader: reader_stub,
-                attributes: AttributeMap.new)
+        Job.new(provider: provider, reader: reader, attributes: AttributeMap.new)
       end
 
       it "indicates if the job has been processed" do
@@ -194,11 +213,9 @@ module Stockboy
 
     describe "#trigger" do
 
-      let(:provider_stub) { double(delete_data: true) }
-
       subject(:job) do
         Job.new(
-          provider: provider_stub,
+          provider: provider,
           triggers: {
             success: [proc { |j| j.provider.delete_data },
                       proc { |j, stats| stats[:count] = 1 if stats }]
@@ -207,11 +224,12 @@ module Stockboy
       end
 
       it "should yield itself to each trigger" do
-        provider_stub.should_receive(:delete_data).once
+        expect(job.provider).to receive(:delete_data).once
         job.trigger(:success)
       end
 
       it "should yield args to each trigger" do
+        expect(job.provider).to receive(:delete_data).once
         stats = {}
         job.trigger(:success, stats)
         stats[:count].should == 1
@@ -234,5 +252,12 @@ module Stockboy
 
     end
 
+    def provider_double(opts={})
+      TestProvider.new(opts)
+    end
+
+    def reader_double(opts={})
+      TestReader.new(opts)
+    end
   end
 end

data/spec/stockboy/provider_repeater_spec.rb

@@ -0,0 +1,80 @@
+require 'spec_helper'
+require 'stockboy/provider_repeater'
+
+class PaginatedProviderSubclass < Stockboy::Provider
+  attr_accessor :page
+  def validate
+    true
+  end
+  def fetch_data
+    @data = "TEST,DATA,#{page}"
+  end
+end
+
+module Stockboy
+  describe ProviderRepeater do
+
+    let(:provider) { PaginatedProviderSubclass.new }
+
+    describe "#data" do
+      let(:repeater) {
+        ProviderRepeater.new(provider) do |output, provider|
+          1.upto 3 do |i|
+            provider.page = i
+            output << provider
+          end
+        end
+      }
+
+      it "yields each data set" do
+        calls = []
+        repeater.data { |data| calls << data[-1] }
+        calls.should == ["1", "2", "3"]
+      end
+
+    end
+
+    describe "#each" do
+
+      context "without a block" do
+        let(:repeater) { ProviderRepeater.new(provider) }
+
+        it "yields the provider once" do
+          provider.page = 42
+          calls = []
+          repeater.each do |nth_provider|
+            calls << nth_provider
+          end
+          calls.map(&:page).should == [42]
+        end
+      end
+
+      context "when it passes a non-provider" do
+        let(:repeater) {
+          ProviderRepeater.new(provider) do |output, provider|
+            output << nil
+          end
+        }
+
+        it "should raise a helpful error" do
+          expect { repeater.each { |provider| } }.to raise_error(
+            "expected Provider, got NilClass" )
+        end
+      end
+
+      context "when it is defined with yield" do
+        let(:repeater) {
+          ProviderRepeater.new(provider) do |output, provider|
+            yield provider
+          end
+        }
+
+        it "should raise a helpful error" do
+          expect { repeater.data { |data| } }.to raise_error(
+            "use output << provider instead of yield" )
+        end
+      end
+    end
+
+  end
+end

data/spec/stockboy/provider_spec.rb

@@ -2,9 +2,11 @@ require 'spec_helper'
 require 'stockboy/provider'
 
 class ProviderSubclass < Stockboy::Provider
-  attr_accessor :foo
   def validate
-    errors.add_on_empty(:foo, "Foo is empty")
+    true
+  end
+  def fetch_data
+    @data = "TEST,DATA"
   end
 end
 
@@ -30,5 +32,23 @@ module Stockboy
         expect{ subject.send :fetch_data }.to raise_error(NoMethodError)
       end
     end
+
+    describe "#data" do
+      subject(:provider) { ProviderSubclass.new(foo: true) }
+
+      it "fetches data when there is none" do
+        expect(provider).to receive(:fetch_data).once.and_call_original
+        2.times do
+          provider.data.should == "TEST,DATA"
+        end
+      end
+
+      it "yields data to a block" do
+        provider.data do |data|
+          data.should == "TEST,DATA"
+        end
+      end
+    end
+
   end
 end

data/spec/stockboy/providers/file_spec.rb

@@ -23,7 +23,7 @@ module Stockboy
 
     describe ".new" do
       it "has no errors" do
-        provider.errors.messages.should be_empty
+        provider.errors.should be_empty
       end
 
       it "accepts block initialization" do
@@ -55,8 +55,8 @@ module Stockboy
       it "fails with an error if the file doesn't exist" do
         provider.file_name = "missing-file.csv"
         provider.data.should be_nil
-        provider.valid?.should == false
-        provider.errors[:base].should_not be_empty
+        provider.valid?.should be_false
+        provider.errors.first.should match /not found/
       end
 
       it "finds last matching file from string glob" do
@@ -76,16 +76,16 @@ module Stockboy
       end
 
       context "with :since validation" do
-        let(:recently) { Time.now - 60 }
+        let(:recently)  { Time.now - 60 }
+        let(:last_week) { Time.now - 86400 }
 
         it "skips old files" do
-          expect_any_instance_of(::File).to receive(:mtime).and_return Time.now - 86400
-          provider.file_dir = RSpec.configuration.fixture_path.join("files")
+          expect_any_instance_of(::File).to receive(:mtime).and_return last_week
           provider.file_name = '*.csv'
           provider.since = recently
 
           provider.data.should be_nil
-          provider.errors[:response].should include "No new files since #{recently}"
+          provider.errors.first.should == "no new files since #{recently}"
         end
       end
     end

data/spec/stockboy/providers/ftp_spec.rb

@@ -32,7 +32,7 @@ module Stockboy
 
     describe ".new" do
       it "has no errors" do
-        subject.errors.messages.should be_empty
+        subject.errors.should be_empty
       end
 
       it "accepts block initialization" do
@@ -67,14 +67,14 @@ module Stockboy
         provider.host = nil
         provider.data
 
-        provider.errors.include?(:host).should be_true
+        provider.errors.first.should match /host/
       end
 
       it "adds an error on missing file_name" do
         provider.file_name = nil
         provider.data
 
-        provider.errors.include?(:file_name).should be_true
+        provider.errors.first.should match /file_name/
       end
 
       it "downloads the last matching file" do

data/spec/stockboy/providers/http_spec.rb

@@ -58,15 +58,17 @@ module Stockboy
 
     describe "validation" do
       it "should not be valid without a method" do
+        provider.uri = "http://example.com"
         provider.method = nil
         provider.should_not be_valid
-        provider.errors.keys.should include(:method)
+        provider.errors.first.should match /method/
       end
 
       it "should not be valid without a uri" do
         provider.uri = ""
+        provider.method = :get
         provider.should_not be_valid
-        provider.errors.keys.should include(:uri)
+        provider.errors.first.should match /uri/
       end
     end
 

data/spec/stockboy/providers/imap_spec.rb

@@ -39,7 +39,7 @@ module Stockboy
 
     describe ".new" do
       it "has no errors" do
-        provider.errors.messages.should be_empty
+        provider.errors.should be_empty
       end
 
       it "accepts block initialization" do
@@ -108,7 +108,7 @@ module Stockboy
       it "closes connections when catching exceptions" do
         net_imap = expect_connection("hhh", "uuu", "ppp", "UNBOX")
         provider.client { |i| raise Net::IMAP::Error }
-        provider.errors[:response].should include "IMAP connection error"
+        provider.errors.first.should match /IMAP connection error/
       end
 
     end

data/spec/stockboy/providers/soap_spec.rb

@@ -52,7 +52,7 @@ module Stockboy
       context "without a WSDL document" do
         it "has error for blank endpoint & WSDL namespace" do
           provider.valid?
-          provider.errors.keys.should include(:endpoint)
+          provider.errors.first.should match /endpoint/
         end
       end
     end
@@ -88,10 +88,15 @@ module Stockboy
         provider.data
       end
 
-      it "returns hash data on success" do
+      it "returns hash data on success by default" do
         should be_a Hash
       end
 
+      it "returns xml data on success with an xml response_format" do
+        provider.response_format = :xml
+        should be_a String
+      end
+
       it "uses string keys" do
         response.keys.each { |k| k.should be_a String }
       end

data/stockboy.gemspec

@@ -29,5 +29,5 @@ Gem::Specification.new do |s|
   s.add_runtime_dependency "savon", ">= 2.3.0"
   s.add_runtime_dependency "httpi"
   s.add_runtime_dependency "mail"
-  s.add_runtime_dependency "activemodel", ">= 3.0"
+  s.add_runtime_dependency "activesupport", ">= 3.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: stockboy
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.7.0
 platform: ruby
 authors:
 - Andrew Vit
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-07 00:00:00.000000000 Z
+date: 2014-03-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -95,7 +95,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: activemodel
+  name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
@@ -141,6 +141,7 @@ files:
 - lib/stockboy/job.rb
 - lib/stockboy/mapped_record.rb
 - lib/stockboy/provider.rb
+- lib/stockboy/provider_repeater.rb
 - lib/stockboy/providers.rb
 - lib/stockboy/providers/file.rb
 - lib/stockboy/providers/ftp.rb
@@ -198,6 +199,7 @@ files:
 - spec/stockboy/filters_spec.rb
 - spec/stockboy/job_spec.rb
 - spec/stockboy/mapped_record_spec.rb
+- spec/stockboy/provider_repeater_spec.rb
 - spec/stockboy/provider_spec.rb
 - spec/stockboy/providers/file_spec.rb
 - spec/stockboy/providers/ftp_spec.rb
@@ -277,6 +279,7 @@ test_files:
 - spec/stockboy/filters_spec.rb
 - spec/stockboy/job_spec.rb
 - spec/stockboy/mapped_record_spec.rb
+- spec/stockboy/provider_repeater_spec.rb
 - spec/stockboy/provider_spec.rb
 - spec/stockboy/providers/file_spec.rb
 - spec/stockboy/providers/ftp_spec.rb