stock_info 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f7d2aa9d2adf0d345b95baac59daf04046176b81
-  data.tar.gz: c7b99c55c21869793d2e71a1edafb875c97ee045
+  metadata.gz: 476a3a1026da6b7478795475012c06dd0b30c9f0
+  data.tar.gz: f7d79d9b713ae7b4b0ac0485e988ba0da206b2b3
 SHA512:
-  metadata.gz: d1f2041a7ad54038f398d0c0a77ae144a69530f3c2dcd0d566b6631c7a6c4ae0ff4bf4de9fd970014db20edf36de8ea4649ec6b7f5ae3b88ad4b13f62ecc343b
-  data.tar.gz: aed8e382818cc9c3574e2196977acbee1355418cb5f1058ea6467e8d1c4c3bbd65e729776a50a1455ecc3a4b672fc4e31a004955f29b7d91823c070b468b2ecd
+  metadata.gz: e659a227c1c0dbf1569ebf2173d128e97378afe83446161f74b9d9915122b8171b20f2225174fd8add8467414a86f95e5c1310310d30962d6953174ab3db705c
+  data.tar.gz: 4061642252a6bd222ada67d27b7f0716a9366a82b6911469ec257fe7b008f801307d19f1390ee382103f9380d77eeb389d9b70b51329fb7337b3f13e31508bc2

data/Gemfile

@@ -1,7 +1,6 @@
+source 'https://rubygems.org'
 
-source "https://rubygems.org"
-
-git_source(:github) {|repo_name| "https://github.com/decentralvision/stock_info" }
+git_source(:github) { |_repo_name| 'https://github.com/decentralvision/stock_info' }
 
 # Specify your gem's dependencies in stock_info.gemspec
 gemspec

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    stock_info (0.1.1)
+    stock_info (0.1.2)
       nokogiri (~> 1.10)
 
 GEM

data/NOTES.md

@@ -1,17 +1 @@
-Can't build gem into executable.
-
-Give a list of trending tickers and their % change : https://finance.yahoo.com/trending-tickers
-Scrape news articles for a given stock ticker symbol https://finviz.com/quote.ashx?t="ticker symbol"
-
 Things to work on:
-
-Referencing with namespace StockInfo::Stock is this correct? 
-
-DRY code
-
-Get rid of system error from opening browser
-
-Can't pull data from :         short_doc = Nokogiri::HTML(open("https://www.nakedshortreport.com/company/#{symbol}"))
-
-Why?
-

data/Rakefile

@@ -1,2 +1,2 @@
-require "bundler/gem_tasks"
-task :default => :spec
+require 'bundler/gem_tasks'
+task default: :spec

data/bin/console

@@ -1,7 +1,7 @@
 #!/usr/bin/env ruby
 
-require "bundler/setup"
-require "stock_info"
+require 'bundler/setup'
+require 'stock_info'
 
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.
@@ -10,5 +10,5 @@ require "stock_info"
 # require "pry"
 # Pry.start
 
-require "irb"
+require 'irb'
 IRB.start(__FILE__)

data/bin/{stock-info → stock_info}

@@ -1,4 +1,4 @@
 #!/usr/bin/env ruby
 require 'bundler/setup'
 require_relative '../lib/stock_info'
-StockInfo::CLI.new.call
+StockInfo::CLI.new.call

data/lib/stock_info/cli.rb

@@ -1,36 +1,37 @@
 # Our CLI controller
 class StockInfo::CLI
-    def call        
+  def call
+    trending_tickers
+    menu
+    goodbye
+  end
+
+  def trending_tickers
+    puts "Loading today's trending stocks..."
+    StockInfo::Stock.print_trending
+  end
+
+  def menu
+    input = nil
+    while input != 'exit'
+      puts 'Enter the ticker symbol of a stock you would like more info on.'
+      puts "Other commands: 'exit' - exits stock-info, 'trending' - shows trending stocks."
+      input = gets.strip.downcase
+      if input == 'trending'
         trending_tickers
-        menu
-        goodbye
+      elsif StockInfo::Stock.check_symbol(input.upcase) == true
+        stock = StockInfo::Stock.new(input.upcase)
+        stock.print_info
+        puts 'View recent news articles related to this stock? (yes/no)'
+        news_bool = gets.strip[0].downcase
+        input = StockInfo::News.news_menu(stock) if news_bool == 'y'
+      elsif input != 'exit'
+        puts 'Please input a command or ticker symbol'
+      end
     end
-    def trending_tickers
-        puts "Loading today's trending stocks..."
-        StockInfo::Stock.print_trending
-    end
-    def menu
-        input = nil
-        while input != 'exit'
-            puts "Enter the ticker symbol of a stock you would like more info on."
-            puts "Other commands: 'exit' - exits stock-info, 'trending' - shows trending stocks."
-            input = gets.strip.downcase
-            if input == 'trending'
-                trending_tickers
-            elsif StockInfo::Stock.check_symbol(input.upcase) == true
-                stock = StockInfo::Stock.new(input.upcase)
-                stock.print_info
-                puts "View recent news articles related to this stock? (yes/no)"
-                news_bool = gets.strip[0].downcase
-                if news_bool == 'y'
-                    StockInfo::Stock::News.news_menu(stock)
-                end
-            elsif input != 'exit'
-                puts 'Please input a command or ticker symbol'
-            end
-        end
-    end
-    def goodbye
-        puts "Goodbye and good luck!"
-    end
-end
+  end
+
+  def goodbye
+    puts 'Goodbye and good luck!'
+  end
+end

data/lib/stock_info/news.rb

@@ -1,43 +1,45 @@
-class StockInfo::Stock::News
-    attr_accessor :symbol, :title, :source, :link
-    def self.get_news(symbol)
-        news = []
-        doc = Nokogiri::HTML(open("https://finviz.com/quote.ashx?t=#{symbol}"))
-        i=0
-        10.times do 
-            article = self.new
-            article.symbol = symbol
-            sources = doc.css("table#news-table.fullview-news-outer tr span") - doc.css("table#news-table.fullview-news-outer tr span.body-table-news-gain")
-            article.title = doc.css("table#news-table.fullview-news-outer tr")[i].css(".tab-link-news").text
-            article.source = sources[i].text
-            article.link = doc.css("table#news-table.fullview-news-outer tr td a")[i].attribute("href").value
-            news << article
-            i+=1
-        end
-        news
-    end
-    def self.news_menu(stock)
-        input = nil
-        while input != 'menu' && input != 'exit'
-            stock.print_news
-            puts "Enter the number of an article you would like to open in your web browser, or 'menu' to return to the main menu"
-            input = gets.strip
-            if input.to_i > 0 && input.to_i <= 10
-                self.open_url(stock.news[(input.to_i) -1].link)
-            elsif input.downcase != 'menu' && input.downcase != 'exit'
-                puts "Enter the number of an article or 'menu'"
-            end
-        end
+class StockInfo::News
+  attr_accessor :symbol, :title, :source, :link
+
+  def self.get_news(stock)
+    symbol = stock.symbol
+    stock.news.clear
+    doc = Nokogiri::HTML(open("https://finviz.com/quote.ashx?t=#{symbol}"))
+    i = 0
+    10.times do
+      article = new
+      article.symbol = symbol
+      sources = doc.css('table#news-table.fullview-news-outer tr span') - doc.css('table#news-table.fullview-news-outer tr span.body-table-news-gain')
+      article.title = doc.css('table#news-table.fullview-news-outer tr')[i].css('.tab-link-news').text
+      article.source = sources[i].text
+      article.link = doc.css('table#news-table.fullview-news-outer tr td a')[i].attribute('href').value
+      stock.news << article
+      i += 1
     end
+  end
 
-    def self.open_url(link)
-            if RbConfig::CONFIG['host_os'] =~ /mswin|mingw|cygwin/
-                system "start #{link}"
-            elsif RbConfig::CONFIG['host_os'] =~ /darwin/
-                system "open #{link}"
-            elsif RbConfig::CONFIG['host_os'] =~ /linux|bsd/
-                system "xdg-open #{link}"
-            end
+  def self.news_menu(stock)
+    input = nil
+    stock.print_news
+    while input != 'menu' && input != 'exit'
+      puts "Enter the number of an article you would like to open in your web browser, 'menu' to return to the main menu, 'refresh' to check for recent news, or 'exit' to exit."
+      input = gets.strip
+      if input.to_i > 0 && input.to_i <= 10
+        open_url(stock.news[input.to_i - 1].link)
+      elsif input.casecmp('refresh').zero?
+        stock.print_news
+      end
+    end
+    'exit' if input == 'exit'
+  end
 
+  def self.open_url(link)
+    if RbConfig::CONFIG['host_os'] =~ /mswin|mingw|cygwin/
+      system "start #{link} -s"
+    elsif RbConfig::CONFIG['host_os'] =~ /darwin/
+      system "open #{link} -s"
+    elsif RbConfig::CONFIG['host_os'] =~ /linux|bsd/
+      system "xdg-open #{link} 2> /dev/null"
     end
-end
+  end
+end

data/lib/stock_info/stock.rb

@@ -1,53 +1,59 @@
 class StockInfo::Stock
-    attr_accessor :company, :symbol, :daily_change, :price, :news, :earnings, :rvol, :optionable, :short_ratio
-    def initialize(symbol)
-        @symbol = symbol
-        self.get_info(symbol)
+  attr_accessor :company, :symbol, :daily_change, :price, :news, :earnings, :rvol, :optionable, :short_ratio
+  @@trending = []
+  def initialize(symbol)
+    @symbol = symbol
+    @news = []
+    get_info(symbol)
+  end
+
+  def self.check_symbol(symbol)
+    open("https://finviz.com/quote.ashx?t=#{symbol}").read
+    true
+  rescue StandardError => e
+    false
+  end
+
+  def get_info(symbol)
+    doc = Nokogiri::HTML(open("https://finviz.com/quote.ashx?t=#{symbol}"))
+    @company = doc.css('table.fullview-title tr')[1].text
+    @rvol = doc.css('table.snapshot-table2 td.snapshot-td2')[-14].text
+    @daily_change = doc.css('table.snapshot-table2 td.snapshot-td2')[-1].text
+    @price = doc.css('table.snapshot-table2 td.snapshot-td2')[-7].text
+    @optionable = doc.css('table.snapshot-table2 td.snapshot-td2')[-18].text
+    @short_ratio = doc.css('table.snapshot-table2 td.snapshot-td2')[22].text
+    @earnings = doc.css('table.snapshot-table2 td.snapshot-td2')[-10].text
+    @earnings = 'None (ETF)' if earnings == '-'
+  end
+
+  def print_news
+    StockInfo::News.get_news(self)
+    @news.each.with_index(1) do |article, i|
+      puts "#{i} | #{article.title} - #{article.source}"
     end
-    def self.check_symbol(symbol)
-        begin
-            open("https://finviz.com/quote.ashx?t=#{symbol}").read
-            true
-        rescue => e
-            false
-        end
+  end
+
+  def print_info
+    puts "#{company} - Price: #{price} - Change: #{daily_change} - Relative Volume: #{rvol} - Earnings Date: #{earnings} - Optionable: #{optionable} - Short Ratio: #{short_ratio}"
+  end
+
+  def self.print_trending
+    trending.each do |stock|
+      puts "#{stock.symbol} - Price: #{stock.price} - Change: #{stock.daily_change} - Relative Volume: #{stock.rvol}"
     end
-    def get_info(symbol)
-        doc = Nokogiri::HTML(open("https://finviz.com/quote.ashx?t=#{symbol}"))
-        self.company = doc.css('table.fullview-title tr')[1].text
-        self.rvol = doc.css("table.snapshot-table2 td.snapshot-td2")[-14].text 
-        self.daily_change = doc.css("table.snapshot-table2 td.snapshot-td2")[-1].text
-        self.price = doc.css("table.snapshot-table2 td.snapshot-td2")[-7].text
-        self.optionable = doc.css("table.snapshot-table2 td.snapshot-td2")[-18].text 
-        self.short_ratio = doc.css("table.snapshot-table2 td.snapshot-td2")[22].text
-        self.earnings = doc.css("table.snapshot-table2 td.snapshot-td2")[-10].text 
-        if self.earnings == '-'
-            self.earnings = "None (ETF)"
-        end
+  end
+
+  def self.trending
+    time = Time.now.localtime('-05:00')
+    unless (time.saturday? || time.sunday? || time.hour > 20 || time.hour < 4) && @@trending.any?
+      i = 0
+      doc = Nokogiri::HTML(open('https://finviz.com/screener.ashx?v=110&s=ta_mostactive'))
+      10.times do
+        symbol = doc.css('tr.table-dark-row-cp a.screener-link-primary')[i].text
+        i += 1
+        @@trending << new(symbol)
+      end
     end
-    def print_news
-        self.news = News.get_news(self.symbol)
-        self.news.each.with_index(1) do |article, i|
-            puts "#{i} | #{article.title} - #{article.source}"
-        end
-    end
-    def print_info
-        puts "#{self.company} - Price: #{self.price} - Change: #{self.daily_change} - Relative Volume: #{self.rvol} - Earnings Date: #{self.earnings} - Optionable: #{self.optionable} - Short Ratio: #{self.short_ratio}"
-    end
-    def self.print_trending
-        self.trending.each do |stock|
-            puts "#{stock.symbol} - Price: #{stock.price} - Change: #{stock.daily_change} - Relative Volume: #{stock.rvol}"
-        end        
-    end
-    def self.trending
-        trending = []
-        i = 0
-        doc = Nokogiri::HTML(open("https://finviz.com/screener.ashx?v=110&s=ta_mostactive"))
-        10.times do 
-            symbol = doc.css("tr.table-dark-row-cp a.screener-link-primary")[i].text
-            i += 1
-            trending << self.new(symbol)
-        end
-        trending
-    end
-end
+    @@trending
+  end
+end

data/lib/stock_info/version.rb

@@ -1,3 +1,3 @@
 module StockInfo
-  VERSION = "0.1.2"
+  VERSION = '0.1.3'.freeze
 end

data/lib/stock_info.rb

@@ -1,8 +1,8 @@
-require_relative "./stock_info/version"
-require_relative "./stock_info/cli"
-require_relative "./stock_info/stock"
-require_relative "./stock_info/news"
+require_relative './stock_info/version'
+require_relative './stock_info/cli'
+require_relative './stock_info/stock'
+require_relative './stock_info/news'
 
 require 'nokogiri'
 require 'pry'
-require 'open-uri'
+require 'open-uri'

data/stock_info.gemspec

@@ -1,30 +1,29 @@
-
-lib = File.expand_path("../lib", __FILE__)
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require "stock_info/version"
+require 'stock_info/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "stock_info"
+  spec.name          = 'stock_info'
   spec.version       = StockInfo::VERSION
-  spec.authors       = ["Tom Kunkel"]
-  spec.email         = ["36858744+decentralvision@users.noreply.github.com"]
+  spec.authors       = ['Tom Kunkel']
+  spec.email         = ['36858744+decentralvision@users.noreply.github.com']
 
-  spec.summary       = "Simple gem providing stock info from finviz.com"
+  spec.summary       = 'Simple gem providing stock info from finviz.com'
   spec.description   = "This CLI gem provides data and news articles from finviz.com, run the program with 'stock-info'. Commands are provided via prompts in the interface."
-  spec.homepage      = "https://github.com/decentralvision/stock-info"
-  spec.license       = "MIT"
+  spec.homepage      = 'https://github.com/decentralvision/stock-info'
+  spec.license       = 'MIT'
 
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
-  spec.files         = Dir.chdir(File.expand_path('..', __FILE__)) do
+  spec.files         = Dir.chdir(File.expand_path(__dir__)) do
     `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   end
-  spec.bindir        = "bin"
-  spec.executables   << "stock-info"
-  spec.require_paths = ["lib"]
+  spec.bindir = 'bin'
+  spec.executables << 'stock_info'
+  spec.require_paths = ['lib']
 
-  spec.add_development_dependency "bundler", "~> 1.16"
-  spec.add_development_dependency "rake", "~> 10.0"
-  spec.add_development_dependency "pry", "~> 0.12"
-  spec.add_dependency "nokogiri", "~> 1.10"
+  spec.add_development_dependency 'bundler', '~> 1.16'
+  spec.add_development_dependency 'pry', '~> 0.12'
+  spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_dependency 'nokogiri', '~> 1.10'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: stock_info
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Tom Kunkel
@@ -25,33 +25,33 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '1.16'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '0.12'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '0.12'
 - !ruby/object:Gem::Dependency
-  name: pry
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.12'
+        version: '10.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.12'
+        version: '10.0'
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
@@ -71,7 +71,7 @@ description: This CLI gem provides data and news articles from finviz.com, run t
 email:
 - 36858744+decentralvision@users.noreply.github.com
 executables:
-- stock-info
+- stock_info
 extensions: []
 extra_rdoc_files: []
 files:
@@ -85,7 +85,7 @@ files:
 - Rakefile
 - bin/console
 - bin/setup
-- bin/stock-info
+- bin/stock_info
 - lib/stock_info.rb
 - lib/stock_info/cli.rb
 - lib/stock_info/news.rb