stitches 5.1.0.RC1 → 5.1.0.RC2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7e87005e3080477f7dc3d927596ea5cdeab14f4b004cd20744894088866f5b2b
-  data.tar.gz: e50f73f746ccc1b283bad98619f9a4e70a56f91c3f0e11faec66e375cfb7055f
+  metadata.gz: 74c049e2d66d366adce255f0fd8d41b6eb0e121669225b1fbce4dbd8ccb19b10
+  data.tar.gz: 8d8b6b8d5cc2e57b4e21a5a9097ccd14b462087c82ce6c30cfd2e6b4617c49c5
 SHA512:
-  metadata.gz: 84cf005517476feb055dbb1d22142d3b17749a7cdd01cb1135de3c00c9d29ca40e034dd2ee23a5d259bcf346458e1aea12cef301145df583f587fb9038d38b63
-  data.tar.gz: 4e592659a77f77ff2f6eb7c6d3b217ab6f36fd52dcf2fdaf3f16ad0e2950f7a8af69efa9a7c880d13100307aecf513c6eed4a1f31392ea1067a97ff9a21634b1
+  metadata.gz: 343c659a9e37f29caadad39b2c0d66496f164efea60e9a499daec8bb156fd5e90801af304d2bc0ac307c00ee4934b400ea4f22db4e7a996b9d7d114751a5a55c
+  data.tar.gz: dfaa3c860b35fbbbd44ba3c99d4ac1a1ce820de42393ddaa9d93cb12fb0062ad03d14cfb2a7f0ab64dfe5fa83ecd72271c30aa222923ba9fc5cecb35501d8311

data/README.md

@@ -72,7 +72,7 @@ end
 
 1. `X-StitchFix-Calling-Service` request header (preferred)
 2. `api_client&.name` — the stitches-authenticated ApiClient (works when API keys are enabled)
-3. `"N/A"` — fallback when neither is available
+3. `""` (empty string) — fallback when neither is available
 
 This is backwards compatible. When `disable_api_key_support` is false, the
 stitches middleware still populates `api_client`, so the fallback returns the

data/lib/stitches/calling_service_name.rb

@@ -5,8 +5,8 @@ module Stitches
     def calling_service_name
       @calling_service_name ||=
         request.headers[HEADER].presence ||
-        api_client&.name ||
-        "N/A"
+        (respond_to?(:api_client, true) && api_client&.name) ||
+        ""
     end
   end
 end

data/lib/stitches/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Stitches
-  VERSION = '5.1.0.RC1'
+  VERSION = '5.1.0.RC2'
 end

data/spec/calling_service_name_spec.rb

@@ -50,15 +50,37 @@ describe Stitches::CallingServiceName do
 
     context "when neither header nor api_client is present" do
       it "returns 'unknown'" do
-        expect(fake_controller.calling_service_name).to eq("N/A")
+        expect(fake_controller.calling_service_name).to eq("")
       end
     end
 
     context "when api_client is nil" do
       let(:fake_api_client) { nil }
 
-      it "returns 'unknown'" do
-        expect(fake_controller.calling_service_name).to eq("N/A")
+      it "returns empty string" do
+        expect(fake_controller.calling_service_name).to eq("")
+      end
+    end
+
+    context "when api_client method is not defined" do
+      let(:fake_controller) {
+        req = fake_request
+        Object.new.tap { |c|
+          c.extend(described_class)
+          c.define_singleton_method(:request) { req }
+        }
+      }
+
+      it "returns empty string" do
+        expect(fake_controller.calling_service_name).to eq("")
+      end
+
+      context "and header is present" do
+        let(:headers) { {"X-StitchFix-Calling-Service" => "fixops"} }
+
+        it "returns the header value" do
+          expect(fake_controller.calling_service_name).to eq("fixops")
+        end
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: stitches
 version: !ruby/object:Gem::Version
-  version: 5.1.0.RC1
+  version: 5.1.0.RC2
 platform: ruby
 authors:
 - Stitch Fix Engineering