stitches 3.7.2 → 3.7.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ca2ab185c1ce66611e8a5fbf874bbbab5caa5ef2dffc760540401f7d1c03ca10
-  data.tar.gz: '087335206e8309b959da8965482d443db390543163b124a47c28636505a088bb'
+  metadata.gz: 5fa18e703222c9f9f2cc2b750cbf06a1bf9ddac8d473e6c2775d3d0cd840e59e
+  data.tar.gz: 550563efbfc95a84ff7c9375cbd4cd6d45eff8621370780f90760ddecc4afa3e
 SHA512:
-  metadata.gz: d42cba4d8621bd45022d12a859b420ac842312a0207dc33590f59eeafc74ef98760011b77169ba7c2408e9e89825c6021f4c44cb449787cd9f316ce1614a093d
-  data.tar.gz: c680ee5c6b9a41f7d9ac281e26a48477e3d7c6920f72334f378686fb4a7d2ae0718728716c8c84bd0c0a07b9a19163fd134ecfdf26f083b6bf3864253b3c456c
+  metadata.gz: 0d81db63050704736cc9aaaebc3ccc0f06bcb271a36b734c195f9b5298121c18fd43c529e32ec2ba2dcf2e76c8dda411fc245d8229a4a2df21889de87dded7d7
+  data.tar.gz: cd636756307dd9395860278f80f9fea1638ceef28105d91cc319c80db74de58809e7e6e396f1e706b123705c7905a46d0a5e3655c7c84cd077fe6eab9808c577

data/.circleci/config.yml

@@ -3,9 +3,22 @@
 ---
 version: 2
 jobs:
-  ruby-2.5.3-rails-5.2:
+  release:
     docker:
-    - image: circleci/ruby:2.5.3
+    - image: circleci/ruby:2.6.3
+    steps:
+    - checkout
+    - run: bundle install --full-index
+    - run:
+        name: Artifactory login
+        command: mkdir -p ~/.gem && curl -u$ARTIFACTORY_USER:$ARTIFACTORY_TOKEN https://stitchfix01.jfrog.io/stitchfix01/api/gems/eng-gems/api/v1/api_key.yaml
+          > ~/.gem/credentials && chmod 0600 ~/.gem/credentials
+    - run:
+        name: Build/release gem to artifactory
+        command: bundle exec rake push_artifactory
+  ruby-2.6.3-rails-5.2:
+    docker:
+    - image: circleci/ruby:2.6.3
       environment:
         BUNDLE_GEMFILE: Gemfile.rails-5.2
     working_directory: "~/stitches"
@@ -20,13 +33,13 @@ jobs:
           fi
     - run:
         name: Notify Pager Duty
-        command: 'bundle exec y-notify #eng-platform'
+        command: bundle exec y-notify "#eng-platform"
         when: on_fail
     - store_test_results:
         path: "/tmp/test-results"
-  ruby-2.4.5-rails-5.2:
+  ruby-2.5.5-rails-5.2:
     docker:
-    - image: circleci/ruby:2.4.5
+    - image: circleci/ruby:2.5.5
       environment:
         BUNDLE_GEMFILE: Gemfile.rails-5.2
     working_directory: "~/stitches"
@@ -41,13 +54,13 @@ jobs:
           fi
     - run:
         name: Notify Pager Duty
-        command: 'bundle exec y-notify #eng-platform'
+        command: bundle exec y-notify "#eng-platform"
         when: on_fail
     - store_test_results:
         path: "/tmp/test-results"
-  ruby-2.5.3-rails-5.1:
+  ruby-2.6.3-rails-5.1:
     docker:
-    - image: circleci/ruby:2.5.3
+    - image: circleci/ruby:2.6.3
       environment:
         BUNDLE_GEMFILE: Gemfile.rails-5.1
     working_directory: "~/stitches"
@@ -62,13 +75,13 @@ jobs:
           fi
     - run:
         name: Notify Pager Duty
-        command: 'bundle exec y-notify #eng-platform'
+        command: bundle exec y-notify "#eng-platform"
         when: on_fail
     - store_test_results:
         path: "/tmp/test-results"
-  ruby-2.4.5-rails-5.1:
+  ruby-2.5.5-rails-5.1:
     docker:
-    - image: circleci/ruby:2.4.5
+    - image: circleci/ruby:2.5.5
       environment:
         BUNDLE_GEMFILE: Gemfile.rails-5.1
     working_directory: "~/stitches"
@@ -83,7 +96,7 @@ jobs:
           fi
     - run:
         name: Notify Pager Duty
-        command: 'bundle exec y-notify #eng-platform'
+        command: bundle exec y-notify "#eng-platform"
         when: on_fail
     - store_test_results:
         path: "/tmp/test-results"
@@ -91,14 +104,38 @@ workflows:
   version: 2
   on-commit:
     jobs:
-    - ruby-2.5.3-rails-5.2:
+    - release:
         context: org-global
-    - ruby-2.4.5-rails-5.2:
+        requires:
+        - ruby-2.6.3-rails-5.2
+        - ruby-2.5.5-rails-5.2
+        - ruby-2.6.3-rails-5.1
+        - ruby-2.5.5-rails-5.1
+        filters:
+          tags:
+            only: /^[0-9]+\.[0-9]+\.[0-9](\.RC\d*)?$/
+          branches:
+            ignore: /.*/
+    - ruby-2.6.3-rails-5.2:
+        context: org-global
+        filters:
+          tags:
+            only: &1 /.*/
+    - ruby-2.5.5-rails-5.2:
         context: org-global
-    - ruby-2.5.3-rails-5.1:
+        filters:
+          tags:
+            only: *1
+    - ruby-2.6.3-rails-5.1:
         context: org-global
-    - ruby-2.4.5-rails-5.1:
+        filters:
+          tags:
+            only: *1
+    - ruby-2.5.5-rails-5.1:
         context: org-global
+        filters:
+          tags:
+            only: *1
   scheduled:
     triggers:
     - schedule:
@@ -108,11 +145,11 @@ workflows:
             only:
             - master
     jobs:
-    - ruby-2.5.3-rails-5.2:
+    - ruby-2.6.3-rails-5.2:
         context: org-global
-    - ruby-2.4.5-rails-5.2:
+    - ruby-2.5.5-rails-5.2:
         context: org-global
-    - ruby-2.5.3-rails-5.1:
+    - ruby-2.6.3-rails-5.1:
         context: org-global
-    - ruby-2.4.5-rails-5.1:
+    - ruby-2.5.5-rails-5.1:
         context: org-global

data/CODEOWNERS

@@ -0,0 +1,11 @@
+# THIS FILE IS NOT THE SOURCE OF TRUTH for app ownership. If this app
+# is transferred to another team, the app ownership should be changed
+# in fixops.
+#
+# View current canonical app ownership on Unwritten:
+# https://unwritten.stitchfix.com/docs/applications-and-services
+#
+# This file uses the GitHub CODEOWNERS convention to assign PR reviewers:
+# https://help.github.com/articles/about-codeowners/
+
+* @brettfishman @bwebster

data/PULL_REQUEST_TEMPLATE.md

@@ -0,0 +1,21 @@
+## Problem
+
+«Brief overview of the problem»
+
+## Solution
+
+«Brief description of how you solved the problem»
+
+## Checklist
+
+### Before Merging
+
+- [ ] If there is an RC on this branch, revert the version change in `version.rb`
+
+### After Merging
+
+See the [gem release process](https://github.com/stitchfix/eng-wiki/blob/master/technical-topics/updating-gem-versions.md) for a detailed list, but the gist of it is:
+
+- [ ] Fetch `master` locally and run the applicable `rake version:*` task **on `master`** to bump the version
+- [ ] Run `rake release` **on `master`** to release the new version on Gemfury
+- [ ] Add [release notes](https://github.com/stitchfix/messaging/releases) - **this is very important in helping other engineers understand what changed in the new version**

data/lib/stitches/generator_files/app/controllers/api/api_controller.rb

@@ -1,4 +1,4 @@
-class Api::ApiController < ActionController::Base
+class Api::ApiController < ActionController::API
   include Stitches::Deprecation
   #
   # The order of the rescue_from blocks is important - ActiveRecord::RecordNotFound must come after StandardError,

data/lib/stitches/generator_files/app/controllers/api/v1/pings_controller.rb

@@ -1,14 +1,10 @@
 class Api::V1::PingsController < Api::ApiController
 
   def create
-    respond_to do |format|
-      format.json do
-        if ping_params[:error]
-          render json: { errors: Stitches::Errors.new([ Stitches::Error.new(code: "test", message: ping_params[:error]) ])} , status: 422
-        else
-          render json: { ping: { status: "ok" } }, status: (ping_params[:status] || "201").to_i
-        end
-      end
+    if ping_params[:error]
+      render json: { errors: Stitches::Errors.new([ Stitches::Error.new(code: "test", message: ping_params[:error]) ])} , status: 422
+    else
+      render json: { ping: { status: "ok" } }, status: (ping_params[:status] || "201").to_i
     end
   end
 

data/lib/stitches/generator_files/app/controllers/api/v2/pings_controller.rb

@@ -1,14 +1,10 @@
 class Api::V2::PingsController < Api::ApiController
 
   def create
-    respond_to do |format|
-      format.json do
-        if ping_params[:error]
-          render json: { errors: Stitches::Errors.new([ Stitches::Error.new(code: "test", message: ping_params[:error]) ])} , status: 422
-        else
-          render json: { ping: { status_v2: "ok" } }, status: (ping_params[:status] || "201").to_i
-        end
-      end
+    if ping_params[:error]
+      render json: { errors: Stitches::Errors.new([ Stitches::Error.new(code: "test", message: ping_params[:error]) ])} , status: 422
+    else
+      render json: { ping: { status_v2: "ok" } }, status: (ping_params[:status] || "201").to_i
     end
   end
 

data/lib/stitches/version.rb

@@ -1,3 +1,3 @@
 module Stitches
-  VERSION = '3.7.2'
+  VERSION = '3.7.3'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: stitches
 version: !ruby/object:Gem::Version
-  version: 3.7.2
+  version: 3.7.3
 platform: ruby
 authors:
 - Stitch Fix Engineering
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-02-01 00:00:00.000000000 Z
+date: 2019-05-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -127,6 +127,7 @@ files:
 - ".ruby-gemset"
 - ".ruby-version"
 - ".travis.yml"
+- CODEOWNERS
 - CODE_OF_CONDUCT.md
 - CONTRIBUTING.md
 - Gemfile
@@ -135,6 +136,7 @@ files:
 - Gemfile.rails-5.1
 - Gemfile.rails-5.2
 - LICENSE.txt
+- PULL_REQUEST_TEMPLATE.md
 - README.md
 - Rakefile
 - build-matrix.json
@@ -210,7 +212,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.1
+rubyforge_project: 
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: You'll be in stitches at how easy it is to create a service at Stitch Fix