stimulus_reflex 3.5.0.pre2 → 3.5.0.pre3

data/test/element_test.rb

@@ -178,4 +178,77 @@ class StimulusReflex::ElementTest < ActiveSupport::TestCase
     assert_equal "19", overlapping_keys_element.dataset.duplicate_value
     assert_equal ["20", "20", "21", "22"], overlapping_keys_element.dataset.duplicate_values
   end
+
+  test "should return true for boolean data attributes" do
+    data = {
+      "dataset" => {
+        "dataset" => {
+          "data-short" => "t",
+          "data-long" => "true",
+          "data-num" => "1",
+          "data-empty" => ""
+        }
+      }
+    }
+
+    element_with_boolean_attributes = StimulusReflex::Element.new(data)
+
+    assert element_with_boolean_attributes.boolean[:short]
+    assert element_with_boolean_attributes.boolean[:long]
+    assert element_with_boolean_attributes.boolean[:num]
+    assert element_with_boolean_attributes.boolean[:empty]
+
+    assert element_with_boolean_attributes.dataset.boolean[:short]
+    assert element_with_boolean_attributes.dataset.boolean[:long]
+    assert element_with_boolean_attributes.dataset.boolean[:num]
+    assert element_with_boolean_attributes.dataset.boolean[:empty]
+  end
+
+  test "should return false for falsey data attributes" do
+    data = {
+      "dataset" => {
+        "dataset" => {
+          "data-short" => "f",
+          "data-long" => "false",
+          "data-num" => "0"
+        }
+      }
+    }
+
+    element_with_falsey_attributes = StimulusReflex::Element.new(data)
+
+    refute element_with_falsey_attributes.boolean[:short]
+    refute element_with_falsey_attributes.boolean[:long]
+    refute element_with_falsey_attributes.boolean[:num]
+
+    refute element_with_falsey_attributes.dataset.boolean[:short]
+    refute element_with_falsey_attributes.dataset.boolean[:long]
+    refute element_with_falsey_attributes.dataset.boolean[:num]
+  end
+
+  test "should return numeric values" do
+    data = {
+      "dataset" => {
+        "dataset" => {
+          "data-int" => "123",
+          "data-float" => "123.456",
+          "data-string" => "asdf"
+        }
+      }
+    }
+
+    element_with_numeric_attributes = StimulusReflex::Element.new(data)
+
+    assert_equal 123.0, element_with_numeric_attributes.numeric[:int]
+    assert_equal 123.456, element_with_numeric_attributes.numeric[:float]
+    assert_raises do
+      element_with_numeric_attributes.numeric[:string]
+    end
+
+    assert_equal 123.0, element_with_numeric_attributes.dataset.numeric[:int]
+    assert_equal 123.456, element_with_numeric_attributes.dataset.numeric[:float]
+    assert_raises do
+      element_with_numeric_attributes.dataset.numeric[:string]
+    end
+  end
 end

data/test/generators/stimulus_reflex_generator_test.rb

@@ -25,6 +25,14 @@ class StimulusReflexGeneratorTest < Rails::Generators::TestCase
     assert_file "app/reflexes/posts_reflex.rb", /PostsReflex/
   end
 
+  test "skips stimulus controller and reflex if option provided" do
+    run_generator %w[users --skip-stimulus --skip-reflex --skip-app-controller --skip-app-reflex]
+    assert_no_file "app/javascript/controllers/application_controller.js"
+    assert_no_file "app/javascript/controllers/users_controller.js"
+    assert_no_file "app/reflexes/application_reflex.rb"
+    assert_no_file "app/reflexes/users_reflex.rb"
+  end
+
   test "creates reflex with given reflex actions" do
     run_generator %w[User update do_stuff DoMoreStuff]
     assert_file "app/reflexes/user_reflex.rb" do |reflex|

data/test/reflex_test.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require_relative "test_helper"
+require "mocha/minitest"
 
 class StimulusReflex::ReflexTest < ActionCable::Channel::TestCase
   tests StimulusReflex::Channel
@@ -29,4 +30,14 @@ class StimulusReflex::ReflexTest < ActionCable::Channel::TestCase
   test "dom_id" do
     assert @reflex.dom_id(TestModel.new(id: 123)) == "#test_model_123"
   end
+
+  test "params behave like ActionController::Parameters" do
+    ActionDispatch::Request.any_instance.stubs(:parameters).returns({"a" => "1", "b" => "2", "c" => "3"})
+    reflex = StimulusReflex::Reflex.new(subscribe, url: "https://test.stimulusreflex.com")
+
+    deleted_param = reflex.params.delete("a")
+
+    assert deleted_param == "1"
+    assert reflex.params.to_unsafe_h == {"b" => "2", "c" => "3"}
+  end
 end

data/test/test_helper.rb

@@ -2,12 +2,14 @@
 
 ENV["RAILS_ENV"] ||= "test"
 
-require "minitest/mock"
+require "mocha"
 require "rails"
 require "active_model"
 require "active_record"
 require "action_controller"
+require "minitest/mock"
 require "pry"
+
 require_relative "../lib/stimulus_reflex"
 
 class TestApp < Rails::Application

data/test/tmp/app/reflexes/demo_reflex.rb

@@ -32,5 +32,4 @@ class DemoReflex < ApplicationReflex
   #   end
   #
   # Learn more at: https://docs.stimulusreflex.com/rtfm/reflex-classes
-
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: stimulus_reflex
 version: !ruby/object:Gem::Version
-  version: 3.5.0.pre2
+  version: 3.5.0.pre3
 platform: ruby
 authors:
 - Nathan Hopkins
-autorequire:
+autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-07-21 00:00:00.000000000 Z
+date: 2021-10-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -72,14 +72,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 5.0.0.pre2
+        version: 5.0.0.pre4
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 5.0.0.pre2
+        version: 5.0.0.pre4
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -136,6 +136,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: mocha
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: standardrb
   requirement: !ruby/object:Gem::Requirement
@@ -150,7 +164,7 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.0'
-description:
+description: 
 email:
 - natehop@gmail.com
 executables: []
@@ -189,19 +203,19 @@ files:
 - lib/stimulus_reflex/callbacks.rb
 - lib/stimulus_reflex/concern_enhancer.rb
 - lib/stimulus_reflex/configuration.rb
+- lib/stimulus_reflex/dataset.rb
 - lib/stimulus_reflex/element.rb
 - lib/stimulus_reflex/policies/reflex_invocation_policy.rb
 - lib/stimulus_reflex/reflex.rb
 - lib/stimulus_reflex/reflex_data.rb
 - lib/stimulus_reflex/reflex_factory.rb
 - lib/stimulus_reflex/request_parameters.rb
+- lib/stimulus_reflex/utils/attribute_builder.rb
 - lib/stimulus_reflex/utils/colorize.rb
 - lib/stimulus_reflex/utils/logger.rb
 - lib/stimulus_reflex/utils/sanity_checker.rb
 - lib/stimulus_reflex/version.rb
 - lib/tasks/stimulus_reflex/install.rake
-- package.json
-- stimulus_reflex.gemspec
 - test/broadcasters/broadcaster_test.rb
 - test/broadcasters/broadcaster_test_case.rb
 - test/broadcasters/nothing_broadcaster_test.rb
@@ -215,7 +229,6 @@ files:
 - test/test_helper.rb
 - test/tmp/app/reflexes/application_reflex.rb
 - test/tmp/app/reflexes/demo_reflex.rb
-- yarn.lock
 homepage: https://github.com/stimulusreflex/stimulus_reflex
 licenses:
 - MIT
@@ -226,6 +239,10 @@ metadata:
   homepage_uri: https://github.com/stimulusreflex/stimulus_reflex
   source_code_uri: https://github.com/stimulusreflex/stimulus_reflex
 post_install_message: |+
+  Finish installation by running:
+
+  rake stimulus_reflex:install
+
   Get support for StimulusReflex and CableReady on Discord:
 
   https://discord.gg/stimulus-reflex
@@ -244,22 +261,21 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: 1.3.1
 requirements: []
-rubygems_version: 3.2.3
-signing_key:
+rubygems_version: 3.1.6
+signing_key: 
 specification_version: 4
 summary: Build reactive applications with the Rails tooling you already know and love.
 test_files:
-- test/broadcasters/broadcaster_test.rb
-- test/broadcasters/broadcaster_test_case.rb
-- test/broadcasters/nothing_broadcaster_test.rb
+- test/generators/stimulus_reflex_generator_test.rb
+- test/element_test.rb
 - test/broadcasters/page_broadcaster_test.rb
+- test/broadcasters/broadcaster_test_case.rb
+- test/broadcasters/broadcaster_test.rb
 - test/broadcasters/selector_broadcaster_test.rb
-- test/callbacks_test.rb
-- test/concern_enhancer_test.rb
-- test/element_test.rb
-- test/generators/stimulus_reflex_generator_test.rb
+- test/broadcasters/nothing_broadcaster_test.rb
 - test/reflex_test.rb
 - test/test_helper.rb
-- test/tmp/app/reflexes/application_reflex.rb
+- test/callbacks_test.rb
 - test/tmp/app/reflexes/demo_reflex.rb
-...
+- test/tmp/app/reflexes/application_reflex.rb
+- test/concern_enhancer_test.rb

data/package.json

@@ -1,58 +0,0 @@
-{
-  "name": "stimulus_reflex",
-  "version": "3.5.0-pre1",
-  "description": "Build reactive applications with the Rails tooling you already know and love.",
-  "keywords": [
-    "ruby",
-    "rails",
-    "websockets",
-    "actioncable",
-    "turbolinks",
-    "reactive",
-    "cable",
-    "ujs",
-    "ssr",
-    "stimulus",
-    "reflex",
-    "stimulus_reflex",
-    "dom",
-    "morphdom"
-  ],
-  "homepage": "https://docs.stimulusreflex.com/",
-  "bugs": {
-    "url": "https://github.com/stimulusreflex/stimulus_reflex/issues"
-  },
-  "repository": {
-    "type": "git",
-    "url": "git+https://github.com:stimulusreflex/stimulus_reflex.git"
-  },
-  "license": "MIT",
-  "author": "Nathan Hopkins <natehop@gmail.com>",
-  "sideEffects": false,
-  "main": "./javascript/stimulus_reflex.js",
-  "module": "./javascript/stimulus_reflex.js",
-  "scripts": {
-    "prettier-standard:check": "yarn run prettier-standard --check ./javascript/*.js ./javascript/**/*.js",
-    "prettier-standard:format": "yarn run prettier-standard ./javascript/*.js ./javascript/**/*.js",
-    "test": "yarn run mocha --require @babel/register --require jsdom-global/register --require esm ./javascript/test"
-  },
-  "peerDependencies": {
-    "stimulus": ">= 1.1"
-  },
-  "dependencies": {
-    "@rails/actioncable": ">= 6.0",
-    "cable_ready": "5.0.0-pre2"
-  },
-  "devDependencies": {
-    "@babel/core": "^7.6.2",
-    "@babel/preset-env": "^7.6.2",
-    "@babel/register": "^7.6.2",
-    "assert": "^2.0.0",
-    "esm": "^3.2.25",
-    "jsdom": "^16.0.1",
-    "jsdom-global": "^3.0.2",
-    "mocha": "^8.0.1",
-    "prettier-standard": "^16.1.0",
-    "stimulus": ">= 1.1"
-  }
-}

data/stimulus_reflex.gemspec

@@ -1,42 +0,0 @@
-# frozen_string_literal: true
-
-require File.expand_path("../lib/stimulus_reflex/version", __FILE__)
-
-Gem::Specification.new do |gem|
-  gem.name = "stimulus_reflex"
-  gem.license = "MIT"
-  gem.version = StimulusReflex::VERSION
-  gem.authors = ["Nathan Hopkins"]
-  gem.email = ["natehop@gmail.com"]
-  gem.homepage = "https://github.com/stimulusreflex/stimulus_reflex"
-  gem.summary = "Build reactive applications with the Rails tooling you already know and love."
-  gem.post_install_message = <<~MESSAGE
-    Get support for StimulusReflex and CableReady on Discord:
-
-    https://discord.gg/stimulus-reflex
-
-  MESSAGE
-
-  gem.metadata = {
-    "bug_tracker_uri" => "https://github.com/stimulusreflex/stimulus_reflex/issues",
-    "changelog_uri" => "https://github.com/stimulusreflex/stimulus_reflex/CHANGELOG.md",
-    "documentation_uri" => "https://docs.stimulusreflex.com",
-    "homepage_uri" => gem.homepage,
-    "source_code_uri" => gem.homepage
-  }
-
-  gem.files = Dir["app/**/*", "lib/**/*", "bin/*", "[A-Z]*"]
-  gem.test_files = Dir["test/**/*.rb"]
-
-  gem.add_dependency "rack"
-  gem.add_dependency "nokogiri"
-  gem.add_dependency "rails", ">= 5.2"
-  gem.add_dependency "redis"
-  gem.add_dependency "cable_ready", "5.0.0.pre2"
-
-  gem.add_development_dependency "bundler", "~> 2.0"
-  gem.add_development_dependency "pry-nav"
-  gem.add_development_dependency "pry"
-  gem.add_development_dependency "rake"
-  gem.add_development_dependency "standardrb", "~> 1.0"
-end