stimulus_reflex 3.2.2.pre0 → 3.3.0.pre1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dd9af85e63dfa792a38d7dd4a560f86c1bcca6898aa8f38882ccfea57e726dbd
-  data.tar.gz: d4fdcadaae536283af5db9e98551a5dbd1cd9aa3100bba806be82e5cf6aecd18
+  metadata.gz: cb3ab10321ba245b37a1c1c930f48218146079db9b3448adf6ec86511a8eee27
+  data.tar.gz: f9e891d1775eca3787f9d95c3860d1cab43fec42895cb97a25f698636d7912e7
 SHA512:
-  metadata.gz: a64205414cfc3630ecb2c537abe5f0deacd0737f5abcf9d33873d57b317d5bf0dfccee6ae09706fdf1e38a5ca7ea6d3159272abd4a293523f9451600ce8d43f7
-  data.tar.gz: 81792f053d071fe1fc63db27609a53b4147b9d0f02f85714ba8c81f7cf7e937f94aca5037845badcdbb7b24e78992152549a991a3a1db5a1e1563d9b1f574713
+  metadata.gz: 6bba44eda7278bf6b54fd3ce3ee511169d6a1170164bea35ec8cf0f3df0b2c55bedd4c4030ee37c650af35c52761e386192e2b1844bd9676244bb67206b2097d
+  data.tar.gz: 8887eb98ce990e7c70e508628850c0955dc81d8a03ec02c94d8e4150a65c708274e7450eb00f81bf7d4be7e8b9f4ca53a201791381a85700c3eec6d26f27de5d

data/CHANGELOG.md

@@ -2,7 +2,98 @@
 
 ## [Unreleased](https://github.com/hopsoft/stimulus_reflex/tree/HEAD)
 
-[Full Changelog](https://github.com/hopsoft/stimulus_reflex/compare/v3.2.1...HEAD)
+[Full Changelog](https://github.com/hopsoft/stimulus_reflex/compare/v3.3.0.pre0...HEAD)
+
+**Merged pull requests:**
+
+- alternate solution [\#262](https://github.com/hopsoft/stimulus_reflex/pull/262) ([leastbad](https://github.com/leastbad))
+
+## [v3.3.0.pre0](https://github.com/hopsoft/stimulus_reflex/tree/v3.3.0.pre0) (2020-07-04)
+
+[Full Changelog](https://github.com/hopsoft/stimulus_reflex/compare/v3.2.3...v3.3.0.pre0)
+
+**Implemented enhancements:**
+
+- Returns more helpful error message if Reflex doesn't exist [\#254](https://github.com/hopsoft/stimulus_reflex/pull/254) ([leastbad](https://github.com/leastbad))
+- Update install.rake to handle Typescript [\#241](https://github.com/hopsoft/stimulus_reflex/pull/241) ([iv-mexx](https://github.com/iv-mexx))
+- Morph Modes: page, selector and nothing [\#211](https://github.com/hopsoft/stimulus_reflex/pull/211) ([leastbad](https://github.com/leastbad))
+
+**Fixed bugs:**
+
+- Limit MutationObserver mutations [\#256](https://github.com/hopsoft/stimulus_reflex/pull/256) ([jasoncharnes](https://github.com/jasoncharnes))
+
+**Closed issues:**
+
+- beforeUpdate/updateSuccess/updateError functions deprecated? [\#255](https://github.com/hopsoft/stimulus_reflex/issues/255)
+- Error handling will fail if reflex is not defined [\#253](https://github.com/hopsoft/stimulus_reflex/issues/253)
+- Select with data-reflex in Firefox flickers [\#251](https://github.com/hopsoft/stimulus_reflex/issues/251)
+- data-reflex-attributes vs data-reflex-dataset [\#237](https://github.com/hopsoft/stimulus_reflex/issues/237)
+- Shorthand action notations corresponding to stimulus [\#233](https://github.com/hopsoft/stimulus_reflex/issues/233)
+- Lifecycle methods only called for one reflex [\#225](https://github.com/hopsoft/stimulus_reflex/issues/225)
+- Tweak the generator so we can specify reflex actions [\#219](https://github.com/hopsoft/stimulus_reflex/issues/219)
+- Docs: Clarify forcing DOM update with authentication [\#123](https://github.com/hopsoft/stimulus_reflex/issues/123)
+- ActiveJob integration example [\#112](https://github.com/hopsoft/stimulus_reflex/issues/112)
+
+**Merged pull requests:**
+
+- Prep for pre release of 3.3.0 [\#259](https://github.com/hopsoft/stimulus_reflex/pull/259) ([hopsoft](https://github.com/hopsoft))
+- Fallback to first Stimulus controller in array [\#257](https://github.com/hopsoft/stimulus_reflex/pull/257) ([jasoncharnes](https://github.com/jasoncharnes))
+- Fix cases where plural reflexes were unresolved [\#252](https://github.com/hopsoft/stimulus_reflex/pull/252) ([joshleblanc](https://github.com/joshleblanc))
+- warn against collections of identical elements that trigger reflexes [\#250](https://github.com/hopsoft/stimulus_reflex/pull/250) ([leastbad](https://github.com/leastbad))
+- always calls params to persist them into controller action [\#249](https://github.com/hopsoft/stimulus_reflex/pull/249) ([RolandStuder](https://github.com/RolandStuder))
+- Update deployment.md [\#248](https://github.com/hopsoft/stimulus_reflex/pull/248) ([user073](https://github.com/user073))
+- Update reflexes.md [\#247](https://github.com/hopsoft/stimulus_reflex/pull/247) ([user073](https://github.com/user073))
+- Bump actionpack from 6.0.3.1 to 6.0.3.2 [\#245](https://github.com/hopsoft/stimulus_reflex/pull/245) ([dependabot[bot]](https://github.com/apps/dependabot))
+- Bump rack from 2.2.2 to 2.2.3 [\#244](https://github.com/hopsoft/stimulus_reflex/pull/244) ([dependabot[bot]](https://github.com/apps/dependabot))
+- Revert "Revert "Add instructions for pulling the user id out of session storage"" [\#240](https://github.com/hopsoft/stimulus_reflex/pull/240) ([leastbad](https://github.com/leastbad))
+- Revert "Add instructions for pulling the user id out of session storage" [\#239](https://github.com/hopsoft/stimulus_reflex/pull/239) ([leastbad](https://github.com/leastbad))
+- Add instructions for pulling the user id out of session storage [\#238](https://github.com/hopsoft/stimulus_reflex/pull/238) ([mtomov](https://github.com/mtomov))
+- adds params documentation [\#230](https://github.com/hopsoft/stimulus_reflex/pull/230) ([RolandStuder](https://github.com/RolandStuder))
+- Fix calling wrong controller lifecycle methods [\#226](https://github.com/hopsoft/stimulus_reflex/pull/226) ([davidalejandroaguilar](https://github.com/davidalejandroaguilar))
+- Allow to pass reflex action names to reflex generator [\#224](https://github.com/hopsoft/stimulus_reflex/pull/224) ([marcoroth](https://github.com/marcoroth))
+
+## [v3.2.3](https://github.com/hopsoft/stimulus_reflex/tree/v3.2.3) (2020-06-15)
+
+[Full Changelog](https://github.com/hopsoft/stimulus_reflex/compare/v3.2.2...v3.2.3)
+
+**Fixed bugs:**
+
+- Add more smarts to \_\_perform [\#235](https://github.com/hopsoft/stimulus_reflex/pull/235) ([hopsoft](https://github.com/hopsoft))
+- \_\_perform had a bug where it was only ever calling the first event [\#234](https://github.com/hopsoft/stimulus_reflex/pull/234) ([leastbad](https://github.com/leastbad))
+- merges insteads of overwrites params for reflex actions with form data [\#231](https://github.com/hopsoft/stimulus_reflex/pull/231) ([RolandStuder](https://github.com/RolandStuder))
+
+**Closed issues:**
+
+- "Uncaught \(in promise\)" error after failed declarative reflex [\#170](https://github.com/hopsoft/stimulus_reflex/issues/170)
+
+**Merged pull requests:**
+
+- Fix typos in the documentation [\#228](https://github.com/hopsoft/stimulus_reflex/pull/228) ([dlt](https://github.com/dlt))
+
+## [v3.2.2](https://github.com/hopsoft/stimulus_reflex/tree/v3.2.2) (2020-06-06)
+
+[Full Changelog](https://github.com/hopsoft/stimulus_reflex/compare/v3.2.2.pre1...v3.2.2)
+
+**Closed issues:**
+
+- Issue with doing a partial dom update [\#223](https://github.com/hopsoft/stimulus_reflex/issues/223)
+
+## [v3.2.2.pre1](https://github.com/hopsoft/stimulus_reflex/tree/v3.2.2.pre1) (2020-05-30)
+
+[Full Changelog](https://github.com/hopsoft/stimulus_reflex/compare/v3.2.2.pre0...v3.2.2.pre1)
+
+**Fixed bugs:**
+
+- Session lost after throw :abort [\#221](https://github.com/hopsoft/stimulus_reflex/issues/221)
+- Fix multipleInstances convenience method [\#220](https://github.com/hopsoft/stimulus_reflex/pull/220) ([julianrubisch](https://github.com/julianrubisch))
+
+**Merged pull requests:**
+
+- Always commit session [\#222](https://github.com/hopsoft/stimulus_reflex/pull/222) ([hopsoft](https://github.com/hopsoft))
+
+## [v3.2.2.pre0](https://github.com/hopsoft/stimulus_reflex/tree/v3.2.2.pre0) (2020-05-27)
+
+[Full Changelog](https://github.com/hopsoft/stimulus_reflex/compare/v3.2.1...v3.2.2.pre0)
 
 **Implemented enhancements:**
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    stimulus_reflex (3.2.2.pre0)
+    stimulus_reflex (3.3.0.pre1)
       cable_ready (>= 4.1.2)
       nokogiri
       rack
@@ -10,74 +10,74 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    actioncable (6.0.3.1)
-      actionpack (= 6.0.3.1)
+    actioncable (6.0.3.2)
+      actionpack (= 6.0.3.2)
       nio4r (~> 2.0)
       websocket-driver (>= 0.6.1)
-    actionmailbox (6.0.3.1)
-      actionpack (= 6.0.3.1)
-      activejob (= 6.0.3.1)
-      activerecord (= 6.0.3.1)
-      activestorage (= 6.0.3.1)
-      activesupport (= 6.0.3.1)
+    actionmailbox (6.0.3.2)
+      actionpack (= 6.0.3.2)
+      activejob (= 6.0.3.2)
+      activerecord (= 6.0.3.2)
+      activestorage (= 6.0.3.2)
+      activesupport (= 6.0.3.2)
       mail (>= 2.7.1)
-    actionmailer (6.0.3.1)
-      actionpack (= 6.0.3.1)
-      actionview (= 6.0.3.1)
-      activejob (= 6.0.3.1)
+    actionmailer (6.0.3.2)
+      actionpack (= 6.0.3.2)
+      actionview (= 6.0.3.2)
+      activejob (= 6.0.3.2)
       mail (~> 2.5, >= 2.5.4)
       rails-dom-testing (~> 2.0)
-    actionpack (6.0.3.1)
-      actionview (= 6.0.3.1)
-      activesupport (= 6.0.3.1)
+    actionpack (6.0.3.2)
+      actionview (= 6.0.3.2)
+      activesupport (= 6.0.3.2)
       rack (~> 2.0, >= 2.0.8)
       rack-test (>= 0.6.3)
       rails-dom-testing (~> 2.0)
       rails-html-sanitizer (~> 1.0, >= 1.2.0)
-    actiontext (6.0.3.1)
-      actionpack (= 6.0.3.1)
-      activerecord (= 6.0.3.1)
-      activestorage (= 6.0.3.1)
-      activesupport (= 6.0.3.1)
+    actiontext (6.0.3.2)
+      actionpack (= 6.0.3.2)
+      activerecord (= 6.0.3.2)
+      activestorage (= 6.0.3.2)
+      activesupport (= 6.0.3.2)
       nokogiri (>= 1.8.5)
-    actionview (6.0.3.1)
-      activesupport (= 6.0.3.1)
+    actionview (6.0.3.2)
+      activesupport (= 6.0.3.2)
       builder (~> 3.1)
       erubi (~> 1.4)
       rails-dom-testing (~> 2.0)
       rails-html-sanitizer (~> 1.1, >= 1.2.0)
-    activejob (6.0.3.1)
-      activesupport (= 6.0.3.1)
+    activejob (6.0.3.2)
+      activesupport (= 6.0.3.2)
       globalid (>= 0.3.6)
-    activemodel (6.0.3.1)
-      activesupport (= 6.0.3.1)
-    activerecord (6.0.3.1)
-      activemodel (= 6.0.3.1)
-      activesupport (= 6.0.3.1)
-    activestorage (6.0.3.1)
-      actionpack (= 6.0.3.1)
-      activejob (= 6.0.3.1)
-      activerecord (= 6.0.3.1)
+    activemodel (6.0.3.2)
+      activesupport (= 6.0.3.2)
+    activerecord (6.0.3.2)
+      activemodel (= 6.0.3.2)
+      activesupport (= 6.0.3.2)
+    activestorage (6.0.3.2)
+      actionpack (= 6.0.3.2)
+      activejob (= 6.0.3.2)
+      activerecord (= 6.0.3.2)
       marcel (~> 0.3.1)
-    activesupport (6.0.3.1)
+    activesupport (6.0.3.2)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 0.7, < 2)
       minitest (~> 5.1)
       tzinfo (~> 1.1)
       zeitwerk (~> 2.2, >= 2.2.2)
-    ast (2.4.0)
+    ast (2.4.1)
     builder (3.2.4)
-    cable_ready (4.1.2)
+    cable_ready (4.3.0)
       rails (>= 5.2)
-    coderay (1.1.2)
+    coderay (1.1.3)
     concurrent-ruby (1.1.6)
     crass (1.0.6)
     erubi (1.9.0)
     globalid (0.4.2)
       activesupport (>= 4.2.0)
-    i18n (1.8.2)
+    i18n (1.8.3)
       concurrent-ruby (~> 1.0)
-    loofah (2.5.0)
+    loofah (2.6.0)
       crass (~> 1.0.2)
       nokogiri (>= 1.5.9)
     mail (2.7.1)
@@ -90,68 +90,73 @@ GEM
     mini_portile2 (2.4.0)
     minitest (5.14.1)
     nio4r (2.5.2)
-    nokogiri (1.10.9)
+    nokogiri (1.10.10)
       mini_portile2 (~> 2.4.0)
-    parallel (1.19.1)
-    parser (2.7.1.3)
-      ast (~> 2.4.0)
+    parallel (1.19.2)
+    parser (2.7.1.4)
+      ast (~> 2.4.1)
     pry (0.12.2)
       coderay (~> 1.1.0)
       method_source (~> 0.9.0)
     pry-nav (0.3.0)
       pry (>= 0.9.10, < 0.13.0)
-    rack (2.2.2)
+    rack (2.2.3)
     rack-test (1.1.0)
       rack (>= 1.0, < 3)
-    rails (6.0.3.1)
-      actioncable (= 6.0.3.1)
-      actionmailbox (= 6.0.3.1)
-      actionmailer (= 6.0.3.1)
-      actionpack (= 6.0.3.1)
-      actiontext (= 6.0.3.1)
-      actionview (= 6.0.3.1)
-      activejob (= 6.0.3.1)
-      activemodel (= 6.0.3.1)
-      activerecord (= 6.0.3.1)
-      activestorage (= 6.0.3.1)
-      activesupport (= 6.0.3.1)
+    rails (6.0.3.2)
+      actioncable (= 6.0.3.2)
+      actionmailbox (= 6.0.3.2)
+      actionmailer (= 6.0.3.2)
+      actionpack (= 6.0.3.2)
+      actiontext (= 6.0.3.2)
+      actionview (= 6.0.3.2)
+      activejob (= 6.0.3.2)
+      activemodel (= 6.0.3.2)
+      activerecord (= 6.0.3.2)
+      activestorage (= 6.0.3.2)
+      activesupport (= 6.0.3.2)
       bundler (>= 1.3.0)
-      railties (= 6.0.3.1)
+      railties (= 6.0.3.2)
       sprockets-rails (>= 2.0.0)
     rails-dom-testing (2.0.3)
       activesupport (>= 4.2.0)
       nokogiri (>= 1.6)
     rails-html-sanitizer (1.3.0)
       loofah (~> 2.3)
-    railties (6.0.3.1)
-      actionpack (= 6.0.3.1)
-      activesupport (= 6.0.3.1)
+    railties (6.0.3.2)
+      actionpack (= 6.0.3.2)
+      activesupport (= 6.0.3.2)
       method_source
       rake (>= 0.8.7)
       thor (>= 0.20.3, < 2.0)
     rainbow (3.0.0)
     rake (13.0.1)
+    regexp_parser (1.7.1)
     rexml (3.2.4)
-    rubocop (0.83.0)
+    rubocop (0.85.1)
       parallel (~> 1.10)
       parser (>= 2.7.0.1)
       rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 1.7)
       rexml
+      rubocop-ast (>= 0.0.3)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 2.0)
-    rubocop-performance (1.5.2)
+    rubocop-ast (0.1.0)
+      parser (>= 2.7.0.1)
+    rubocop-performance (1.6.1)
       rubocop (>= 0.71.0)
     ruby-progressbar (1.10.1)
-    sprockets (4.0.0)
+    sprockets (4.0.2)
       concurrent-ruby (~> 1.0)
       rack (> 1, < 3)
     sprockets-rails (3.2.1)
       actionpack (>= 4.0)
       activesupport (>= 4.0)
       sprockets (>= 3.0.0)
-    standard (0.4.6)
-      rubocop (~> 0.83.0)
-      rubocop-performance (~> 1.5.2)
+    standard (0.4.7)
+      rubocop (~> 0.85.0)
+      rubocop-performance (~> 1.6.0)
     standardrb (1.0.0)
       standard
     thor (1.0.1)
@@ -161,8 +166,8 @@ GEM
     unicode-display_width (1.7.0)
     websocket-driver (0.7.2)
       websocket-extensions (>= 0.1.0)
-    websocket-extensions (0.1.4)
-    zeitwerk (2.3.0)
+    websocket-extensions (0.1.5)
+    zeitwerk (2.3.1)
 
 PLATFORMS
   ruby

data/README.md

@@ -11,7 +11,7 @@
       <img alt="License: MIT" src="https://img.shields.io/badge/license-MIT-brightgreen.svg" target="_blank" />
     </a>
     <a href="http://blog.codinghorror.com/the-best-code-is-no-code-at-all/" target="_blank">
-      <img alt="Lines of Code" src="https://img.shields.io/badge/lines_of_code-923-brightgreen.svg?style=flat" />
+      <img alt="Lines of Code" src="https://img.shields.io/badge/lines_of_code-1084-brightgreen.svg?style=flat" />
     </a>
     <a href="https://docs.stimulusreflex.com/" target="_blank">
       <img alt="Documentation" src="https://img.shields.io/badge/documentation-yes-brightgreen.svg" />

data/lib/generators/USAGE

@@ -2,7 +2,7 @@ Description:
     Generate boilerplate files to help get you up and running with StimulusReflex
 
 Example:
-    rails generate stimulus_reflex User
+    rails generate stimulus_reflex User update do_stuff [options]
 
     This will create, but not overwrite the following files:
 

data/lib/generators/stimulus_reflex_generator.rb

@@ -5,33 +5,22 @@ require "rails/generators"
 class StimulusReflexGenerator < Rails::Generators::NamedBase
   source_root File.expand_path("templates", __dir__)
 
-  def initialize_application_reflexes
-    copy_application_files if behavior == :invoke
-  end
-
-  def initialize_reflexes
-    copy_reflex_files
-  end
-
-  def initialize_controllers
-    copy_controller_files
-  end
+  argument :name, type: :string, required: true, banner: "NAME"
+  argument :actions, type: :array, default: [], banner: "action action"
 
-  private
+  def execute
+    actions.map!(&:underscore)
 
-  CONTROLLER_BASE_PATH = "app/javascript/controllers"
-  REFLEX_BASE_PATH = "app/reflexes"
+    copy_application_files if behavior == :invoke
 
-  def copy_reflex_files
-    template "custom_reflex.rb", File.join(REFLEX_BASE_PATH, "#{name.underscore}_reflex.rb")
+    template "app/reflexes/%file_name%_reflex.rb"
+    template "app/javascript/controllers/%file_name%_controller.js"
   end
 
-  def copy_controller_files
-    template "custom_controller.js", File.join(CONTROLLER_BASE_PATH, "#{name.underscore}_controller.js")
-  end
+  private
 
   def copy_application_files
-    template "application_reflex.rb", File.join(REFLEX_BASE_PATH, "application_reflex.rb")
-    template "application_controller.js", File.join(CONTROLLER_BASE_PATH, "application_controller.js")
+    template "app/reflexes/application_reflex.rb"
+    template "app/javascript/controllers/application_controller.js"
   end
 end

data/lib/generators/templates/{custom_controller.js → app/javascript/controllers/%file_name%_controller.js.tt}

@@ -22,6 +22,7 @@ export default class extends ApplicationController {
    *   error - error message from the server
    */
 
+<% if actions.empty? -%>
   // beforeUpdate(element, reflex) {
   //  element.innerText = 'Updating...'
   // }
@@ -34,4 +35,23 @@ export default class extends ApplicationController {
   //   console.error('updateError', error);
   //   element.innerText = 'Update Failed!'
   // }
+<% end -%>
+<% actions.each do |action| -%>
+  // <%= "before_#{action}".camelize(:lower) %>(element, reflex) {
+  //  console.log("before <%= action %>", element, reflex)
+  // }
+
+  // <%= "#{action}_success".camelize(:lower) %>(element, reflex) {
+  //   console.log("<%= action %> success", element, reflex)
+  // }
+
+  // <%= "#{action}_error".camelize(:lower) %>(element, reflex, error) {
+  //   console.error("<%= action %> error", element, reflex, error)
+  // }
+
+  // <%= "after_#{action}".camelize(:lower) %>(element, reflex, error) {
+  //   console.log("after <%= action %>", element, reflex, error)
+  // }
+<%= "\n" unless action == actions.last -%>
+<% end -%>
 }

data/lib/generators/templates/{custom_reflex.rb → app/reflexes/%file_name%_reflex.rb.tt}

@@ -21,4 +21,10 @@ class <%= class_name %>Reflex < ApplicationReflex
   #   end
   #
   # Learn more at: https://docs.stimulusreflex.com
+
+<% actions.each do |action| -%>
+  def <%= action %>
+  end
+<%= "\n" unless action == actions.last -%>
+<% end -%>
 end

data/lib/stimulus_reflex.rb

@@ -11,7 +11,12 @@ require "cable_ready"
 require "stimulus_reflex/version"
 require "stimulus_reflex/reflex"
 require "stimulus_reflex/element"
+require "stimulus_reflex/broadcaster"
+require "stimulus_reflex/morph_mode"
 require "stimulus_reflex/channel"
+require "stimulus_reflex/morph_mode/nothing_morph_mode"
+require "stimulus_reflex/morph_mode/page_morph_mode"
+require "stimulus_reflex/morph_mode/selector_morph_mode"
 require "generators/stimulus_reflex_generator"
 
 module StimulusReflex

data/lib/stimulus_reflex/broadcaster.rb

@@ -0,0 +1,53 @@
+module StimulusReflex
+  module Broadcaster
+    include CableReady::Broadcaster
+
+    def render_page_and_broadcast_morph(reflex, selectors, data = {})
+      html = render_page(reflex)
+      broadcast_morphs selectors, data, html if html.present?
+    end
+
+    def render_page(reflex)
+      reflex.controller.process reflex.url_params[:action]
+      reflex.controller.response.body
+    end
+
+    def broadcast_morphs(selectors, data, html)
+      document = Nokogiri::HTML(html)
+      selectors = selectors.select { |s| document.css(s).present? }
+      selectors.each do |selector|
+        cable_ready[stream_name].morph(
+          selector: selector,
+          html: document.css(selector).inner_html,
+          children_only: true,
+          permanent_attribute_name: data["permanent_attribute_name"],
+          stimulus_reflex: data.merge({
+            last: selector == selectors.last,
+            morph_mode: "page"
+          })
+        )
+      end
+      cable_ready.broadcast
+    end
+
+    def broadcast_message(subject:, body: nil, data: {})
+      message = {
+        subject: subject,
+        body: body
+      }
+
+      logger.error "\e[31m#{body}\e[0m" if subject == "error"
+
+      data[:morph_mode] = "page"
+      data[:server_message] = message
+      data[:morph_mode] = "selector" if subject == "selector"
+      data[:morph_mode] = "nothing" if subject == "nothing"
+
+      cable_ready[stream_name].dispatch_event(
+        name: "stimulus-reflex:server-message",
+        detail: {stimulus_reflex: data}
+      )
+      cable_ready.broadcast
+    end
+  end
+end

data/lib/stimulus_reflex/channel.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class StimulusReflex::Channel < ActionCable::Channel::Base
-  include CableReady::Broadcaster
+  include StimulusReflex::Broadcaster
 
   def stream_name
     ids = connection.identifiers.map { |identifier| send(identifier).try(:id) || send(identifier) }
@@ -21,32 +21,38 @@ class StimulusReflex::Channel < ActionCable::Channel::Base
     selectors = data["selectors"] = ["body"] if selectors.blank?
     target = data["target"].to_s
     reflex_name, method_name = target.split("#")
-    reflex_name = reflex_name.classify
+    reflex_name = reflex_name.camelize
     reflex_name = reflex_name.end_with?("Reflex") ? reflex_name : "#{reflex_name}Reflex"
     arguments = (data["args"] || []).map { |arg| object_with_indifferent_access arg }
     element = StimulusReflex::Element.new(data)
+    permanent_attribute_name = data["permanent_attribute_name"]
     params = data["params"] || {}
 
     begin
-      reflex_class = reflex_name.constantize.tap { |klass| raise ArgumentError.new("#{reflex_name} is not a StimulusReflex::Reflex") unless is_reflex?(klass) }
-      reflex = reflex_class.new(self, url: url, element: element, selectors: selectors, method_name: method_name, params: params)
-      delegate_call_to_reflex reflex, method_name, arguments
-    rescue => invoke_error
-      reflex.rescue_with_handler(invoke_error)
-      message = exception_message_with_backtrace(invoke_error)
-      return broadcast_message subject: "error", body: "StimulusReflex::Channel Failed to invoke #{target}! #{url} #{message}", data: data
-    end
-
-    if reflex.halted?
-      broadcast_message subject: "halted", data: data
-    else
       begin
-        render_page_and_broadcast_morph reflex, selectors, data
-      rescue => render_error
-        reflex.rescue_with_handler(render_error)
-        message = exception_message_with_backtrace(render_error)
-        broadcast_message subject: "error", body: "StimulusReflex::Channel Failed to re-render #{url} #{message}", data: data
+        reflex_class = reflex_name.constantize.tap { |klass| raise ArgumentError.new("#{reflex_name} is not a StimulusReflex::Reflex") unless is_reflex?(klass) }
+        reflex = reflex_class.new(self, url: url, element: element, selectors: selectors, method_name: method_name, permanent_attribute_name: permanent_attribute_name, params: params)
+        delegate_call_to_reflex reflex, method_name, arguments
+      rescue => invoke_error
+        reflex&.rescue_with_handler(invoke_error)
+        message = exception_message_with_backtrace(invoke_error)
+        return broadcast_message subject: "error", body: "StimulusReflex::Channel Failed to invoke #{target}! #{url} #{message}", data: data
+      end
+
+      if reflex.halted?
+        broadcast_message subject: "halted", data: data
+      else
+        begin
+          reflex.morph_mode.stream_name = stream_name
+          reflex.morph_mode.broadcast(reflex, selectors, data)
+        rescue => render_error
+          reflex.rescue_with_handler(render_error)
+          message = exception_message_with_backtrace(render_error)
+          broadcast_message subject: "error", body: "StimulusReflex::Channel Failed to re-render #{url} #{message}", data: data
+        end
       end
+    ensure
+      commit_session reflex if reflex
     end
   end
 
@@ -76,63 +82,14 @@ class StimulusReflex::Channel < ActionCable::Channel::Base
     end
   end
 
-  def render_page_and_broadcast_morph(reflex, selectors, data = {})
-    html = render_page(reflex)
-    broadcast_morphs selectors, data, html if html.present?
-  end
-
-  def commit_session(request, response)
-    store = request.session.instance_variable_get("@by")
-    store.commit_session request, response
+  def commit_session(reflex)
+    store = reflex.request.session.instance_variable_get("@by")
+    store.commit_session reflex.request, reflex.controller.response
   rescue => e
     message = "Failed to commit session! #{exception_message_with_backtrace(e)}"
     logger.error "\e[31m#{message}\e[0m"
   end
 
-  def render_page(reflex)
-    controller = reflex.request.controller_class.new
-    controller.instance_variable_set :"@stimulus_reflex", true
-    reflex.instance_variables.each do |name|
-      controller.instance_variable_set name, reflex.instance_variable_get(name)
-    end
-
-    controller.request = reflex.request
-    controller.response = ActionDispatch::Response.new
-    controller.process reflex.url_params[:action]
-    commit_session reflex.request, controller.response
-    controller.response.body
-  end
-
-  def broadcast_morphs(selectors, data, html)
-    document = Nokogiri::HTML(html)
-    selectors = selectors.select { |s| document.css(s).present? }
-    selectors.each do |selector|
-      cable_ready[stream_name].morph(
-        selector: selector,
-        html: document.css(selector).inner_html,
-        children_only: true,
-        permanent_attribute_name: data["permanent_attribute_name"],
-        stimulus_reflex: data.merge(last: selector == selectors.last)
-      )
-    end
-    cable_ready.broadcast
-  end
-
-  def broadcast_message(subject:, body: nil, data: {})
-    message = {
-      subject: subject,
-      body: body
-    }
-
-    logger.error "\e[31m#{body}\e[0m" if subject == "error"
-
-    cable_ready[stream_name].dispatch_event(
-      name: "stimulus-reflex:server-message",
-      detail: {stimulus_reflex: data.merge(server_message: message)}
-    )
-    cable_ready.broadcast
-  end
-
   def exception_message_with_backtrace(exception)
     "#{exception} #{exception.backtrace.first}"
   end

data/lib/stimulus_reflex/morph_mode.rb

@@ -0,0 +1,19 @@
+module StimulusReflex
+  class MorphMode
+    include StimulusReflex::Broadcaster
+
+    attr_accessor :stream_name
+
+    def page?
+      false
+    end
+
+    def nothing?
+      false
+    end
+
+    def selector?
+      false
+    end
+  end
+end

data/lib/stimulus_reflex/morph_mode/nothing_morph_mode.rb

@@ -0,0 +1,15 @@
+module StimulusReflex
+  class NothingMorphMode < MorphMode
+    def broadcast(reflex, selectors, data)
+      broadcast_message subject: "nothing", data: data
+    end
+
+    def to_sym
+      :nothing
+    end
+
+    def nothing?
+      true
+    end
+  end
+end

data/lib/stimulus_reflex/morph_mode/page_morph_mode.rb

@@ -0,0 +1,15 @@
+module StimulusReflex
+  class PageMorphMode < MorphMode
+    def broadcast(reflex, selectors, data)
+      render_page_and_broadcast_morph reflex, selectors, data
+    end
+
+    def to_sym
+      :page
+    end
+
+    def page?
+      true
+    end
+  end
+end

data/lib/stimulus_reflex/morph_mode/selector_morph_mode.rb

@@ -0,0 +1,15 @@
+module StimulusReflex
+  class SelectorMorphMode < MorphMode
+    def broadcast(reflex, selectors, data)
+      broadcast_message subject: "selector", data: data
+    end
+
+    def to_sym
+      :selector
+    end
+
+    def selector?
+      true
+    end
+  end
+end

data/lib/stimulus_reflex/reflex.rb

@@ -3,6 +3,7 @@
 class StimulusReflex::Reflex
   include ActiveSupport::Rescuable
   include ActiveSupport::Callbacks
+  include CableReady::Broadcaster
 
   define_callbacks :process, skip_after_callbacks_if_terminated: true
 
@@ -42,18 +43,21 @@ class StimulusReflex::Reflex
     end
   end
 
-  attr_reader :channel, :url, :element, :selectors, :method_name
+  attr_reader :channel, :url, :element, :selectors, :method_name, :morph_mode, :permanent_attribute_name
 
   delegate :connection, to: :channel
   delegate :session, to: :request
 
-  def initialize(channel, url: nil, element: nil, selectors: [], method_name: nil, params: {})
+  def initialize(channel, url: nil, element: nil, selectors: [], method_name: nil, stream_name: nil, permanent_attribute_name: nil, params: {})
     @channel = channel
     @url = url
     @element = element
     @selectors = selectors
     @method_name = method_name
     @params = params
+    @permanent_attribute_name = permanent_attribute_name
+    @morph_mode = StimulusReflex::PageMorphMode.new
+    self.params
   end
 
   def request
@@ -77,11 +81,54 @@ class StimulusReflex::Reflex
       )
       path_params = Rails.application.routes.recognize_path_with_request(req, url, req.env[:extras] || {})
       req.env.merge(ActionDispatch::Http::Parameters::PARAMETERS_KEY => path_params)
-      req.env["action_dispatch.request.parameters"] = @params
+      req.env["action_dispatch.request.parameters"] = req.parameters.merge(@params)
       req.tap { |r| r.session.send :load! }
     end
   end
 
+  def morph(selectors, html = "")
+    case selectors
+    when :page
+      raise StandardError.new("Cannot call :page morph after :#{@morph_mode.to_sym} morph") unless @morph_mode.page?
+    when :nothing
+      raise StandardError.new("Cannot call :nothing morph after :selector morph") if @morph_mode.selector?
+      @morph_mode = StimulusReflex::NothingMorphMode.new
+    else
+      raise StandardError.new("Cannot call :selector morph after :nothing morph") if @morph_mode.nothing?
+      @morph_mode = StimulusReflex::SelectorMorphMode.new
+      if selectors.is_a?(Hash)
+        selectors.each do |selector, html|
+          enqueue_selector_broadcast selector, html
+        end
+      else
+        enqueue_selector_broadcast selectors, html
+      end
+      cable_ready.broadcast
+    end
+  end
+
+  def enqueue_selector_broadcast(selector, html)
+    fragment = Nokogiri::HTML(html)
+    parent = fragment.at_css(selector)
+    cable_ready[channel.stream_name].morph(
+      selector: selector,
+      html: parent.present? ? parent.inner_html : fragment.to_html,
+      children_only: true,
+      permanent_attribute_name: permanent_attribute_name
+    )
+  end
+
+  def controller
+    @controller ||= begin
+      request.controller_class.new.tap do |c|
+        c.instance_variable_set :"@stimulus_reflex", true
+        instance_variables.each { |name| c.instance_variable_set name, instance_variable_get(name) }
+        c.request = request
+        c.response = ActionDispatch::Response.new
+      end
+    end
+  end
+
   def url_params
     @url_params ||= Rails.application.routes.recognize_path_with_request(request, request.path, request.env[:extras] || {})
   end

data/lib/stimulus_reflex/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module StimulusReflex
-  VERSION = "3.2.2.pre0"
+  VERSION = "3.3.0.pre1"
 end

data/lib/tasks/stimulus_reflex/install.rake

@@ -11,11 +11,16 @@ namespace :stimulus_reflex do
     FileUtils.mkdir_p Rails.root.join("app/javascript/controllers"), verbose: true
     FileUtils.mkdir_p Rails.root.join("app/reflexes"), verbose: true
 
-    filepath = if File.exist? Rails.root.join("app/javascript/controllers/index.js")
-      Rails.root.join("app/javascript/controllers/index.js")
-    else
-      Rails.root.join("app/javascript/packs/application.js")
-    end
+    filepath = %w[
+      app/javascript/controllers/index.js
+      app/javascript/controllers/index.ts
+      app/javascript/packs/application.js
+      app/javascript/packs/application.ts
+    ]
+      .select { |path| File.exist?(path) }
+      .map { |path| Rails.root.join(path) }
+      .first
+
     puts "Updating #{filepath}"
     lines = File.open(filepath, "r") { |f| f.readlines }
 

data/test/generators/stimulus_reflex_generator_test.rb

@@ -23,4 +23,27 @@ class StimulusReflexGeneratorTest < Rails::Generators::TestCase
     assert_file "app/reflexes/application_reflex.rb"
     assert_file "app/reflexes/posts_reflex.rb", /PostsReflex/
   end
+
+  test "creates reflex with given reflex actions" do
+    run_generator %w[User update do_stuff DoMoreStuff]
+    assert_file "app/reflexes/user_reflex.rb" do |reflex|
+      assert_instance_method :update, reflex
+      assert_instance_method :do_stuff, reflex
+      assert_instance_method :do_more_stuff, reflex
+    end
+    assert_file "app/javascript/controllers/user_controller.js" do |controller|
+      assert_match(/beforeUpdate/, controller)
+      assert_match(/updateSuccess/, controller)
+      assert_match(/updateError/, controller)
+      assert_match(/afterUpdate/, controller)
+      assert_match(/beforeDoStuff/, controller)
+      assert_match(/doStuffSuccess/, controller)
+      assert_match(/doStuffError/, controller)
+      assert_match(/afterDoStuff/, controller)
+      assert_match(/beforeDoMoreStuff/, controller)
+      assert_match(/doMoreStuffSuccess/, controller)
+      assert_match(/doMoreStuffError/, controller)
+      assert_match(/afterDoMoreStuff/, controller)
+    end
+  end
 end

data/test/tmp/app/reflexes/demo_reflex.rb

@@ -21,4 +21,5 @@ class DemoReflex < ApplicationReflex
   #   end
   #
   # Learn more at: https://docs.stimulusreflex.com
+
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: stimulus_reflex
 version: !ruby/object:Gem::Version
-  version: 3.2.2.pre0
+  version: 3.3.0.pre1
 platform: ruby
 authors:
 - Nathan Hopkins
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-05-27 00:00:00.000000000 Z
+date: 2020-07-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -136,7 +136,7 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: 
+description:
 email:
 - natehop@gmail.com
 executables: []
@@ -157,13 +157,18 @@ files:
 - bin/standardize
 - lib/generators/USAGE
 - lib/generators/stimulus_reflex_generator.rb
-- lib/generators/templates/application_controller.js
-- lib/generators/templates/application_reflex.rb
-- lib/generators/templates/custom_controller.js
-- lib/generators/templates/custom_reflex.rb
+- lib/generators/templates/app/javascript/controllers/%file_name%_controller.js.tt
+- lib/generators/templates/app/javascript/controllers/application_controller.js.tt
+- lib/generators/templates/app/reflexes/%file_name%_reflex.rb.tt
+- lib/generators/templates/app/reflexes/application_reflex.rb.tt
 - lib/stimulus_reflex.rb
+- lib/stimulus_reflex/broadcaster.rb
 - lib/stimulus_reflex/channel.rb
 - lib/stimulus_reflex/element.rb
+- lib/stimulus_reflex/morph_mode.rb
+- lib/stimulus_reflex/morph_mode/nothing_morph_mode.rb
+- lib/stimulus_reflex/morph_mode/page_morph_mode.rb
+- lib/stimulus_reflex/morph_mode/selector_morph_mode.rb
 - lib/stimulus_reflex/reflex.rb
 - lib/stimulus_reflex/version.rb
 - lib/tasks/stimulus_reflex/install.rake
@@ -202,7 +207,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.1
 requirements: []
 rubygems_version: 3.0.3
-signing_key: 
+signing_key:
 specification_version: 4
 summary: Build reactive applications with the Rails tooling you already know and love.
 test_files: