stimulus-pdf-viewer-rails 0.3.1 → 0.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6fe6b668cbffa8acaf9ade9ef15614aad4d7677e3dc505bebe4065ba8ccdb726
-  data.tar.gz: f8f51d4e310e36beb6dd51efc9dd3501daaa15067b2a853912d074427a04b9f7
+  metadata.gz: 94c69ce661ffbfcc99fa65676d97183b65252cb525c69ac4ef4d0dd128a6ba48
+  data.tar.gz: c51c519b51d76b496afa78ffa68703bf7eb17e2f147516de224e75bf6c834bfe
 SHA512:
-  metadata.gz: ad37d63e9f0c26f373b293737818fd85121bf78945f8e97ab06371f75d2aa3ac6b8b4b9976a27cb5553b5cb3f738b51258a82541761bb78531116e34fa27e90f
-  data.tar.gz: 41b654cae115f12ef9a8f33c80d5d0645657cbccc7b70ee94651dd557b2ea416b38ace501b7a0e43cf9387dc8b16237c2f7e442915d338e1c03dd0ee3108ad45
+  metadata.gz: db307a6dc1e632f7d4e6ddb1c5fec962c421e4981a0e713e71b33686d5b82bf9f3a16ac297049c50bd217424254e863aaca8d63320d695c6feadea5be7bbad6b
+  data.tar.gz: d01c3a7398acf4b25054685c87258bf1dc9d24718905c014c5b41410d0bcb0f878c9495ec7f13e639d2071adb3737625e88e793da97424014fe0a43ae82f4733

data/CHANGELOG.md

@@ -2,6 +2,11 @@
 
 All notable changes to this project will be documented in this file.
 
+## [0.3.2] - 2026-05-13
+
+### Added
+- Updated stimulus-pdf-viewer to 0.3.2
+
 ## [0.3.0] - 2026-04-01
 
 ### Added

data/app/assets/javascripts/stimulus-pdf-viewer.esm.js

@@ -395,40 +395,87 @@ class CoreViewer {
 
   /**
    * Load a PDF document from a URL.
+   *
+   * PDF.js loads PDFs via streamed HTTP Range requests by default, which some
+   * corporate antivirus / web-filter products block while letting plain GETs
+   * through. If the initial streamed load fails with a network-shaped error,
+   * we retry once by fetching the entire PDF as an ArrayBuffer and handing the
+   * bytes to PDF.js directly.
+   *
    * @param {string} url - The PDF URL
    * @returns {Promise<PDFDocumentProxy>}
    */
   async load(url) {
     try {
-      const loadingTask = pdfjsLib.getDocument(url);
-      this.pdfDocument = await loadingTask.promise;
-      this.pageCount = this.pdfDocument.numPages;
+      return await this._loadDocument(url)
+    } catch (error) {
+      if (typeof url === "string" && this._shouldRetryAsBlob(error)) {
+        console.warn("PDF streamed load failed, retrying as full fetch:", error);
+        try {
+          const response = await fetch(url, { credentials: "same-origin" });
+          if (!response.ok) {
+            throw new Error(`HTTP ${response.status} fetching PDF`)
+          }
+          const data = new Uint8Array(await response.arrayBuffer());
+          return await this._loadDocument({ data })
+        } catch (retryError) {
+          console.error("PDF blob fallback also failed:", retryError);
+          this.eventBus.dispatch(ViewerEvents.DOCUMENT_LOAD_ERROR, { error: retryError });
+          throw retryError
+        }
+      }
+      console.error("Error loading PDF:", error);
+      this.eventBus.dispatch(ViewerEvents.DOCUMENT_LOAD_ERROR, { error });
+      throw error
+    }
+  }
 
-      // Clear any existing content
-      this.container.innerHTML = "";
-      this.pages.clear();
+  /**
+   * Load a PDF document from either a URL or pre-fetched bytes.
+   * @param {string|{data: Uint8Array}} source
+   * @returns {Promise<PDFDocumentProxy>}
+   */
+  async _loadDocument(source) {
+    const loadingTask = pdfjsLib.getDocument(source);
+    this.pdfDocument = await loadingTask.promise;
+    this.pageCount = this.pdfDocument.numPages;
 
-      // Set initial display scale on container
-      this.container.style.setProperty("--display-scale", String(this.displayScale));
+    // Clear any existing content
+    this.container.innerHTML = "";
+    this.pages.clear();
 
-      // Create page placeholders for all pages
-      await this._createPagePlaceholders();
+    // Set initial display scale on container
+    this.container.style.setProperty("--display-scale", String(this.displayScale));
 
-      // Dispatch loaded event
-      this.eventBus.dispatch(ViewerEvents.DOCUMENT_LOADED, {
-        pageCount: this.pageCount,
-        pdfDocument: this.pdfDocument
-      });
+    // Create page placeholders for all pages
+    await this._createPagePlaceholders();
 
-      // Trigger initial render of visible pages
-      this._renderingQueue.renderHighestPriority(this.getVisiblePages());
+    // Dispatch loaded event
+    this.eventBus.dispatch(ViewerEvents.DOCUMENT_LOADED, {
+      pageCount: this.pageCount,
+      pdfDocument: this.pdfDocument
+    });
 
-      return this.pdfDocument
-    } catch (error) {
-      console.error("Error loading PDF:", error);
-      this.eventBus.dispatch(ViewerEvents.DOCUMENT_LOAD_ERROR, { error });
-      throw error
-    }
+    // Trigger initial render of visible pages
+    this._renderingQueue.renderHighestPriority(this.getVisiblePages());
+
+    return this.pdfDocument
+  }
+
+  /**
+   * Decide whether a load failure is worth retrying via full-fetch.
+   * Skips errors where a different transport won't help: password-protected
+   * PDFs, corrupt files, and auth failures.
+   */
+  _shouldRetryAsBlob(error) {
+    const message = String(error?.message || error || "");
+    const name = String(error?.name || "");
+
+    if (/Password|InvalidPDF/i.test(name)) return false
+    if (/\b40[0-9]\b/.test(message)) return false
+    if (/password|invalid pdf|encrypted/i.test(message)) return false
+
+    return true
   }
 
   /**
@@ -2435,11 +2482,12 @@ class ColorPicker {
     });
 
     // Close on outside click
-    document.addEventListener("click", () => {
+    this._documentClickHandler = () => {
       if (this.isOpen) {
         this._closeDropdown();
       }
-    });
+    };
+    document.addEventListener("click", this._documentClickHandler);
   }
 
   _closeDropdown() {
@@ -2472,6 +2520,15 @@ class ColorPicker {
   getColor() {
     return this.currentColor
   }
+
+  destroy() {
+    if (this._documentClickHandler) {
+      document.removeEventListener("click", this._documentClickHandler);
+      this._documentClickHandler = null;
+    }
+    this.element?.remove();
+    this.element = null;
+  }
 }
 
 class AnnotationEditToolbar {
@@ -8388,6 +8445,7 @@ class PdfViewer {
     this.annotationSidebar?.destroy();
     this.findController?.destroy();
     this.findBar?.destroy();
+    this.colorPicker?.destroy();
 
     Object.values(this.tools).forEach(tool => tool.destroy?.());
 
@@ -8410,7 +8468,8 @@ class pdf_viewer_controller extends Controller {
     initialPage: Number,
     initialAnnotation: String,
     autoHeight: { type: Boolean, default: true },
-    detailPanel: { type: Boolean, default: false }
+    detailPanel: { type: Boolean, default: false },
+    errorMessage: String
   }
 
   initialize() {
@@ -8446,10 +8505,27 @@ class pdf_viewer_controller extends Controller {
       await this.pdfViewer.load();
     } catch (error) {
       console.error("Failed to load PDF:", error);
-      this._showError("Failed to load PDF document");
+      this._handleLoadFailure(error);
     }
   }
 
+  // Surface a final load failure: hide the spinner, show a host-customizable
+  // message, and dispatch a DOM event so the host app can wire telemetry.
+  _handleLoadFailure(error) {
+    if (this.hasLoadingOverlayTarget) {
+      this.loadingOverlayTarget.classList.add("hidden");
+    }
+    const message = this.errorMessageValue || "Failed to load PDF document";
+    this._showError(message);
+    this.containerTarget.dispatchEvent(new CustomEvent("pdf-viewer:load-failed", {
+      bubbles: true,
+      detail: {
+        message: String(error?.message || error || ""),
+        name: String(error?.name || "")
+      }
+    }));
+  }
+
   _setupErrorListener() {
     this._errorHandler = (e) => {
       const { message } = e.detail;

data/app/assets/javascripts/stimulus-pdf-viewer.js

@@ -415,40 +415,87 @@
 
     /**
      * Load a PDF document from a URL.
+     *
+     * PDF.js loads PDFs via streamed HTTP Range requests by default, which some
+     * corporate antivirus / web-filter products block while letting plain GETs
+     * through. If the initial streamed load fails with a network-shaped error,
+     * we retry once by fetching the entire PDF as an ArrayBuffer and handing the
+     * bytes to PDF.js directly.
+     *
      * @param {string} url - The PDF URL
      * @returns {Promise<PDFDocumentProxy>}
      */
     async load(url) {
       try {
-        const loadingTask = pdfjsLib__namespace.getDocument(url);
-        this.pdfDocument = await loadingTask.promise;
-        this.pageCount = this.pdfDocument.numPages;
+        return await this._loadDocument(url)
+      } catch (error) {
+        if (typeof url === "string" && this._shouldRetryAsBlob(error)) {
+          console.warn("PDF streamed load failed, retrying as full fetch:", error);
+          try {
+            const response = await fetch(url, { credentials: "same-origin" });
+            if (!response.ok) {
+              throw new Error(`HTTP ${response.status} fetching PDF`)
+            }
+            const data = new Uint8Array(await response.arrayBuffer());
+            return await this._loadDocument({ data })
+          } catch (retryError) {
+            console.error("PDF blob fallback also failed:", retryError);
+            this.eventBus.dispatch(ViewerEvents.DOCUMENT_LOAD_ERROR, { error: retryError });
+            throw retryError
+          }
+        }
+        console.error("Error loading PDF:", error);
+        this.eventBus.dispatch(ViewerEvents.DOCUMENT_LOAD_ERROR, { error });
+        throw error
+      }
+    }
 
-        // Clear any existing content
-        this.container.innerHTML = "";
-        this.pages.clear();
+    /**
+     * Load a PDF document from either a URL or pre-fetched bytes.
+     * @param {string|{data: Uint8Array}} source
+     * @returns {Promise<PDFDocumentProxy>}
+     */
+    async _loadDocument(source) {
+      const loadingTask = pdfjsLib__namespace.getDocument(source);
+      this.pdfDocument = await loadingTask.promise;
+      this.pageCount = this.pdfDocument.numPages;
 
-        // Set initial display scale on container
-        this.container.style.setProperty("--display-scale", String(this.displayScale));
+      // Clear any existing content
+      this.container.innerHTML = "";
+      this.pages.clear();
 
-        // Create page placeholders for all pages
-        await this._createPagePlaceholders();
+      // Set initial display scale on container
+      this.container.style.setProperty("--display-scale", String(this.displayScale));
 
-        // Dispatch loaded event
-        this.eventBus.dispatch(ViewerEvents.DOCUMENT_LOADED, {
-          pageCount: this.pageCount,
-          pdfDocument: this.pdfDocument
-        });
+      // Create page placeholders for all pages
+      await this._createPagePlaceholders();
 
-        // Trigger initial render of visible pages
-        this._renderingQueue.renderHighestPriority(this.getVisiblePages());
+      // Dispatch loaded event
+      this.eventBus.dispatch(ViewerEvents.DOCUMENT_LOADED, {
+        pageCount: this.pageCount,
+        pdfDocument: this.pdfDocument
+      });
 
-        return this.pdfDocument
-      } catch (error) {
-        console.error("Error loading PDF:", error);
-        this.eventBus.dispatch(ViewerEvents.DOCUMENT_LOAD_ERROR, { error });
-        throw error
-      }
+      // Trigger initial render of visible pages
+      this._renderingQueue.renderHighestPriority(this.getVisiblePages());
+
+      return this.pdfDocument
+    }
+
+    /**
+     * Decide whether a load failure is worth retrying via full-fetch.
+     * Skips errors where a different transport won't help: password-protected
+     * PDFs, corrupt files, and auth failures.
+     */
+    _shouldRetryAsBlob(error) {
+      const message = String(error?.message || error || "");
+      const name = String(error?.name || "");
+
+      if (/Password|InvalidPDF/i.test(name)) return false
+      if (/\b40[0-9]\b/.test(message)) return false
+      if (/password|invalid pdf|encrypted/i.test(message)) return false
+
+      return true
     }
 
     /**
@@ -2455,11 +2502,12 @@
       });
 
       // Close on outside click
-      document.addEventListener("click", () => {
+      this._documentClickHandler = () => {
         if (this.isOpen) {
           this._closeDropdown();
         }
-      });
+      };
+      document.addEventListener("click", this._documentClickHandler);
     }
 
     _closeDropdown() {
@@ -2492,6 +2540,15 @@
     getColor() {
       return this.currentColor
     }
+
+    destroy() {
+      if (this._documentClickHandler) {
+        document.removeEventListener("click", this._documentClickHandler);
+        this._documentClickHandler = null;
+      }
+      this.element?.remove();
+      this.element = null;
+    }
   }
 
   class AnnotationEditToolbar {
@@ -8408,6 +8465,7 @@
       this.annotationSidebar?.destroy();
       this.findController?.destroy();
       this.findBar?.destroy();
+      this.colorPicker?.destroy();
 
       Object.values(this.tools).forEach(tool => tool.destroy?.());
 
@@ -8430,7 +8488,8 @@
       initialPage: Number,
       initialAnnotation: String,
       autoHeight: { type: Boolean, default: true },
-      detailPanel: { type: Boolean, default: false }
+      detailPanel: { type: Boolean, default: false },
+      errorMessage: String
     }
 
     initialize() {
@@ -8466,10 +8525,27 @@
         await this.pdfViewer.load();
       } catch (error) {
         console.error("Failed to load PDF:", error);
-        this._showError("Failed to load PDF document");
+        this._handleLoadFailure(error);
       }
     }
 
+    // Surface a final load failure: hide the spinner, show a host-customizable
+    // message, and dispatch a DOM event so the host app can wire telemetry.
+    _handleLoadFailure(error) {
+      if (this.hasLoadingOverlayTarget) {
+        this.loadingOverlayTarget.classList.add("hidden");
+      }
+      const message = this.errorMessageValue || "Failed to load PDF document";
+      this._showError(message);
+      this.containerTarget.dispatchEvent(new CustomEvent("pdf-viewer:load-failed", {
+        bubbles: true,
+        detail: {
+          message: String(error?.message || error || ""),
+          name: String(error?.name || "")
+        }
+      }));
+    }
+
     _setupErrorListener() {
       this._errorHandler = (e) => {
         const { message } = e.detail;

data/lib/stimulus_pdf_viewer/rails/version.rb

@@ -1,7 +1,7 @@
 module StimulusPdfViewer
   module Rails
-    VERSION = "0.3.1"
+    VERSION = "0.3.2"
     # This should match the npm package version
-    STIMULUS_PDF_VIEWER_VERSION = "0.3.1"
+    STIMULUS_PDF_VIEWER_VERSION = "0.3.2"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: stimulus-pdf-viewer-rails
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.3.2
 platform: ruby
 authors:
 - Jeremy Baker
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-04-04 00:00:00.000000000 Z
+date: 2026-05-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties