stew 0.5.2 → 0.5.3

data/spec/integration/broken_sales_integration_spec.rb

@@ -0,0 +1,19 @@
+#encoding: utf-8
+
+require 'spec_helper'
+
+describe "Parsing of broken sales", :vcr do
+  before(:each) do
+    raw_response_file = File.new("spec/fixtures/store/sales/broken_sales.txt")
+    stub_request(:get, "http://store.steampowered.com/search/tab?cc=us&l=english&tab=Discounts&start=0&count=10000").to_return(raw_response_file)
+  end
+
+  describe "parsing of the sales" do
+    let(:subject){Stew::Store::SalesClient.new}
+    let(:sales){subject.sales}
+
+    it "handles responses with no original price" do
+      sales.each(&:original_price)
+    end
+  end
+end

data/spec/integration/sales_integration_spec.rb

@@ -0,0 +1,32 @@
+#encoding: utf-8
+
+require 'spec_helper'
+
+describe "Sales" do
+  before(:each) do
+    raw_response_file = File.new("spec/fixtures/store/sales/sales.txt")
+    stub_request(:get, "http://store.steampowered.com/search/tab?cc=us&l=english&tab=Discounts&start=0&count=10000").to_return(raw_response_file)
+  end
+
+  describe "parsing of the sales" do
+    let(:subject){Stew::Store::SalesClient.new}
+    let(:sales){subject.sales}
+
+    it "has the correct names" do
+      sales.entries[0].name.should eq "Call of Duty®: Black Ops II"
+      sales.entries[1].name.should eq "Tomb Raider"
+    end
+
+    it "has the correct price" do
+      sales.first.price.should eq Money.new('4019', :eur)
+    end
+
+    it "has the correct original price" do
+      sales.first.original_price.should eq Money.new('5999', :usd)
+    end
+
+    it "has an app id" do
+      sales.first.app_id.should eq 202970
+    end
+  end
+end

data/spec/integration/store_integration_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe "Store", :vcr do
+describe "Store", :vcr => {:cassette_name => 'store_integration'} do
 
   let(:store_client){Stew::Store::StoreClient.new}
   subject{store_client.app(id)}
@@ -41,6 +41,14 @@ describe "Store", :vcr do
     it "is not indie" do
       subject.indie?.should be_false
     end
+
+    it "sets the header image" do
+      subject.header_image.should match /http:\/\/cdn.\.?steampowered.com\/v\/gfx\/apps\/211420\/header_292x136\.jpg/
+    end
+
+    it "sets the capsule image" do
+      subject.capsule_image.should match /http:\/\/cdn.\.?steampowered.com\/v\/gfx\/apps\/211420\/capsule_sm_120\.jpg/
+    end
   end
 
   describe "Creation of a store DLC app with data" do
@@ -51,6 +59,10 @@ describe "Store", :vcr do
     it "sets dlc flag" do
       subject.dlc?.should be_true
     end
+
+    it "sets the dlc_app_id" do
+      subject.dlc_app_id.should eq 8930
+    end
   end
 
   describe "Creation of a store App with multiple offers" do

data/spec/lib/stew/store/app_spec.rb

@@ -4,9 +4,8 @@ require 'spec_helper'
 
 describe Stew::Store::App do
   let(:response){open("spec/fixtures/store/apps/#{id}.txt")}
-  #let(:document){Nokogiri.HTML(response)}
 
-  subject{Stew::Store::App.new(response)}
+  subject{Stew::Store::App.new(response, id)}
 
   describe "attributes" do
     context "when the parse is successful" do
@@ -56,6 +55,22 @@ describe Stew::Store::App do
         end
       end
 
+      describe ".dlc_app_id" do
+        context "when the app is not DLC" do
+          it "returns nil" do
+            subject.dlc_app_id.should be_nil
+          end
+        end
+        
+        context "when the app is DLC" do
+          let(:id){16870}
+
+          it "returns true" do
+            subject.dlc_app_id.should eq 8930
+          end
+        end
+      end
+
       describe ".developer" do
         it "returns the developer" do
           subject.developer.should eq 'FromSoftware'
@@ -90,12 +105,41 @@ describe Stew::Store::App do
         end
       end
 
+      describe ".regular_price" do
+        context "when the app is not on sale" do
+          it "returns the price" do
+            subject.regular_price.should eq Money.new(3999, 'EUR')
+          end
+        end
+
+        context "when the app is on sale" do
+          let(:id){211400}
+          let(:response){open("spec/fixtures/store/apps/#{id}_sale.txt")}
+
+          it "returns the price of the app when it is not on sale" do
+            subject.regular_price.should eq Money.new(1199, 'EUR')
+          end
+        end
+      end
+
       describe ".free?" do
         it "returns true if the the app is free" do
           subject.free?.should be_false
         end
       end
 
+      describe ".header_image" do
+        it "return the URL of the header image" do
+          subject.header_image.should eq 'http://cdn.steampowered.com/v/gfx/apps/211420/header_292x136.jpg'
+        end
+      end
+
+      describe ".capsule_image" do
+        it "return the URL of the capsule image" do
+          subject.capsule_image.should eq 'http://cdn2.steampowered.com/v/gfx/apps/211420/capsule_sm_120.jpg'
+        end
+      end
+
       describe "offers" do
         it "creates an AppOffers instance with the offer node" do
           subject.offers.count.should eq 1
@@ -122,7 +166,7 @@ describe Stew::Store::App do
 
       describe ".dlc?" do
         it "should be nil" do
-          subject.dlc?.should be_nil
+          subject.dlc?.should be_false
         end
       end
 
@@ -137,6 +181,12 @@ describe Stew::Store::App do
           subject.price.should be_nil
         end
       end
+
+      describe ".header_image" do
+        it "should be nil" do
+          subject.header_image.should be_nil
+        end
+      end
     end
   end
 end

data/spec/lib/stew/store/sale_spec.rb

@@ -0,0 +1,51 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Stew::Store::Sale do
+  subject{Stew::Store::Sale.new(Nokogiri::HTML(response))}
+
+  context "a broken sale with no original price" do
+    let(:response){File.new("spec/fixtures/store/sales/broken_sale.txt").read}
+
+    it "sets the original price to the discounted price" do
+      subject.original_price.should eq subject.price
+    end
+  end
+
+  context "a proper sale" do
+    let(:response){File.new("spec/fixtures/store/sales/sale.txt").read}
+
+    describe "#name" do
+      let(:expected_name){"Tomb Raider"}
+
+      it "returns the name" do
+        subject.name.should eq expected_name
+      end
+    end
+
+    describe "#price" do
+      let(:expected_price){Money.new("4499", :usd)}
+
+      it "returns the price" do
+        subject.price.should eq expected_price
+      end
+    end
+
+    describe "#original_price" do
+      let(:expected_original_price){Money.new("4999", :usd)}
+
+      it "returns the original price" do
+        subject.original_price.should eq expected_original_price
+      end
+    end
+
+    describe "#app_id" do
+      let(:expected_app_id){203160}
+
+      it "returns the app id" do
+        subject.app_id.should eq expected_app_id
+      end
+    end
+  end
+end

data/spec/lib/stew/store/sales_client_spec.rb

@@ -0,0 +1,28 @@
+require 'spec_helper'
+
+describe "Stew::Store::SalesClient" do
+  let(:client){double('sales_client')}
+  let(:response){open("spec/fixtures/store/sales/sales.txt")}
+  let(:region){:se}
+  subject{Stew::Store::SalesClient.new({:client => client})}
+
+  describe "sales" do
+    context "when no specific region is selected" do
+      it "sends the correct message to it's client" do
+      expected_options = {:cc => Stew.config[:default_region], :l => 'english', :tab => 'Discounts', :start => 0, :count => 10000}
+      client.should_receive(:get).with("/search/tab", expected_options).and_return(response)
+      Stew::Store::Sales.should_receive(:new).with(response)
+      subject.sales
+      end
+    end
+
+    context "when a region is given" do
+      it "sends the correct message to it's client" do
+        expected_options = {:cc => region, :l => 'english', :tab => 'Discounts', :start => 0, :count => 10000}
+        client.should_receive(:get).with("/search/tab", expected_options).and_return(response)
+        Stew::Store::Sales.should_receive(:new).with(response)
+        subject.sales(region)
+      end
+    end
+  end
+end

data/spec/lib/stew/store/sales_spec.rb

@@ -0,0 +1,8 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Stew::Store::Sales do
+  let(:response){File.new("spec/fixtures/store/sales/sales.txt").read}
+  subject{Stew::Store::Sales.new(response)}
+end

data/spec/lib/stew/store/store_client_spec.rb

@@ -10,7 +10,7 @@ describe "Stew::Store::StoreClient" do
     let(:id) {211420}
     it "sends the correct message to its client" do
       client.should_receive(:get).with("/app/#{id}", {:cc => region}).and_return(response)
-      Stew::Store::App.should_receive(:new).with(response)
+      Stew::Store::App.should_receive(:new).with(response, id)
       subject.app(id)
     end
   end
@@ -21,7 +21,7 @@ describe "Stew::Store::StoreClient" do
     context "when given an integer" do
       it "creates an app with the given integer as id" do
         client.stub(:get).with("/app/#{id}", {:cc => :us}).and_return(response)
-        Stew::Store::App.should_receive(:new).with(response)
+        Stew::Store::App.should_receive(:new).with(response, id)
         subject.create_app(id)
       end
     end
@@ -32,7 +32,7 @@ describe "Stew::Store::StoreClient" do
 
       it "creates an app" do
         client.stub(:get).with("/app/#{id}", {:cc => region}).and_return(response)
-        Stew::Store::App.should_receive(:new).with(response)
+        Stew::Store::App.should_receive(:new).with(response, id)
         subject.create_app(url)
       end
     end
@@ -42,7 +42,7 @@ describe "Stew::Store::StoreClient" do
 
       it "creates an app" do
         client.stub(:get).with("/app/#{id}", {:cc => :us}).and_return(response)
-        Stew::Store::App.should_receive(:new).with(response)
+        Stew::Store::App.should_receive(:new).with(response, id)
         subject.create_app(url)
       end
     end

data/spec/lib/stew/store/web_client_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe "Stew::Store::WebClient", :vcr do
+describe "Stew::Store::WebClient", :vcr => {:cassette_name => 'web_client'} do
   let(:uri){'http://store.steampowered.com/'}
 
   subject{Stew::Store::WebClient.new(uri)}

data/spec/spec_helper.rb

@@ -13,11 +13,12 @@ RSpec.configure do |config|
   config.run_all_when_everything_filtered = true
   config.filter_run :focus
   config.order = 'random'
+  config.fail_fast = true
 end
 
 VCR.configure do |c|
   c.cassette_library_dir = 'spec/fixtures/cassette_library'
   c.hook_into :webmock
   c.configure_rspec_metadata!
-  c.default_cassette_options = {:re_record_interval => 3600*24}
+  c.default_cassette_options = {:re_record_interval => 3600*24, :record => :new_episodes}
 end

metadata

@@ -1,20 +1,18 @@
 --- !ruby/object:Gem::Specification
 name: stew
 version: !ruby/object:Gem::Version
-  version: 0.5.2
-  prerelease: 
+  version: 0.5.3
 platform: ruby
 authors:
 - Magnus Skog
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-02-11 00:00:00.000000000 Z
+date: 2013-04-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -22,7 +20,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -30,7 +27,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: guard
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -38,7 +34,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -46,7 +41,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: guard-rspec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -54,7 +48,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -62,7 +55,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: vcr
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -70,7 +62,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -78,7 +69,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -86,7 +76,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -94,7 +83,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: ci_reporter
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -102,7 +90,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -110,7 +97,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -118,7 +104,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -126,7 +111,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -134,7 +118,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -142,7 +125,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: simplecov-rcov
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -150,7 +132,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -158,7 +139,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: rb-inotify
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -166,7 +146,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -174,7 +153,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -182,7 +160,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -190,7 +167,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: rdiscount
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -198,7 +174,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -206,7 +181,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_xml
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -214,7 +188,6 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -222,7 +195,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -230,7 +202,6 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -238,7 +209,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -246,7 +216,6 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -254,7 +223,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday_middleware
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -262,7 +230,6 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -270,7 +237,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: money
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -278,7 +244,6 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -313,6 +278,9 @@ files:
 - lib/stew/store/app_offer.rb
 - lib/stew/store/app_offer_sale.rb
 - lib/stew/store/app_offers.rb
+- lib/stew/store/sale.rb
+- lib/stew/store/sales.rb
+- lib/stew/store/sales_client.rb
 - lib/stew/store/store_client.rb
 - lib/stew/store/web_client.rb
 - lib/stew/version.rb
@@ -333,7 +301,13 @@ files:
 - spec/fixtures/store/apps/49520.txt
 - spec/fixtures/store/apps/49520_offers.txt
 - spec/fixtures/store/apps/no_app.txt
+- spec/fixtures/store/sales/broken_sale.txt
+- spec/fixtures/store/sales/broken_sales.txt
+- spec/fixtures/store/sales/sale.txt
+- spec/fixtures/store/sales/sales.txt
+- spec/integration/broken_sales_integration_spec.rb
 - spec/integration/community_integration_spec.rb
+- spec/integration/sales_integration_spec.rb
 - spec/integration/store_integration_spec.rb
 - spec/lib/stew/community/community_client_spec.rb
 - spec/lib/stew/community/profile_friends_spec.rb
@@ -346,6 +320,9 @@ files:
 - spec/lib/stew/store/app_offer_spec.rb
 - spec/lib/stew/store/app_offers_spec.rb
 - spec/lib/stew/store/app_spec.rb
+- spec/lib/stew/store/sale_spec.rb
+- spec/lib/stew/store/sales_client_spec.rb
+- spec/lib/stew/store/sales_spec.rb
 - spec/lib/stew/store/store_client_spec.rb
 - spec/lib/stew/store/web_client_spec.rb
 - spec/lib/stew_spec.rb
@@ -353,33 +330,26 @@ files:
 - stew.gemspec
 homepage: https://github.com/mskog/stew
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: -5319004060931315
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: -5319004060931315
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.24
+rubygems_version: 2.0.0.rc.2
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: A client for the Steam Gaming service.
 test_files:
 - spec/fixtures/profiles/4d.txt
@@ -399,7 +369,13 @@ test_files:
 - spec/fixtures/store/apps/49520.txt
 - spec/fixtures/store/apps/49520_offers.txt
 - spec/fixtures/store/apps/no_app.txt
+- spec/fixtures/store/sales/broken_sale.txt
+- spec/fixtures/store/sales/broken_sales.txt
+- spec/fixtures/store/sales/sale.txt
+- spec/fixtures/store/sales/sales.txt
+- spec/integration/broken_sales_integration_spec.rb
 - spec/integration/community_integration_spec.rb
+- spec/integration/sales_integration_spec.rb
 - spec/integration/store_integration_spec.rb
 - spec/lib/stew/community/community_client_spec.rb
 - spec/lib/stew/community/profile_friends_spec.rb
@@ -412,6 +388,9 @@ test_files:
 - spec/lib/stew/store/app_offer_spec.rb
 - spec/lib/stew/store/app_offers_spec.rb
 - spec/lib/stew/store/app_spec.rb
+- spec/lib/stew/store/sale_spec.rb
+- spec/lib/stew/store/sales_client_spec.rb
+- spec/lib/stew/store/sales_spec.rb
 - spec/lib/stew/store/store_client_spec.rb
 - spec/lib/stew/store/web_client_spec.rb
 - spec/lib/stew_spec.rb